net: ipa: correct IPA v4.7 IMEM offset
PATCH v2 1/1 net: ipa: correct IPA v4.7 IMEM offset
Commit b310de784bacd ("net: ipa: add IPA v4.7 support") was merged despite an unresolved comment made by Konrad Dybcio. Konrad observed that the IMEM region specified for IPA v4.7 did not match that used downstream for the SM7225 SoC. In "lagoon.dtsi" present in a Sony Xperia source tree, a ipa_smmu_ap node was defined with a "qcom,additional-mapping" property that defined the IPA IMEM area starting at offset 0x146a8000 (not 0x146a9000 that was committed).
The IPA v4.7 target system used for testing uses the SM7225 SoC, so we'll adhere what the downstream code specifies is the address of the IMEM region used for IPA.
---
v2: Based on net/master this time...
drivers/net/ipa/data/ipa_data-v4.7.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipa/data/ipa_data-v4.7.c +1 -1
@@ -357,7 +357,7 @@ static const struct ipa_mem ipa_mem_local_data[] = {static const struct ipa_mem_data ipa_mem_data = { .local_count =ARRAY_SIZE (ipa_mem_local_data), .local = ipa_mem_local_data, - .imem_addr =0x146a9000 , + .imem_addr =0x146a8000 , .imem_size =0x00002000 , .smem_id =497 , .smem_size =0x00009000 ,
Signature · 1 line
2.34.1
Quoted 12 lines · Alex Elder
Commit
b310de784bacd("net: ipa: add IPA v4.7 support") was merged despite an unresolved comment made by Konrad Dybcio. Konrad observed that the IMEM region specified for IPA v4.7 did not match that used downstream for the SM7225 SoC. In "lagoon.dtsi" present in a Sony Xperia source tree, aipa_smmu_apnode was defined with a "qcom,additional-mapping" property that defined the IPA IMEM area starting at offset0x146a8000(not0x146a9000that was committed).The IPA v4.7 target system used for testing uses the SM7225 SoC, so we'll adhere what the downstream code specifies is the address of the IMEM region used for IPA.
Quoted 5 lines
Fixes b310de784bac ("net: ipa: add IPA v4.7 support")Tested-by Luca Weiss <[email protected]>Signed-off-by Alex Elder <[email protected]>---
Konrad
Quoted 18 lines
v2: Based on net/master this time...
drivers/net/ipa/data/ipa_data-v4.7.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ipa/data/ipa_data-v4.7.c +1
-1@@ -357,7 +357,7 @@ static const struct ipa_mem ipa_mem_local_data[] = {static const struct ipa_mem_data ipa_mem_data = { .local_count =ARRAY_SIZE (ipa_mem_local_data), .local = ipa_mem_local_data, - .imem_addr =0x146a9000 , + .imem_addr =0x146a8000 , .imem_size =0x00002000 , .smem_id =497 , .smem_size =0x00009000 ,
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 9 lines · On Fri, 6 Jan 2023 07:25:01 -0600 you wrote:
Commit
b310de784bacd("net: ipa: add IPA v4.7 support") was merged despite an unresolved comment made by Konrad Dybcio. Konrad observed that the IMEM region specified for IPA v4.7 did not match that used downstream for the SM7225 SoC. In "lagoon.dtsi" present in a Sony Xperia source tree, aipa_smmu_apnode was defined with a "qcom,additional-mapping" property that defined the IPA IMEM area starting at offset0x146a8000(not0x146a9000that was committed).[...]
Here is the summary with links:
- [net,v2] net: ipa: correct IPA v4.7 IMEM offset
https://git.kernel.org/netdev/net/c/60ea6f00c57d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html