backlight: ipaq_micro: Use backlight helper
Subsystems (2)
PATCH RESEND 3/4 backlight: ipaq_micro: Use backlight helper
Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes.
--- drivers/video/backlight/ipaq_micro_bl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/video/backlight/ipaq_micro_bl.c +1 -6
@@ -16,17 +16,12 @@static int micro_bl_update_status (struct backlight_device *bd) {struct ipaq_micro *micro =dev_get_drvdata (&bd->dev); -int intensity = bd->props.brightness; +int intensity =backlight_get_brightness (bd);struct ipaq_micro_msg msg = { .id =MSG_BACKLIGHT , .tx_len =3 , }; -if (bd->props.power !=FB_BLANK_UNBLANK ) - intensity =0 ; -if (bd->props.state & (BL_CORE_FBBLANK |BL_CORE_SUSPENDED )) - intensity =0 ; -/* * Message format: * Byte 0: backlight instance (usually 1)
Signature · 1 line
2.30.2
Quoted 6 lines · Stephen Kitt
Instead of retrieving the backlight brightness in struct
backlight_propertiesmanually, and then checking whether the backlight should be on at all, usebacklight_get_brightness()which does all this and insulates this from future changes.Signed-off-by Stephen Kitt <[email protected]>
Quoted 29 lines
--- drivers/video/backlight/ipaq_micro_bl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)drivers/video/backlight/ipaq_micro_bl.c +1
-6@@ -16,17 +16,12 @@static int micro_bl_update_status (struct backlight_device *bd) {struct ipaq_micro *micro =dev_get_drvdata (&bd->dev); -int intensity = bd->props.brightness; +int intensity =backlight_get_brightness (bd);struct ipaq_micro_msg msg = { .id =MSG_BACKLIGHT , .tx_len =3 , }; -if (bd->props.power !=FB_BLANK_UNBLANK ) - intensity =0 ; -if (bd->props.state & (BL_CORE_FBBLANK |BL_CORE_SUSPENDED )) - intensity =0 ; -/* * Message format: * Byte 0: backlight instance (usually 1) Signature · 1 line
2.30.2
Quoted 6 lines · Stephen Kitt
Instead of retrieving the backlight brightness in struct
backlight_propertiesmanually, and then checking whether the backlight should be on at all, usebacklight_get_brightness()which does all this and insulates this from future changes.Signed-off-by Stephen Kitt <[email protected]>
For the tools:
D.
Quoted 9 lines · Stephen Kitt
Instead of retrieving the backlight brightness in struct
backlight_propertiesmanually, and then checking whether the backlight should be on at all, usebacklight_get_brightness()which does all this and insulates this from future changes.Signed-off-by Stephen Kitt <[email protected]>--- drivers/video/backlight/ipaq_micro_bl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
Applied, thanks
Signature · 1 line
Lee Jones [李琼斯]