Skip to contentSkip to conversation

rockchip: Fix the broken Video out for rk3288 boards

PATCH In review Jagan Teki 3 participants 3 messages Jan 2, 2023 – Jan 6, 2023

lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH 1/1 rockchip: Fix the broken Video out for rk3288 boards

Video out on RK3288 boards has been broken since from few releases due to the adding of reset support on vop but missed enabling DM_RESET on associated boards.

This patch fixes those RK3288 boards.

Cc Simon Glass <[email protected]>
Cc Lin Huang <[email protected]>
Cc Jernej Skrabec <[email protected]>
Cc Michael Trimarchi <[email protected]>
Cc Arnaud Patard (Rtp) <[email protected]>
Fixes <9749d2ea29e1> ("rockchip: video: vop: Add reset support")
---
 configs/evb-rk3288_defconfig        | 1 +
 configs/firefly-rk3288_defconfig    | 1 +
 configs/miqi-rk3288_defconfig       | 1 +
 configs/rock-pi-n8-rk3288_defconfig | 1 +
 configs/tinker-rk3288_defconfig     | 1 +
 configs/tinker-s-rk3288_defconfig   | 1 +
 configs/vyasa-rk3288_defconfig      | 1 +
 7 files changed, 7 insertions(+)
configs/evb-rk3288_defconfig +1 -0
index 7c0b856ca5..2c2c679b29 100644
@@ -80,6 +80,7 @@ CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYSRESET=y
 CONFIG_USB=y
configs/firefly-rk3288_defconfig +1 -0
index 63c53a0248..12ed055acf 100644
@@ -77,6 +77,7 @@ CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYSRESET=y
 CONFIG_USB=y
configs/miqi-rk3288_defconfig +1 -0
index 0811e70dce..2cf0efc816 100644
@@ -74,6 +74,7 @@ CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYSRESET=y
 CONFIG_USB=y
configs/rock-pi-n8-rk3288_defconfig +1 -0
index 4ed98c0a51..757d99b8b5 100644
@@ -73,6 +73,7 @@ CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
 # CONFIG_RAM_ROCKCHIP_DEBUG is not set
+CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYSRESET=y
 CONFIG_USB=y
configs/tinker-rk3288_defconfig +1 -0
index 85d94a6ea8..e69ef6875f 100644
@@ -82,6 +82,7 @@ CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYSRESET=y
 CONFIG_USB=y
configs/tinker-s-rk3288_defconfig +1 -0
index 7dfbad8083..eb153dc8d5 100644
@@ -82,6 +82,7 @@ CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYSRESET=y
 CONFIG_USB=y
configs/vyasa-rk3288_defconfig +1 -0
index cbae60f987..f503cc1604 100644
@@ -82,6 +82,7 @@ CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYSRESET=y
 CONFIG_USB=y
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Jagan Teki

Video out on RK3288 boards has been broken since from few releases due to the adding of reset support on vop but missed enabling DM_RESET on associated boards.

This patch fixes those RK3288 boards.

Cc Simon Glass <[email protected]>
Cc Lin Huang <[email protected]>
Cc Jernej Skrabec <[email protected]>
Cc Michael Trimarchi <[email protected]>
Cc Arnaud Patard (Rtp) <[email protected]>
Fixes <9749d2ea29e1> ("rockchip: video: vop: Add reset support")
Quoted 9 lines
---
 configs/evb-rk3288_defconfig        | 1 +
 configs/firefly-rk3288_defconfig    | 1 +
 configs/miqi-rk3288_defconfig       | 1 +
 configs/rock-pi-n8-rk3288_defconfig | 1 +
 configs/tinker-rk3288_defconfig     | 1 +
 configs/tinker-s-rk3288_defconfig   | 1 +
 configs/vyasa-rk3288_defconfig      | 1 +
 7 files changed, 7 insertions(+)

This should get in for the release

#2 lore raw
In reply to Jagan Teki
Quoted 6 lines · Jagan Teki

Video out on RK3288 boards has been broken since from few releases due to the adding of reset support on vop but missed enabling DM_RESET on associated boards.

This patch fixes those RK3288 boards.

Quoted 9 lines
Cc Simon Glass <[email protected]>
Cc Lin Huang <[email protected]>
Cc Jernej Skrabec <[email protected]>
Cc Michael Trimarchi <[email protected]>
Cc Arnaud Patard (Rtp) <[email protected]>
Fixes <9749d2ea29e1> ("rockchip: video: vop: Add reset support")

Applied to u-boot/master, thanks!

Signature · 1 line
Tom