common: bouncebuf: Use dma-mapping for cache ops
PATCH 1/1 common: bouncebuf: Use dma-mapping for cache ops
This matches how this would be done in Linux and these functions do the alignment for us which makes the code look cleaner.
Signed-off-by Andrew Davis <[email protected]>
--- common/bouncebuf.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
common/bouncebuf.c +7 -6
@@ -12,6 +12,7 @@#include <errno.h> #include <bouncebuf.h> #include <asm/cache.h> +#include <linux/dma-mapping.h> static int addr_aligned (struct bounce_buffer *state) {
@@ -59,9 +60,9 @@ int bounce_buffer_start_extalign(struct bounce_buffer *state, void *data,* Flush data to RAM so DMA reads can pick it up, * and any CPU writebacks don't race with DMA writes */ -flush_dcache_range ((unsigned long )state->bounce_buffer, - (unsigned long )(state->bounce_buffer) + - state->len_aligned); +dma_map_single (state->bounce_buffer, + state->len_aligned, +DMA_BIDIRECTIONAL );return 0 ; }
@@ -78,9 +79,9 @@ int bounce_buffer_stop(struct bounce_buffer *state) {if (state->flags &GEN_BB_WRITE ) {/* Invalidate cache so that CPU can see any newly DMA'd data */ -invalidate_dcache_range ((unsigned long )state->bounce_buffer, - (unsigned long )(state->bounce_buffer) + - state->len_aligned); +dma_unmap_single ((dma_addr_t )state->bounce_buffer, + state->len_aligned, +DMA_BIDIRECTIONAL ); }if (state->bounce_buffer == state->user_buffer)
Signature · 1 line
2.38.1
Quoted 8 lines · Andrew Davis
This matches how this would be done in Linux and these functions do the alignment for us which makes the code look cleaner.
Signed-off-by Andrew Davis <[email protected]>--- common/bouncebuf.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
Reviewed-by Simon Glass <[email protected]>
Quoted 5 lines · Andrew Davis
This matches how this would be done in Linux and these functions do the alignment for us which makes the code look cleaner.
Signed-off-by Andrew Davis <[email protected]>Reviewed-by Simon Glass <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom