Skip to contentSkip to conversation

Docs/admin-guide/mm/zswap: remove zsmalloc's lack of writeback warning

PATCH Applied Nhat Pham 2 participants 3 messages Jan 6, 2023 – Jan 11, 2023

Subsystems (4)
lore
Share & tools
lore

Nhat Pham

author maintainer
#0 lore raw

PATCH 1/1 Docs/admin-guide/mm/zswap: remove zsmalloc's lack of writeback warning

Writeback has been implemented for zsmalloc, so this warning no longer holds.

---
 Documentation/admin-guide/mm/zswap.rst | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Documentation/admin-guide/mm/zswap.rst +1 -3
index f67de481c7f6..6dd74a18268b 100644
@@ -70,9 +70,7 @@ e.g. ``zswap.zpool=zbud``. It can also be changed at runtime using the sysfs
 The zbud type zpool allocates exactly 1 page to store 2 compressed pages, which
 means the compression ratio will always be 2:1 or worse (because of half-full
 zbud pages).  The zsmalloc type zpool has a more complex compressed page
-storage method, and it can achieve greater storage densities.  However,
-zsmalloc does not implement compressed page eviction, so once zswap fills it
-cannot evict the oldest page, it can only reject new pages.
+storage method, and it can achieve greater storage densities.
 
 When a swap page is passed from frontswap to zswap, zswap maintains a mapping
 of the swap entry, a combination of the swap type and swap offset, to the zpool
Signature · 1 line
2.30.2
author maintainer
#1 lore raw
Quoted 26 lines · Nhat Pham

Writeback has been implemented for zsmalloc, so this warning no longer holds.

---
 Documentation/admin-guide/mm/zswap.rst | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Documentation/admin-guide/mm/zswap.rst +1 -4
index f67de481c7f6..6dd74a18268b 100644
@@ -70,9 +70,7 @@ e.g. ``zswap.zpool=zbud``. It can also be changed at runtime using the sysfs
 The zbud type zpool allocates exactly 1 page to store 2 compressed pages, which
 means the compression ratio will always be 2:1 or worse (because of half-full
 zbud pages).  The zsmalloc type zpool has a more complex compressed page
-storage method, and it can achieve greater storage densities.  However,
-zsmalloc does not implement compressed page eviction, so once zswap fills it
-cannot evict the oldest page, it can only reject new pages.
+storage method, and it can achieve greater storage densities.
 
 When a swap page is passed from frontswap to zswap, zswap maintains a mapping
 of the swap entry, a combination of the swap type and swap offset, to the zpool
--
Quoted 2 lines

2.30.2

Link to the patch series:
https://lkml.org/lkml/2022/11/28/1140

And the suggestion:
https://lkml.org/lkml/2023/1/2/823

maintainer Applied
#2 lore raw
In reply to Nhat Pham
Quoted 14 lines · Nhat Pham

Writeback has been implemented for zsmalloc, so this warning no longer holds.

---
 Documentation/admin-guide/mm/zswap.rst | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Documentation/admin-guide/mm/zswap.rst +0 -0
index f67de481c7f6..6dd74a18268b 100644

Documentation/admin-guide/mm/zswap.rst e.g. ``zswap.zpool=zbud``. It can also be changed at runtime using the sysfs · line 74

Quoted 8 lines
Documentation/admin-guide/mm/zswap.rst +1 -3
@@ -70,9 +70,7 @@ e.g. ``zswap.zpool=zbud``. It can also be changed at runtime using the sysfs
 The zbud type zpool allocates exactly 1 page to store 2 compressed pages, which
 means the compression ratio will always be 2:1 or worse (because of half-full
 zbud pages).  The zsmalloc type zpool has a more complex compressed page
-storage method, and it can achieve greater storage densities.  However,
-zsmalloc does not implement compressed page eviction, so once zswap fills it
-cannot evict the oldest page, it can only reject new pages.
+storage method, and it can achieve greater storage densities.
 

Applied, thanks.

jon