thermal: intel: pch: Add support for Wellsburg PCH

PATCH Applied Tim Zimmermann 4 participants 5 messages Jan 7, 2023 – Jan 24, 2023 Thermal

Share & tools

Tim Zimmermann

author

2023-01-07 19:42 UTC #0 lore raw

PATCH 1/1 thermal: intel: pch: Add support for Wellsburg PCH

This adds the PCI ID for the Wellsburg C610 series chipset PCH. The driver can read the temperature from the Wellsburg PCH with only the PCI ID added and no other modifications.

Signed-off-by Tim Zimmermann <[email protected]>

---
 drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++
 1 file changed, 8 insertions(+)

drivers/thermal/intel/intel_pch_thermal.c +8 -0

index dabf11a687a1..9e27f430e034 100644
@@ -29,6 +29,7 @@
 #define PCH_THERMAL_DID_CNL_LP	0x02F9 /* CNL-LP PCH */
 #define PCH_THERMAL_DID_CML_H	0X06F9 /* CML-H PCH */
 #define PCH_THERMAL_DID_LWB	0xA1B1 /* Lewisburg PCH */
+#define PCH_THERMAL_DID_WBG	0x8D24 /* Wellsburg PCH */
 
 /* Wildcat Point-LP  PCH Thermal registers */
 #define WPT_TEMP	0x0000	/* Temperature */

@@ -350,6 +351,7 @@ enum board_ids {
 	board_cnl,
 	board_cml,
 	board_lwb,
+	board_wbg,
 };
 
 static const struct board_info {

@@ -380,6 +382,10 @@ static const struct board_info {
 		.name = "pch_lewisburg",
 		.ops = &pch_dev_ops_wpt,
 	},
+	[board_wbg] = {
+		.name = "pch_wellsburg",
+		.ops = &pch_dev_ops_wpt,
+	},
 };
 
 static int intel_pch_thermal_probe(struct pci_dev *pdev,

@@ -495,6 +501,8 @@ static const struct pci_device_id intel_pch_thermal_id[] = {
 		.driver_data = board_cml, },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_LWB),
 		.driver_data = board_lwb, },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_WBG),
+		.driver_data = board_wbg, },
 	{ 0, },
 };
 MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);

Signature · 1 line

2.39.0

Rafael J. Wysocki

maintainer

2023-01-20 16:40 UTC #1 lore raw

Quoted 6 lines · Tim Zimmermann

This adds the PCI ID for the Wellsburg C610 series chipset PCH. The driver can read the temperature from the Wellsburg PCH with only the PCI ID added and no other modifications.
Signed-off-by Tim Zimmermann <[email protected]>

Rui, Srinivas, any objections to this one?

Quoted 47 lines

---
 drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++
 1 file changed, 8 insertions(+)

drivers/thermal/intel/intel_pch_thermal.c +8 -1

index dabf11a687a1..9e27f430e034 100644
@@ -29,6 +29,7 @@
 #define PCH_THERMAL_DID_CNL_LP 0x02F9 /* CNL-LP PCH */
 #define PCH_THERMAL_DID_CML_H  0X06F9 /* CML-H PCH */
 #define PCH_THERMAL_DID_LWB    0xA1B1 /* Lewisburg PCH */
+#define PCH_THERMAL_DID_WBG    0x8D24 /* Wellsburg PCH */
 
 /* Wildcat Point-LP  PCH Thermal registers */
 #define WPT_TEMP       0x0000  /* Temperature */

@@ -350,6 +351,7 @@ enum board_ids {
        board_cnl,
        board_cml,
        board_lwb,
+       board_wbg,
 };
 
 static const struct board_info {

@@ -380,6 +382,10 @@ static const struct board_info {
                .name = "pch_lewisburg",
                .ops = &pch_dev_ops_wpt,
        },
+       [board_wbg] = {
+               .name = "pch_wellsburg",
+               .ops = &pch_dev_ops_wpt,
+       },
 };
 
 static int intel_pch_thermal_probe(struct pci_dev *pdev,

@@ -495,6 +501,8 @@ static const struct pci_device_id intel_pch_thermal_id[] = {
                .driver_data = board_cml, },
        { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_LWB),
                .driver_data = board_lwb, },
+       { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_WBG),
+               .driver_data = board_wbg, },
        { 0, },
 };
 MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);
--

2.39.0

srinivas pandruvada

2023-01-20 17:50 UTC #2 lore raw

Quoted 10 lines · Rafael J. Wysocki

Quoted 7 lines · Tim Zimmermann
This adds the PCI ID for the Wellsburg C610 series chipset PCH. The driver can read the temperature from the Wellsburg PCH with only the PCI
ID added and no other modifications.
Signed-off-by Tim Zimmermann <[email protected]>
Rui, Srinivas, any objections to this one?

No objection.

Thanks,
Srinivas

Quoted 50 lines

---
drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++

 1 file changed, 8 insertions(+)

drivers/thermal/intel/intel_pch_thermal.c +8 -0

index dabf11a687a1..9e27f430e034 100644
@@ -29,6 +29,7 @@
  #define PCH_THERMAL_DID_CNL_LP 0x02F9 /* CNL-LP PCH */
  #define PCH_THERMAL_DID_CML_H  0X06F9 /* CML-H PCH */
  #define PCH_THERMAL_DID_LWB    0xA1B1 /* Lewisburg PCH */
+#define PCH_THERMAL_DID_WBG    0x8D24 /* Wellsburg PCH */
 
  /* Wildcat Point-LP  PCH Thermal registers */
  #define WPT_TEMP       0x0000  /* Temperature */

@@ -350,6 +351,7 @@ enum board_ids {
         board_cnl,
         board_cml,
         board_lwb,
+       board_wbg,
  };
 
  static const struct board_info {

@@ -380,6 +382,10 @@ static const struct board_info {
                 .name = "pch_lewisburg",
                 .ops = &pch_dev_ops_wpt,
         },
+       [board_wbg] = {
+               .name = "pch_wellsburg",
+               .ops = &pch_dev_ops_wpt,
+       },
  };
 
  static int intel_pch_thermal_probe(struct pci_dev *pdev,

@@ -495,6 +501,8 @@ static const struct pci_device_id
 intel_pch_thermal_id[] = {
                 .driver_data = board_cml, },
         { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_LWB),
                 .driver_data = board_lwb, },
+       { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_WBG),
+               .driver_data = board_wbg, },
         { 0, },
  };

MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);
--
2.39.0

Zhang, Rui

reviewer

2023-01-21 05:01 UTC #3 lore raw

Quoted 9 lines · srinivas pandruvada

Quoted 8 lines · Rafael J. Wysocki
Quoted 6 lines · Tim Zimmermann
This adds the PCI ID for the Wellsburg C610 series chipset PCH. The
driver can read the temperature from the Wellsburg PCH with only the PCI
ID added and no other modifications.

Quoted 5 lines

Quoted 3 lines
Quoted 1 line
Signed-off-by Tim Zimmermann <[email protected]>
Rui, Srinivas, any objections to this one?
No objection.

And no objections from me.

thanks,
rui

Quoted 52 lines

Thanks,
Srinivas

Quoted 49 lines

---
 drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++
 1 file changed, 8 insertions(+)

drivers/thermal/intel/intel_pch_thermal.c +8 -0

index dabf11a687a1..9e27f430e034 100644
@@ -29,6 +29,7 @@
 #define PCH_THERMAL_DID_CNL_LP 0x02F9 /* CNL-LP PCH */
 #define PCH_THERMAL_DID_CML_H  0X06F9 /* CML-H PCH */
 #define PCH_THERMAL_DID_LWB    0xA1B1 /* Lewisburg PCH */
+#define PCH_THERMAL_DID_WBG    0x8D24 /* Wellsburg PCH */
 
 /* Wildcat Point-LP  PCH Thermal registers */
 #define WPT_TEMP       0x0000  /* Temperature */

@@ -350,6 +351,7 @@ enum board_ids {
        board_cnl,
        board_cml,
        board_lwb,
+       board_wbg,
 };
 
 static const struct board_info {

@@ -380,6 +382,10 @@ static const struct board_info {
                .name = "pch_lewisburg",
                .ops = &pch_dev_ops_wpt,
        },
+       [board_wbg] = {
+               .name = "pch_wellsburg",
+               .ops = &pch_dev_ops_wpt,
+       },
 };
 
 static int intel_pch_thermal_probe(struct pci_dev *pdev,

@@ -495,6 +501,8 @@ static const struct pci_device_id
 intel_pch_thermal_id[] = {
                .driver_data = board_cml, },
        { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_LWB),
                .driver_data = board_lwb, },
+       { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_WBG),
+               .driver_data = board_wbg, },
        { 0, },
 };

MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);
--
2.39.0

Rafael J. Wysocki

maintainer Applied

2023-01-24 14:47 UTC #4 lore raw

Quoted 11 lines · Rui

Quoted 9 lines · srinivas pandruvada
Quoted 8 lines · Rafael J. Wysocki
Quoted 6 lines · Tim Zimmermann
This adds the PCI ID for the Wellsburg C610 series chipset PCH. The
driver can read the temperature from the Wellsburg PCH with only the PCI
ID added and no other modifications.

Quoted 6 lines

Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Tim Zimmermann <[email protected]>
Rui, Srinivas, any objections to this one?
No objection.
And no objections from me.

Applied as 6.3 material, thanks!