arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC
Subsystems (2)
PATCH 1/1 arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC
The GPIO watchdog property name is 'always-running', not 'always-enabled'. Use the correct property name and reinstate it into the DT.
---
Cc: Fabio Estevam <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: NXP Linux Team <[email protected]>
To: [email protected]
--- arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts +1 -0
@@ -88,6 +88,7 @@ watchdog { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_watchdog_gpio>; compatible = "linux,wdt-gpio"; + always-running; gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>; hw_algo = "level"; /* Reset triggers in 2..3 seconds */
Signature · 7 lines
2.35.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 1 line · Marek Vasut
The GPIO watchdog property name is 'always-running', not 'always-enabled'.
The patch only adds property 'always-running'. Why is 'always-enabled' involved here?
Shawn
Quoted 29 lines
Use the correct property name and reinstate it into the DT.
Fixes eff6b33c9ce9 ("arm64: dts: imx8mm: Remove watchdog always-enabled property from eDM SBC")Signed-off-by Marek Vasut <[email protected]>---
Cc: Fabio Estevam <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: NXP Linux Team <[email protected]>
To: [email protected]--- arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts +1
-0@@ -88,6 +88,7 @@ watchdog { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_watchdog_gpio>; compatible = "linux,wdt-gpio"; + always-running; gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>; hw_algo = "level"; /* Reset triggers in 2..3 seconds */Signature · 1 line
2.35.1
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 5 lines · Shawn Guo
Quoted 1 line · Marek Vasut
The GPIO watchdog property name is 'always-running', not 'always-enabled'.
The patch only adds property 'always-running'. Why is 'always-enabled' involved here?
Have a look at the Fixes: commit eff6b33c9ce9 below, that one removed 'always-enabled' , this one adds the correct one 'always-running'. The naming got confused.
Quoted 16 lines
Shawn
Quoted 14 lines
Use the correct property name and reinstate it into the DT.
Fixes eff6b33c9ce9 ("arm64: dts: imx8mm: Remove watchdog always-enabled property from eDM SBC")Signed-off-by Marek Vasut <[email protected]>---
Cc: Fabio Estevam <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: NXP Linux Team <[email protected]>
To: [email protected]--- arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 + 1 file changed, 1 insertion(+)
Quoted 12 lines
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts watchdog { · line 94
Quoted 12 lines
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts +1
-0@@ -88,6 +88,7 @@ watchdog { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_watchdog_gpio>; compatible = "linux,wdt-gpio"; + always-running; gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>; hw_algo = "level"; /* Reset triggers in 2..3 seconds */
[...]
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Shawn Guo
AppliedQuoted 5 lines · Marek Vasut
The GPIO watchdog property name is 'always-running', not 'always-enabled'. Use the correct property name and reinstate it into the DT.
Fixes eff6b33c9ce9 ("arm64: dts: imx8mm: Remove watchdog always-enabled property from eDM SBC")Signed-off-by Marek Vasut <[email protected]>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel