tests/qtest/test-hmp: Improve the check for verbose mode
PATCH 1/1 tests/qtest/test-hmp: Improve the check for verbose mode
Running the test-hmp with V=2 up to V=9 runs the test in verbose mode, but running for example with V=10 falls back to non-verbose mode ... Improve this oddity by properly treating the argument as a number.
--- tests/qtest/test-hmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/qtest/test-hmp.c +1 -1
@@ -151,7 +151,7 @@ int main(int argc, char **argv) {char *v_env =getenv ("V" ); -if (v_env && *v_env >='2' ) { +if (v_env &&atoi (v_env) >=2 ) { verbose = true; }
Signature · 1 line
2.31.1
Quoted 8 lines · Thomas Huth
Running the test-hmp with V=2 up to V=9 runs the test in verbose mode, but running for example with V=10 falls back to non-verbose mode ... Improve this oddity by properly treating the argument as a number.
Signed-off-by Thomas Huth <[email protected]>--- tests/qtest/test-hmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Laurent Vivier
AppliedLe 09/01/2023 à 11:13, Thomas Huth a écrit :
Quoted 14 lines
Running the test-hmp with V=2 up to V=9 runs the test in verbose mode, but running for example with V=10 falls back to non-verbose mode ... Improve this oddity by properly treating the argument as a number.
Signed-off-by Thomas Huth <[email protected]>--- tests/qtest/test-hmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qtest/test-hmp.c +0
-0
tests/qtest/test-hmp.c int main(int argc, char **argv) · line 157
Quoted 8 lines
tests/qtest/test-hmp.c +1
-1@@ -151,7 +151,7 @@ int main(int argc, char **argv) {char *v_env =getenv ("V" ); -if (v_env && *v_env >='2' ) { +if (v_env &&atoi (v_env) >=2 ) { verbose = true; }
Applied to my trivial-patches branch.
Thanks,
Laurent