mm/damon/sysfs-schemes: use strscpy() to instead of strncpy()
Subsystems (2)
PATCH 1/1 mm/damon/sysfs-schemes: use strscpy() to instead of strncpy()
From: Xu Panda <[email protected]>
The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL-terminated strings.
Signed-off-by Xu Panda <[email protected]>
Signed-off-by Yang Yang <[email protected]>
--- mm/damon/sysfs-schemes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
mm/damon/sysfs-schemes.c +1 -2
@@ -353,8 +353,7 @@ static ssize_t memcg_path_store(struct kobject *kobj,if (!path)return -ENOMEM ; -strncpy (path, buf, count); - path[count] ='\0' ; +strscpy (path, buf, count +1 ); filter->memcg_path = path;return count; }
Signature · 1 line
2.15.2
Hello Xu,
Thank you for this patch.
Quoted 7 lines · On Mon, 9 Jan 2023 19:46:55 +0800 (CST) <[email protected]> wrote:
From: Xu Panda <[email protected]>
The implementation of
strscpy()is more robust and safer. That's now the recommended way to copy NUL-terminated strings.Signed-off-by Xu Panda <[email protected]>Signed-off-by Yang Yang <[email protected]>
Reviewed-by SeongJae Park <[email protected]>
Thanks,
SJ
Quoted 20 lines
--- mm/damon/sysfs-schemes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)mm/damon/sysfs-schemes.c +1
-2@@ -353,8 +353,7 @@ static ssize_t memcg_path_store(struct kobject *kobj,if (!path)return -ENOMEM ; -strncpy (path, buf, count); - path[count] ='\0' ; +strscpy (path, buf, count +1 ); filter->memcg_path = path;return count; }Signature · 1 line
2.15.2