Skip to contentSkip to conversation

riscv: pgtable: Fixup comment for KERN_VIRT_SIZE

PATCH Applied [email protected] 4 participants 4 messages Jan 10, 2023 – Jan 25, 2023 RISC-V

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 riscv: pgtable: Fixup comment for KERN_VIRT_SIZE

From: Guo Ren <[email protected]>

KERN_VIRT_SIZE is 1/4 of the entries of the page global directory, not half.

Fixes f7ae02333d13 ("riscv: Move KASAN mapping next to the kernel mapping")
Cc Alexandre Ghiti <[email protected]>
---
 arch/riscv/include/asm/pgtable.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/include/asm/pgtable.h +1 -1
index 4eba9a98d0e3..2a88362dffa5 100644
@@ -31,7 +31,7 @@
 #define PTRS_PER_PTE    (PAGE_SIZE / sizeof(pte_t))
 
 /*
- * Half of the kernel address space (half of the entries of the page global
+ * Half of the kernel address space (1/4 of the entries of the page global
  * directory) is for the direct mapping.
  */
 #define KERN_VIRT_SIZE          ((PTRS_PER_PGD / 2 * PGDIR_SIZE) / 2)
Signature · 7 lines
2.36.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
reviewer Reviewed-by on v1 1/1
#1 lore raw

Hi Guo,

Quoted 18 lines · On 1/10/23 09:04, [email protected] wrote:

From: Guo Ren <[email protected]>

KERN_VIRT_SIZE is 1/4 of the entries of the page global directory, not half.

Fixes f7ae02333d13 ("riscv: Move KASAN mapping next to the kernel mapping")
Cc Alexandre Ghiti <[email protected]>
---
  arch/riscv/include/asm/pgtable.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/include/asm/pgtable.h +0 -0
index 4eba9a98d0e3..2a88362dffa5 100644

arch/riscv/include/asm/pgtable.h line 34

Quoted 5 lines
arch/riscv/include/asm/pgtable.h +1 -1
@@ -31,7 +31,7 @@
  #define PTRS_PER_PTE    (PAGE_SIZE / sizeof(pte_t))
 
  /*
- * Half of the kernel address space (half of the entries of the page global
+ * Half of the kernel address space (1/4 of the entries of the page global

Thanks,

Alex

arch/riscv/include/asm/pgtable.h line 37

Quoted 3 lines
arch/riscv/include/asm/pgtable.h +0 -0
   * directory) is for the direct mapping.
   */
  #define KERN_VIRT_SIZE          ((PTRS_PER_PGD / 2 * PGDIR_SIZE) / 2)

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#3 lore raw
In reply to [email protected]
This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:

Hello:

This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:

Quoted 11 lines · On Tue, 10 Jan 2023 03:04:19 -0500 you wrote:

From: Guo Ren <[email protected]>

KERN_VIRT_SIZE is 1/4 of the entries of the page global directory, not half.

Fixes f7ae02333d13 ("riscv: Move KASAN mapping next to the kernel mapping")
Cc Alexandre Ghiti <[email protected]>

[...]

Here is the summary with links:
- riscv: pgtable: Fixup comment for KERN_VIRT_SIZE

    https://git.kernel.org/riscv/c/6be1ff430dab

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html