Skip to contentSkip to conversation

mm/mmap: fix comment of unmapped_area{_topdown}

PATCH Superseded Vernon Yang 2 participants 3 messages Jan 10, 2023 – Jan 11, 2023

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/mmap: fix comment of unmapped_area{_topdown}

The low_limit of unmapped area information is inclusive, and the hight_limit is not, so make the comment to correct.

Fixes 3499a13168da ("mm/mmap: use maple tree for unmapped_area{_topdown}")
---
 mm/mmap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
mm/mmap.c +3 -3
index c9da9119d7f2..e06f9ae34ff8 100644
@@ -1554,7 +1554,7 @@ static inline int accountable_mapping(struct file *file, vm_flags_t vm_flags)
  * the correct alignment and offset, all from @info. Note: current->mm is used
  * for the search.
  *
- * @info: The unmapped area information including the range (low_limit -
+ * @info: The unmapped area information including the range [low_limit -
  * hight_limit), the alignment offset and mask.
  *
  * Return: A memory address or -ENOMEM.
@@ -1581,10 +1581,10 @@ static unsigned long unmapped_area(struct vm_unmapped_area_info *info)
 
 /**
  * unmapped_area_topdown() - Find an area between the low_limit and the
- * high_limit with * the correct alignment and offset at the highest available
+ * high_limit with the correct alignment and offset at the highest available
  * address, all from @info. Note: current->mm is used for the search.
  *
- * @info: The unmapped area information including the range (low_limit -
+ * @info: The unmapped area information including the range [low_limit -
  * hight_limit), the alignment offset and mask.
  *
  * Return: A memory address or -ENOMEM.
Signature · 1 line
2.34.1
#1 lore raw
Quoted 3 lines · Vernon Yang

- * @info: The unmapped area information including the range (low_limit -
+ * @info: The unmapped area information including the range [low_limit -
* hight_limit), the alignment offset and mask.

s/hight_limit/high_limit/

Quoted 3 lines

- * @info: The unmapped area information including the range (low_limit -
+ * @info: The unmapped area information including the range [low_limit -
* hight_limit), the alignment offset and mask.

ditto

#2 lore raw
Quoted 6 lines · Matthew Wilcox
Quoted 3 lines · Vernon Yang

- * @info: The unmapped area information including the range (low_limit -
+ * @info: The unmapped area information including the range [low_limit -
* hight_limit), the alignment offset and mask.

s/hight_limit/high_limit/

Okay, thanks you for review.

Quoted 6 lines
Quoted 4 lines

- * @info: The unmapped area information including the range (low_limit -
+ * @info: The unmapped area information including the range [low_limit -
* hight_limit), the alignment offset and mask.

ditto