Skip to contentSkip to conversation

cpufreq: amd-pstate: fix kernel hang issue while amd-pstate unregistering

PATCH Applied Perry Yuan 2 participants 2 messages Jan 10, 2023 – Jan 12, 2023

Subsystems (2)
lore
Share & tools
lore

Perry Yuan

author reviewer
#0 lore raw

PATCH v3 1/1 cpufreq: amd-pstate: fix kernel hang issue while amd-pstate unregistering

In the amd_pstate_adjust_perf(), there is one cpufreq_cpu_get() call to increase increments the kobject reference count of policy and make it as busy. Therefore, a corresponding call to cpufreq_cpu_put() is needed to decrement the kobject reference count back, it will resolve the kernel hang issue when unregistering the amd-pstate driver and register the amd_pstate_epp driver instance.

Fixes 1d215f0319 ("cpufreq: amd-pstate: Add fast switch function for AMD P-State")

v3: add Fixes tag
v2: add test-by flag from Wyes.

---
 drivers/cpufreq/amd-pstate.c | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/amd-pstate.c +1 -0
index 204e39006dda..c17bd845f5fc 100644
@@ -307,6 +307,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu,
 		max_perf = min_perf;
 
 	amd_pstate_update(cpudata, min_perf, des_perf, max_perf, true);
+	cpufreq_cpu_put(policy);
 }
 
 static int amd_get_min_freq(struct amd_cpudata *cpudata)
Signature · 1 line
2.34.1
maintainer Applied
#1 lore raw
Quoted 26 lines · Perry Yuan

In the amd_pstate_adjust_perf(), there is one cpufreq_cpu_get() call to increase increments the kobject reference count of policy and make it as busy. Therefore, a corresponding call to cpufreq_cpu_put() is needed to decrement the kobject reference count back, it will resolve the kernel hang issue when unregistering the amd-pstate driver and register the amd_pstate_epp driver instance.

Fixes 1d215f0319 ("cpufreq: amd-pstate: Add fast switch function for AMD P-State")

v3: add Fixes tag
v2: add test-by flag from Wyes.

---
 drivers/cpufreq/amd-pstate.c | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/amd-pstate.c +0 -0
index 204e39006dda..c17bd845f5fc 100644

drivers/cpufreq/amd-pstate.c static void amd_pstate_adjust_perf(unsigned int cpu,

Quoted 8 lines
drivers/cpufreq/amd-pstate.c +1 -1
@@ -307,6 +307,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu,
                max_perf = min_perf;
 
        amd_pstate_update(cpudata, min_perf, des_perf, max_perf, true);
+       cpufreq_cpu_put(policy);
 }
 
 static int amd_get_min_freq(struct amd_cpudata *cpudata)
--

Applied as 6.2-rc material, thanks!