Skip to contentSkip to conversation

iio: light : max44009 : Convert to i2c's .probe_new()

PATCH In review Anup Sharma 2 participants 2 messages Jan 10, 2023 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: light : max44009 : Convert to i2c's .probe_new()

The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted.

---
 drivers/iio/light/max44009.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/iio/light/max44009.c +2 -3
index 801e5a0ad496..3dadace09fe2 100644
@@ -487,8 +487,7 @@ static irqreturn_t max44009_threaded_irq_handler(int irq, void *p)
 	return IRQ_NONE;
 }
 
-static int max44009_probe(struct i2c_client *client,
-			  const struct i2c_device_id *id)
+static int max44009_probe(struct i2c_client *client)
 {
 	struct max44009_data *data;
 	struct iio_dev *indio_dev;
@@ -538,7 +537,7 @@ static struct i2c_driver max44009_driver = {
 	.driver = {
 		.name = MAX44009_DRV_NAME,
 	},
-	.probe = max44009_probe,
+	.probe_new = max44009_probe,
 	.id_table = max44009_id,
 };
 module_i2c_driver(max44009_driver);
Signature · 1 line
2.34.1
#1 lore raw
Quoted 4 lines · On Tue, 10 Jan 2023 21:48:19 +0530 Anup Sharma <[email protected]> wrote:

The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted.

This driver didn't get converted due to a mess up by me when applying patches. I've now picked up Uwe's original patch.

https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=testing&id=22cd9320b11a2eb05e5d490863a4219ca32e8ec9

Quoted 27 lines
---
 drivers/iio/light/max44009.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/iio/light/max44009.c +2 -3
index 801e5a0ad496..3dadace09fe2 100644
@@ -487,8 +487,7 @@ static irqreturn_t max44009_threaded_irq_handler(int irq, void *p)
 	return IRQ_NONE;
 }
 
-static int max44009_probe(struct i2c_client *client,
-			  const struct i2c_device_id *id)
+static int max44009_probe(struct i2c_client *client)
 {
 	struct max44009_data *data;
 	struct iio_dev *indio_dev;
@@ -538,7 +537,7 @@ static struct i2c_driver max44009_driver = {
 	.driver = {
 		.name = MAX44009_DRV_NAME,
 	},
-	.probe = max44009_probe,
+	.probe_new = max44009_probe,
 	.id_table = max44009_id,
 };
 module_i2c_driver(max44009_driver);