Skip to contentSkip to conversation

nommu: Fix do_munmap() error path

PATCH New Liam Howlett 1 participant 1 message Jan 10, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 nommu: Fix do_munmap() error path

When removing a VMA from the tree fails due to no memory, do not free the VMA since a reference still exists.

Fixes 8220543df148 ("nommu: remove uses of VMA linked list")

---

Changes since v1:
- Added 'Cc: [email protected]' to commit message

 mm/nommu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
mm/nommu.c +2 -1
index c8252f01d5db..844af5be7640 100644
@@ -1509,7 +1509,8 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list
 erase_whole_vma:
 	if (delete_vma_from_mm(vma))
 		ret = -ENOMEM;
-	delete_vma(mm, vma);
+	else
+		delete_vma(mm, vma);
 	return ret;
 }
 
Signature · 1 line
2.35.1