Skip to contentSkip to conversation

drm/mediatek: stop using 0 as NULL pointer

PATCH In review Miles Chen 2 participants 3 messages Jan 10, 2023 – Jan 11, 2023

Subsystems (3)
lore
Share & tools
lore

Miles Chen

author
#0 lore raw

PATCH 1/1 drm/mediatek: stop using 0 as NULL pointer

Use NULL for NULL pointer to fix the following sparse warning:
drivers/gpu/drm/mediatek/mtk_drm_gem.c:265:27: sparse: warning: Using plain integer as NULL pointer

---
 drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/mediatek/mtk_drm_gem.c +1 -1
index 47e96b0289f9..06aadd5e7f5b 100644
@@ -262,6 +262,6 @@ void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj,
 		return;
 
 	vunmap(vaddr);
-	mtk_gem->kvaddr = 0;
+	mtk_gem->kvaddr = NULL;
 	kfree(mtk_gem->pages);
 }
Signature · 1 line
2.18.0
maintainer Reviewed-by on v1 1/1
#1 lore raw

Il 10/01/23 04:12, Miles Chen ha scritto:

Quoted 4 lines

Use NULL for NULL pointer to fix the following sparse warning:
drivers/gpu/drm/mediatek/mtk_drm_gem.c:265:27: sparse: warning: Using plain integer as NULL pointer

Please add the appropriate tag...

Fixes 3df64d7b0a4f ("drm/mediatek: Implement gem prime vmap/vunmap function")

after which:

author
#2 lore raw

Hi Angelo,

Quoted 9 lines

Il 10/01/23 04:12, Miles Chen ha scritto:

Quoted 4 lines

Use NULL for NULL pointer to fix the following sparse warning:
drivers/gpu/drm/mediatek/mtk_drm_gem.c:265:27: sparse: warning: Using plain integer as NULL pointer

Please add the appropriate tag...

Fixes 3df64d7b0a4f ("drm/mediatek: Implement gem prime vmap/vunmap function")

No problem, I will add the Fixes tag and submit v2.

thanks,
Miles

Quoted 4 lines

after which: