Skip to contentSkip to conversation

drm/mediatek: stop using 0 as NULL pointer

PATCH Applied Miles Chen 2 participants 2 messages Jan 11, 2023 – Jan 27, 2023

Subsystems (3)
lore
Share & tools
lore

Miles Chen

author
#0 lore raw

PATCH v2 1/1 drm/mediatek: stop using 0 as NULL pointer

Use NULL for NULL pointer to fix the following sparse warning:
drivers/gpu/drm/mediatek/mtk_drm_gem.c:265:27: sparse: warning: Using plain integer as NULL pointer

Fixes 3df64d7b0a4f ("drm/mediatek: Implement gem prime vmap/vunmap function")

---

Change since v1:
Add Fixes tag

---
 drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/mediatek/mtk_drm_gem.c +1 -1
index 47e96b0289f9..06aadd5e7f5b 100644
@@ -262,6 +262,6 @@ void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj,
 		return;
 
 	vunmap(vaddr);
-	mtk_gem->kvaddr = 0;
+	mtk_gem->kvaddr = NULL;
 	kfree(mtk_gem->pages);
 }
Signature · 1 line
2.18.0
maintainer Applied
#1 lore raw

Hi, Miles:

Miles Chen <[email protected]> 於 2023年1月11日 週三 上午10:52寫道:

Quoted 3 lines

Use NULL for NULL pointer to fix the following sparse warning:
drivers/gpu/drm/mediatek/mtk_drm_gem.c:265:27: sparse: warning: Using plain integer as NULL pointer

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

Quoted 29 lines
Fixes 3df64d7b0a4f ("drm/mediatek: Implement gem prime vmap/vunmap function")

---

Change since v1:
Add Fixes tag

---
 drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/mediatek/mtk_drm_gem.c +1 -2
index 47e96b0289f9..06aadd5e7f5b 100644
@@ -262,6 +262,6 @@ void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj,
                return;
 
        vunmap(vaddr);
-       mtk_gem->kvaddr = 0;
+       mtk_gem->kvaddr = NULL;
        kfree(mtk_gem->pages);
 }
--

2.18.0