Enable USB host on Jetson AGX Orin
Subsystems (6)
Jon Hunter
maintainerv6 cover Enable USB host on Jetson AGX Orin
Enable support for USB host on the Tegra234 Jetson AGX Orin platform. This series is based upon the previous series [0] to enable USB host and device for this platform, however, for now we have dropped USB device support and support for the type-c connector while we resolve review comments for these changes.
[0] https://lore.kernel.org/linux-tegra/[email protected]/
Jon Hunter (1):
dt-bindings: phy: tegra-xusb: Add support for Tegra234
Sing-Han Chen (2):
phy: tegra: xusb: Add Tegra234 support
usb: host: xhci-tegra: Add Tegra234 XHCI support
Wayne Chang (3):
dt-bindings: usb: Add NVIDIA Tegra234 XUSB host controller binding
arm64: tegra: Enable XUSB host function on Jetson AGX Orin
phy: tegra: xusb: Disable trk clk when not in use
.../phy/nvidia,tegra194-xusb-padctl.yaml | 4 +- .../bindings/usb/nvidia,tegra234-xusb.yaml | 159 +++++++++++ .../boot/dts/nvidia/tegra234-p3701-0000.dtsi | 48 ++++ .../nvidia/tegra234-p3737-0000+p3701-0000.dts | 93 ++++++ arch/arm64/boot/dts/nvidia/tegra234.dtsi | 145 ++++++++++ drivers/phy/tegra/Makefile | 1 + drivers/phy/tegra/xusb-tegra186.c | 64 ++++- drivers/phy/tegra/xusb.c | 6 + drivers/phy/tegra/xusb.h | 23 ++ drivers/usb/host/xhci-tegra.c | 267 +++++++++++++++--- 10 files changed, 768 insertions(+), 42 deletions(-) create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml
Signature · 1 line
2.25.1
Jon Hunter
maintainerPATCH v6 1/6 dt-bindings: usb: Add NVIDIA Tegra234 XUSB host controller binding
From: Wayne Chang <[email protected]>
Add device-tree binding documentation for the XUSB host controller present on Tegra234 SoC. This controller supports the USB 3.1 specification.
---
V5 -> V6: Updated main description and register description.
Corrected 'dma-coherent'.
V4 -> V5: No changes
V3 -> V4: minor update to the power-domain description V2 -> V3: nothing has changed
V1 -> V2: address the issue on phy-names property
.../bindings/usb/nvidia,tegra234-xusb.yaml | 159 ++++++++++++++++++ 1 file changed, 159 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml
Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml new file +159 -0
@@ -0,0 +1,159 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/nvidia,tegra234-xusb.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NVIDIA Tegra234 xHCI controller + +maintainers: + - Thierry Reding <[email protected]> + - Jon Hunter <[email protected]> + +description: | + The Tegra xHCI controller supports both USB2 and USB3 interfaces exposed by + the Tegra XUSB pad controller. The xHCI controller controls up to eight + ports; there are four USB 2.0 ports and four USB 3.2 Gen1 x1 ports. + +properties: + compatible: + const: nvidia,tegra234-xusb + + reg: + items: + - description: xHCI host registers + - description: XUSB FPCI registers + - description: XUSB bar2 registers + + reg-names: + items: + - const: hcd + - const: fpci + - const: bar2 + + interrupts: + items: + - description: xHCI host interrupt + - description: mailbox interrupt + + clocks: + items: + - description: XUSB host clock + - description: XUSB Falcon source clock + - description: XUSB SuperSpeed clock + - description: XUSB SuperSpeed source clock + - description: XUSB HighSpeed clock source + - description: XUSB FullSpeed clock source + - description: USB PLL + - description: reference clock + - description: I/O PLL + + clock-names: + items: + - const: xusb_host + - const: xusb_falcon_src + - const: xusb_ss + - const: xusb_ss_src + - const: xusb_hs_src + - const: xusb_fs_src + - const: pll_u_480m + - const: clk_m + - const: pll_e + + interconnects: + items: + - description: read client + - description: write client + + interconnect-names: + items: + - const: dma-mem # read + - const: write + + iommus: + maxItems: 1 + + nvidia,xusb-padctl: + $ref: /schemas/types.yaml#/definitions/phandle + description: phandle to the XUSB pad controller that is used to configure + the USB pads used by the XHCI controller + + phys: + minItems: 1 + maxItems: 8 + + phy-names: + minItems: 1 + maxItems: 8 + items: + enum: + - usb2-0 + - usb2-1 + - usb2-2 + - usb2-3 + - usb3-0 + - usb3-1 + - usb3-2 + - usb3-3 + + power-domains: + items: + - description: XUSBC power domain (for Host and USB 2.0) + - description: XUSBA power domain (for SuperSpeed) + + power-domain-names: + items: + - const: xusb_host + - const: xusb_ss + + dma-coherent: true + +allOf: + - $ref: usb-xhci.yaml + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/tegra234-clock.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/memory/tegra234-mc.h> + #include <dt-bindings/power/tegra234-powergate.h> + + usb@3610000 { + compatible = "nvidia,tegra234-xusb"; + reg = <0x03610000 0x40000>, + <0x03600000 0x10000>, + <0x03650000 0x10000>; + reg-names = "hcd", "fpci", "bar2"; + + interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>; + + clocks = <&bpmp TEGRA234_CLK_XUSB_CORE_HOST>, + <&bpmp TEGRA234_CLK_XUSB_FALCON>, + <&bpmp TEGRA234_CLK_XUSB_CORE_SS>, + <&bpmp TEGRA234_CLK_XUSB_SS>, + <&bpmp TEGRA234_CLK_CLK_M>, + <&bpmp TEGRA234_CLK_XUSB_FS>, + <&bpmp TEGRA234_CLK_UTMIP_PLL>, + <&bpmp TEGRA234_CLK_CLK_M>, + <&bpmp TEGRA234_CLK_PLLE>; + clock-names = "xusb_host", "xusb_falcon_src", + "xusb_ss", "xusb_ss_src", "xusb_hs_src", + "xusb_fs_src", "pll_u_480m", "clk_m", + "pll_e"; + interconnects = <&mc TEGRA234_MEMORY_CLIENT_XUSB_HOSTR &emc>, + <&mc TEGRA234_MEMORY_CLIENT_XUSB_HOSTW &emc>; + interconnect-names = "dma-mem", "write"; + iommus = <&smmu_niso1 TEGRA234_SID_XUSB_HOST>; + + power-domains = <&bpmp TEGRA234_POWER_DOMAIN_XUSBC>, + <&bpmp TEGRA234_POWER_DOMAIN_XUSBA>; + power-domain-names = "xusb_host", "xusb_ss"; + + nvidia,xusb-padctl = <&xusb_padctl>; + + phys = <&pad_lanes_usb2_0>; + phy-names = "usb2-0"; + };
Signature · 7 lines
2.25.1 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Re: [PATCH V6 1/6] dt-bindings: usb: Add NVIDIA Tegra234 XUSB host controller binding
Quoted 16 lines · Jon Hunter
From: Wayne Chang <[email protected]>
Add device-tree binding documentation for the XUSB host controller present on Tegra234 SoC. This controller supports the USB 3.1 specification.
Signed-off-by Wayne Chang <[email protected]>Signed-off-by Thierry Reding <[email protected]>Signed-off-by Jon Hunter <[email protected]>---
V5 -> V6: Updated main description and register description.
Corrected 'dma-coherent'.
V4 -> V5: No changes
V3 -> V4: minor update to the power-domain description V2 -> V3: nothing has changed
V1 -> V2: address the issue on phy-names property
Quoted 4 lines
.../bindings/usb/nvidia,tegra234-xusb.yaml | 159 ++++++++++++++++++ 1 file changed, 159 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml
Jon Hunter
maintainerPATCH v6 2/6 dt-bindings: phy: tegra-xusb: Add support for Tegra234
In reply to Jon HunterAdd the compatible string for the Tegra234 XUSB PHY.
---
V5 -> V6: Added Krzysztof's ACK
V3 -> V5: Fixed compatible string
V3 -> V4: Added patch
.../devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml +3 -1
@@ -42,7 +42,9 @@ description: properties: compatible: - const: nvidia,tegra194-xusb-padctl + enum: + - nvidia,tegra194-xusb-padctl + - nvidia,tegra234-xusb-padctl reg: items:
Signature · 7 lines
2.25.1 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Re: [PATCH V6 2/6] dt-bindings: phy: tegra-xusb: Add support for Tegra234
Quoted 11 lines · Jon Hunter
Add the compatible string for the Tegra234 XUSB PHY.
Signed-off-by Jon Hunter <[email protected]>---
V5 -> V6: Added Krzysztof's ACK
V3 -> V5: Fixed compatible string
V3 -> V4: Added patch.../devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Hi Vinod,
can you pick this up into your tree? This applies on top of the conversion patch ("dt-bindings: phy: tegra-xusb: Convert to json-schema") that's aready in your next branch.
Thanks,
Thierry
Vinod Koul
maintainerRe: [PATCH V6 2/6] dt-bindings: phy: tegra-xusb: Add support for Tegra234
Quoted 10 lines · Thierry Reding
Quoted 9 lines · Jon Hunter
Add the compatible string for the Tegra234 XUSB PHY.
Signed-off-by Jon Hunter <[email protected]>---
V5 -> V6: Added Krzysztof's ACK
V3 -> V5: Fixed compatible string
V3 -> V4: Added patch
Quoted 8 lines
Quoted 2 lines
.../devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)Hi Vinod,
can you pick this up into your tree? This applies on top of the conversion patch ("dt-bindings: phy: tegra-xusb: Convert to json-schema") that's aready in your next branch.
Applied now, thanks for pinging
Signature · 1 line
~Vinod
Jon Hunter
maintainerPATCH v6 3/6 arm64: tegra: Enable XUSB host function on Jetson AGX Orin
In reply to Jon HunterFrom: Wayne Chang <[email protected]>
This commit enables XUSB host and pad controller on Jetson AGX Orin.
---
V4 -> V6: No changes
V3 -> V4: dropped support for the USB device and type-c connector V2 -> V3: nothing has changed but added the dependency here V1 -> V2: removed the redundant cells and status in ucsi-cc
.../boot/dts/nvidia/tegra234-p3701-0000.dtsi | 48 ++++++ .../nvidia/tegra234-p3737-0000+p3701-0000.dts | 93 +++++++++++ arch/arm64/boot/dts/nvidia/tegra234.dtsi | 145 ++++++++++++++++++ 3 files changed, 286 insertions(+)
arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi +48 -0
@@ -67,6 +67,29 @@ mmc@3460000 { non-removable; }; + padctl@3520000 { + vclamp-usb-supply = <&vdd_ao_1v8>; + avdd-usb-supply = <&vdd_ao_3v3>; + + ports { + usb2-0 { + vbus-supply = <&vdd_5v0_sys>; + }; + + usb2-1 { + vbus-supply = <&vdd_5v0_sys>; + }; + + usb2-2 { + vbus-supply = <&vdd_5v0_sys>; + }; + + usb2-3 { + vbus-supply = <&vdd_5v0_sys>; + }; + }; + }; + rtc@c2a0000 { status = "okay"; };
@@ -75,4 +98,29 @@ pmc@c360000 { nvidia,invert-interrupt; }; }; + + vdd_5v0_sys: regulator-vdd-5v0-sys { + compatible = "regulator-fixed"; + regulator-name = "VIN_SYS_5V0"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + regulator-boot-on; + }; + + vdd_ao_1v8: regulator-vdd-1v8-ao { + compatible = "regulator-fixed"; + regulator-name = "vdd-AO-1v8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + }; + + vdd_ao_3v3: regulator-vdd-3v3-ao { + compatible = "regulator-fixed"; + regulator-name = "vdd-AO-3v3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; };
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts +93 -0
99 lines not on this page · raw message
arch/arm64/boot/dts/nvidia/tegra234.dtsi +145 -0
151 lines not on this page · raw message
Signature · 1 line
2.25.1
Jon Hunter
maintainerPATCH v6 4/6 phy: tegra: xusb: Disable trk clk when not in use
In reply to Jon HunterFrom: Wayne Chang <[email protected]>
Pad tracking is a one-time calibration for Tegra186 and Tegra194. Clk should be disabled after calibration.
Disable clk after calibration.
While at it add 100us delay for HW recording the calibration value.
---
V2 -> V6: no changes
V1 -> V2: update the commit message
drivers/phy/tegra/xusb-tegra186.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/phy/tegra/xusb-tegra186.c +4 -2
@@ -609,6 +609,10 @@ static void tegra186_utmi_bias_pad_power_on(struct tegra_xusb_padctl *padctl) value &= ~USB2_PD_TRK ;padctl_writel (padctl, value,XUSB_PADCTL_USB2_BIAS_PAD_CTL1 ); +udelay (100 ); + +clk_disable_unprepare (priv->usb2_trk_clk); +mutex_unlock (&padctl->lock); }
@@ -633,8 +637,6 @@ static void tegra186_utmi_bias_pad_power_off(struct tegra_xusb_padctl *padctl) value |=USB2_PD_TRK ;padctl_writel (padctl, value,XUSB_PADCTL_USB2_BIAS_PAD_CTL1 ); -clk_disable_unprepare (priv->usb2_trk_clk); -mutex_unlock (&padctl->lock); }
Signature · 1 line
2.25.1
Re: [PATCH V6 4/6] phy: tegra: xusb: Disable trk clk when not in use
Quoted 7 lines · Jon Hunter
From: Wayne Chang <[email protected]>
Pad tracking is a one-time calibration for Tegra186 and Tegra194. Clk should be disabled after calibration.
Disable clk after calibration.
While at it add 100us delay for HW recording the calibration value.
I have applied these two, somehow replied to an older thread..
Sorry for the noise
Signature · 6 lines
~Vinod -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Jon Hunter
maintainerPATCH v6 5/6 phy: tegra: xusb: Add Tegra234 support
In reply to Jon HunterFrom: Sing-Han Chen <[email protected]>
Add support for the XUSB pad controller found on Tegra234 SoCs. It is mostly similar to the same IP found on Tegra194, because most of the Tegra234 XUSB PADCTL registers definition and programming sequence are the same as Tegra194, Tegra234 XUSB PADCTL can share the same driver with Tegra186 and Tegra194 XUSB PADCTL.
Introduce a new feature, USB2 HW tracking, for Tegra234. The feature is to enable HW periodical PAD tracking which measure and capture the electric parameters of USB2.0 PAD.
---
V4 -> V6: no changes
V3 -> V4: fixed checkpatch warnings
V2 -> V3: nothing has changed
V1 -> V2: remove atomic and the helper in padctl_readl_poll
drivers/phy/tegra/Makefile | 1 + drivers/phy/tegra/xusb-tegra186.c | 64 +++++++++++++++++++++++++++++-- drivers/phy/tegra/xusb.c | 6 +++ drivers/phy/tegra/xusb.h | 23 +++++++++++ 4 files changed, 91 insertions(+), 3 deletions(-)
drivers/phy/tegra/Makefile +1 -0
@@ -7,4 +7,5 @@ phy-tegra-xusb-$(CONFIG_ARCH_TEGRA_132_SOC) += xusb-tegra124.o phy-tegra-xusb-$(CONFIG_ARCH_TEGRA_210_SOC) += xusb-tegra210.o phy-tegra-xusb-$(CONFIG_ARCH_TEGRA_186_SOC) += xusb-tegra186.o phy-tegra-xusb-$(CONFIG_ARCH_TEGRA_194_SOC) += xusb-tegra186.o +phy-tegra-xusb-$(CONFIG_ARCH_TEGRA_234_SOC) += xusb-tegra186.o obj-$(CONFIG_PHY_TEGRA194_P2U) += phy-tegra194-p2u.o
drivers/phy/tegra/xusb-tegra186.c +61 -3
97 lines not on this page · raw message
drivers/phy/tegra/xusb.c +6 -0
@@ -71,6 +71,12 @@ static const struct of_device_id tegra_xusb_padctl_of_match[] = { .compatible = "nvidia,tegra194-xusb-padctl", .data = &tegra194_xusb_padctl_soc, }, +#endif +#if defined(CONFIG_ARCH_TEGRA_234_SOC ) + { + .compatible = "nvidia,tegra234-xusb-padctl", + .data = &tegra234_xusb_padctl_soc, + }, #endif { } };
drivers/phy/tegra/xusb.h +23 -0
@@ -8,6 +8,7 @@#define __PHY_TEGRA_XUSB_H#include <linux/io.h> +#include <linux/iopoll.h> #include <linux/mutex.h> #include <linux/workqueue.h>
@@ -431,6 +432,8 @@ struct tegra_xusb_padctl_soc {unsigned int num_supplies;bool supports_gen2;bool need_fake_usb3_port; +bool poll_trk_completed; +bool trk_hw_mode; };struct tegra_xusb_padctl {
@@ -473,6 +476,23 @@ static inline u32 padctl_readl(struct tegra_xusb_padctl *padctl,return value; } +static inline u32 padctl_readl_poll (struct tegra_xusb_padctl *padctl, +unsigned long offset,u32 val,u32 mask, +int us) +{ +u32 regval; +int err; + + err =readl_poll_timeout (padctl->regs + offset, regval, + (regval & mask) == val,1 , us); +if (err) { +dev_err (padctl->dev,"%08lx poll timeout > %08x\n" , offset, + regval); + } + +return err; +} +struct tegra_xusb_lane *tegra_xusb_find_lane (struct tegra_xusb_padctl *padctl,const char *name,unsigned int index);
@@ -489,5 +509,8 @@ extern const struct tegra_xusb_padctl_soc tegra186_xusb_padctl_soc;#if defined(CONFIG_ARCH_TEGRA_194_SOC )extern const struct tegra_xusb_padctl_soc tegra194_xusb_padctl_soc;#endif +#if defined(CONFIG_ARCH_TEGRA_234_SOC ) +extern const struct tegra_xusb_padctl_soc tegra234_xusb_padctl_soc; +#endif #endif /* __PHY_TEGRA_XUSB_H */
Signature · 7 lines
2.25.1 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Jon Hunter
maintainerPATCH v6 6/6 usb: host: xhci-tegra: Add Tegra234 XHCI support
In reply to Jon HunterFrom: Sing-Han Chen <[email protected]>
This change adds Tegra234 XUSB host mode controller support.
In Tegra234, some of the registers have moved to bar2 space. The new soc variable has_bar2 indicates the chip with bar2 area. This patch adds new reg helper to let the driver reuse the same code for those chips with bar2 support.
---
V4 -> V6: no changes
V3 -> V4: fixed checkpatch warnings
V2 -> V3: nothing has changed
V1 -> V2: fix some issues on coding style
drivers/usb/host/xhci-tegra.c | 267 +++++++++++++++++++++++++++++----- 1 file changed, 228 insertions(+), 39 deletions(-)
drivers/usb/host/xhci-tegra.c +228 -39
@@ -44,6 +44,9 @@#define XUSB_CFG_4 0x010#define XUSB_BASE_ADDR_SHIFT 15#define XUSB_BASE_ADDR_MASK 0x1ffff +#define XUSB_CFG_7 0x01c +#define XUSB_BASE2_ADDR_SHIFT 16 +#define XUSB_BASE2_ADDR_MASK 0xffff#define XUSB_CFG_16 0x040#define XUSB_CFG_24 0x060#define XUSB_CFG_AXI_CFG 0x0f8
@@ -75,6 +78,20 @@#define MBOX_SMI_INTR_FW_HANG BIT(1)#define MBOX_SMI_INTR_EN BIT(3) +/* BAR2 registers */ +#define XUSB_BAR2_ARU_MBOX_CMD 0x004 +#define XUSB_BAR2_ARU_MBOX_DATA_IN 0x008 +#define XUSB_BAR2_ARU_MBOX_DATA_OUT 0x00c +#define XUSB_BAR2_ARU_MBOX_OWNER 0x010 +#define XUSB_BAR2_ARU_SMI_INTR 0x014 +#define XUSB_BAR2_ARU_SMI_ARU_FW_SCRATCH_DATA0 0x01c +#define XUSB_BAR2_ARU_IFRDMA_CFG0 0x0e0 +#define XUSB_BAR2_ARU_IFRDMA_CFG1 0x0e4 +#define XUSB_BAR2_ARU_IFRDMA_STREAMID_FIELD 0x0e8 +#define XUSB_BAR2_ARU_C11_CSBRANGE 0x9c +#define XUSB_BAR2_ARU_FW_SCRATCH 0x1000 +#define XUSB_BAR2_CSB_BASE_ADDR 0x2000 +/* IPFS registers */ #define IPFS_XUSB_HOST_MSI_BAR_SZ_0 0x0c0#define IPFS_XUSB_HOST_MSI_AXI_BAR_ST_0 0x0c4
@@ -111,6 +128,9 @@#define IMFILLRNG1_TAG_HI_SHIFT 16#define XUSB_FALC_IMFILLCTL 0x158 +/* CSB ARU registers */ +#define XUSB_CSB_ARU_SCRATCH0 0x100100 +/* MP CSB registers */ #define XUSB_CSB_MP_ILOAD_ATTR 0x101a00#define XUSB_CSB_MP_ILOAD_BASE_LO 0x101a04
@@ -131,6 +151,9 @@#define IMEM_BLOCK_SIZE 256 +#define FW_IOCTL_TYPE_SHIFT 24 +#define FW_IOCTL_CFGTBL_READ 17 +struct tegra_xusb_fw_header {__le32 boot_loadaddr_in_imem;__le32 boot_codedfi_offset;
@@ -175,6 +198,7 @@ struct tegra_xusb_mbox_regs {u16 data_in;u16 data_out;u16 owner; +u16 smi_intr; };struct tegra_xusb_context_soc {
@@ -189,6 +213,14 @@ struct tegra_xusb_context_soc { } fpci; }; +struct tegra_xusb ; +struct tegra_xusb_soc_ops { +u32 (*mbox_reg_readl)(struct tegra_xusb *tegra,unsigned int offset); +void (*mbox_reg_writel)(struct tegra_xusb *tegra,u32 value,unsigned int offset); +u32 (*csb_reg_readl)(struct tegra_xusb *tegra,unsigned int offset); +void (*csb_reg_writel)(struct tegra_xusb *tegra,u32 value,unsigned int offset); +}; +struct tegra_xusb_soc {const char *firmware;const char *const *supply_names;
@@ -205,11 +237,14 @@ struct tegra_xusb_soc { } ports;struct tegra_xusb_mbox_regs mbox; +const struct tegra_xusb_soc_ops *ops;bool scale_ss_clock;bool has_ipfs;bool lpm_support;bool otg_reset_sspi; + +bool has_bar2; };struct tegra_xusb_context {
@@ -230,6 +265,8 @@ struct tegra_xusb {void __iomem *ipfs_base;void __iomem *fpci_base; +void __iomem *bar2_base; +struct resource *bar2;const struct tegra_xusb_soc *soc;
@@ -301,7 +338,33 @@ static inline void ipfs_writel(struct tegra_xusb *tegra, u32 value,writel (value, tegra->ipfs_base + offset); } +static inline u32 bar2_readl (struct tegra_xusb *tegra,unsigned int offset) +{ +return readl (tegra->bar2_base + offset); +} + +static inline void bar2_writel (struct tegra_xusb *tegra,u32 value, +unsigned int offset) +{ +writel (value, tegra->bar2_base + offset); +} +static u32 csb_readl (struct tegra_xusb *tegra,unsigned int offset) +{ +const struct tegra_xusb_soc_ops *ops = tegra->soc->ops; + +return ops->csb_reg_readl (tegra, offset); +} + +static void csb_writel (struct tegra_xusb *tegra,u32 value, +unsigned int offset) +{ +const struct tegra_xusb_soc_ops *ops = tegra->soc->ops; + + ops->csb_reg_writel (tegra, value, offset); +} + +static u32 fpci_csb_readl (struct tegra_xusb *tegra,unsigned int offset) {u32 page =CSB_PAGE_SELECT (offset);u32 ofs =CSB_PAGE_OFFSET (offset);
@@ -311,8 +374,8 @@ static u32 csb_readl(struct tegra_xusb *tegra, unsigned int offset)return fpci_readl (tegra,XUSB_CFG_CSB_BASE_ADDR + ofs); } -static void csb_writel (struct tegra_xusb *tegra,u32 value, -unsigned int offset) +static void fpci_csb_writel (struct tegra_xusb *tegra,u32 value, +unsigned int offset) {u32 page =CSB_PAGE_SELECT (offset);u32 ofs =CSB_PAGE_OFFSET (offset);
@@ -321,6 +384,26 @@ static void csb_writel(struct tegra_xusb *tegra, u32 value,fpci_writel (tegra, value,XUSB_CFG_CSB_BASE_ADDR + ofs); } +static u32 bar2_csb_readl (struct tegra_xusb *tegra,unsigned int offset) +{ +u32 page =CSB_PAGE_SELECT (offset); +u32 ofs =CSB_PAGE_OFFSET (offset); + +bar2_writel (tegra, page,XUSB_BAR2_ARU_C11_CSBRANGE ); + +return bar2_readl (tegra,XUSB_BAR2_CSB_BASE_ADDR + ofs); +} + +static void bar2_csb_writel (struct tegra_xusb *tegra,u32 value, +unsigned int offset) +{ +u32 page =CSB_PAGE_SELECT (offset); +u32 ofs =CSB_PAGE_OFFSET (offset); + +bar2_writel (tegra, page,XUSB_BAR2_ARU_C11_CSBRANGE ); +bar2_writel (tegra, value,XUSB_BAR2_CSB_BASE_ADDR + ofs); +} +static int tegra_xusb_set_ss_clk (struct tegra_xusb *tegra,unsigned long rate) {
@@ -452,6 +535,7 @@ static bool tegra_xusb_mbox_cmd_requires_ack(enum tegra_xusb_mbox_cmd cmd)static int tegra_xusb_mbox_send (struct tegra_xusb *tegra,const struct tegra_xusb_mbox_msg *msg) { +const struct tegra_xusb_soc_ops *ops = tegra->soc->ops;bool wait_for_idle = false;u32 value;
@@ -460,15 +544,15 @@ static int tegra_xusb_mbox_send(struct tegra_xusb *tegra,* ACK/NAK messages. */ if (!(msg->cmd ==MBOX_CMD_ACK || msg->cmd ==MBOX_CMD_NAK )) { - value =fpci_readl (tegra, tegra->soc->mbox.owner); + value = ops->mbox_reg_readl (tegra, tegra->soc->mbox.owner);if (value !=MBOX_OWNER_NONE ) {dev_err (tegra->dev,"mailbox is busy\n" );return -EBUSY ; } -fpci_writel (tegra,MBOX_OWNER_SW , tegra->soc->mbox.owner); + ops->mbox_reg_writel (tegra,MBOX_OWNER_SW , tegra->soc->mbox.owner); - value =fpci_readl (tegra, tegra->soc->mbox.owner); + value = ops->mbox_reg_readl (tegra, tegra->soc->mbox.owner);if (value !=MBOX_OWNER_SW ) {dev_err (tegra->dev,"failed to acquire mailbox\n" );return -EBUSY ;
@@ -478,17 +562,17 @@ static int tegra_xusb_mbox_send(struct tegra_xusb *tegra, } value =tegra_xusb_mbox_pack (msg); -fpci_writel (tegra, value, tegra->soc->mbox.data_in); + ops->mbox_reg_writel (tegra, value, tegra->soc->mbox.data_in); - value =fpci_readl (tegra, tegra->soc->mbox.cmd); + value = ops->mbox_reg_readl (tegra, tegra->soc->mbox.cmd); value |=MBOX_INT_EN |MBOX_DEST_FALC ; -fpci_writel (tegra, value, tegra->soc->mbox.cmd); + ops->mbox_reg_writel (tegra, value, tegra->soc->mbox.cmd);if (wait_for_idle) {unsigned long timeout = jiffies +msecs_to_jiffies (250 );while (time_before (jiffies, timeout)) { - value =fpci_readl (tegra, tegra->soc->mbox.owner); + value = ops->mbox_reg_readl (tegra, tegra->soc->mbox.owner);if (value ==MBOX_OWNER_NONE )break ;
@@ -496,7 +580,7 @@ static int tegra_xusb_mbox_send(struct tegra_xusb *tegra, }if (time_after (jiffies, timeout)) - value =fpci_readl (tegra, tegra->soc->mbox.owner); + value = ops->mbox_reg_readl (tegra, tegra->soc->mbox.owner);if (value !=MBOX_OWNER_NONE )return -ETIMEDOUT ;
@@ -508,11 +592,12 @@ static int tegra_xusb_mbox_send(struct tegra_xusb *tegra,static irqreturn_t tegra_xusb_mbox_irq (int irq,void *data) {struct tegra_xusb *tegra = data; +const struct tegra_xusb_soc_ops *ops = tegra->soc->ops;u32 value;/* clear mailbox interrupts */ - value =fpci_readl (tegra,XUSB_CFG_ARU_SMI_INTR ); -fpci_writel (tegra, value,XUSB_CFG_ARU_SMI_INTR ); + value = ops->mbox_reg_readl (tegra, tegra->soc->mbox.smi_intr); + ops->mbox_reg_writel (tegra, value, tegra->soc->mbox.smi_intr);if (value &MBOX_SMI_INTR_FW_HANG )dev_err (tegra->dev,"controller firmware hang\n" );
@@ -665,6 +750,7 @@ static void tegra_xusb_mbox_handle(struct tegra_xusb *tegra,static irqreturn_t tegra_xusb_mbox_thread (int irq,void *data) {struct tegra_xusb *tegra = data; +const struct tegra_xusb_soc_ops *ops = tegra->soc->ops;struct tegra_xusb_mbox_msg msg;u32 value;
@@ -673,16 +759,16 @@ static irqreturn_t tegra_xusb_mbox_thread(int irq, void *data)if (pm_runtime_suspended (tegra->dev) || tegra->suspended) goto out; - value =fpci_readl (tegra, tegra->soc->mbox.data_out); + value = ops->mbox_reg_readl (tegra, tegra->soc->mbox.data_out);tegra_xusb_mbox_unpack (&msg, value); - value =fpci_readl (tegra, tegra->soc->mbox.cmd); + value = ops->mbox_reg_readl (tegra, tegra->soc->mbox.cmd); value &= ~MBOX_DEST_SMI ; -fpci_writel (tegra, value, tegra->soc->mbox.cmd); + ops->mbox_reg_writel (tegra, value, tegra->soc->mbox.cmd);/* clear mailbox owner if no ACK/NAK is required */ if (!tegra_xusb_mbox_cmd_requires_ack (msg.cmd)) -fpci_writel (tegra,MBOX_OWNER_NONE , tegra->soc->mbox.owner); + ops->mbox_reg_writel (tegra,MBOX_OWNER_NONE , tegra->soc->mbox.owner);tegra_xusb_mbox_handle (tegra, &msg);
@@ -710,6 +796,15 @@ static void tegra_xusb_config(struct tegra_xusb *tegra) value |= regs & (XUSB_BASE_ADDR_MASK <<XUSB_BASE_ADDR_SHIFT );fpci_writel (tegra, value,XUSB_CFG_4 ); +/* Program BAR2 space */ +if (tegra->bar2) { + value =fpci_readl (tegra,XUSB_CFG_7 ); + value &= ~(XUSB_BASE2_ADDR_MASK <<XUSB_BASE2_ADDR_SHIFT ); + value |= tegra->bar2->start & + (XUSB_BASE2_ADDR_MASK <<XUSB_BASE2_ADDR_SHIFT ); +fpci_writel (tegra, value,XUSB_CFG_7 ); + } +usleep_range (100 ,200 );/* Enable bus master */
@@ -882,21 +977,36 @@ static int tegra_xusb_request_firmware(struct tegra_xusb *tegra)return 0 ; } -static int tegra_xusb_load_firmware (struct tegra_xusb *tegra) +static int tegra_xusb_wait_for_falcon (struct tegra_xusb *tegra) +{ +struct xhci_cap_regs __iomem *cap_regs; +struct xhci_op_regs __iomem *op_regs; +int ret; +u32 value; + + cap_regs = tegra->regs; + op_regs = tegra->regs +HC_LENGTH (readl (&cap_regs->hc_capbase)); + + ret =readl_poll_timeout (&op_regs->status, value, !(value &STS_CNR ),1000 ,200000 ); + +if (ret) +dev_err (tegra->dev,"XHCI Controller not ready. Falcon state: 0x%x\n" , +csb_readl (tegra,XUSB_FALC_CPUCTL )); + +return ret; +} + +static int tegra_xusb_load_firmware_rom (struct tegra_xusb *tegra) {unsigned int code_tag_blocks, code_size_blocks, code_blocks; -struct xhci_cap_regs __iomem *cap = tegra->regs;struct tegra_xusb_fw_header *header;struct device *dev = tegra->dev; -struct xhci_op_regs __iomem *op; -unsigned long timeout;time64_t timestamp;u64 address;u32 value;int err; header = (struct tegra_xusb_fw_header *)tegra->fw.virt; - op = tegra->regs +HC_LENGTH (readl (&cap->hc_capbase));if (csb_readl (tegra,XUSB_CSB_MP_ILOAD_BASE_LO ) !=0 ) { dev_info(dev, "Firmware already loaded, Falcon state %#x\n",
@@ -969,30 +1079,54 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)/* Boot Falcon CPU and wait for USBSTS_CNR to get cleared. */ csb_writel (tegra,CPUCTL_STARTCPU ,XUSB_FALC_CPUCTL ); - timeout = jiffies +msecs_to_jiffies (200 ); +if (tegra_xusb_wait_for_falcon (tegra)) +return -EIO ; + + timestamp =le32_to_cpu (header->fwimg_created_time); -do { - value =readl (&op->status); -if ((value &STS_CNR ) ==0 ) -break ; +dev_info (dev,"Firmware timestamp: %ptTs UTC\n" , ×tamp); + +return 0 ; +} + +static u32 tegra_xusb_read_firmware_header (struct tegra_xusb *tegra,u32 offset) +{ +/* +* We only accept reading the firmware config table +* The offset should not exceed the fw header structure +*/ +if (offset >=sizeof (struct tegra_xusb_fw_header )) +return 0 ; -usleep_range (1000 ,2000 ); - }while (time_is_after_jiffies (timeout)); +bar2_writel (tegra, (FW_IOCTL_CFGTBL_READ <<FW_IOCTL_TYPE_SHIFT ) | offset, +XUSB_BAR2_ARU_FW_SCRATCH ); +return bar2_readl (tegra,XUSB_BAR2_ARU_SMI_ARU_FW_SCRATCH_DATA0 ); +} + +static int tegra_xusb_init_ifr_firmware (struct tegra_xusb *tegra) +{ +time64_t timestamp; - value =readl (&op->status); -if (value &STS_CNR ) { - value =csb_readl (tegra,XUSB_FALC_CPUCTL ); -dev_err (dev,"XHCI controller not read: %#010x\n" , value); +if (tegra_xusb_wait_for_falcon (tegra))return -EIO ; - } - timestamp =le32_to_cpu (header->fwimg_created_time); +#define offsetof_32 (X ,Y ) ((u8)(offsetof(X, Y) / sizeof(__le32))) + timestamp = tegra_xusb_read_firmware_header(tegra, offsetof_32(struct tegra_xusb_fw_header, + fwimg_created_time) <<2 ); -dev_info (dev,"Firmware timestamp: %ptTs UTC\n" , ×tamp); +dev_info (tegra->dev,"Firmware timestamp: %ptTs UTC\n" , ×tamp);return 0 ; } +static int tegra_xusb_load_firmware (struct tegra_xusb *tegra) +{ +if (!tegra->soc->firmware) +return tegra_xusb_init_ifr_firmware (tegra); +else +return tegra_xusb_load_firmware_rom (tegra); +} +static void tegra_xusb_powerdomain_remove (struct device *dev,struct tegra_xusb *tegra) {
@@ -1436,6 +1570,10 @@ static int tegra_xusb_probe(struct platform_device *pdev) tegra->ipfs_base =devm_platform_ioremap_resource (pdev,2 );if (IS_ERR (tegra->ipfs_base))return PTR_ERR (tegra->ipfs_base); + }else if (tegra->soc->has_bar2) { + tegra->bar2_base =devm_platform_get_and_ioremap_resource (pdev,2 , &tegra->bar2); +if (IS_ERR (tegra->bar2_base)) +return PTR_ERR (tegra->bar2_base); } tegra->xhci_irq =platform_get_irq (pdev,0 );
@@ -1652,10 +1790,13 @@ static int tegra_xusb_probe(struct platform_device *pdev) goto disable_phy; } - err =tegra_xusb_request_firmware (tegra); -if (err <0 ) { -dev_err (&pdev->dev,"failed to request firmware: %d\n" , err); - goto disable_phy; +if (tegra->soc->firmware) { + err =tegra_xusb_request_firmware (tegra); +if (err <0 ) { +dev_err (&pdev->dev, +"failed to request firmware: %d\n" , err); + goto disable_phy; + } } err =tegra_xusb_unpowergate_partitions (tegra);
@@ -2320,6 +2461,13 @@ static const struct tegra_xusb_context_soc tegra124_xusb_context = { }, }; +static const struct tegra_xusb_soc_ops tegra124_ops = { + .mbox_reg_readl = &fpci_readl, + .mbox_reg_writel = &fpci_writel, + .csb_reg_readl = &fpci_csb_readl, + .csb_reg_writel = &fpci_csb_writel, +}; +static const struct tegra_xusb_soc tegra124_soc = { .firmware ="nvidia/tegra124/xusb.bin" , .supply_names = tegra124_supply_names,
@@ -2335,11 +2483,13 @@ static const struct tegra_xusb_soc tegra124_soc = { .scale_ss_clock = true, .has_ipfs = true, .otg_reset_sspi = false, + .ops = &tegra124_ops, .mbox = { .cmd = 0xe4, .data_in = 0xe8, .data_out = 0xec, .owner = 0xf0, + .smi_intr = XUSB_CFG_ARU_SMI_INTR, }, };MODULE_FIRMWARE ("nvidia/tegra124/xusb.bin" );
@@ -2371,11 +2521,13 @@ static const struct tegra_xusb_soc tegra210_soc = { .scale_ss_clock = false, .has_ipfs = true, .otg_reset_sspi = true, + .ops = &tegra124_ops, .mbox = { .cmd = 0xe4, .data_in = 0xe8, .data_out = 0xec, .owner = 0xf0, + .smi_intr = XUSB_CFG_ARU_SMI_INTR, }, };MODULE_FIRMWARE ("nvidia/tegra210/xusb.bin" );
@@ -2412,11 +2564,13 @@ static const struct tegra_xusb_soc tegra186_soc = { .scale_ss_clock = false, .has_ipfs = false, .otg_reset_sspi = false, + .ops = &tegra124_ops, .mbox = { .cmd = 0xe4, .data_in = 0xe8, .data_out = 0xec, .owner = 0xf0, + .smi_intr = XUSB_CFG_ARU_SMI_INTR, }, .lpm_support = true, };
@@ -2443,21 +2597,56 @@ static const struct tegra_xusb_soc tegra194_soc = { .scale_ss_clock = false, .has_ipfs = false, .otg_reset_sspi = false, + .ops = &tegra124_ops, .mbox = { .cmd = 0x68, .data_in = 0x6c, .data_out = 0x70, .owner = 0x74, + .smi_intr = XUSB_CFG_ARU_SMI_INTR, }, .lpm_support = true, };MODULE_FIRMWARE ("nvidia/tegra194/xusb.bin" ); +static const struct tegra_xusb_soc_ops tegra234_ops = { + .mbox_reg_readl = &bar2_readl, + .mbox_reg_writel = &bar2_writel, + .csb_reg_readl = &bar2_csb_readl, + .csb_reg_writel = &bar2_csb_writel, +}; + +static const struct tegra_xusb_soc tegra234_soc = { + .supply_names = tegra194_supply_names, + .num_supplies =ARRAY_SIZE (tegra194_supply_names), + .phy_types = tegra194_phy_types, + .num_types =ARRAY_SIZE (tegra194_phy_types), + .context = &tegra186_xusb_context, + .ports = { + .usb3 = { .offset =0 , .count =4 , }, + .usb2 = { .offset =4 , .count =4 , }, + }, + .scale_ss_clock = false, + .has_ipfs = false, + .otg_reset_sspi = false, + .ops = &tegra234_ops, + .mbox = { + .cmd =XUSB_BAR2_ARU_MBOX_CMD , + .data_in =XUSB_BAR2_ARU_MBOX_DATA_IN , + .data_out =XUSB_BAR2_ARU_MBOX_DATA_OUT , + .owner =XUSB_BAR2_ARU_MBOX_OWNER , + .smi_intr =XUSB_BAR2_ARU_SMI_INTR , + }, + .lpm_support = true, + .has_bar2 = true, +}; +static const struct of_device_id tegra_xusb_of_match[] = { { .compatible ="nvidia,tegra124-xusb" , .data = &tegra124_soc }, { .compatible ="nvidia,tegra210-xusb" , .data = &tegra210_soc }, { .compatible ="nvidia,tegra186-xusb" , .data = &tegra186_soc }, { .compatible ="nvidia,tegra194-xusb" , .data = &tegra194_soc }, + { .compatible ="nvidia,tegra234-xusb" , .data = &tegra234_soc }, { }, };MODULE_DEVICE_TABLE (of, tegra_xusb_of_match);
Signature · 7 lines
2.25.1 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy