dmaengine: dw-edma: remove redundant config PCI dependency for some Synopsys DesignWare eDMA driver configs
Subsystems (3)
PATCH 1/1 dmaengine: dw-edma: remove redundant config PCI dependency for some Synopsys DesignWare eDMA driver configs
While reviewing dependencies in some Kconfig files, I noticed the redundant dependency "depends on PCI && PCI_MSI". The config PCI_MSI has always, since its introduction, been dependent on the config PCI. So, it is sufficient to just depend on PCI_MSI, and know that the dependency on PCI is implicitly implied.
Reduce the dependencies of configs DW_EDMA and DW_EDMA_PCIE. No functional change and effective change of Kconfig dependendencies.
--- drivers/dma/dw-edma/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/dma/dw-edma/Kconfig +2 -2
@@ -2,7 +2,7 @@ config DW_EDMA tristate "Synopsys DesignWare eDMA controller driver" - depends on PCI && PCI_MSI + depends on PCI_MSI select DMA_ENGINE select DMA_VIRTUAL_CHANNELS help
@@ -11,7 +11,7 @@ config DW_EDMA config DW_EDMA_PCIE tristate "Synopsys DesignWare eDMA PCIe driver" - depends on PCI && PCI_MSI + depends on PCI_MSI select DW_EDMA help Provides a glue-logic between the Synopsys DesignWare
Signature · 1 line
2.17.1
Quoted 8 lines · Lukas Bulwahn
While reviewing dependencies in some
Kconfigfiles, I noticed the redundant dependency "depends on PCI &&PCI_MSI". The configPCI_MSIhas always, since its introduction, been dependent on the config PCI. So, it is sufficient to just depend onPCI_MSI, and know that the dependency on PCI is implicitly implied.Reduce the dependencies of configs
DW_EDMAandDW_EDMA_PCIE. No functional change and effective change ofKconfigdependendencies.
Indeed. Thanks.
-Serge(y)
Quoted 31 lines
Signed-off-by Lukas Bulwahn <[email protected]>--- drivers/dma/dw-edma/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/dma/dw-edma/Kconfig +2
-2@@ -2,7 +2,7 @@ config DW_EDMA tristate "Synopsys DesignWare eDMA controller driver" - depends on PCI && PCI_MSI + depends on PCI_MSI select DMA_ENGINE select DMA_VIRTUAL_CHANNELS help@@ -11,7 +11,7 @@ config DW_EDMA config DW_EDMA_PCIE tristate "Synopsys DesignWare eDMA PCIe driver" - depends on PCI && PCI_MSI + depends on PCI_MSI select DW_EDMA help Provides a glue-logic between the Synopsys DesignWareSignature · 1 line
2.17.1
Quoted 8 lines · Lukas Bulwahn
While reviewing dependencies in some
Kconfigfiles, I noticed the redundant dependency "depends on PCI &&PCI_MSI". The configPCI_MSIhas always, since its introduction, been dependent on the config PCI. So, it is sufficient to just depend onPCI_MSI, and know that the dependency on PCI is implicitly implied.Reduce the dependencies of configs
DW_EDMAandDW_EDMA_PCIE. No functional change and effective change ofKconfigdependendencies.
Applied, thanks
Signature · 1 line
~Vinod