net: remove redundant config PCI dependency for some network driver configs
Subsystems (6)
PATCH 1/1 net: remove redundant config PCI dependency for some network driver configs
While reviewing dependencies in some Kconfig files, I noticed the redundant dependency "depends on PCI && PCI_MSI". The config PCI_MSI has always, since its introduction, been dependent on the config PCI. So, it is sufficient to just depend on PCI_MSI, and know that the dependency on PCI is implicitly implied.
Reduce the dependencies of some network driver configs.
No functional change and effective change of Kconfig dependendencies.
--- drivers/net/ethernet/freescale/enetc/Kconfig | 4 ++-- drivers/net/ethernet/fungible/funeth/Kconfig | 2 +- drivers/net/ethernet/netronome/Kconfig | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/net/ethernet/freescale/enetc/Kconfig +2 -2
@@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 config FSL_ENETC tristate "ENETC PF driver" - depends on PCI && PCI_MSI + depends on PCI_MSI select FSL_ENETC_IERB select FSL_ENETC_MDIO select PHYLINK
@@ -16,7 +16,7 @@ config FSL_ENETC config FSL_ENETC_VF tristate "ENETC VF driver" - depends on PCI && PCI_MSI + depends on PCI_MSI select FSL_ENETC_MDIO select PHYLINK select DIMLIB
drivers/net/ethernet/fungible/funeth/Kconfig +1 -1
@@ -5,7 +5,7 @@ config FUN_ETH tristate "Fungible Ethernet device driver" - depends on PCI && PCI_MSI + depends on PCI_MSI depends on TLS && TLS_DEVICE || TLS_DEVICE=n select NET_DEVLINK select FUN_CORE
drivers/net/ethernet/netronome/Kconfig +1 -1
@@ -18,7 +18,7 @@ if NET_VENDOR_NETRONOME config NFP tristate "Netronome(R) NFP4000/NFP6000 NIC driver" - depends on PCI && PCI_MSI + depends on PCI_MSI depends on VXLAN || VXLAN=n depends on TLS && TLS_DEVICE || TLS_DEVICE=n select NET_DEVLINK
Signature · 1 line
2.17.1
Quoted 11 lines · Lukas Bulwahn
[Some people who received this message don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
While reviewing dependencies in some
Kconfigfiles, I noticed the redundant dependency "depends on PCI &&PCI_MSI". The configPCI_MSIhas always, since its introduction, been dependent on the config PCI. So, it is sufficient to just depend onPCI_MSI, and know that the dependency on PCI is implicitly implied.Reduce the dependencies of some network driver configs.
No functional change and effective change ofKconfigdependendencies.
Quoted 6 lines
Signed-off-by Lukas Bulwahn <[email protected]>--- drivers/net/ethernet/freescale/enetc/Kconfig | 4 ++-- drivers/net/ethernet/fungible/funeth/Kconfig | 2 +- drivers/net/ethernet/netronome/Kconfig | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
For nfp portion.
Quoted 10 lines · Lukas Bulwahn
While reviewing dependencies in some
Kconfigfiles, I noticed the redundant dependency "depends on PCI &&PCI_MSI". The configPCI_MSIhas always, since its introduction, been dependent on the config PCI. So, it is sufficient to just depend onPCI_MSI, and know that the dependency on PCI is implicitly implied.Reduce the dependencies of some network driver configs.
No functional change and effective change ofKconfigdependendencies.
Quoted 6 lines
Signed-off-by Lukas Bulwahn <[email protected]>--- drivers/net/ethernet/freescale/enetc/Kconfig | 4 ++-- drivers/net/ethernet/fungible/funeth/Kconfig | 2 +- drivers/net/ethernet/netronome/Kconfig | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
For funeth part:
Quoted 8 lines · On Wed, 11 Jan 2023 13:58:55 +0100 Lukas Bulwahn wrote:
While reviewing dependencies in some
Kconfigfiles, I noticed the redundant dependency "depends on PCI &&PCI_MSI". The configPCI_MSIhas always, since its introduction, been dependent on the config PCI. So, it is sufficient to just depend onPCI_MSI, and know that the dependency on PCI is implicitly implied.Reduce the dependencies of some network driver configs.
No functional change and effective change ofKconfigdependendencies.
Applied, thanks!