Skip to contentSkip to conversation

baseband/acc: changes for 23.03

PATCH Superseded Hernan Vargas 2 participants 3 messages Jan 11, 2023 – Jan 12, 2023

lore
Share & tools
lore
#0 lore raw

v3 cover baseband/acc: changes for 23.03

v3: Remove unused mempool header.
v2: Reordered commits and added one more fix.
v1: Upstreaming ACC100 changes for 23.03.

Hernan Vargas (1):
baseband/acc: acc100 ignore missing mempools

 drivers/baseband/acc/rte_acc100_pmd.c | 9 ---------
 1 file changed, 9 deletions(-)
Signature · 1 line
2.37.1
#1 lore raw

PATCH v3 1/1 baseband/acc: acc100 ignore missing mempools

Mempool not strictly required to be present in op for processing. Previous criteria too strict. No functional impact.

---
 drivers/baseband/acc/rte_acc100_pmd.c | 9 ---------
 1 file changed, 9 deletions(-)
drivers/baseband/acc/rte_acc100_pmd.c +0 -9
index f841b31348..523d8fdb9c 100644
@@ -8,7 +8,6 @@
 #include <rte_log.h>
 #include <dev_driver.h>
 #include <rte_malloc.h>
-#include <rte_mempool.h>
 #include <rte_byteorder.h>
 #include <rte_errno.h>
 #include <rte_branch_prediction.h>
@@ -1832,10 +1831,6 @@ validate_enc_op(struct rte_bbdev_enc_op *op, struct acc_queue *q)
 	if (!validate_op_required(q))
 		return 0;
 
-	if (op->mempool == NULL) {
-		rte_bbdev_log(ERR, "Invalid mempool pointer");
-		return -1;
-	}
 	if (turbo_enc->input.data == NULL) {
 		rte_bbdev_log(ERR, "Invalid input pointer");
 		return -1;
@@ -2679,10 +2674,6 @@ validate_dec_op(struct rte_bbdev_dec_op *op, struct acc_queue *q)
 	if (!validate_op_required(q))
 		return 0;
 
-	if (op->mempool == NULL) {
-		rte_bbdev_log(ERR, "Invalid mempool pointer");
-		return -1;
-	}
 	if (turbo_dec->input.data == NULL) {
 		rte_bbdev_log(ERR, "Invalid input pointer");
 		return -1;
Signature · 1 line
2.37.1
#2 lore raw
In reply to Hernan Vargas

Hi Hernan,

Quoted 10 lines · Hernan Vargas

v3: Remove unused mempool header.
v2: Reordered commits and added one more fix.
v1: Upstreaming ACC100 changes for 23.03.

Hernan Vargas (1):
baseband/acc: acc100 ignore missing mempools

  drivers/baseband/acc/rte_acc100_pmd.c | 9 ---------
  1 file changed, 9 deletions(-)

Please resend the full series, including the R-by I gave on other patches.

Regards,
Maxime