Skip to contentSkip to conversation

Fix coding style issue

PATCH In review WEI GAO via ltp 2 participants 3 messages Jan 12, 2023 – Jan 13, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix coding style issue

---
 testcases/kernel/syscalls/readahead/readahead02.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
testcases/kernel/syscalls/readahead/readahead02.c +3 -3
index 3ed88c005..4eef353a8 100644
@@ -69,7 +69,7 @@ static struct tcase {
 	int use_overlay;
 	int use_fadvise;
 	/* Use either readahead() syscall or POSIX_FADV_WILLNEED */
-	int (*readahead)(int, off_t, size_t);
+	int (*readahead)(int fd, off_t offset, size_t len);
 } tcases[] = {
 	{ "readahead on file", 0, 0, libc_readahead },
 	{ "readahead on overlayfs file", 1, 0, libc_readahead },
@@ -224,7 +224,7 @@ static void test_readahead(unsigned int n)
 
 	if (tc->use_overlay && !ovl_mounted) {
 		tst_res(TCONF,
-		        "overlayfs is not configured in this kernel.");
+		"overlayfs is not configured in this kernel.");
 		return;
 	}
 
@@ -252,7 +252,7 @@ static void test_readahead(unsigned int n)
 	cached_low = get_cached_size();
 	tst_res(TINFO, "read_testfile(1)");
 	ret = read_testfile(tc, 1, testfile, testfile_size, &read_bytes_ra,
-		            &usec_ra, &cached_ra);
+			    &usec_ra, &cached_ra);
 
 	if (ret == EINVAL) {
 		if (tc->use_fadvise &&
Signature · 5 lines
2.35.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi Wei,

...

testcases/kernel/syscalls/readahead/readahead02.c static void test_readahead(unsigned int n) · line 227

Quoted 4 lines
testcases/kernel/syscalls/readahead/readahead02.c +1 -1
 	if (tc->use_overlay && !ovl_mounted) {
 		tst_res(TCONF,
-		        "overlayfs is not configured in this kernel.");
+		"overlayfs is not configured in this kernel.");

This was short enough to put it on the single line. I also removed the dot at the end and merged.

Thanks!

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

Hi Petr

Thanks a lot : )

Regards
Gao Wei

-----Original Message-----
From: Petr Vorel <[email protected]>
Sent: 13 January 2023 18:02
To: Wei Gao <[email protected]>
Cc: [email protected]
Subject: Re: [LTP] [PATCH v1] Fix coding style issue

Hi Wei,

...

testcases/kernel/syscalls/readahead/readahead02.c static void test_readahead(unsigned int n) · line 227

Quoted 4 lines
testcases/kernel/syscalls/readahead/readahead02.c +1 -1
 	if (tc->use_overlay && !ovl_mounted) {
 		tst_res(TCONF,
-		        "overlayfs is not configured in this kernel.");
+		"overlayfs is not configured in this kernel.");

This was short enough to put it on the single line. I also removed the dot at the end and merged.

Thanks!

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp