rcu: Track laziness during boot and suspend
PATCH v2 1/2 rcu: Track laziness during boot and suspend
During boot and suspend/resume, it is desired to prevent RCU laziness from effecting performance and in some cases failures like with suspend.
Track whether RCU laziness is to be ignored or not, in kernels with CONFIG_RCU_LAZY enabled. We do such tracking for expedited-RCU already, however since Android currently expedites synchronous_rcu() always, we cannot rely on that. The next patch ignores laziness hints based on this tracking.
---
Paul, could we take this and the next one for 6.2 -rc cycle?
I also booted debian Linux and verified the flag is reset correctly after boot completes. Thanks.
kernel/rcu/rcu.h | 6 ++++++ kernel/rcu/tree.c | 2 ++ kernel/rcu/update.c | 40 +++++++++++++++++++++++++++++++++++++++- 5 files changed, 55 insertions(+), 1 deletion(-) create mode 100644 cc_list create mode 100644 to_list
kernel/rcu/rcu.h +6 -0
@@ -449,14 +449,20 @@ do { \/* Tiny RCU doesn't expedite, as its purpose in life is instead to be tiny. */ static inline bool rcu_gp_is_normal (void ) {return true; }static inline bool rcu_gp_is_expedited (void ) {return false; } +static inline bool rcu_async_should_hurry (void ) {return false; }static inline void rcu_expedite_gp (void ) { }static inline void rcu_unexpedite_gp (void ) { } +static inline void rcu_async_hurry (void ) { } +static inline void rcu_async_relax (void ) { }static inline void rcu_request_urgent_qs_task (struct task_struct *t) { }#else /* #ifdef CONFIG_TINY_RCU */ bool rcu_gp_is_normal (void );/* Internal RCU use. */ bool rcu_gp_is_expedited (void );/* Internal RCU use. */ +bool rcu_async_should_hurry (void );/* Internal RCU use. */ void rcu_expedite_gp (void );void rcu_unexpedite_gp (void ); +void rcu_async_hurry (void ); +void rcu_async_relax (void );void rcupdate_announce_bootup_oddness (void );#ifdef CONFIG_TASKS_RCU_GENERIC void show_rcu_tasks_gp_kthreads (void );
kernel/rcu/tree.c +2 -0
@@ -4504,11 +4504,13 @@ static int rcu_pm_notify(struct notifier_block *self,switch (action) {case PM_HIBERNATION_PREPARE :case PM_SUSPEND_PREPARE : +rcu_async_hurry ();rcu_expedite_gp ();break ;case PM_POST_HIBERNATION :case PM_POST_SUSPEND :rcu_unexpedite_gp (); +rcu_async_relax ();break ;default :break ;
kernel/rcu/update.c +39 -1
@@ -144,8 +144,45 @@ bool rcu_gp_is_normal(void) }EXPORT_SYMBOL_GPL (rcu_gp_is_normal); -static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 ); +static atomic_t rcu_async_hurry_nesting =ATOMIC_INIT (1 ); +/* +* Should call_rcu() callbacks be processed with urgency or are +* they OK being executed with arbitrary delays? +*/ +bool rcu_async_should_hurry (void ) +{ +return !IS_ENABLED (CONFIG_RCU_LAZY ) || +atomic_read (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_should_hurry); + +/** +* rcu_async_hurry - Make future async RCU callbacks not lazy. +* +* After a call to this function, future calls to call_rcu() +* will be processed in a timely fashion. +*/ +void rcu_async_hurry (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_inc (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_hurry); +/** +* rcu_async_relax - Make future async RCU callbacks lazy. +* +* After a call to this function, future calls to call_rcu() +* will be processed in a lazy fashion. +*/ +void rcu_async_relax (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_dec (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_relax); + +static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 );/* * Should normal grace-period primitives be expedited? Intended for * use within RCU. Note that this function takes the rcu_expedited
@@ -195,6 +232,7 @@ static bool rcu_boot_ended __read_mostly;void rcu_end_inkernel_boot (void ) {rcu_unexpedite_gp (); +rcu_async_relax ();if (rcu_normal_after_boot)WRITE_ONCE (rcu_normal,1 ); rcu_boot_ended = true;
Signature · 1 line
2.39.0.314.g84b9a713c41-goog
PATCH v2 2/2 rcu: Disable laziness if lazy-tracking says so
During suspend, we see failures to suspend 1 in 300-500 suspends. Looking closer, it appears that asynchronous RCU callbacks are being queued as lazy even though synchronous callbacks are expedited. These delays appear to not be very welcome by the suspend/resume code as evidenced by these occasional suspend failures.
This commit modifies call_rcu() to check if rcu_async_should_hurry(), which will return true if we are in suspend or in-kernel boot.
Ignoring the lazy hint makes the 3000 suspend/resume cycles pass reliably on a 12th gen 12-core Intel CPU, and there is some evidence that it also slightly speeds up boot performance.
--- kernel/rcu/tree.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
kernel/rcu/tree.c +3 -2
@@ -2594,12 +2594,12 @@ static void check_cb_ovld(struct rcu_data *rdp) }static void -__call_rcu_common (struct rcu_head *head,rcu_callback_t func,bool lazy) +__call_rcu_common (struct rcu_head *head,rcu_callback_t func,bool lazy_in) {static atomic_t doublefrees;unsigned long flags;struct rcu_data *rdp; -bool was_alldone; +bool was_alldone, lazy;/* Misaligned rcu_head! */ WARN_ON_ONCE ((unsigned long )head & (sizeof (void *) -1 ));
@@ -2622,6 +2622,7 @@ __call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy)kasan_record_aux_stack_noalloc (head);local_irq_save (flags); rdp =this_cpu_ptr (&rcu_data); + lazy = lazy_in && !rcu_async_should_hurry ();/* Add the callback to our list. */ if (unlikely (!rcu_segcblist_is_enabled (&rdp->cblist))) {
Signature · 1 line
2.39.0.314.g84b9a713c41-goog
Steven Rostedt
reviewerRe: [PATCH v2 rcu/dev 2/2] rcu: Disable laziness if lazy-tracking says so
kernel/rcu/tree.c static void check_cb_ovld(struct rcu_data *rdp) · line 2602
Quoted 10 lines · On Thu, 12 Jan 2023 00:52:23 +0000 "Joel Fernandes (Google)"…
static void
kernel/rcu/tree.c +2
-2-__call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy) +__call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy_in) { static atomic_t doublefrees;unsigned long flags;struct rcu_data *rdp; -bool was_alldone; +bool was_alldone, lazy;
I'm curious to why the the extra variable.
kernel/rcu/tree.c __call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy) · line 2625
Quoted 8 lines
kernel/rcu/tree.c +1
-0/* Misaligned rcu_head! */ WARN_ON_ONCE ((unsigned long )head & (sizeof (void *) -1 ));@@ -2622,6 +2622,7 @@ __call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy)kasan_record_aux_stack_noalloc (head);local_irq_save (flags); rdp =this_cpu_ptr (&rcu_data); + lazy = lazy_in && !rcu_async_should_hurry ();
Wouldn't just having:
lazy = lazy && !rcu_async_should_hurry();
be sufficient?
-- Steve
Quoted 4 lines
kernel/rcu/tree.c +0
-0/* Add the callback to our list. */ if (unlikely (!rcu_segcblist_is_enabled (&rdp->cblist))) {
Re: [PATCH v2 rcu/dev 2/2] rcu: Disable laziness if lazy-tracking says so
Quoted 28 lines · Steven Rostedt
kernel/rcu/tree.c static void check_cb_ovld(struct rcu_data *rdp) · line 2602
Quoted 10 lines · On Thu, 12 Jan 2023 00:52:23 +0000 "Joel Fernandes (Google)"…
static void
kernel/rcu/tree.c +2
-2-__call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy) +__call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy_in) { static atomic_t doublefrees;unsigned long flags;struct rcu_data *rdp; -bool was_alldone; +bool was_alldone, lazy;I'm curious to why the the extra variable.
kernel/rcu/tree.c __call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy) · line 2625
Quoted 8 lines
/* Misaligned rcu_head! */ WARN_ON_ONCE((unsigned long)head & (sizeof(void *) - 1));kernel/rcu/tree.c +1
-0@@ -2622,6 +2622,7 @@ __call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy)kasan_record_aux_stack_noalloc (head);local_irq_save (flags); rdp =this_cpu_ptr (&rcu_data); + lazy = lazy_in && !rcu_async_should_hurry ();Wouldn't just having:
Quoted 3 lines
lazy = lazy && !rcu_async_should_hurry();be sufficient?
I prefer to not overwrite function arguments, it makes debugging harder IMHO.
- Joel
Quoted 7 lines
-- Steve
Quoted 4 lines
kernel/rcu/tree.c +0
-1/* Add the callback to our list. */ if (unlikely (!rcu_segcblist_is_enabled (&rdp->cblist))) { --
Paul E. McKenney
maintainerQuoted 11 lines · Joel Fernandes (Google)
During boot and suspend/resume, it is desired to prevent RCU laziness from effecting performance and in some cases failures like with suspend.
Track whether RCU laziness is to be ignored or not, in kernels with
CONFIG_RCU_LAZYenabled. We do such tracking for expedited-RCU already, however since Android currently expeditessynchronous_rcu()always, we cannot rely on that. The next patch ignores laziness hints based on this tracking.Signed-off-by Joel Fernandes (Google) <[email protected]>---
Paul, could we take this and the next one for 6.2 -rc cycle?
Given how late it is in v6.2, I would need you to make it all depend on CONFIG_RCU_LAZY, so that it is blindingly and immediately obvious that there is no change in behavior for kernels built with CONFIG_RCU_LAZY=n.
If you are OK with the v6.3 merge window and backports, what you have likely suffices, modulo review and testing.
So, how would you like to proceed?
Thanx, Paul
Quoted 114 lines
I also booted debian Linux and verified the flag is reset correctly after boot completes. Thanks.
kernel/rcu/rcu.h | 6 ++++++ kernel/rcu/tree.c | 2 ++ kernel/rcu/update.c | 40 +++++++++++++++++++++++++++++++++++++++- 5 files changed, 55 insertions(+), 1 deletion(-) create mode 100644 cc_list create mode 100644 to_listkernel/rcu/rcu.h +6
-0@@ -449,14 +449,20 @@ do { \/* Tiny RCU doesn't expedite, as its purpose in life is instead to be tiny. */ static inline bool rcu_gp_is_normal (void ) {return true; }static inline bool rcu_gp_is_expedited (void ) {return false; } +static inline bool rcu_async_should_hurry (void ) {return false; }static inline void rcu_expedite_gp (void ) { }static inline void rcu_unexpedite_gp (void ) { } +static inline void rcu_async_hurry (void ) { } +static inline void rcu_async_relax (void ) { }static inline void rcu_request_urgent_qs_task (struct task_struct *t) { }#else /* #ifdef CONFIG_TINY_RCU */ bool rcu_gp_is_normal (void );/* Internal RCU use. */ bool rcu_gp_is_expedited (void );/* Internal RCU use. */ +bool rcu_async_should_hurry (void );/* Internal RCU use. */ void rcu_expedite_gp (void );void rcu_unexpedite_gp (void ); +void rcu_async_hurry (void ); +void rcu_async_relax (void );void rcupdate_announce_bootup_oddness (void );#ifdef CONFIG_TASKS_RCU_GENERIC void show_rcu_tasks_gp_kthreads (void );kernel/rcu/tree.c +2
-0@@ -4504,11 +4504,13 @@ static int rcu_pm_notify(struct notifier_block *self,switch (action) {case PM_HIBERNATION_PREPARE :case PM_SUSPEND_PREPARE : +rcu_async_hurry ();rcu_expedite_gp ();break ;case PM_POST_HIBERNATION :case PM_POST_SUSPEND :rcu_unexpedite_gp (); +rcu_async_relax ();break ;default :break ;kernel/rcu/update.c +39
-1@@ -144,8 +144,45 @@ bool rcu_gp_is_normal(void) }EXPORT_SYMBOL_GPL (rcu_gp_is_normal); -static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 ); +static atomic_t rcu_async_hurry_nesting =ATOMIC_INIT (1 ); +/* +* Should call_rcu() callbacks be processed with urgency or are +* they OK being executed with arbitrary delays? +*/ +bool rcu_async_should_hurry (void ) +{ +return !IS_ENABLED (CONFIG_RCU_LAZY ) || +atomic_read (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_should_hurry); + +/** +* rcu_async_hurry - Make future async RCU callbacks not lazy. +* +* After a call to this function, future calls to call_rcu() +* will be processed in a timely fashion. +*/ +void rcu_async_hurry (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_inc (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_hurry); +/** +* rcu_async_relax - Make future async RCU callbacks lazy. +* +* After a call to this function, future calls to call_rcu() +* will be processed in a lazy fashion. +*/ +void rcu_async_relax (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_dec (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_relax); + +static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 );/* * Should normal grace-period primitives be expedited? Intended for * use within RCU. Note that this function takes the rcu_expedited @@ -195,6 +232,7 @@ static bool rcu_boot_ended __read_mostly;void rcu_end_inkernel_boot (void ) {rcu_unexpedite_gp (); +rcu_async_relax ();if (rcu_normal_after_boot)WRITE_ONCE (rcu_normal,1 ); rcu_boot_ended = true;Signature · 1 line
2.39.0.314.g84b9a713c41-goog
Quoted 17 lines · Paul E. McKenney
Quoted 11 lines · Joel Fernandes (Google)
During boot and suspend/resume, it is desired to prevent RCU laziness from effecting performance and in some cases failures like with suspend.
Track whether RCU laziness is to be ignored or not, in kernels with
CONFIG_RCU_LAZYenabled. We do such tracking for expedited-RCU already, however since Android currently expeditessynchronous_rcu()always, we cannot rely on that. The next patch ignores laziness hints based on this tracking.Signed-off-by Joel Fernandes (Google) <[email protected]>---
Paul, could we take this and the next one for 6.2 -rc cycle?
Quoted 8 lines
Given how late it is in v6.2, I would need you to make it all depend on
CONFIG_RCU_LAZY, so that it is blindingly and immediately obvious that there is no change in behavior for kernels built withCONFIG_RCU_LAZY=n.If you are OK with the v6.3 merge window and backports, what you have likely suffices, modulo review and testing.
So, how would you like to proceed?
Yes that is fine with me. Though, it is right now fully compile-time dependent on the lazy config, except the definition of the integer which I can’t put behind a config because of ugly ifdefs. I would expect LTO to remove the integer definition automatically. But it has no effect otherwise.
I do worry a bit about users who are not using stable and have their own kernel versions with backports. But maybe a fixes tag will get their attention?
Android and ChromeOS should both be fine though, given they swear by stable.
Thanks,
- Joel
Quoted 117 lines
Thanx, Paul
Quoted 114 lines
I also booted debian Linux and verified the flag is reset correctly after boot completes. Thanks.
kernel/rcu/rcu.h | 6 ++++++ kernel/rcu/tree.c | 2 ++ kernel/rcu/update.c | 40 +++++++++++++++++++++++++++++++++++++++- 5 files changed, 55 insertions(+), 1 deletion(-)create mode 100644
cc_list
create mode 100644to_listkernel/rcu/rcu.h +3
-0@@ -449,14 +449,20 @@ do { \/* Tiny RCU doesn't expedite, as its purpose in life is instead to be tiny. */ static inline bool rcu_gp_is_normal (void ) {return true; }static inline bool rcu_gp_is_expedited (void ) {return false; } +static inline bool rcu_async_should_hurry (void ) {return false; }static inline void rcu_expedite_gp (void ) { }static inline void rcu_unexpedite_gp (void ) { } +static inline void rcu_async_hurry (void ) { } +static inline void rcu_async_relax (void ) { }static inline void rcu_request_urgent_qs_task (struct task_struct *t) { }#else /* #ifdef CONFIG_TINY_RCU */ bool
rcu_gp_is_normal(void); /* Internal RCU use. */
boolrcu_gp_is_expedited(void); /* Internal RCU use. */ +boolrcu_async_should_hurry(void); /* Internal RCU use. */ voidrcu_expedite_gp(void);
voidrcu_unexpedite_gp(void);kernel/rcu/rcu.h +2
-0+void rcu_async_hurry (void ); +void rcu_async_relax (void );void
rcupdate_announce_bootup_oddness(void);
#ifdefCONFIG_TASKS_RCU_GENERIC
voidshow_rcu_tasks_gp_kthreads(void);kernel/rcu/tree.c +2
-0@@ -4504,11 +4504,13 @@ static int rcu_pm_notify(struct notifier_block *self,switch (action) {case PM_HIBERNATION_PREPARE :case PM_SUSPEND_PREPARE : +rcu_async_hurry ();rcu_expedite_gp ();break ;case PM_POST_HIBERNATION :case PM_POST_SUSPEND :rcu_unexpedite_gp (); +rcu_async_relax ();break ;default :break ;kernel/rcu/update.c +39
-1@@ -144,8 +144,45 @@ bool rcu_gp_is_normal(void) }EXPORT_SYMBOL_GPL (rcu_gp_is_normal); -static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 ); +static atomic_t rcu_async_hurry_nesting =ATOMIC_INIT (1 ); +/* +* Should call_rcu() callbacks be processed with urgency or are +* they OK being executed with arbitrary delays? +*/ +bool rcu_async_should_hurry (void ) +{ +return !IS_ENABLED (CONFIG_RCU_LAZY ) || +atomic_read (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_should_hurry); + +/** +* rcu_async_hurry - Make future async RCU callbacks not lazy. +* +* After a call to this function, future calls to call_rcu() +* will be processed in a timely fashion. +*/ +void rcu_async_hurry (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_inc (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_hurry); +/** +* rcu_async_relax - Make future async RCU callbacks lazy. +* +* After a call to this function, future calls to call_rcu() +* will be processed in a lazy fashion. +*/ +void rcu_async_relax (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_dec (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_relax); + +static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 );/* * Should normal grace-period primitives be expedited? Intended for * use within RCU. Note that this function takes the rcu_expedited @@ -195,6 +232,7 @@ static bool rcu_boot_ended __read_mostly;void rcu_end_inkernel_boot (void ) {rcu_unexpedite_gp (); +rcu_async_relax ();if (rcu_normal_after_boot)WRITE_ONCE (rcu_normal,1 ); rcu_boot_ended = true;Signature · 1 line
2.39.0.314.g84b9a713c41-goog
Paul E. McKenney
maintainerQuoted 8 lines · Joel Fernandes (Google)
During boot and suspend/resume, it is desired to prevent RCU laziness from effecting performance and in some cases failures like with suspend.
Track whether RCU laziness is to be ignored or not, in kernels with
CONFIG_RCU_LAZYenabled. We do such tracking for expedited-RCU already, however since Android currently expeditessynchronous_rcu()always, we cannot rely on that. The next patch ignores laziness hints based on this tracking.
Quoted 6 lines
Signed-off-by Joel Fernandes (Google) <[email protected]>---
Paul, could we take this and the next one for 6.2 -rc cycle?I also booted debian Linux and verified the flag is reset correctly after boot completes. Thanks.
After going back and forth a bit, I took these two as-is (aside from the usual commit-log wordsmithing).
At some point, the state-change-notification from things like boot, suspend/resume, sysrq-t, and panic() should probably be refactored. But I do not believe that we are yet at that point, and there is not much point in half-refactorings in cases such as this one.
I added the Fixes tags, and, if testing goes well, I plan to submit them into the upcoming merge window. I have no reason to believe that anyone is hitting this, it is only a few weeks away anyhow, and a good chunk of that would be consumed by testing and review.
And if someone does hit it, we do have your fixes to send to them, so thank you for that!
(These won't become visible on -rcu until I complete today's rebase, in case you were wondering.)
Thanx, Paul
Quoted 111 lines
kernel/rcu/rcu.h | 6 ++++++ kernel/rcu/tree.c | 2 ++ kernel/rcu/update.c | 40 +++++++++++++++++++++++++++++++++++++++- 5 files changed, 55 insertions(+), 1 deletion(-) create mode 100644 cc_list create mode 100644 to_listkernel/rcu/rcu.h +6
-0@@ -449,14 +449,20 @@ do { \/* Tiny RCU doesn't expedite, as its purpose in life is instead to be tiny. */ static inline bool rcu_gp_is_normal (void ) {return true; }static inline bool rcu_gp_is_expedited (void ) {return false; } +static inline bool rcu_async_should_hurry (void ) {return false; }static inline void rcu_expedite_gp (void ) { }static inline void rcu_unexpedite_gp (void ) { } +static inline void rcu_async_hurry (void ) { } +static inline void rcu_async_relax (void ) { }static inline void rcu_request_urgent_qs_task (struct task_struct *t) { }#else /* #ifdef CONFIG_TINY_RCU */ bool rcu_gp_is_normal (void );/* Internal RCU use. */ bool rcu_gp_is_expedited (void );/* Internal RCU use. */ +bool rcu_async_should_hurry (void );/* Internal RCU use. */ void rcu_expedite_gp (void );void rcu_unexpedite_gp (void ); +void rcu_async_hurry (void ); +void rcu_async_relax (void );void rcupdate_announce_bootup_oddness (void );#ifdef CONFIG_TASKS_RCU_GENERIC void show_rcu_tasks_gp_kthreads (void );kernel/rcu/tree.c +2
-0@@ -4504,11 +4504,13 @@ static int rcu_pm_notify(struct notifier_block *self,switch (action) {case PM_HIBERNATION_PREPARE :case PM_SUSPEND_PREPARE : +rcu_async_hurry ();rcu_expedite_gp ();break ;case PM_POST_HIBERNATION :case PM_POST_SUSPEND :rcu_unexpedite_gp (); +rcu_async_relax ();break ;default :break ;kernel/rcu/update.c +39
-1@@ -144,8 +144,45 @@ bool rcu_gp_is_normal(void) }EXPORT_SYMBOL_GPL (rcu_gp_is_normal); -static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 ); +static atomic_t rcu_async_hurry_nesting =ATOMIC_INIT (1 ); +/* +* Should call_rcu() callbacks be processed with urgency or are +* they OK being executed with arbitrary delays? +*/ +bool rcu_async_should_hurry (void ) +{ +return !IS_ENABLED (CONFIG_RCU_LAZY ) || +atomic_read (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_should_hurry); + +/** +* rcu_async_hurry - Make future async RCU callbacks not lazy. +* +* After a call to this function, future calls to call_rcu() +* will be processed in a timely fashion. +*/ +void rcu_async_hurry (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_inc (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_hurry); +/** +* rcu_async_relax - Make future async RCU callbacks lazy. +* +* After a call to this function, future calls to call_rcu() +* will be processed in a lazy fashion. +*/ +void rcu_async_relax (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_dec (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_relax); + +static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 );/* * Should normal grace-period primitives be expedited? Intended for * use within RCU. Note that this function takes the rcu_expedited @@ -195,6 +232,7 @@ static bool rcu_boot_ended __read_mostly;void rcu_end_inkernel_boot (void ) {rcu_unexpedite_gp (); +rcu_async_relax ();if (rcu_normal_after_boot)WRITE_ONCE (rcu_normal,1 ); rcu_boot_ended = true;Signature · 1 line
2.39.0.314.g84b9a713c41-goog
Quoted 33 lines · Paul E. McKenney
Quoted 8 lines · Joel Fernandes (Google)
During boot and suspend/resume, it is desired to prevent RCU laziness from effecting performance and in some cases failures like with suspend.
Track whether RCU laziness is to be ignored or not, in kernels with
CONFIG_RCU_LAZYenabled. We do such tracking for expedited-RCU already, however since Android currently expeditessynchronous_rcu()always, we cannot rely on that. The next patch ignores laziness hints based on this tracking.Quoted 6 lines
Signed-off-by Joel Fernandes (Google) <[email protected]>---
Paul, could we take this and the next one for 6.2 -rc cycle?I also booted debian Linux and verified the flag is reset correctly after boot completes. Thanks.
After going back and forth a bit, I took these two as-is (aside from the usual commit-log wordsmithing).
At some point, the state-change-notification from things like boot, suspend/resume, sysrq-t, and
panic()should probably be refactored. But I do not believe that we are yet at that point, and there is not much point in half-refactorings in cases such as this one.I added the Fixes tags, and, if testing goes well, I plan to submit them into the upcoming merge window. I have no reason to believe that anyone is hitting this, it is only a few weeks away anyhow, and a good chunk of that would be consumed by testing and review.
Quoted 4 lines
And if someone does hit it, we do have your fixes to send to them, so thank you for that!
(These won't become visible on -rcu until I complete today's rebase, in case you were wondering.)
Thanks and this sounds good to me. Meanwhile I pulled into our product kernel so all is good.
Thanks,
- Joel
Quoted 114 lines
Thanx, Paul
Quoted 111 lines
kernel/rcu/rcu.h | 6 ++++++ kernel/rcu/tree.c | 2 ++ kernel/rcu/update.c | 40 +++++++++++++++++++++++++++++++++++++++- 5 files changed, 55 insertions(+), 1 deletion(-)create mode 100644
cc_list
create mode 100644to_listkernel/rcu/rcu.h +3
-0@@ -449,14 +449,20 @@ do { \/* Tiny RCU doesn't expedite, as its purpose in life is instead to be tiny. */ static inline bool rcu_gp_is_normal (void ) {return true; }static inline bool rcu_gp_is_expedited (void ) {return false; } +static inline bool rcu_async_should_hurry (void ) {return false; }static inline void rcu_expedite_gp (void ) { }static inline void rcu_unexpedite_gp (void ) { } +static inline void rcu_async_hurry (void ) { } +static inline void rcu_async_relax (void ) { }static inline void rcu_request_urgent_qs_task (struct task_struct *t) { }#else /* #ifdef CONFIG_TINY_RCU */ bool
rcu_gp_is_normal(void); /* Internal RCU use. */
boolrcu_gp_is_expedited(void); /* Internal RCU use. */ +boolrcu_async_should_hurry(void); /* Internal RCU use. */ voidrcu_expedite_gp(void);
voidrcu_unexpedite_gp(void);kernel/rcu/rcu.h +2
-0+void rcu_async_hurry (void ); +void rcu_async_relax (void );void
rcupdate_announce_bootup_oddness(void);
#ifdefCONFIG_TASKS_RCU_GENERIC
voidshow_rcu_tasks_gp_kthreads(void);kernel/rcu/tree.c +2
-0@@ -4504,11 +4504,13 @@ static int rcu_pm_notify(struct notifier_block *self,switch (action) {case PM_HIBERNATION_PREPARE :case PM_SUSPEND_PREPARE : +rcu_async_hurry ();rcu_expedite_gp ();break ;case PM_POST_HIBERNATION :case PM_POST_SUSPEND :rcu_unexpedite_gp (); +rcu_async_relax ();break ;default :break ;kernel/rcu/update.c +39
-1@@ -144,8 +144,45 @@ bool rcu_gp_is_normal(void) }EXPORT_SYMBOL_GPL (rcu_gp_is_normal); -static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 ); +static atomic_t rcu_async_hurry_nesting =ATOMIC_INIT (1 ); +/* +* Should call_rcu() callbacks be processed with urgency or are +* they OK being executed with arbitrary delays? +*/ +bool rcu_async_should_hurry (void ) +{ +return !IS_ENABLED (CONFIG_RCU_LAZY ) || +atomic_read (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_should_hurry); + +/** +* rcu_async_hurry - Make future async RCU callbacks not lazy. +* +* After a call to this function, future calls to call_rcu() +* will be processed in a timely fashion. +*/ +void rcu_async_hurry (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_inc (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_hurry); +/** +* rcu_async_relax - Make future async RCU callbacks lazy. +* +* After a call to this function, future calls to call_rcu() +* will be processed in a lazy fashion. +*/ +void rcu_async_relax (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_dec (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_relax); + +static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 );/* * Should normal grace-period primitives be expedited? Intended for * use within RCU. Note that this function takes the rcu_expedited @@ -195,6 +232,7 @@ static bool rcu_boot_ended __read_mostly;void rcu_end_inkernel_boot (void ) {rcu_unexpedite_gp (); +rcu_async_relax ();if (rcu_normal_after_boot)WRITE_ONCE (rcu_normal,1 ); rcu_boot_ended = true;Signature · 1 line
2.39.0.314.g84b9a713c41-goog
Paul E. McKenney
maintainerQuoted 33 lines · Joel Fernandes
Quoted 33 lines · Paul E. McKenney
Quoted 8 lines · Joel Fernandes (Google)
During boot and suspend/resume, it is desired to prevent RCU laziness from effecting performance and in some cases failures like with suspend.
Track whether RCU laziness is to be ignored or not, in kernels with
CONFIG_RCU_LAZYenabled. We do such tracking for expedited-RCU already, however since Android currently expeditessynchronous_rcu()always, we cannot rely on that. The next patch ignores laziness hints based on this tracking.Quoted 6 lines
Signed-off-by Joel Fernandes (Google) <[email protected]>---
Paul, could we take this and the next one for 6.2 -rc cycle?I also booted debian Linux and verified the flag is reset correctly after boot completes. Thanks.
After going back and forth a bit, I took these two as-is (aside from the usual commit-log wordsmithing).
At some point, the state-change-notification from things like boot, suspend/resume, sysrq-t, and
panic()should probably be refactored. But I do not believe that we are yet at that point, and there is not much point in half-refactorings in cases such as this one.I added the Fixes tags, and, if testing goes well, I plan to submit them into the upcoming merge window. I have no reason to believe that anyone is hitting this, it is only a few weeks away anyhow, and a good chunk of that would be consumed by testing and review.
Quoted 6 lines
Quoted 4 lines
And if someone does hit it, we do have your fixes to send to them, so thank you for that!
(These won't become visible on -rcu until I complete today's rebase, in case you were wondering.)Thanks and this sounds good to me. Meanwhile I pulled into our product kernel so all is good.
Very good! Please let me know how it goes!
Thanx, Paul
Quoted 119 lines
Thanks,
- Joel
Quoted 114 lines
Thanx, Paul
Quoted 111 lines
kernel/rcu/rcu.h | 6 ++++++ kernel/rcu/tree.c | 2 ++ kernel/rcu/update.c | 40 +++++++++++++++++++++++++++++++++++++++- 5 files changed, 55 insertions(+), 1 deletion(-)create mode 100644
cc_list
create mode 100644to_listkernel/rcu/rcu.h +3
-0@@ -449,14 +449,20 @@ do { \/* Tiny RCU doesn't expedite, as its purpose in life is instead to be tiny. */ static inline bool rcu_gp_is_normal (void ) {return true; }static inline bool rcu_gp_is_expedited (void ) {return false; } +static inline bool rcu_async_should_hurry (void ) {return false; }static inline void rcu_expedite_gp (void ) { }static inline void rcu_unexpedite_gp (void ) { } +static inline void rcu_async_hurry (void ) { } +static inline void rcu_async_relax (void ) { }static inline void rcu_request_urgent_qs_task (struct task_struct *t) { }#else /* #ifdef CONFIG_TINY_RCU */ bool
rcu_gp_is_normal(void); /* Internal RCU use. */
boolrcu_gp_is_expedited(void); /* Internal RCU use. */ +boolrcu_async_should_hurry(void); /* Internal RCU use. */ voidrcu_expedite_gp(void);
voidrcu_unexpedite_gp(void);kernel/rcu/rcu.h +2
-0+void rcu_async_hurry (void ); +void rcu_async_relax (void );void
rcupdate_announce_bootup_oddness(void);
#ifdefCONFIG_TASKS_RCU_GENERIC
voidshow_rcu_tasks_gp_kthreads(void);kernel/rcu/tree.c +2
-0@@ -4504,11 +4504,13 @@ static int rcu_pm_notify(struct notifier_block *self,switch (action) {case PM_HIBERNATION_PREPARE :case PM_SUSPEND_PREPARE : +rcu_async_hurry ();rcu_expedite_gp ();break ;case PM_POST_HIBERNATION :case PM_POST_SUSPEND :rcu_unexpedite_gp (); +rcu_async_relax ();break ;default :break ;kernel/rcu/update.c +39
-1@@ -144,8 +144,45 @@ bool rcu_gp_is_normal(void) }EXPORT_SYMBOL_GPL (rcu_gp_is_normal); -static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 ); +static atomic_t rcu_async_hurry_nesting =ATOMIC_INIT (1 ); +/* +* Should call_rcu() callbacks be processed with urgency or are +* they OK being executed with arbitrary delays? +*/ +bool rcu_async_should_hurry (void ) +{ +return !IS_ENABLED (CONFIG_RCU_LAZY ) || +atomic_read (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_should_hurry); + +/** +* rcu_async_hurry - Make future async RCU callbacks not lazy. +* +* After a call to this function, future calls to call_rcu() +* will be processed in a timely fashion. +*/ +void rcu_async_hurry (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_inc (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_hurry); +/** +* rcu_async_relax - Make future async RCU callbacks lazy. +* +* After a call to this function, future calls to call_rcu() +* will be processed in a lazy fashion. +*/ +void rcu_async_relax (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_dec (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_relax); + +static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 );/* * Should normal grace-period primitives be expedited? Intended for * use within RCU. Note that this function takes the rcu_expedited @@ -195,6 +232,7 @@ static bool rcu_boot_ended __read_mostly;void rcu_end_inkernel_boot (void ) {rcu_unexpedite_gp (); +rcu_async_relax ();if (rcu_normal_after_boot)WRITE_ONCE (rcu_normal,1 ); rcu_boot_ended = true;Signature · 1 line
2.39.0.314.g84b9a713c41-goog
Steven Rostedt
reviewerQuoted 22 lines · On Thu, 12 Jan 2023 00:52:22 +0000 "Joel Fernandes (Google)"…
--
a/kernel/rcu/update.c
+++b/kernel/rcu/update.ckernel/rcu/update.c +15
-1@@ -144,8 +144,45 @@ bool rcu_gp_is_normal(void) }EXPORT_SYMBOL_GPL (rcu_gp_is_normal); -static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 ); +static atomic_t rcu_async_hurry_nesting =ATOMIC_INIT (1 ); +/* +* Should call_rcu() callbacks be processed with urgency or are +* they OK being executed with arbitrary delays? +*/ +bool rcu_async_should_hurry (void ) +{ +return !IS_ENABLED (CONFIG_RCU_LAZY ) || +atomic_read (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_should_hurry); + +/** +* rcu_async_hurry - Make future async RCU callbacks not lazy. +*
kernel/rcu/update.c bool rcu_gp_is_normal(void) · line 171
Quoted 10 lines
kernel/rcu/update.c +9
-0+* After a call to this function, future calls to call_rcu() +* will be processed in a timely fashion. +*/ +void rcu_async_hurry (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_inc (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_hurry);
Where do you plan on calling these externally, as they are being marked exported?
If you allow random drivers to enable this, I can see something enabling it and hitting an error path that causes it to never disable it.
I wouldn't have EXPORT_SYMBOL_GPL() unless you really know that it is needed externally. In fact, is this really needed outside of the RCU subsystem?
-- Steve
Quoted 14 lines
kernel/rcu/update.c +14
-0+/** +* rcu_async_relax - Make future async RCU callbacks lazy. +* +* After a call to this function, future calls to call_rcu() +* will be processed in a lazy fashion. +*/ +void rcu_async_relax (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_dec (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_relax); + +static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 );
Quoted 40 lines · Steven Rostedt
Quoted 22 lines · On Thu, 12 Jan 2023 00:52:22 +0000 "Joel Fernandes (Google)"…
--
a/kernel/rcu/update.c
+++b/kernel/rcu/update.ckernel/rcu/update.c +15
-1@@ -144,8 +144,45 @@ bool rcu_gp_is_normal(void) }EXPORT_SYMBOL_GPL (rcu_gp_is_normal); -static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 ); +static atomic_t rcu_async_hurry_nesting =ATOMIC_INIT (1 ); +/* +* Should call_rcu() callbacks be processed with urgency or are +* they OK being executed with arbitrary delays? +*/ +bool rcu_async_should_hurry (void ) +{ +return !IS_ENABLED (CONFIG_RCU_LAZY ) || +atomic_read (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_should_hurry); + +/** +* rcu_async_hurry - Make future async RCU callbacks not lazy. +* kernel/rcu/update.c bool rcu_gp_is_normal(void) · line 171
Quoted 10 lines
kernel/rcu/update.c +9
-0+* After a call to this function, future calls to call_rcu() +* will be processed in a timely fashion. +*/ +void rcu_async_hurry (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_inc (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_hurry);Where do you plan on calling these externally, as they are being marked exported?
Quoted 3 lines
If you allow random drivers to enable this, I can see something enabling it and hitting an error path that causes it to never disable it.
You mean, just like rcu_expedite_gp() ?
Quoted 2 lines
I wouldn't have
EXPORT_SYMBOL_GPL()unless you really know that it is needed externally.
At the moment it is not called externally but in the future, it could be from rcutorture. If you see rcu_expedite_gp(), that is exported too. I was just modeling it around that API.
thanks,
- Joel
Quoted 18 lines
-- Steve
Quoted 14 lines
kernel/rcu/update.c +14
-0+/** +* rcu_async_relax - Make future async RCU callbacks lazy. +* +* After a call to this function, future calls to call_rcu() +* will be processed in a lazy fashion. +*/ +void rcu_async_relax (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_dec (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_relax); + +static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 );
Paul E. McKenney
maintainerQuoted 45 lines · Joel Fernandes
Quoted 40 lines · Steven Rostedt
Quoted 22 lines · On Thu, 12 Jan 2023 00:52:22 +0000 "Joel Fernandes (Google)"…
--
a/kernel/rcu/update.c
+++b/kernel/rcu/update.ckernel/rcu/update.c +15
-1@@ -144,8 +144,45 @@ bool rcu_gp_is_normal(void) }EXPORT_SYMBOL_GPL (rcu_gp_is_normal); -static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 ); +static atomic_t rcu_async_hurry_nesting =ATOMIC_INIT (1 ); +/* +* Should call_rcu() callbacks be processed with urgency or are +* they OK being executed with arbitrary delays? +*/ +bool rcu_async_should_hurry (void ) +{ +return !IS_ENABLED (CONFIG_RCU_LAZY ) || +atomic_read (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_should_hurry); + +/** +* rcu_async_hurry - Make future async RCU callbacks not lazy. +* kernel/rcu/update.c bool rcu_gp_is_normal(void) · line 171
Quoted 10 lines
kernel/rcu/update.c +9
-0+* After a call to this function, future calls to call_rcu() +* will be processed in a timely fashion. +*/ +void rcu_async_hurry (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_inc (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_hurry);Where do you plan on calling these externally, as they are being marked exported?
Quoted 3 lines
If you allow random drivers to enable this, I can see something enabling it and hitting an error path that causes it to never disable it.
Quoted 8 lines
You mean, just like
rcu_expedite_gp()?Quoted 2 lines
I wouldn't have
EXPORT_SYMBOL_GPL()unless you really know that it is needed externally.At the moment it is not called externally but in the future, it could be from rcutorture. If you see
rcu_expedite_gp(), that is exported too. I was just modeling it around that API.
It really should be invoked from rcutorture for testing purposes. In current -rcu, TREE01 enables LAZY_RCU, so we are finally getting coverage (aside from my manual enablement on part of the test grid that I use).
So we need that export.
On the other hand, wasn't there some talk recently of targeted exports? If that comes to pass, this could be exported to only rcutorture and rcuscale.
Thanx, Paul
Quoted 22 lines
thanks,
- Joel
Quoted 18 lines
-- Steve
Quoted 14 lines
kernel/rcu/update.c +14
-0+/** +* rcu_async_relax - Make future async RCU callbacks lazy. +* +* After a call to this function, future calls to call_rcu() +* will be processed in a lazy fashion. +*/ +void rcu_async_relax (void ) +{ +if (IS_ENABLED (CONFIG_RCU_LAZY )) +atomic_dec (&rcu_async_hurry_nesting); +} +EXPORT_SYMBOL_GPL (rcu_async_relax); + +static atomic_t rcu_expedited_nesting =ATOMIC_INIT (1 );
Steven Rostedt
reviewerQuoted 10 lines · On Sun, 15 Jan 2023 16:34:58 -0500 Joel Fernandes <[email protected]>…
Quoted 9 lines
Quoted 2 lines
+EXPORT_SYMBOL_GPL(rcu_async_hurry);
Where do you plan on calling these externally, as they are being marked exported?
If you allow random drivers to enable this, I can see something enabling it and hitting an error path that causes it to never disable it.
Quoted 8 lines
You mean, just like
rcu_expedite_gp()?Quoted 2 lines
I wouldn't have
EXPORT_SYMBOL_GPL()unless you really know that it is needed externally.At the moment it is not called externally but in the future, it could be from rcutorture. If you see
rcu_expedite_gp(), that is exported too. I was just modeling it around that API.
The reason for the export should have been mentioned in the change log if the patch is not obvious to why it is being exported.
Thanks,
-- Steve
Paul E. McKenney
maintainerQuoted 18 lines · Steven Rostedt
Quoted 15 lines · On Sun, 15 Jan 2023 16:34:58 -0500 Joel Fernandes <[email protected]>…
Quoted 9 lines
Quoted 2 lines
+EXPORT_SYMBOL_GPL(rcu_async_hurry);
Where do you plan on calling these externally, as they are being marked exported?
If you allow random drivers to enable this, I can see something enabling it and hitting an error path that causes it to never disable it.
You mean, just like
rcu_expedite_gp()?Quoted 2 lines
I wouldn't have
EXPORT_SYMBOL_GPL()unless you really know that it is needed externally.
Quoted 6 lines
Quoted 3 lines
At the moment it is not called externally but in the future, it could be from rcutorture. If you see
rcu_expedite_gp(), that is exported too. I was just modeling it around that API.The reason for the export should have been mentioned in the change log if the patch is not obvious to why it is being exported.
Would something like this suffice? With attribution, of course.
Export rcu_async_should_hurry(), rcu_async_hurry(), and rcu_async_relax() for later use by rcutorture.
Thanx, Paul
Quoted 24 lines · Paul E. McKenney
Quoted 22 lines · Steven Rostedt
Quoted 18 lines · On Sun, 15 Jan 2023 16:34:58 -0500 Joel Fernandes <[email protected]>…
Quoted 9 lines
Quoted 2 lines
+EXPORT_SYMBOL_GPL(rcu_async_hurry);
Where do you plan on calling these externally, as they are being marked exported?
If you allow random drivers to enable this, I can see something enabling it and hitting an error path that causes it to never disable it.
You mean, just like
rcu_expedite_gp()?Quoted 2 lines
I wouldn't have
EXPORT_SYMBOL_GPL()unless you really know that it is needed externally.At the moment it is not called externally but in the future, it could be from rcutorture. If you see
rcu_expedite_gp(), that is exported too. I was just modeling it around that API.
Quoted 7 lines
Quoted 2 lines
The reason for the export should have been mentioned in the change log if the patch is not obvious to why it is being exported.
Would something like this suffice? With attribution, of course.
Export
rcu_async_should_hurry(),rcu_async_hurry(), andrcu_async_relax()for later use by rcutorture.
Looks good to me Paul, and thanks for the suggestion Steven!
- Joel
Steven Rostedt
reviewerQuoted 7 lines · On Tue, 17 Jan 2023 11:37:34 -0800 "Paul E. McKenney" <[email protected]>…
Quoted 2 lines
The reason for the export should have been mentioned in the change log if the patch is not obvious to why it is being exported.
Would something like this suffice? With attribution, of course.
Export
rcu_async_should_hurry(),rcu_async_hurry(), andrcu_async_relax()for later use by rcutorture.
Yes thanks. That way, at least a git blame will give some rationale for the export.
-- Steve
Paul E. McKenney
maintainerQuoted 6 lines · Steven Rostedt
Quoted 3 lines · On Tue, 17 Jan 2023 11:37:34 -0800 "Paul E. McKenney" <[email protected]>…
Quoted 2 lines
The reason for the export should have been mentioned in the change log if the patch is not obvious to why it is being exported.
Quoted 7 lines
Quoted 4 lines
Would something like this suffice? With attribution, of course.
Export
rcu_async_should_hurry(),rcu_async_hurry(), andrcu_async_relax()for later use by rcutorture.Yes thanks. That way, at least a git blame will give some rationale for the export.
Very well, I will apply this on my next rebase.
Thanx, Paul