Skip to contentSkip to conversation

extensions: NAT: Fix for -Werror=format-security

PATCH In review Phil Sutter 1 participant 2 messages Jan 12, 2023 netfilter

lore
Share & tools
lore

Phil Sutter

author reviewer
#0 lore raw

PATCH 1/1 extensions: NAT: Fix for -Werror=format-security

Have to pass either a string literal or format string to xt_xlate_add().

Fixes f30c5edce0413 ("extensions: Merge SNAT, DNAT, REDIRECT and MASQUERADE")
---
 extensions/libxt_NAT.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
extensions/libxt_NAT.c +1 -1
index da9f22012c5d6..2a6343986d54f 100644
@@ -424,7 +424,7 @@ __NAT_xlate(struct xt_xlate *xl, const struct nf_nat_range2 *r,
 	if (r->flags & NF_NAT_RANGE_PROTO_OFFSET)
 		return 0;
 
-	xt_xlate_add(xl, tgt);
+	xt_xlate_add(xl, "%s", tgt);
 	if (strlen(range_str))
 		xt_xlate_add(xl, " to %s", range_str);
 	if (r->flags & NF_NAT_RANGE_PROTO_RANDOM) {
Signature · 1 line
2.38.0
author reviewer
#1 lore raw
Quoted 4 lines · Phil Sutter

Have to pass either a string literal or format string to xt_xlate_add().

Fixes f30c5edce0413 ("extensions: Merge SNAT, DNAT, REDIRECT and MASQUERADE")

Patch applied.