Skip to contentSkip to conversation

gpio: ge: Remove duplicate assignment of of_gpio_n_cells

PATCH Applied Andy Shevchenko 2 participants 2 messages Jan 12, 2023 – Jan 16, 2023 GPIO

lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 gpio: ge: Remove duplicate assignment of of_gpio_n_cells

The of_gpio_n_cells default is 2 when ->of_xlate() callback is not defined. No need to assign it explicitly in the driver.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/gpio/gpio-ge.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpio/gpio-ge.c +0 -1
index f6a3de99f7db..7bd4c2a4cc11 100644
@@ -81,7 +81,6 @@ static int __init gef_gpio_probe(struct platform_device *pdev)
 
 	gc->base = -1;
 	gc->ngpio = (u16)(uintptr_t)of_device_get_match_data(&pdev->dev);
-	gc->of_gpio_n_cells = 2;
 
 	/* This function adds a memory mapped GPIO chip */
 	ret = devm_gpiochip_add_data(&pdev->dev, gc, NULL);
Signature · 1 line
2.39.0
Applied
#1 lore raw
Quoted 22 lines · Andy Shevchenko

The of_gpio_n_cells default is 2 when ->of_xlate() callback is not defined. No need to assign it explicitly in the driver.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/gpio/gpio-ge.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpio/gpio-ge.c +0 -2
index f6a3de99f7db..7bd4c2a4cc11 100644
@@ -81,7 +81,6 @@ static int __init gef_gpio_probe(struct platform_device *pdev)
 
        gc->base = -1;
        gc->ngpio = (u16)(uintptr_t)of_device_get_match_data(&pdev->dev);
-       gc->of_gpio_n_cells = 2;
 
        /* This function adds a memory mapped GPIO chip */
        ret = devm_gpiochip_add_data(&pdev->dev, gc, NULL);
--
Quoted 2 lines

2.39.0

Applied, thanks!

Bart