gpio: xilinx: Remove duplicate assignment of of_gpio_n_cells
Subsystems (3)
PATCH 1/1 gpio: xilinx: Remove duplicate assignment of of_gpio_n_cells
The of_gpio_n_cells default is 2 when ->of_xlate() callback is not defined. No need to assign it explicitly in the driver.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/gpio/gpio-xilinx.c | 11 ----------- 1 file changed, 11 deletions(-)
drivers/gpio/gpio-xilinx.c +0 -11
@@ -558,7 +558,6 @@ static int xgpio_probe(struct platform_device *pdev)int status =0 ;struct device_node *np = pdev->dev.of_node;u32 is_dual =0 ; -u32 cells =2 ;u32 width[2 ];u32 state[2 ];u32 dir[2 ];
@@ -591,15 +590,6 @@ static int xgpio_probe(struct platform_device *pdev)bitmap_from_arr32 (chip->dir, dir,64 ); -/* Update cells with gpio-cells value */ -if (of_property_read_u32 (np,"#gpio-cells" , &cells)) -dev_dbg (&pdev->dev,"Missing gpio-cells property\n" ); - -if (cells !=2 ) { -dev_err (&pdev->dev,"#gpio-cells mismatch\n" ); -return -EINVAL ; - } -/* * Check device node and parent device node for device width * and assume default width of 32
@@ -630,7 +620,6 @@ static int xgpio_probe(struct platform_device *pdev) chip->gc.parent = &pdev->dev; chip->gc.direction_input = xgpio_dir_in; chip->gc.direction_output = xgpio_dir_out; - chip->gc.of_gpio_n_cells = cells; chip->gc.get = xgpio_get; chip->gc.set = xgpio_set; chip->gc.request = xgpio_request;
Signature · 7 lines
2.39.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Bartosz Golaszewski
AppliedQuoted 46 lines · Andy Shevchenko
The
of_gpio_n_cellsdefault is 2 when ->of_xlate() callback is not defined. No need to assign it explicitly in the driver.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/gpio/gpio-xilinx.c | 11 ----------- 1 file changed, 11 deletions(-)drivers/gpio/gpio-xilinx.c +0
-12@@ -558,7 +558,6 @@ static int xgpio_probe(struct platform_device *pdev)int status =0 ;struct device_node *np = pdev->dev.of_node;u32 is_dual =0 ; -u32 cells =2 ;u32 width[2 ];u32 state[2 ];u32 dir[2 ];@@ -591,15 +590,6 @@ static int xgpio_probe(struct platform_device *pdev)bitmap_from_arr32 (chip->dir, dir,64 ); -/* Update cells with gpio-cells value */ -if (of_property_read_u32 (np,"#gpio-cells" , &cells)) -dev_dbg (&pdev->dev,"Missing gpio-cells property\n" ); - -if (cells !=2 ) { -dev_err (&pdev->dev,"#gpio-cells mismatch\n" ); -return -EINVAL ; - } -/* * Check device node and parent device node for device width * and assume default width of 32 @@ -630,7 +620,6 @@ static int xgpio_probe(struct platform_device *pdev) chip->gc.parent = &pdev->dev; chip->gc.direction_input = xgpio_dir_in; chip->gc.direction_output = xgpio_dir_out; - chip->gc.of_gpio_n_cells = cells; chip->gc.get = xgpio_get; chip->gc.set = xgpio_set; chip->gc.request = xgpio_request; --
Quoted 2 lines
2.39.0
Applied, thanks!
Bart