Skip to contentSkip to conversation

Some intel_gpu_top tweaks

PATCH In review Tvrtko Ursulin 3 participants 16 messages Jan 12, 2023 – Jan 26, 2023

lore
Share & tools
lore
#0 lore raw

cover Some intel_gpu_top tweaks

From: Tvrtko Ursulin <[email protected]>

Mostly by popular demand from
https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/109, although for some of these changes I'd like some second opinions. For instance is it user friendly to change the default aggregation mode for stdout and JSON output?

Tvrtko Ursulin (4):
intel_gpu_top: Fix man page formatting
intel_gpu_top: Automatically enclose JSON output into brackets
intel_gpu_top: Add command line switch to start in physical engine
mode
intel_gpu_top: Aggregate engine classes in all output modes

 man/intel_gpu_top.rst | 20 ++++++++++++--------
 tools/intel_gpu_top.c | 16 ++++++++++++++--
 2 files changed, 26 insertions(+), 10 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/4 intel_gpu_top: Fix man page formatting

From: Tvrtko Ursulin <[email protected]>

New lines are not respected when rst2man generates the page so try to work around that by followin advice from the Internet.

---
 man/intel_gpu_top.rst | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)
man/intel_gpu_top.rst +8 -7
index 748c7740c800..b0c95446a011 100644
@@ -53,13 +53,14 @@ RUNTIME CONTROL
 
 Supported keys:
 
-    'q'    Exit from the tool.
-    'h'    Show interactive help.
-    '1'    Toggle between aggregated engine class and physical engine mode.
-    'n'    Toggle display of numeric client busyness overlay.
-    's'    Toggle between sort modes (runtime, total runtime, pid, client id).
-    'i'    Toggle display of clients which used no GPU time.
-    'H'    Toggle between per PID aggregation and individual clients.
+|
+|    'q'    Exit from the tool.
+|    'h'    Show interactive help.
+|    '1'    Toggle between aggregated engine class and physical engine mode.
+|    'n'    Toggle display of numeric client busyness overlay.
+|    's'    Toggle between sort modes (runtime, total runtime, pid, client id).
+|    'i'    Toggle display of clients which used no GPU time.
+|    'H'    Toggle between per PID aggregation and individual clients.
 
 DEVICE SELECTION
 ================
Signature · 1 line
2.34.1
Reviewed-by on v1 1/4
#2 lore raw

Re: [igt-dev] [PATCH i-g-t 1/4] intel_gpu_top: Fix man page formatting

Quoted 6 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

New lines are not respected when rst2man generates the page so try to work around that by followin advice from the Internet.

Quoted 33 lines
---
 man/intel_gpu_top.rst | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)
man/intel_gpu_top.rst +8 -7
index 748c7740c800..b0c95446a011 100644
@@ -53,13 +53,14 @@ RUNTIME CONTROL
 
 Supported keys:
 
-    'q'    Exit from the tool.
-    'h'    Show interactive help.
-    '1'    Toggle between aggregated engine class and physical engine mode.
-    'n'    Toggle display of numeric client busyness overlay.
-    's'    Toggle between sort modes (runtime, total runtime, pid, client id).
-    'i'    Toggle display of clients which used no GPU time.
-    'H'    Toggle between per PID aggregation and individual clients.
+|
+|    'q'    Exit from the tool.
+|    'h'    Show interactive help.
+|    '1'    Toggle between aggregated engine class and physical engine mode.
+|    'n'    Toggle display of numeric client busyness overlay.
+|    's'    Toggle between sort modes (runtime, total runtime, pid, client id).
+|    'i'    Toggle display of clients which used no GPU time.
+|    'H'    Toggle between per PID aggregation and individual clients.
 
 DEVICE SELECTION
 ================
Signature · 1 line
2.34.1
#3 lore raw

Re: [igt-dev] [PATCH i-g-t 1/4] intel_gpu_top: Fix man page formatting

Quoted 9 lines · Kamil Konieczny
Quoted 6 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

New lines are not respected when rst2man generates the page so try to work around that by followin advice from the Internet.

Thanks! Later I noticed there is one more thing which currently renders badly, this line:

-o <file path | ->

Are you okay with re-review if I can fix that one too and respin?

Regards,

Tvrtko

Quoted 33 lines
Quoted 33 lines
---
  man/intel_gpu_top.rst | 15 ++++++++-------
  1 file changed, 8 insertions(+), 7 deletions(-)
man/intel_gpu_top.rst +8 -7
index 748c7740c800..b0c95446a011 100644
@@ -53,13 +53,14 @@ RUNTIME CONTROL
 
  Supported keys:
 
-    'q'    Exit from the tool.
-    'h'    Show interactive help.
-    '1'    Toggle between aggregated engine class and physical engine mode.
-    'n'    Toggle display of numeric client busyness overlay.
-    's'    Toggle between sort modes (runtime, total runtime, pid, client id).
-    'i'    Toggle display of clients which used no GPU time.
-    'H'    Toggle between per PID aggregation and individual clients.
+|
+|    'q'    Exit from the tool.
+|    'h'    Show interactive help.
+|    '1'    Toggle between aggregated engine class and physical engine mode.
+|    'n'    Toggle display of numeric client busyness overlay.
+|    's'    Toggle between sort modes (runtime, total runtime, pid, client id).
+|    'i'    Toggle display of clients which used no GPU time.
+|    'H'    Toggle between per PID aggregation and individual clients.
 
  DEVICE SELECTION
  ================
Signature · 1 line
2.34.1
#4 lore raw

Re: [igt-dev] [PATCH i-g-t 1/4] intel_gpu_top: Fix man page formatting

Hi,

Quoted 10 lines · Tvrtko Ursulin
Quoted 8 lines · Kamil Konieczny
Quoted 6 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

New lines are not respected when rst2man generates the page so try to work around that by followin advice from the Internet.

Quoted 8 lines
Quoted 1 line

Thanks! Later I noticed there is one more thing which currently renders badly, this line:

-o <file path | ->

Are you okay with re-review if I can fix that one too and respin?

Yes, no problem, I can review respin.

Regards,
Kamil

Quoted 35 lines

Regards,

Tvrtko

Quoted 30 lines
Quoted 30 lines
---
  man/intel_gpu_top.rst | 15 ++++++++-------
  1 file changed, 8 insertions(+), 7 deletions(-)
man/intel_gpu_top.rst +8 -7
index 748c7740c800..b0c95446a011 100644
@@ -53,13 +53,14 @@ RUNTIME CONTROL
  Supported keys:
-    'q'    Exit from the tool.
-    'h'    Show interactive help.
-    '1'    Toggle between aggregated engine class and physical engine mode.
-    'n'    Toggle display of numeric client busyness overlay.
-    's'    Toggle between sort modes (runtime, total runtime, pid, client id).
-    'i'    Toggle display of clients which used no GPU time.
-    'H'    Toggle between per PID aggregation and individual clients.
+|
+|    'q'    Exit from the tool.
+|    'h'    Show interactive help.
+|    '1'    Toggle between aggregated engine class and physical engine mode.
+|    'n'    Toggle display of numeric client busyness overlay.
+|    's'    Toggle between sort modes (runtime, total runtime, pid, client id).
+|    'i'    Toggle display of clients which used no GPU time.
+|    'H'    Toggle between per PID aggregation and individual clients.
  DEVICE SELECTION
  ================
Signature · 1 line
2.34.1
#5 lore raw

PATCH 2/4 intel_gpu_top: Automatically enclose JSON output into brackets

In reply to Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Parsers need the whole output enclosed into square brackets so every period sample becomes an array element.

So far we have been suggesting this in the man page but we can trivially make the tool output that itself.

---
 man/intel_gpu_top.rst | 2 +-
 tools/intel_gpu_top.c | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)
man/intel_gpu_top.rst +1 -1
index b0c95446a011..3317e04816b4 100644
@@ -85,7 +85,7 @@ Filter types: ::
 JSON OUTPUT
 ===========
 
-To parse the JSON as output by the tool the consumer should wrap its entirety into square brackets ([ ]). This will make each sample point a JSON array element and will avoid "Multiple root elements" JSON validation error.
+JSON output will be correctly terminated when the tool cleanly exits, otherwise one square bracket needs to be added before parsing.
 
 LIMITATIONS
 ===========
tools/intel_gpu_top.c +6 -0
index 6de8a164fcff..c4d98de4fe31 100644
@@ -2597,6 +2597,9 @@ int main(int argc, char **argv)
 	scan_clients(clients, false);
 	codename = igt_device_get_pretty_name(&card, false);
 
+	if (output_mode == JSON)
+		printf("[\n");
+
 	while (!stop_top) {
 		struct clients *disp_clients;
 		bool consumed = false;
@@ -2683,6 +2686,9 @@ int main(int argc, char **argv)
 			usleep(period_us);
 	}
 
+	if (output_mode == JSON)
+		printf("]\n");
+
 	if (clients)
 		free_clients(clients);
 
Signature · 1 line
2.34.1
Reviewed-by on v1 2/4
#6 lore raw

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 2/4] intel_gpu_top: Automatically enclose JSON output into brackets

Quoted 10 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Parsers need the whole output enclosed into square brackets so every period sample becomes an array element.

So far we have been suggesting this in the man page but we can trivially make the tool output that itself.

Quoted 45 lines
---
 man/intel_gpu_top.rst | 2 +-
 tools/intel_gpu_top.c | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)
man/intel_gpu_top.rst +1 -1
index b0c95446a011..3317e04816b4 100644
@@ -85,7 +85,7 @@ Filter types: ::
 JSON OUTPUT
 ===========
 
-To parse the JSON as output by the tool the consumer should wrap its entirety into square brackets ([ ]). This will make each sample point a JSON array element and will avoid "Multiple root elements" JSON validation error.
+JSON output will be correctly terminated when the tool cleanly exits, otherwise one square bracket needs to be added before parsing.
 
 LIMITATIONS
 ===========
tools/intel_gpu_top.c +6 -0
index 6de8a164fcff..c4d98de4fe31 100644
@@ -2597,6 +2597,9 @@ int main(int argc, char **argv)
 	scan_clients(clients, false);
 	codename = igt_device_get_pretty_name(&card, false);
 
+	if (output_mode == JSON)
+		printf("[\n");
+
 	while (!stop_top) {
 		struct clients *disp_clients;
 		bool consumed = false;
@@ -2683,6 +2686,9 @@ int main(int argc, char **argv)
 			usleep(period_us);
 	}
 
+	if (output_mode == JSON)
+		printf("]\n");
+
 	if (clients)
 		free_clients(clients);
 
Signature · 1 line
2.34.1
#7 lore raw

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 2/4] intel_gpu_top: Automatically enclose JSON output into brackets

Quoted 6 lines · Kamil Konieczny
Quoted 5 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Parsers need the whole output enclosed into square brackets so every period sample becomes an array element.

Quoted 7 lines
Quoted 5 lines

So far we have been suggesting this in the man page but we can trivially make the tool output that itself.

Disclaimer with this one is that I am not really sure if it is a good idea. How people might use the JSON output and if this helps or harms them I mean, I have no idea.

Regards,

Tvrtko

Quoted 45 lines
Quoted 45 lines
---
  man/intel_gpu_top.rst | 2 +-
  tools/intel_gpu_top.c | 6 ++++++
  2 files changed, 7 insertions(+), 1 deletion(-)
man/intel_gpu_top.rst +1 -1
index b0c95446a011..3317e04816b4 100644
@@ -85,7 +85,7 @@ Filter types: ::
  JSON OUTPUT
  ===========
 
-To parse the JSON as output by the tool the consumer should wrap its entirety into square brackets ([ ]). This will make each sample point a JSON array element and will avoid "Multiple root elements" JSON validation error.
+JSON output will be correctly terminated when the tool cleanly exits, otherwise one square bracket needs to be added before parsing.
 
  LIMITATIONS
  ===========
tools/intel_gpu_top.c +6 -0
index 6de8a164fcff..c4d98de4fe31 100644
@@ -2597,6 +2597,9 @@ int main(int argc, char **argv)
  	scan_clients(clients, false);
  	codename = igt_device_get_pretty_name(&card, false);
 
+	if (output_mode == JSON)
+		printf("[\n");
+
  	while (!stop_top) {
  		struct clients *disp_clients;
  		bool consumed = false;
@@ -2683,6 +2686,9 @@ int main(int argc, char **argv)
  			usleep(period_us);
  	}
 
+	if (output_mode == JSON)
+		printf("]\n");
+
  	if (clients)
  		free_clients(clients);
 
Signature · 1 line
2.34.1
#8 lore raw

PATCH 3/4 intel_gpu_top: Add command line switch to start in physical engine mode

In reply to Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Default mode is to aggreate engines per class but some users would prefer to be able to start in physical engine mode too.

Cc Dmitry Rogozhkin <[email protected]>
---
 man/intel_gpu_top.rst | 3 +++
 tools/intel_gpu_top.c | 9 +++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)
man/intel_gpu_top.rst +3 -0
index 3317e04816b4..b24216c0ae91 100644
@@ -48,6 +48,9 @@ OPTIONS
 -d
     Select a specific GPU using supported filter.
 
+-p
+   Default to showing physical engines instead of classes.
+
 RUNTIME CONTROL
 ===============
 
tools/intel_gpu_top.c +7 -2
index c4d98de4fe31..e91b47baf72b 100644
@@ -1268,6 +1268,7 @@ usage(const char *appname)
 		"\t[-s <ms>]       Refresh period in milliseconds (default %ums).\n"
 		"\t[-L]            List all cards.\n"
 		"\t[-d <device>]   Device filter, please check manual page for more details.\n"
+		"\t[-p]            Default to showing physical engines instead of classes.\n"
 		"\n",
 		appname, DEFAULT_PERIOD_MS);
 	igt_device_print_filter_types();
@@ -2446,6 +2447,7 @@ int main(int argc, char **argv)
 {
 	unsigned int period_us = DEFAULT_PERIOD_MS * 1000;
 	struct clients *clients = NULL;
+	bool physical_engines = false;
 	int con_w = -1, con_h = -1;
 	char *output_path = NULL;
 	struct engines *engines;
@@ -2456,7 +2458,7 @@ int main(int argc, char **argv)
 	char *codename = NULL;
 
 	/* Parse options */
-	while ((ch = getopt(argc, argv, "o:s:d:JLlh")) != -1) {
+	while ((ch = getopt(argc, argv, "o:s:d:pJLlh")) != -1) {
 		switch (ch) {
 		case 'o':
 			output_path = optarg;
@@ -2467,6 +2469,9 @@ int main(int argc, char **argv)
 		case 'd':
 			opt_device = strdup(optarg);
 			break;
+		case 'p':
+			physical_engines = true;
+			break;
 		case 'J':
 			output_mode = JSON;
 			break;
@@ -2508,7 +2513,7 @@ int main(int argc, char **argv)
 	case INTERACTIVE:
 		pops = &term_pops;
 		interactive_stdin();
-		class_view = true;
+		class_view = !physical_engines;
 		break;
 	case STDOUT:
 		pops = &stdout_pops;
Signature · 1 line
2.34.1
Reviewed-by on v1 3/4
#9 lore raw

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 3/4] intel_gpu_top: Add command line switch to start in physical engine mode

Quoted 7 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Default mode is to aggreate engines per class but some users would prefer to be able to start in physical engine mode too.

Cc Dmitry Rogozhkin <[email protected]>
Quoted 70 lines
---
 man/intel_gpu_top.rst | 3 +++
 tools/intel_gpu_top.c | 9 +++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)
man/intel_gpu_top.rst +3 -0
index 3317e04816b4..b24216c0ae91 100644
@@ -48,6 +48,9 @@ OPTIONS
 -d
     Select a specific GPU using supported filter.
 
+-p
+   Default to showing physical engines instead of classes.
+
 RUNTIME CONTROL
 ===============
 
tools/intel_gpu_top.c +7 -2
index c4d98de4fe31..e91b47baf72b 100644
@@ -1268,6 +1268,7 @@ usage(const char *appname)
 		"\t[-s <ms>]       Refresh period in milliseconds (default %ums).\n"
 		"\t[-L]            List all cards.\n"
 		"\t[-d <device>]   Device filter, please check manual page for more details.\n"
+		"\t[-p]            Default to showing physical engines instead of classes.\n"
 		"\n",
 		appname, DEFAULT_PERIOD_MS);
 	igt_device_print_filter_types();
@@ -2446,6 +2447,7 @@ int main(int argc, char **argv)
 {
 	unsigned int period_us = DEFAULT_PERIOD_MS * 1000;
 	struct clients *clients = NULL;
+	bool physical_engines = false;
 	int con_w = -1, con_h = -1;
 	char *output_path = NULL;
 	struct engines *engines;
@@ -2456,7 +2458,7 @@ int main(int argc, char **argv)
 	char *codename = NULL;
 
 	/* Parse options */
-	while ((ch = getopt(argc, argv, "o:s:d:JLlh")) != -1) {
+	while ((ch = getopt(argc, argv, "o:s:d:pJLlh")) != -1) {
 		switch (ch) {
 		case 'o':
 			output_path = optarg;
@@ -2467,6 +2469,9 @@ int main(int argc, char **argv)
 		case 'd':
 			opt_device = strdup(optarg);
 			break;
+		case 'p':
+			physical_engines = true;
+			break;
 		case 'J':
 			output_mode = JSON;
 			break;
@@ -2508,7 +2513,7 @@ int main(int argc, char **argv)
 	case INTERACTIVE:
 		pops = &term_pops;
 		interactive_stdin();
-		class_view = true;
+		class_view = !physical_engines;
 		break;
 	case STDOUT:
 		pops = &stdout_pops;
Signature · 1 line
2.34.1
#10 lore raw

PATCH 4/4 intel_gpu_top: Aggregate engine classes in all output modes

In reply to Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Use the same default for stdout and JSON output modes as it is for interactive.

Previously added command line switch can be used to go back to showing all physical engines.

Cc Dmitry Rogozhkin <[email protected]>
---
 tools/intel_gpu_top.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/intel_gpu_top.c +2 -1
index e91b47baf72b..7aa233570463 100644
@@ -2509,11 +2509,12 @@ int main(int argc, char **argv)
 	if (signal(SIGINT, sigint_handler) == SIG_ERR)
 		fprintf(stderr, "Failed to install signal handler!\n");
 
+	class_view = !physical_engines;
+
 	switch (output_mode) {
 	case INTERACTIVE:
 		pops = &term_pops;
 		interactive_stdin();
-		class_view = !physical_engines;
 		break;
 	case STDOUT:
 		pops = &stdout_pops;
Signature · 1 line
2.34.1
Reviewed-by on v1 4/4
#11 lore raw

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 4/4] intel_gpu_top: Aggregate engine classes in all output modes

Quoted 10 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Use the same default for stdout and JSON output modes as it is for interactive.

Previously added command line switch can be used to go back to showing all physical engines.

Cc Dmitry Rogozhkin <[email protected]>
Quoted 25 lines
---
 tools/intel_gpu_top.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/intel_gpu_top.c +2 -1
index e91b47baf72b..7aa233570463 100644
@@ -2509,11 +2509,12 @@ int main(int argc, char **argv)
 	if (signal(SIGINT, sigint_handler) == SIG_ERR)
 		fprintf(stderr, "Failed to install signal handler!\n");
 
+	class_view = !physical_engines;
+
 	switch (output_mode) {
 	case INTERACTIVE:
 		pops = &term_pops;
 		interactive_stdin();
-		class_view = !physical_engines;
 		break;
 	case STDOUT:
 		pops = &stdout_pops;
Signature · 1 line
2.34.1
#12 lore raw

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 4/4] intel_gpu_top: Aggregate engine classes in all output modes

Quoted 6 lines · Kamil Konieczny
Quoted 5 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Use the same default for stdout and JSON output modes as it is for interactive.

Quoted 7 lines
Quoted 5 lines

Previously added command line switch can be used to go back to showing all physical engines.

Cc Dmitry Rogozhkin <[email protected]>

Downside with this one is that the default output for -l and -J modes will change. Which may result in bug reports. I am undecided on balance.. should have tagged it as RFC really. Thoughts?

Regards,

Tvrtko

Quoted 25 lines
Quoted 25 lines
---
  tools/intel_gpu_top.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
tools/intel_gpu_top.c +2 -1
index e91b47baf72b..7aa233570463 100644
@@ -2509,11 +2509,12 @@ int main(int argc, char **argv)
  	if (signal(SIGINT, sigint_handler) == SIG_ERR)
  		fprintf(stderr, "Failed to install signal handler!\n");
 
+	class_view = !physical_engines;
+
  	switch (output_mode) {
  	case INTERACTIVE:
  		pops = &term_pops;
  		interactive_stdin();
-		class_view = !physical_engines;
  		break;
  	case STDOUT:
  		pops = &stdout_pops;
Signature · 1 line
2.34.1
#13 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for Some intel_gpu_top tweaks

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: Some intel_gpu_top tweaks
URL : https://patchwork.freedesktop.org/series/112751/
State : success

== Summary ==

CI Bug Log - changes from IGT_7119 -> IGTPW_8332
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/index.html

Participating hosts (43 -> 42)
------------------------------

Missing (1): fi-snb-2520m

Known issues
------------

Here are the changes found in IGTPW_8332 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-rkl-guc: NOTRUN -> [SKIP][1] ([i915#7828])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/fi-rkl-guc/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: [INCOMPLETE][2] ([i915#4983]) -> [PASS][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@migrate:
- {bat-adlp-9}: [DMESG-FAIL][4] ([i915#7699]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/bat-adlp-9/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/bat-adlp-9/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- {bat-rpls-1}: [DMESG-FAIL][6] ([i915#6367]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/bat-rpls-1/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/bat-rpls-1/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#4137]: https://gitlab.freedesktop.org/drm/intel/issues/4137
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7119 -> IGTPW_8332

CI-20190529: 20190529
CI_DRM_12577: e3da2dad96f658f4275d39977a7258ccfeedac1d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8332: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/index.html
IGT_7119: 1e6d24e6dfa42b22f950f7d5e436b8f9acf8747f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/index.html

#14 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for Some intel_gpu_top tweaks

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: Some intel_gpu_top tweaks
URL : https://patchwork.freedesktop.org/series/112751/
State : success

== Summary ==

CI Bug Log - changes from IGT_7119_full -> IGTPW_8332_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/index.html

Participating hosts (11 -> 9)
------------------------------

Missing (2): shard-rkl0 shard-tglu-9

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_8332_full:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@kms_chamelium_hpd@dp-hpd-after-suspend:
- {shard-rkl}: [SKIP][1] ([i915#7828]) -> [SKIP][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-5/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_8332_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2842]) +5 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-glk8/igt@gem_exec_fair@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-glk4/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@smem-oom:
- shard-apl: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-apl1/igt@[email protected]

* igt@gem_pwrite@basic-exhaustion:
- shard-apl: NOTRUN -> [WARN][6] ([i915#2658])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-apl7/igt@[email protected]

* igt@i915_pm_rps@engine-order:
- shard-apl: [PASS][7] -> [FAIL][8] ([i915#6537])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-apl6/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-apl1/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#3886]) +7 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-apl6/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_ccs:
- shard-glk: NOTRUN -> [SKIP][10] ([fdo#109271]) +4 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-glk6/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_ccs.html

* igt@kms_content_protection@atomic@pipe-a-dp-1:
- shard-apl: NOTRUN -> [TIMEOUT][11] ([i915#7173])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-apl7/igt@kms_content_protection@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-apl: [PASS][12] -> [FAIL][13] ([i915#2346]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-apl3/igt@kms_cursor_legacy@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-apl1/igt@kms_cursor_legacy@[email protected]
- shard-glk: [PASS][14] -> [FAIL][15] ([i915#2346])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-glk6/igt@kms_cursor_legacy@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-glk6/igt@kms_cursor_legacy@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: NOTRUN -> [FAIL][16] ([i915#4767])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-apl6/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#658]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-apl6/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-apl: NOTRUN -> [SKIP][18] ([fdo#109271]) +177 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-apl7/igt@kms_psr@psr2_sprite_plane_onoff.html

* igt@kms_vblank@pipe-a-accuracy-idle:
- shard-glk: [PASS][19] -> [FAIL][20] ([i915#43])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-glk5/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-glk9/igt@[email protected]

* igt@sysfs_clients@split-50:
- shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#2994]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-apl2/igt@[email protected]

#### Possible fixes ####

* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}: [FAIL][22] ([i915#7742]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-6/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-3/igt@[email protected]

* igt@drm_read@empty-block:
- {shard-rkl}: [SKIP][24] ([i915#4098]) -> [PASS][25] +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-3/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-6/igt@[email protected]

* igt@fbdev@info:
- {shard-rkl}: [SKIP][26] ([i915#2582]) -> [PASS][27] +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-1/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-6/igt@[email protected]

* igt@fbdev@write:
- {shard-dg1}: [FAIL][28] -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-dg1-15/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-dg1-14/igt@[email protected]
- shard-snb: [FAIL][30] -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-snb2/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-snb2/igt@[email protected]

* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][32] ([i915#6268]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-4/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-5/igt@[email protected]

* igt@gem_eio@in-flight-suspend:
- {shard-rkl}: [FAIL][34] ([fdo#103375]) -> [PASS][35] +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-4/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-5/igt@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- {shard-rkl}: [FAIL][36] ([i915#2842]) -> [PASS][37] +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-3/igt@gem_exec_fair@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-tglu}: [FAIL][38] ([i915#2842]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-tglu-4/igt@gem_exec_fair@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-tglu-3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [FAIL][40] ([i915#2842]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-glk5/igt@gem_exec_fair@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-glk1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- {shard-rkl}: [SKIP][42] ([fdo#109313]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-3/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-5/igt@[email protected]

* igt@gem_exec_reloc@basic-gtt-read:
- {shard-rkl}: [SKIP][44] ([i915#3281]) -> [PASS][45] +9 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-3/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-5/igt@[email protected]

* igt@gem_partial_pwrite_pread@writes-after-reads-snoop:
- shard-apl: [INCOMPLETE][46] ([i915#7708] / [i915#7833]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-apl2/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-apl6/igt@[email protected]

* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- shard-apl: [INCOMPLETE][48] ([i915#7708]) -> [PASS][49] +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-apl2/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-apl7/igt@[email protected]

* igt@gem_pwrite@basic-self:
- {shard-rkl}: [SKIP][50] ([i915#3282]) -> [PASS][51] +8 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-6/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-5/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-apl: [DMESG-WARN][52] ([i915#5566] / [i915#716]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-apl2/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-apl7/igt@[email protected]

* igt@gen9_exec_parse@batch-invalid-length:
- {shard-rkl}: [SKIP][54] ([i915#2527]) -> [PASS][55] +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-6/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-5/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][56] ([fdo#109271]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-apl7/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-apl3/igt@[email protected]

* igt@i915_pm_rpm@dpms-lpsp:
- {shard-rkl}: [SKIP][58] ([i915#1397]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-1/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-6/igt@[email protected]

* igt@i915_pm_rpm@modeset-lpsp-stress:
- {shard-dg1}: [SKIP][60] ([i915#1397]) -> [PASS][61] +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-dg1-18/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-dg1-14/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-modeset:
- {shard-rkl}: [SKIP][62] ([fdo#109308]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-5/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-6/igt@[email protected]

* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs:
- {shard-rkl}: [SKIP][64] ([i915#1845] / [i915#4098]) -> [PASS][65] +22 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-3/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-6/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs.html

* igt@kms_dp_aux_dev:
- {shard-rkl}: [SKIP][66] ([i915#1257]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-5/igt@kms_dp_aux_dev.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-6/igt@kms_dp_aux_dev.html

* igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][68] ([i915#79]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-glk7/igt@kms_flip@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-glk1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1:
- shard-apl: [FAIL][70] ([i915#79]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-apl7/igt@kms_flip@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-apl6/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-render:
- {shard-rkl}: [SKIP][72] ([i915#1849] / [i915#4098]) -> [PASS][73] +10 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-5/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-6/igt@[email protected]

* igt@kms_plane@plane-position-hole-dpms@pipe-b-planes:
- {shard-rkl}: [SKIP][74] ([i915#1849]) -> [PASS][75] +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-4/igt@kms_plane@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-6/igt@kms_plane@[email protected]

* igt@kms_psr@primary_mmap_gtt:
- {shard-rkl}: [SKIP][76] ([i915#1072]) -> [PASS][77] +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-1/igt@kms_psr@primary_mmap_gtt.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-6/igt@kms_psr@primary_mmap_gtt.html

* igt@perf_pmu@all-busy-idle-check-all:
- {shard-dg1}: [FAIL][78] ([i915#5234]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-dg1-19/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-dg1-16/igt@[email protected]

* igt@perf_pmu@idle@rcs0:
- {shard-rkl}: [FAIL][80] ([i915#4349]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7119/shard-rkl-4/igt@perf_pmu@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/shard-rkl-5/igt@perf_pmu@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4778]: https://gitlab.freedesktop.org/drm/intel/issues/4778
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5234]: https://gitlab.freedesktop.org/drm/intel/issues/5234
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7708]: https://gitlab.freedesktop.org/drm/intel/issues/7708
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7833]: https://gitlab.freedesktop.org/drm/intel/issues/7833
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7119 -> IGTPW_8332

CI-20190529: 20190529
CI_DRM_12577: e3da2dad96f658f4275d39977a7258ccfeedac1d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8332: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/index.html
IGT_7119: 1e6d24e6dfa42b22f950f7d5e436b8f9acf8747f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8332/index.html

#15 lore raw
In reply to Tvrtko Ursulin
Quoted 6 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Mostly by popular demand from
https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/109, although for some of these changes I'd like some second opinions. For instance is it user friendly to change the default aggregation mode for stdout and JSON output?

I do not see any response so imho we can merge this.

Regrads,
Kamil

Quoted 15 lines

Tvrtko Ursulin (4):
intel_gpu_top: Fix man page formatting
intel_gpu_top: Automatically enclose JSON output into brackets
intel_gpu_top: Add command line switch to start in physical engine
mode
intel_gpu_top: Aggregate engine classes in all output modes

 man/intel_gpu_top.rst | 20 ++++++++++++--------
 tools/intel_gpu_top.c | 16 ++++++++++++++--
 2 files changed, 26 insertions(+), 10 deletions(-)
Signature · 1 line
2.34.1