pinctrl: mediatek: Remove duplicate assignment of of_gpio_n_cells
Subsystems (4)
PATCH 1/1 pinctrl: mediatek: Remove duplicate assignment of of_gpio_n_cells
The of_gpio_n_cells default is 2 when ->of_xlate() callback is not defined. No need to assign it explicitly in the driver.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/pinctrl/mediatek/pinctrl-moore.c | 1 - drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 1 - drivers/pinctrl/mediatek/pinctrl-paris.c | 1 - 3 files changed, 3 deletions(-)
drivers/pinctrl/mediatek/pinctrl-moore.c +0 -1
@@ -574,7 +574,6 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw) chip->set_config = mtk_gpio_set_config; chip->base =-1 ; chip->ngpio = hw->soc->npins; - chip->of_gpio_n_cells =2 ; ret =gpiochip_add_data (chip, hw);if (ret <0 )
drivers/pinctrl/mediatek/pinctrl-mtk-common.c +0 -1
@@ -906,7 +906,6 @@ static const struct gpio_chip mtk_gpio_chip = { .set = mtk_gpio_set, .to_irq = mtk_gpio_to_irq, .set_config = mtk_gpio_set_config, - .of_gpio_n_cells = 2, };static int mtk_eint_suspend (struct device *device)
drivers/pinctrl/mediatek/pinctrl-paris.c +0 -1
@@ -987,7 +987,6 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw) chip->set_config = mtk_gpio_set_config; chip->base =-1 ; chip->ngpio = hw->soc->npins; - chip->of_gpio_n_cells =2 ; ret =gpiochip_add_data (chip, hw);if (ret <0 )
Signature · 1 line
2.39.0
Quoted 4 lines · Andy Shevchenko
The
of_gpio_n_cellsdefault is 2 when ->of_xlate() callback is not defined. No need to assign it explicitly in the driver.Signed-off-by Andy Shevchenko <[email protected]>
Patch applied!
Yours,
Linus Walleij