Skip to contentSkip to conversation

pinctrl: mediatek: Remove duplicate assignment of of_gpio_n_cells

PATCH In review Andy Shevchenko 2 participants 2 messages Jan 12, 2023 – Jan 16, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: mediatek: Remove duplicate assignment of of_gpio_n_cells

The of_gpio_n_cells default is 2 when ->of_xlate() callback is not defined. No need to assign it explicitly in the driver.

---
 drivers/pinctrl/mediatek/pinctrl-moore.c      | 1 -
 drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 1 -
 drivers/pinctrl/mediatek/pinctrl-paris.c      | 1 -
 3 files changed, 3 deletions(-)
drivers/pinctrl/mediatek/pinctrl-moore.c +0 -1
index 1ec0413959e1..007b98ce5631 100644
@@ -574,7 +574,6 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw)
 	chip->set_config	= mtk_gpio_set_config;
 	chip->base		= -1;
 	chip->ngpio		= hw->soc->npins;
-	chip->of_gpio_n_cells	= 2;
 
 	ret = gpiochip_add_data(chip, hw);
 	if (ret < 0)
drivers/pinctrl/mediatek/pinctrl-mtk-common.c +0 -1
index 553d16703475..665dec419e7c 100644
@@ -906,7 +906,6 @@ static const struct gpio_chip mtk_gpio_chip = {
 	.set			= mtk_gpio_set,
 	.to_irq			= mtk_gpio_to_irq,
 	.set_config		= mtk_gpio_set_config,
-	.of_gpio_n_cells	= 2,
 };
 
 static int mtk_eint_suspend(struct device *device)
drivers/pinctrl/mediatek/pinctrl-paris.c +0 -1
index 475f4172d508..17eead44b675 100644
@@ -987,7 +987,6 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw)
 	chip->set_config	= mtk_gpio_set_config;
 	chip->base		= -1;
 	chip->ngpio		= hw->soc->npins;
-	chip->of_gpio_n_cells	= 2;
 
 	ret = gpiochip_add_data(chip, hw);
 	if (ret < 0)
Signature · 1 line
2.39.0