iio: chemical: scd30_core: use sysfs_emit() to instead of scnprintf()
Subsystems (2)
PATCH 1/1 iio: chemical: scd30_core: use sysfs_emit() to instead of scnprintf()
Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/iio/chemical/scd30_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/iio/chemical/scd30_core.c +3 -3
@@ -354,7 +354,7 @@ static ssize_t sampling_frequency_available_show(struct device *dev, struct devissize_t len =0 ; do { - len += scnprintf(buf + len, PAGE_SIZE - len, "0.%09u ", 1000000000 / i); + len += sysfs_emit_at(buf, len, "0.%09u ", 1000000000 / i); /* * Not all values fit PAGE_SIZE buffer hence print every 6th * (each frequency differs by 6s in time domain from the
@@ -380,7 +380,7 @@ static ssize_t calibration_auto_enable_show(struct device *dev, struct device_at ret =scd30_command_read (state,CMD_ASC , &val);mutex_unlock (&state->lock); -return ret ?:sprintf (buf,"%d\n" , val); +return ret ?:sysfs_emit (buf,"%d\n" , val); } static ssize_t calibration_auto_enable_store(struct device *dev, struct device_attribute *attr,
@@ -414,7 +414,7 @@ static ssize_t calibration_forced_value_show(struct device *dev, struct device_a ret =scd30_command_read (state,CMD_FRC , &val);mutex_unlock (&state->lock); -return ret ?:sprintf (buf,"%d\n" , val); +return ret ?:sysfs_emit (buf,"%d\n" , val); } static ssize_t calibration_forced_value_store(struct device *dev, struct device_attribute *attr,
Signature · 1 line
2.39.0
Quoted 5 lines · On Fri, 13 Jan 2023 16:11:17 +0200 Andy Shevchenko…
Follow the advice of the
Documentation/filesystems/sysfs.rstandshow()should only usesysfs_emit()orsysfs_emit_at()when formatting the value to be returned to user space.Signed-off-by Andy Shevchenko <[email protected]>
Applied
Thanks,
Quoted 35 lines
--- drivers/iio/chemical/scd30_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/iio/chemical/scd30_core.c +3
-3@@ -354,7 +354,7 @@ static ssize_t sampling_frequency_available_show(struct device *dev, struct devissize_t len =0 ; do { - len += scnprintf(buf + len, PAGE_SIZE - len, "0.%09u ", 1000000000 / i); + len += sysfs_emit_at(buf, len, "0.%09u ", 1000000000 / i); /* * Not all values fit PAGE_SIZE buffer hence print every 6th * (each frequency differs by 6s in time domain from the@@ -380,7 +380,7 @@ static ssize_t calibration_auto_enable_show(struct device *dev, struct device_at ret =scd30_command_read (state,CMD_ASC , &val);mutex_unlock (&state->lock); -return ret ?:sprintf (buf,"%d\n" , val); +return ret ?:sysfs_emit (buf,"%d\n" , val); } static ssize_t calibration_auto_enable_store(struct device *dev, struct device_attribute *attr,@@ -414,7 +414,7 @@ static ssize_t calibration_forced_value_show(struct device *dev, struct device_a ret =scd30_command_read (state,CMD_FRC , &val);mutex_unlock (&state->lock); -return ret ?:sprintf (buf,"%d\n" , val); +return ret ?:sysfs_emit (buf,"%d\n" , val); } static ssize_t calibration_forced_value_store(struct device *dev, struct device_attribute *attr,