drm/vc4: bo: Fix unused variable warning
Subsystems (3)
PATCH 1/1 drm/vc4: bo: Fix unused variable warning
Commit 07a2975c65f2 ("drm/vc4: bo: Fix drmm_mutex_init memory hog") removed the only user of the ret variable, but didn't remove the variable itself leading to a unused variable warning.
Remove that variable.
--- drivers/gpu/drm/vc4/vc4_bo.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/vc4/vc4_bo.c +0 -1
@@ -395,7 +395,6 @@ struct drm_gem_object *vc4_create_object(struct drm_device *dev, size_t size) {struct vc4_dev *vc4 =to_vc4_dev (dev);struct vc4_bo *bo; -int ret;if (WARN_ON_ONCE (vc4->is_vc5))return ERR_PTR (-ENODEV );
Signature · 1 line
2.39.0
Quoted 2 lines · Maxime Ripard
Commit
07a2975c65f2("drm/vc4: bo: Fixdrmm_mutex_initmemory hog") removed the only user of the ret variable, but didn't remove the
s/user/use
Quoted 7 lines
variable itself leading to a unused variable warning.
Remove that variable.
Reported-by Stephen Rothwell <[email protected]>Fixes 07a2975c65f2 ("drm/vc4: bo: Fix drmm_mutex_init memory hog")Signed-off-by Maxime Ripard <[email protected]>
With that small nit:
Best Regards,
- Maíra Canal
Quoted 16 lines
--- drivers/gpu/drm/vc4/vc4_bo.c | 1 - 1 file changed, 1 deletion(-)drivers/gpu/drm/vc4/vc4_bo.c +0
-1@@ -395,7 +395,6 @@ struct drm_gem_object *vc4_create_object(struct drm_device *dev, size_t size) {struct vc4_dev *vc4 =to_vc4_dev (dev);struct vc4_bo *bo; -int ret;if (WARN_ON_ONCE (vc4->is_vc5))return ERR_PTR (-ENODEV );
Maxime Ripard
AppliedRe: (subset) [PATCH] drm/vc4: bo: Fix unused variable warning
In reply to Maxime RipardQuoted 8 lines · Maxime Ripard
Commit
07a2975c65f2("drm/vc4: bo: Fixdrmm_mutex_initmemory hog") removed the only user of the ret variable, but didn't remove the variable itself leading to a unused variable warning.Remove that variable.
[...]
Applied to drm/drm-misc (drm-misc-fixes).
Thanks!
Maxime