Skip to contentSkip to conversation

ice: Add the CEE DCBX support in the comments

PATCH In review Zhu Yanjun 2 participants 2 messages Jan 13, 2023

Subsystems (3)
lore
Share & tools
lore

Zhu Yanjun

author
#0 lore raw

PATCH 1/1 ice: Add the CEE DCBX support in the comments

From: Zhu Yanjun <[email protected]>

From the function ice_parse_org_tlv, CEE DCBX TLV is also supported. The comments are changed.

---
 drivers/net/ethernet/intel/ice/ice_dcb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/ice/ice_dcb.c +2 -2
index 6be02f9b0b8c..7964405efa77 100644
@@ -566,7 +566,7 @@ ice_parse_cee_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
  * @tlv: Organization specific TLV
  * @dcbcfg: Local store to update ETS REC data
  *
- * Currently only IEEE 802.1Qaz TLV is supported, all others
+ * Currently IEEE 802.1Qaz and CEE DCBX TLV are supported, others
  * will be returned
  */
 static void
@@ -585,7 +585,7 @@ ice_parse_org_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
 		ice_parse_cee_tlv(tlv, dcbcfg);
 		break;
 	default:
-		break;
+		break; /* Other OUIs not supported */
 	}
 }
 
Signature · 6 lines
2.27.0

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
#1 lore raw

Dear Zhu,

Thank you for your patch. (Unfortunately your system time is incorrect, so the message date is from the future.)

Am 14.01.23 um 00:19 schrieb Zhu Yanjun:

Quoted 1 line

From: Zhu Yanjun <[email protected]>

Maybe use the following summary/title/subject:

ice: Mention CEE DCBX in code comment

Quoted 2 lines

From the function ice_parse_org_tlv, CEE DCBX TLV is also supported. The comments are changed.

…, so update the comment.

Quoted 4 lines
---
  drivers/net/ethernet/intel/ice/ice_dcb.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

The rest looks good.

[…]

Kind regards,

Paul
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan