Skip to contentSkip to conversation

iio: hid: fix the retval in gyro_3d_capture_sample

PATCH Applied Dmitry Perchanov 2 participants 2 messages Jan 11, 2023 – Jan 14, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Return value should be zero for success.
This was forgotten for timestamp feature.
Verified on RealSense cameras.

Fixes 4648cbd8fb92 ("iio: hid-sensor-gyro-3d: Add timestamp channel")
---
 drivers/iio/gyro/hid-sensor-gyro-3d.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/gyro/hid-sensor-gyro-3d.c +1 -0
index 8f0ad022c..698c50da1 100644
@@ -231,6 +231,7 @@ static int gyro_3d_capture_sample(struct hid_sensor_hub_device *hsdev,
 		gyro_state->timestamp =
 			hid_sensor_convert_timestamp(&gyro_state->common_attributes,
 						     *(s64 *)raw_data);
+		ret = 0;
 	break;
 	default:
 		break;
Signature · 10 lines
2.39.0


---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
maintainer Applied
#1 lore raw
Quoted 7 lines · On Wed, 11 Jan 2023 14:24:25 +0200 Dmitry Perchanov…

Return value should be zero for success.
This was forgotten for timestamp feature.
Verified on RealSense cameras.

Fixes 4648cbd8fb92 ("iio: hid-sensor-gyro-3d: Add timestamp channel")

Applied with patch description white space tidied up (wrap at 75 chars, not blank lines in tags block).

Applied to the fixes-togreg branch of iio.git and marked for stable inclusion.

Thanks,

Jonathan

Quoted 16 lines
---
 drivers/iio/gyro/hid-sensor-gyro-3d.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/gyro/hid-sensor-gyro-3d.c +1 -0
index 8f0ad022c..698c50da1 100644
@@ -231,6 +231,7 @@ static int gyro_3d_capture_sample(struct hid_sensor_hub_device *hsdev,
 		gyro_state->timestamp =
 			hid_sensor_convert_timestamp(&gyro_state->common_attributes,
 						     *(s64 *)raw_data);
+		ret = 0;
 	break;
 	default:
 		break;