Skip to contentSkip to conversation

arm64: dts: beacon-renesom: Fix gpio expander reference

PATCH In review Adam Ford 2 participants 7 messages Jan 14, 2023 – Jan 23, 2023

Subsystems (2)
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/3 arm64: dts: beacon-renesom: Fix gpio expander reference

The board used to originally introduce the Beacon Embedded RZ/G2[M/N/H] boards had a GPIO expander with address 20, but this was change when the final board went to production.

The production boards changed both the part itself and the address. With the incorrect address, the LCD cannot come up. If the LCD fails, the rcar-du driver fails to come up, and that also breaks HDMI.

Pre-release board were not shipped to the general public, so it should be safe to push this as a fix. Anyone with a production board would have video fail due to this GPIO expander change.

Fixes a1d8a344f1ca ("arm64: dts: renesas: Introduce r8a774a1-beacon-rzg2m-kit")

---
V2: Update compatible to reflect the part change.

arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +15 -14
index d3ec8c45d5af..518885cb1e7e 100644
@@ -437,20 +437,6 @@ wm8962_endpoint: endpoint {
 		};
 	};
 
-	/* 0 - lcd_reset */
-	/* 1 - lcd_pwr */
-	/* 2 - lcd_select */
-	/* 3 - backlight-enable */
-	/* 4 - Touch_shdwn */
-	/* 5 - LCD_H_pol */
-	/* 6 - lcd_V_pol */
-	gpio_exp1: gpio@20 {
-		compatible = "onnn,pca9654";
-		reg = <0x20>;
-		gpio-controller;
-		#gpio-cells = <2>;
-	};
-
 	touchscreen@26 {
 		compatible = "ilitek,ili2117";
 		reg = <0x26>;
@@ -482,6 +468,21 @@ hd3ss3220_out_ep: endpoint {
 			};
 		};
 	};
+
+	gpio_exp1: gpio@70 {
+		compatible = "nxp,pca9538";
+		reg = <0x70>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		gpio-line-names =
+			"lcd_reset",
+			"lcd_pwr",
+			"lcd_select",
+			"backlight-enable",
+			"Touch_shdwn",
+			"LCD_H_pol",
+			"lcd_V_pol";
+	};
 };
 
 &lvds0 {
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH 2/3 arm64: dts: beacon-renesom: Update Ethernet PHY ID

Due to the part shortage, the AR8031 PHY was replaced with a Micrel KSZ9131. Hard-coding the ID of the PHY makes this new PHY non-operational on newer hardware. Since previous hardware had only shipped to a limited number of people, and they have not gone to production, it should be safe to update the PHY ID.

arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi +1 -1
index d3fc8ffd5b4c..a302f0ea8a48 100644
@@ -59,7 +59,7 @@ &avb {
 	status = "okay";
 
 	phy0: ethernet-phy@0 {
-		compatible = "ethernet-phy-id004d.d074",
+		compatible = "ethernet-phy-i0022.1640",
 			     "ethernet-phy-ieee802.3-c22";
 		reg = <0>;
 		interrupt-parent = <&gpio2>;
Signature · 1 line
2.34.1
Reviewed-by on v1 2/3
#2 lore raw

Re: [PATCH 2/3] arm64: dts: beacon-renesom: Update Ethernet PHY ID

Quoted 7 lines · Adam Ford

Due to the part shortage, the AR8031 PHY was replaced with a Micrel KSZ9131. Hard-coding the ID of the PHY makes this new PHY non-operational on newer hardware. Since previous hardware had only shipped to a limited number of people, and they have not gone to production, it should be safe to update the PHY ID.

i.e. will queue in renesas-devel for v6.3.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#3 lore raw

Re: [PATCH 2/3] arm64: dts: beacon-renesom: Update Ethernet PHY ID

In reply to Adam Ford
Quoted 13 lines · Adam Ford

Due to the part shortage, the AR8031 PHY was replaced with a Micrel KSZ9131. Hard-coding the ID of the PHY makes this new PHY non-operational on newer hardware. Since previous hardware had only shipped to a limited number of people, and they have not gone to production, it should be safe to update the PHY ID.

arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi +0 -0
index d3fc8ffd5b4c..a302f0ea8a48 100644

arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi &avb { · line 62

Quoted 5 lines
arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi +1 -1
@@ -59,7 +59,7 @@ &avb {
        status = "okay";
 
        phy0: ethernet-phy@0 {
-               compatible = "ethernet-phy-id004d.d074",
+               compatible = "ethernet-phy-i0022.1640",

ethernet-phy-id0022.1640

Fixing while applying...

arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi &avb { · line 65

Quoted 3 lines
arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi +0 -0
                             "ethernet-phy-ieee802.3-c22";
                reg = <0>;
                interrupt-parent = <&gpio2>;

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

author
#4 lore raw

PATCH 3/3 arm64: dts: beacon-renesom: Fix some audio messages

In reply to Adam Ford

The WM8962 is configured so the SoC is driving the clock, and it's currently set to 24 MHz. However, when playing audio it shows the following message:

    wm8962 5-001a: Unsupported sysclk ratio 500

While not harmful, a better clock ratio is 512. It makes the message disappear, and it still plays sound.

arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +1 -1
index 518885cb1e7e..e0b9aee8e181 100644
@@ -367,7 +367,7 @@ versaclock6_bb: clock-controller@6a {
 
 		assigned-clocks = <&versaclock6_bb 1>, <&versaclock6_bb 2>,
 				  <&versaclock6_bb 3>, <&versaclock6_bb 4>;
-		assigned-clock-rates = <24000000>, <24000000>, <24000000>,
+		assigned-clock-rates = <24000000>, <24000000>, <24576000>,
 				       <24576000>;
 
 		OUT1 {
Signature · 1 line
2.34.1
Reviewed-by on v1 3/3
#5 lore raw

Re: [PATCH 3/3] arm64: dts: beacon-renesom: Fix some audio messages

Quoted 9 lines · Adam Ford

The WM8962 is configured so the SoC is driving the clock, and it's currently set to 24 MHz. However, when playing audio it shows the following message:

    wm8962 5-001a: Unsupported sysclk ratio 500

While not harmful, a better clock ratio is 512. It makes the message disappear, and it still plays sound.

i.e. will queue in renesas-devel for v6.3.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Reviewed-by on v1 1/3
#6 lore raw
In reply to Adam Ford
Quoted 9 lines · Adam Ford

The board used to originally introduce the Beacon Embedded RZ/G2[M/N/H] boards had a GPIO expander with address 20, but this was change when the final board went to production.

The production boards changed both the part itself and the address. With the incorrect address, the LCD cannot come up. If the LCD fails, the rcar-du driver fails to come up, and that also breaks HDMI.

Quoted 8 lines

Pre-release board were not shipped to the general public, so it should be safe to push this as a fix. Anyone with a production board would have video fail due to this GPIO expander change.

Fixes a1d8a344f1ca ("arm64: dts: renesas: Introduce r8a774a1-beacon-rzg2m-kit")

---
V2: Update compatible to reflect the part change.

i.e. will queue in renesas-devel for v6.3.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds