Skip to contentSkip to conversation

Windows installer: keep dependency cache

PATCH New Arthur Sengileyev 1 participant 1 message Jan 15, 2023

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 Windows installer: keep dependency cache

It should be possible to reuse cache built by previous iteration to process next executables. Processed dependencies are already skipped later based on dll name.

---
 scripts/nsis.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/nsis.py +2 -1
index 03ed7608a2..7cffba70ff 100644
@@ -91,12 +91,13 @@ def main():
         print("Searching '%s' for the dependent dlls ..." % search_path)
         dlldir = os.path.join(destdir + prefix, "dll")
         os.mkdir(dlldir)
+        deps_cache = set()
 
         for exe in glob.glob(os.path.join(destdir + prefix, "*.exe")):
             signcode(exe)
 
             # find all dll dependencies
-            deps = set(find_deps(exe, search_path, set()))
+            deps = set(find_deps(exe, search_path, deps_cache))
             deps.remove(exe)
 
             # copy all dlls to the DLLDIR
Signature · 1 line
2.39.0