Skip to contentSkip to conversation

build: drop unused python-related bits from configure.ac

PATCH New Bartosz Golaszewski 1 participant 2 messages Jan 16, 2023 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 build: drop unused python-related bits from configure.ac

From: Bartosz Golaszewski <[email protected]>

We no longer use autotools to build python bindings. We should still check the interpreter but let's not set any automake variables.

---
 configure.ac | 15 ---------------
 1 file changed, 15 deletions(-)
configure.ac +0 -15
index 599c598..d305506 100644
@@ -40,11 +40,6 @@ m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 m4_pattern_forbid([^AX_],
 	[Unexpanded AX_ macro found. Please install GNU autoconf-archive.])
 
-AC_ARG_VAR([PYTHON_CPPFLAGS],
-	[Compiler flags to find Python headers [default: auto-detect]])
-AC_ARG_VAR([PYTHON_LIBS],
-	[Libraries to link into Python extensions [default: auto-detect]])
-
 AC_CONFIG_SRCDIR([lib])
 AC_CONFIG_HEADERS([config.h])
 
@@ -229,16 +224,6 @@ then
 	then
 		AC_MSG_ERROR([python3-config not found - needed for python bindings])
 	fi
-
-	if test -z "$PYTHON_CPPFLAGS"
-	then
-		AC_SUBST(PYTHON_CPPFLAGS, [`$PYTHON-config --includes`])
-	fi
-
-	if test -z "$PYTHON_LIBS"
-	then
-		AC_SUBST(PYTHON_LIBS, [`$PYTHON-config --libs`])
-	fi
 fi
 
 AC_ARG_ENABLE([bindings-rust],
Signature · 1 line
2.37.2
#1 lore raw

PATCH 2/2 build: update the required python version

From: Bartosz Golaszewski <[email protected]>

We don't guarantee libgpiod python bindings to work with anything older than python 3.9. Let's fix the required version in configure.ac.

---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure.ac +1 -1
index d305506..7b8c65a 100644
@@ -216,7 +216,7 @@ AM_CONDITIONAL([WITH_BINDINGS_PYTHON], [test "x$with_bindings_python" = xtrue])
 
 if test "x$with_bindings_python" = xtrue
 then
-	AM_PATH_PYTHON([3.0], [],
+	AM_PATH_PYTHON([3.9], [],
 		[AC_MSG_ERROR([python3 not found - needed for python bindings])])
 	AC_CHECK_PROG([has_python_config], [python3-config], [true], [false])
 
Signature · 1 line
2.37.2