wifi: rtw89: coex: the last patchset to adapt BTC version
Ping-Ke Shih
maintainercover wifi: rtw89: coex: the last patchset to adapt BTC version
This patchset is to add some fixes and refinements found during adapting BTC version. After these, we can support all current firmware and will continue to update to support newer ones in the future.
Ching-Te Ku (8):
wifi: rtw89: coex: Update Wi-Fi external control TDMA
parameters/tables
wifi: rtw89: coex: Clear Bluetooth HW PTA counter when radio state
change
wifi: rtw89: coex: Force to update TDMA parameter when radio state
change
wifi: rtw89: coex: Refine coexistence log
wifi: rtw89: coex: Set Bluetooth background scan PTA request priority
wifi: rtw89: coex: Correct A2DP exist variable source
wifi: rtw89: coex: Fix test fail when coexist with raspberryPI A2DP
idle
wifi: rtw89: coex: Update Wi-Fi Bluetooth coexistence version to 7.0.0
drivers/net/wireless/realtek/rtw89/coex.c | 212 ++++++++++++---------- 1 file changed, 113 insertions(+), 99 deletions(-)
Signature · 1 line
2.25.1
Ping-Ke Shih
maintainerPATCH 1/8 wifi: rtw89: coex: Update Wi-Fi external control TDMA parameters/tables
From: Ching-Te Ku <[email protected]>
This patch update the external control (Wi-Fi firmware control) type of TDMA related parameters, almost all of these case were related to Wi-Fi multi-role situations & AP mode.
--- drivers/net/wireless/realtek/rtw89/coex.c | 37 +++++++++++++++-------- 1 file changed, 24 insertions(+), 13 deletions(-)
drivers/net/wireless/realtek/rtw89/coex.c +24 -13
@@ -63,7 +63,7 @@ struct btc_fbtc_1slot {static const struct rtw89_btc_fbtc_tdma t_def[] = { [CXTD_OFF ] = {CXTDMA_OFF ,CXFLC_OFF ,CXTPS_OFF ,0 ,0 ,0 ,0 ,0 }, [CXTD_OFF_B2 ] = {CXTDMA_OFF ,CXFLC_OFF ,CXTPS_OFF ,0 ,0 ,1 ,0 ,0 }, - [CXTD_OFF_EXT ] = {CXTDMA_OFF ,CXFLC_OFF ,CXTPS_OFF ,0 ,0 ,3 ,0 ,0 }, + [CXTD_OFF_EXT ] = {CXTDMA_OFF ,CXFLC_OFF ,CXTPS_OFF ,0 ,0 ,2 ,0 ,0 }, [CXTD_FIX ] = {CXTDMA_FIX ,CXFLC_OFF ,CXTPS_OFF ,0 ,0 ,0 ,0 ,0 }, [CXTD_PFIX ] = {CXTDMA_FIX ,CXFLC_NULLP ,CXTPS_ON ,0 ,5 ,0 ,0 ,0 }, [CXTD_AUTO ] = {CXTDMA_AUTO ,CXFLC_OFF ,CXTPS_OFF ,0 ,0 ,0 ,0 ,0 },
@@ -80,21 +80,21 @@ static const struct rtw89_btc_fbtc_slot s_def[] = { [CXST_OFF] = __DEF_FBTC_SLOT(100, 0x55555555, SLOT_MIX), [CXST_B2W] = __DEF_FBTC_SLOT(5, 0xea5a5a5a, SLOT_ISO), [CXST_W1] = __DEF_FBTC_SLOT(70, 0xea5a5a5a, SLOT_ISO), - [CXST_W2] = __DEF_FBTC_SLOT(70, 0xea5a5aaa, SLOT_ISO), + [CXST_W2] = __DEF_FBTC_SLOT(15, 0xea5a5a5a, SLOT_ISO), [CXST_W2B] = __DEF_FBTC_SLOT(15, 0xea5a5a5a, SLOT_ISO), - [CXST_B1] = __DEF_FBTC_SLOT(100, 0xe5555555, SLOT_MIX), + [CXST_B1] = __DEF_FBTC_SLOT(250, 0xe5555555, SLOT_MIX), [CXST_B2] = __DEF_FBTC_SLOT(7, 0xea5a5a5a, SLOT_MIX), [CXST_B3] = __DEF_FBTC_SLOT(5, 0xe5555555, SLOT_MIX), [CXST_B4] = __DEF_FBTC_SLOT(50, 0xe5555555, SLOT_MIX), [CXST_LK] = __DEF_FBTC_SLOT(20, 0xea5a5a5a, SLOT_ISO), - [CXST_BLK] = __DEF_FBTC_SLOT(250, 0x55555555, SLOT_MIX), - [CXST_E2G] = __DEF_FBTC_SLOT(20, 0xea5a5a5a, SLOT_MIX), - [CXST_E5G] = __DEF_FBTC_SLOT(20, 0xffffffff, SLOT_MIX), - [CXST_EBT] = __DEF_FBTC_SLOT(20, 0xe5555555, SLOT_MIX), - [CXST_ENULL] = __DEF_FBTC_SLOT(7, 0xaaaaaaaa, SLOT_ISO), + [CXST_BLK] = __DEF_FBTC_SLOT(500, 0x55555555, SLOT_MIX), + [CXST_E2G] = __DEF_FBTC_SLOT(0, 0xea5a5a5a, SLOT_MIX), + [CXST_E5G] = __DEF_FBTC_SLOT(0, 0xffffffff, SLOT_ISO), + [CXST_EBT] = __DEF_FBTC_SLOT(0, 0xe5555555, SLOT_MIX), + [CXST_ENULL] = __DEF_FBTC_SLOT(0, 0xaaaaaaaa, SLOT_ISO), [CXST_WLK] = __DEF_FBTC_SLOT(250, 0xea5a5a5a, SLOT_MIX), - [CXST_W1FDD] = __DEF_FBTC_SLOT(35, 0xfafafafa, SLOT_ISO), - [CXST_B1FDD] = __DEF_FBTC_SLOT(100, 0xffffffff, SLOT_MIX), + [CXST_W1FDD] = __DEF_FBTC_SLOT(50, 0xffffffff, SLOT_ISO), + [CXST_B1FDD] = __DEF_FBTC_SLOT(50, 0xffffdfff, SLOT_ISO), };static const u32 cxtbl[] = {
@@ -117,7 +117,12 @@ static const u32 cxtbl[] = {0xfafafafa ,/* 16 */ 0xffffddff ,/* 17 */ 0xdaffdaff ,/* 18 */ -0xfafadafa /* 19 */ +0xfafadafa ,/* 19 */ +0xea6a6a6a ,/* 20 */ +0xea55556a ,/* 21 */ +0xaafafafa ,/* 22 */ +0xfafaaafa ,/* 23 */ +0xfafffaff /* 24 */ }; static const struct rtw89_btc_ver rtw89_btc_ver_defs[] = {
@@ -2701,15 +2706,16 @@ void rtw89_btc_set_policy_v1(struct rtw89_dev *rtwdev, u16 policy_type)break ;case BTC_CXP_OFF_EQ0 :_slot_set_tbl (btc,CXST_OFF , cxtbl[0 ]); +_slot_set_type (btc,CXST_OFF ,SLOT_ISO );break ;case BTC_CXP_OFF_EQ1 :_slot_set_tbl (btc,CXST_OFF , cxtbl[16 ]);break ;case BTC_CXP_OFF_EQ2 : -_slot_set_tbl (btc,CXST_OFF , cxtbl[17 ]); +_slot_set_tbl (btc,CXST_OFF , cxtbl[0 ]);break ;case BTC_CXP_OFF_EQ3 : -_slot_set_tbl (btc,CXST_OFF , cxtbl[18 ]); +_slot_set_tbl (btc,CXST_OFF , cxtbl[24 ]);break ;case BTC_CXP_OFF_BWB0 :_slot_set_tbl (btc,CXST_OFF , cxtbl[5 ]);
@@ -2765,6 +2771,7 @@ void rtw89_btc_set_policy_v1(struct rtw89_dev *rtwdev, u16 policy_type)default :break ; } + s[CXST_OFF ] = s_def[CXST_OFF ];break ;case BTC_CXP_FIX :/* TDMA Fix-Slot */ _write_scbd (rtwdev,BTC_WSCB_TDMA , true);
@@ -2791,6 +2798,10 @@ void rtw89_btc_set_policy_v1(struct rtw89_dev *rtwdev, u16 policy_type)_slot_set (btc,CXST_W1 ,40 , cxtbl[1 ],SLOT_ISO );_slot_set (btc,CXST_B1 ,10 , tbl_b1,SLOT_MIX );break ; +case BTC_CXP_FIX_TD4020 : +_slot_set (btc,CXST_W1 ,40 , cxtbl[1 ],SLOT_MIX ); +_slot_set (btc,CXST_B1 ,20 , tbl_b1,SLOT_MIX ); +break ;case BTC_CXP_FIX_TD7010 :_slot_set (btc,CXST_W1 ,70 , tbl_w1,SLOT_ISO );_slot_set (btc,CXST_B1 ,10 , tbl_b1,SLOT_MIX );
Signature · 1 line
2.25.1
Re: [PATCH 1/8] wifi: rtw89: coex: Update Wi-Fi external control TDMA parameters/tables
Quoted 8 lines · Ping-Ke Shih
From: Ching-Te Ku <[email protected]>
This patch update the external control (Wi-Fi firmware control) type of TDMA related parameters, almost all of these case were related to Wi-Fi multi-role situations & AP mode.
Signed-off-by Ching-Te Ku <[email protected]>Signed-off-by Ping-Ke Shih <[email protected]>
8 patches applied to wireless-next.git, thanks.
1742fbae7a49 wifi: rtw89: coex: Update Wi-Fi external control TDMA parameters/tables aae256c0f233 wifi: rtw89: coex: Clear Bluetooth HW PTA counter when radio state change 3f857b23dd8d wifi: rtw89: coex: Force to update TDMA parameter when radio state change 7cd8200555d4 wifi: rtw89: coex: Refine coexistence log6d2a479c1f9e wifi: rtw89: coex: Set Bluetooth background scan PTA request priority c7d2b22f52bd wifi: rtw89: coex: Correct A2DP exist variable source 4b3e7e813bba wifi: rtw89: coex: Fix test fail when coexist with raspberryPI A2DP idle de06588cb95c wifi: rtw89: coex: Update Wi-Fi Bluetooth coexistence version to 7.0.0
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Ping-Ke Shih
maintainerPATCH 2/8 wifi: rtw89: coex: Clear Bluetooth HW PTA counter when radio state change
In reply to Ping-Ke ShihFrom: Ching-Te Ku <[email protected]>
Reset the counter no matter Wi-Fi is notified turning into power save or not. With rest the counter coexistence will recognize Bluetooth is hanged easily.
--- drivers/net/wireless/realtek/rtw89/coex.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/realtek/rtw89/coex.c +2 -1
@@ -5335,7 +5335,6 @@ void rtw89_btc_ntfy_radio_state(struct rtw89_dev *rtwdev, enum btc_rfctrl rf_sta }if (rf_state ==BTC_RFCTRL_WL_ON ) { - btc->dm.cnt_dm[BTC_DCNT_BTCNT_FREEZE ] =0 ;rtw89_btc_fw_en_rpt (rtwdev,RPT_EN_MREG , true); val =BTC_WSCB_ACTIVE |BTC_WSCB_ON |BTC_WSCB_BTLOG ;_write_scbd (rtwdev, val, true);
@@ -5347,6 +5346,8 @@ void rtw89_btc_ntfy_radio_state(struct rtw89_dev *rtwdev, enum btc_rfctrl rf_sta_write_scbd (rtwdev,BTC_WSCB_ALL , false); } + btc->dm.cnt_dm[BTC_DCNT_BTCNT_FREEZE ] =0 ; +_run_coex (rtwdev,BTC_RSN_NTFY_RADIO_STATE ); wl->status.map.rf_off_pre = wl->status.map.rf_off;
Signature · 1 line
2.25.1
Ping-Ke Shih
maintainerPATCH 3/8 wifi: rtw89: coex: Force to update TDMA parameter when radio state change
In reply to Ping-Ke ShihFrom: Ching-Te Ku <[email protected]>
Force firmware to update TDMA parameter when enter/exit power saving. The TDMA instant feature will make firmware force update TDMA parameter immediately when the TDMA parameter H2C to firmware. Without this feature, it will have a low fail rate trigger Bluetooth audio sound glitch when Wi-Fi is under power saving. Or Wi-Fi fail to turn in to power save state.
--- drivers/net/wireless/realtek/rtw89/coex.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/net/wireless/realtek/rtw89/coex.c +6 -0
@@ -3818,6 +3818,7 @@ static void _action_common(struct rtw89_dev *rtwdev) wl->scbd_change = false; btc->cx.cnt_wl[BTC_WCNT_SCBDUPDATE ]++; } + btc->dm.tdma_instant_excute =0 ; }static void _action_by_bt (struct rtw89_dev *rtwdev)
@@ -5347,6 +5348,11 @@ void rtw89_btc_ntfy_radio_state(struct rtw89_dev *rtwdev, enum btc_rfctrl rf_sta } btc->dm.cnt_dm[BTC_DCNT_BTCNT_FREEZE ] =0 ; +if (wl->status.map.lps_pre ==BTC_LPS_OFF && + wl->status.map.lps_pre != wl->status.map.lps) + btc->dm.tdma_instant_excute =1 ; +else + btc->dm.tdma_instant_excute =0 ;_run_coex (rtwdev,BTC_RSN_NTFY_RADIO_STATE );
Signature · 1 line
2.25.1
Ping-Ke Shih
maintainerPATCH 4/8 wifi: rtw89: coex: Refine coexistence log
In reply to Ping-Ke ShihFrom: Ching-Te Ku <[email protected]>
Adjust the log format and correct variable reference to make the log more readable.
--- drivers/net/wireless/realtek/rtw89/coex.c | 158 +++++++++++----------- 1 file changed, 76 insertions(+), 82 deletions(-)
drivers/net/wireless/realtek/rtw89/coex.c +76 -82
@@ -6401,20 +6401,21 @@ static void _show_fbtc_slots(struct rtw89_dev *rtwdev, struct seq_file *m)for (i =0 ; i <CXST_MAX ; i++) { s = &dm->slot_now[i]; -if (i %6 ==0 ) +if (i %5 ==0 )seq_printf (m, -" %-15s : %02d[%03d/0x%x/%d]" , +" %-15s : %5s[%03d/0x%x/%d]" ,"[slot_list]" , - (u32 )i, +id_to_slot ((u32 )i), s->dur, s->cxtbl, s->cxtype);else seq_printf (m, -", %02d[%03d/0x%x/%d]" , - (u32 )i, +", %5s[%03d/0x%x/%d]" , +id_to_slot ((u32 )i), s->dur, s->cxtbl, s->cxtype); -if (i %6 ==5 ) +if (i %5 ==4 )seq_puts (m,"\n" ); } +seq_puts (m,"\n" ); }static void _show_fbtc_cysta_v2 (struct rtw89_dev *rtwdev,struct seq_file *m)
@@ -6446,7 +6447,7 @@ static void _show_fbtc_cysta_v2(struct rtw89_dev *rtwdev, struct seq_file *m)for (i =0 ; i <CXST_MAX ; i++) {if (!le32_to_cpu (pcysta_le32->slot_cnt[i]))continue ; -seq_printf (m,", %d:%d" , (u32 )i, +seq_printf (m,", %s:%d" ,id_to_slot ((u32 )i),le32_to_cpu (pcysta_le32->slot_cnt[i])); }
@@ -6481,7 +6482,7 @@ static void _show_fbtc_cysta_v2(struct rtw89_dev *rtwdev, struct seq_file *m)le16_to_cpu (pcysta_le32->tmaxdiff_cycle[CXT_WL ]), le16_to_cpu(pcysta_le32->tmaxdiff_cycle[CXT_BT])); -if (le16_to_cpu (pcysta_le32->cycles) ==0 ) +if (le16_to_cpu (pcysta_le32->cycles) <=1 )return ;/* 1 cycle record 1 wl-slot and 1 bt-slot */
@@ -6608,7 +6609,7 @@ static void _show_fbtc_cysta_v3(struct rtw89_dev *rtwdev, struct seq_file *m) le16_to_cpu(pcysta->cycle_time.tmaxdiff[CXT_BT])); cycle =le16_to_cpu (pcysta->cycles); -if (cycle ==0 ) +if (cycle <=1 )return ;/* 1 cycle record 1 wl-slot and 1 bt-slot */
@@ -6630,40 +6631,39 @@ static void _show_fbtc_cysta_v3(struct rtw89_dev *rtwdev, struct seq_file *m) cnt++; store_index = ((cycle -1 ) % slot_pair) *2 ; -if (cnt % divide_cnt ==1 ) { -seq_printf (m,"\n\r %-15s : " ,"[cycle_step]" ); - }else { -seq_printf (m,"->b%02d" , -le16_to_cpu (pcysta->slot_step_time[store_index])); -if (a2dp->exist) { - a2dp_trx = &pcysta->a2dp_trx[store_index]; -seq_printf (m,"(%d/%d/%dM/%d/%d/%d)" , - a2dp_trx->empty_cnt, - a2dp_trx->retry_cnt, - a2dp_trx->tx_rate ?3 :2 , - a2dp_trx->tx_cnt, - a2dp_trx->ack_cnt, - a2dp_trx->nack_cnt); - } -seq_printf (m,"->w%02d" , -le16_to_cpu (pcysta->slot_step_time[store_index +1 ])); -if (a2dp->exist) { - a2dp_trx = &pcysta->a2dp_trx[store_index +1 ]; -seq_printf (m,"(%d/%d/%dM/%d/%d/%d)" , - a2dp_trx->empty_cnt, - a2dp_trx->retry_cnt, - a2dp_trx->tx_rate ?3 :2 , - a2dp_trx->tx_cnt, - a2dp_trx->ack_cnt, - a2dp_trx->nack_cnt); - } +if (cnt % divide_cnt ==1 ) +seq_printf (m," %-15s : " ,"[cycle_step]" ); + +seq_printf (m,"->b%02d" , +le16_to_cpu (pcysta->slot_step_time[store_index])); +if (a2dp->exist) { + a2dp_trx = &pcysta->a2dp_trx[store_index]; +seq_printf (m,"(%d/%d/%dM/%d/%d/%d)" , + a2dp_trx->empty_cnt, + a2dp_trx->retry_cnt, + a2dp_trx->tx_rate ?3 :2 , + a2dp_trx->tx_cnt, + a2dp_trx->ack_cnt, + a2dp_trx->nack_cnt); } -if (cnt % (BTC_CYCLE_SLOT_MAX /4 ) ==0 || cnt == c_end) +seq_printf (m,"->w%02d" , +le16_to_cpu (pcysta->slot_step_time[store_index +1 ])); +if (a2dp->exist) { + a2dp_trx = &pcysta->a2dp_trx[store_index +1 ]; +seq_printf (m,"(%d/%d/%dM/%d/%d/%d)" , + a2dp_trx->empty_cnt, + a2dp_trx->retry_cnt, + a2dp_trx->tx_rate ?3 :2 , + a2dp_trx->tx_cnt, + a2dp_trx->ack_cnt, + a2dp_trx->nack_cnt); + } +if (cnt % divide_cnt ==0 || cnt == c_end)seq_puts (m,"\n" ); }if (a2dp->exist) { -seq_printf (m,"%-15s : a2dp_ept:%d, a2dp_late:%d" , +seq_printf (m," %-15s : a2dp_ept:%d, a2dp_late:%d" ,"[a2dp_t_sta]" ,le16_to_cpu (pcysta->a2dp_ept.cnt),le16_to_cpu (pcysta->a2dp_ept.cnt_timeout));
@@ -6741,7 +6741,7 @@ static void _show_fbtc_cysta_v4(struct rtw89_dev *rtwdev, struct seq_file *m) le16_to_cpu(pcysta->cycle_time.tmaxdiff[CXT_BT])); cycle =le16_to_cpu (pcysta->cycles); -if (cycle ==0 ) +if (cycle <=1 )return ;/* 1 cycle record 1 wl-slot and 1 bt-slot */
@@ -6763,40 +6763,39 @@ static void _show_fbtc_cysta_v4(struct rtw89_dev *rtwdev, struct seq_file *m) cnt++; store_index = ((cycle -1 ) % slot_pair) *2 ; -if (cnt % divide_cnt ==1 ) { -seq_printf (m,"\n\r %-15s : " ,"[cycle_step]" ); - }else { -seq_printf (m,"->b%02d" , -le16_to_cpu (pcysta->slot_step_time[store_index])); -if (a2dp->exist) { - a2dp_trx = &pcysta->a2dp_trx[store_index]; -seq_printf (m,"(%d/%d/%dM/%d/%d/%d)" , - a2dp_trx->empty_cnt, - a2dp_trx->retry_cnt, - a2dp_trx->tx_rate ?3 :2 , - a2dp_trx->tx_cnt, - a2dp_trx->ack_cnt, - a2dp_trx->nack_cnt); - } -seq_printf (m,"->w%02d" , -le16_to_cpu (pcysta->slot_step_time[store_index +1 ])); -if (a2dp->exist) { - a2dp_trx = &pcysta->a2dp_trx[store_index +1 ]; -seq_printf (m,"(%d/%d/%dM/%d/%d/%d)" , - a2dp_trx->empty_cnt, - a2dp_trx->retry_cnt, - a2dp_trx->tx_rate ?3 :2 , - a2dp_trx->tx_cnt, - a2dp_trx->ack_cnt, - a2dp_trx->nack_cnt); - } +if (cnt % divide_cnt ==1 ) +seq_printf (m," %-15s : " ,"[cycle_step]" ); + +seq_printf (m,"->b%02d" , +le16_to_cpu (pcysta->slot_step_time[store_index])); +if (a2dp->exist) { + a2dp_trx = &pcysta->a2dp_trx[store_index]; +seq_printf (m,"(%d/%d/%dM/%d/%d/%d)" , + a2dp_trx->empty_cnt, + a2dp_trx->retry_cnt, + a2dp_trx->tx_rate ?3 :2 , + a2dp_trx->tx_cnt, + a2dp_trx->ack_cnt, + a2dp_trx->nack_cnt); } -if (cnt % (BTC_CYCLE_SLOT_MAX /4 ) ==0 || cnt == c_end) +seq_printf (m,"->w%02d" , +le16_to_cpu (pcysta->slot_step_time[store_index +1 ])); +if (a2dp->exist) { + a2dp_trx = &pcysta->a2dp_trx[store_index +1 ]; +seq_printf (m,"(%d/%d/%dM/%d/%d/%d)" , + a2dp_trx->empty_cnt, + a2dp_trx->retry_cnt, + a2dp_trx->tx_rate ?3 :2 , + a2dp_trx->tx_cnt, + a2dp_trx->ack_cnt, + a2dp_trx->nack_cnt); + } +if (cnt % divide_cnt ==0 || cnt == c_end)seq_puts (m,"\n" ); }if (a2dp->exist) { -seq_printf (m,"%-15s : a2dp_ept:%d, a2dp_late:%d" , +seq_printf (m," %-15s : a2dp_ept:%d, a2dp_late:%d" ,"[a2dp_t_sta]" ,le16_to_cpu (pcysta->a2dp_ept.cnt),le16_to_cpu (pcysta->a2dp_ept.cnt_timeout));
@@ -6827,13 +6826,9 @@ static void _show_fbtc_nullsta(struct rtw89_dev *rtwdev, struct seq_file *m) ns = &pfwinfo->rpt_fbtc_nullsta.finfo;if (ver->fcxnullsta ==1 ) { -seq_printf (m," %-15s : " ,"[null_sta]" ); -for (i =0 ; i <2 ; i++) { -if (i !=0 ) -seq_printf (m,", null-%d" , i); -else -seq_printf (m,"null-%d" , i); +seq_printf (m," %-15s : " ,"[NULL-STA]" ); +seq_printf (m,"null-%d" , i);seq_printf (m,"[ok:%d/" ,le32_to_cpu (ns->v1.result[i][1 ])); seq_printf(m, "fail:%d/",
@@ -6845,17 +6840,14 @@ static void _show_fbtc_nullsta(struct rtw89_dev *rtwdev, struct seq_file *m)seq_printf (m,"avg_t:%d.%03d/" ,le32_to_cpu (ns->v1.avg_t[i]) /1000 ,le32_to_cpu (ns->v1.avg_t[i]) %1000 ); -seq_printf (m,"max_t:%d.%03d]" , +seq_printf (m,"max_t:%d.%03d]\n" ,le32_to_cpu (ns->v1.max_t[i]) /1000 ,le32_to_cpu (ns->v1.max_t[i]) %1000 ); } }else { -seq_printf (m," %-15s : " ,"[null_sta]" );for (i =0 ; i <2 ; i++) { -if (i !=0 ) -seq_printf (m,", null-%d" , i); -else -seq_printf (m,"null-%d" , i); +seq_printf (m," %-15s : " ,"[NULL-STA]" ); +seq_printf (m,"null-%d" , i);seq_printf (m,"[Tx:%d/" ,le32_to_cpu (ns->v2.result[i][4 ])); seq_printf(m, "[ok:%d/",
@@ -6869,12 +6861,11 @@ static void _show_fbtc_nullsta(struct rtw89_dev *rtwdev, struct seq_file *m)seq_printf (m,"avg_t:%d.%03d/" ,le32_to_cpu (ns->v2.avg_t[i]) /1000 ,le32_to_cpu (ns->v2.avg_t[i]) %1000 ); -seq_printf (m,"max_t:%d.%03d]" , +seq_printf (m,"max_t:%d.%03d]\n" ,le32_to_cpu (ns->v2.max_t[i]) /1000 ,le32_to_cpu (ns->v2.max_t[i]) %1000 ); } } -seq_puts (m,"\n" ); }static void _show_fbtc_step_v2 (struct rtw89_dev *rtwdev,struct seq_file *m)
@@ -7147,6 +7138,9 @@ static void _show_mreg(struct rtw89_dev *rtwdev, struct seq_file *m)if (cnt %6 ==5 )seq_puts (m,"\n" ); cnt++; + +if (i >= pmreg->reg_num) +seq_puts (m,"\n" ); } pcinfo = &pfwinfo->rpt_fbtc_gpio_dbg.cinfo;
Signature · 1 line
2.25.1
Ping-Ke Shih
maintainerPATCH 5/8 wifi: rtw89: coex: Set Bluetooth background scan PTA request priority
In reply to Ping-Ke ShihFrom: Ching-Te Ku <[email protected]>
When Wi-Fi is RX, set Bluetooth background scan to low-priority and not to break Wi-Fi packet. Bluetooth can RX depend on hardware ability even RX request has been rejected. This way can improve Wi-Fi RX throughput performance.
--- drivers/net/wireless/realtek/rtw89/coex.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/wireless/realtek/rtw89/coex.c +2 -0
@@ -4763,6 +4763,8 @@ void _run_coex(struct rtw89_dev *rtwdev, enum btc_reason_and_action reason)_action_wl_nc (rtwdev);break ;case BTC_WLINK_2G_STA : +if (wl->status.map.traffic_dir &BIT (RTW89_TFC_DL )) + bt->scan_rx_low_pri = true;_action_wl_2g_sta (rtwdev);break ;case BTC_WLINK_2G_AP :
Signature · 1 line
2.25.1
Ping-Ke Shih
maintainerPATCH 6/8 wifi: rtw89: coex: Correct A2DP exist variable source
In reply to Ping-Ke ShihFrom: Ching-Te Ku <[email protected]>
When Wi-Fi enter and leave LPS, coexistence driver need to know is there A2DP exist or not. And when Wi-Fi sleep in deep power save state will not able to receive mailbox sent from Bluetooth. So update the A2DP exist information from reading register.
--- drivers/net/wireless/realtek/rtw89/coex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtw89/coex.c +1 -1
@@ -4602,7 +4602,7 @@ static void _update_bt_scbd(struct rtw89_dev *rtwdev, bool only_update) bt->whql_test = !!(val &BTC_BSCB_WHQL ); bt->btg_type = val &BTC_BSCB_BT_S1 ?BTC_BT_BTG :BTC_BT_ALONE ; - bt->link_info.a2dp_desc.active = !!(val &BTC_BSCB_A2DP_ACT ); + bt->link_info.a2dp_desc.exist = !!(val &BTC_BSCB_A2DP_ACT );/* if rfk run 1->0 */ if (bt->rfk_info.map.run && !(val &BTC_BSCB_RFK_RUN ))
Signature · 1 line
2.25.1
Ping-Ke Shih
maintainerPATCH 7/8 wifi: rtw89: coex: Fix test fail when coexist with raspberryPI A2DP idle
In reply to Ping-Ke ShihFrom: Ching-Te Ku <[email protected]>
The origin code will enable TDMA WL:BT = 50:50 to prevent Wi-Fi throughput suddenly drop to 0 in the moment while A2DP pause. And this protection just a short moment, and will turn to Bluetooth idle case when A2DP turn into sniff mode. But the raspberryPI simulated A2DP device will not turn into sniff mode. So the protection will bring the throughput drop.
--- drivers/net/wireless/realtek/rtw89/coex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtw89/coex.c +1 -1
@@ -3847,7 +3847,7 @@ static void _action_by_bt(struct rtw89_dev *rtwdev)case BTC_BT_NOPROFILE :if (_check_freerun (rtwdev))_action_freerun (rtwdev); -else if (a2dp.active || pan.active) +else if (pan.active)_action_bt_pan (rtwdev);else _action_bt_idle (rtwdev);
Signature · 1 line
2.25.1
Ping-Ke Shih
maintainerPATCH 8/8 wifi: rtw89: coex: Update Wi-Fi Bluetooth coexistence version to 7.0.0
In reply to Ping-Ke ShihFrom: Ching-Te Ku <[email protected]>
Should update the driver with the supported firmware version of the below item.
Bluetooth firmware BT_Coex_Ver: 0x07
Wi-Fi firmware version: RTL8852C->v0.27.56.10, RTL8852A->v0.24.36
--- drivers/net/wireless/realtek/rtw89/coex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtw89/coex.c +1 -1
@@ -9,7 +9,7 @@#include "ps.h" #include "reg.h" -#define RTW89_COEX_VERSION 0x06030013 +#define RTW89_COEX_VERSION 0x07000013#define FCXDEF_STEP 50/* MUST <= FCXMAX_STEP and match with wl fw*/ enum btc_fbtc_tdma_template {
Signature · 1 line
2.25.1