Skip to contentSkip to conversation

Input: ipaq-micro-ts - fix DEFINE_SIMPLE_DEV_PM_OPS typo

PATCH Applied Arnd Bergmann 3 participants 3 messages Jan 17, 2023 – Jan 27, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: ipaq-micro-ts - fix DEFINE_SIMPLE_DEV_PM_OPS typo

From: Arnd Bergmann <[email protected]>

The previous change was not properly build tested and needs a trivial spelling change:

ipaq-micro-ts.c:146:8: error: type defaults to 'int' in declaration of 'DEFINE_SIMPLE_DEV_PM' [-Werror=implicit-int]

Fixes 144ff5e03d74 ("Input: ipaq-micro-ts - use DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()")
---
 drivers/input/touchscreen/ipaq-micro-ts.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/input/touchscreen/ipaq-micro-ts.c +2 -2
index d8e25b502968..94720c41c9be 100644
@@ -143,8 +143,8 @@ static int micro_ts_resume(struct device *dev)
 	return 0;
 }
 
-static DEFINE_SIMPLE_DEV_PM(micro_ts_dev_pm_ops,
-			    micro_ts_suspend, micro_ts_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(micro_ts_dev_pm_ops,
+				micro_ts_suspend, micro_ts_resume);
 
 static struct platform_driver micro_ts_device_driver = {
 	.driver	= {
Signature · 1 line
2.39.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Tue, 17 Jan 2023 17:45:33 +0100 Arnd Bergmann <[email protected]> wrote:

From: Arnd Bergmann <[email protected]>

The previous change was not properly build tested and needs a trivial spelling change:

ipaq-micro-ts.c:146:8: error: type defaults to 'int' in declaration of 'DEFINE_SIMPLE_DEV_PM' [-Werror=implicit-int]

Fixes 144ff5e03d74 ("Input: ipaq-micro-ts - use DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()")

Hi Arnd,

I clearly messed up my build tests - will look into how that went wrong. From an initial look, this looks like a driver that could benefit from a || COMPILE_TEST addition to the Kconfig depenencies. Nothing looks to be build time dependent on the related MFD.

Thanks for fixing it up.

Quoted 19 lines
---
 drivers/input/touchscreen/ipaq-micro-ts.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/input/touchscreen/ipaq-micro-ts.c +2 -2
index d8e25b502968..94720c41c9be 100644
@@ -143,8 +143,8 @@ static int micro_ts_resume(struct device *dev)
 	return 0;
 }
 
-static DEFINE_SIMPLE_DEV_PM(micro_ts_dev_pm_ops,
-			    micro_ts_suspend, micro_ts_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(micro_ts_dev_pm_ops,
+				micro_ts_suspend, micro_ts_resume);
 
 static struct platform_driver micro_ts_device_driver = {
 	.driver	= {
maintainer Applied
#2 lore raw
In reply to Arnd Bergmann
Quoted 9 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The previous change was not properly build tested and needs a trivial spelling change:

ipaq-micro-ts.c:146:8: error: type defaults to 'int' in declaration of 'DEFINE_SIMPLE_DEV_PM' [-Werror=implicit-int]

Fixes 144ff5e03d74 ("Input: ipaq-micro-ts - use DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()")

Applied, thank you.

Signature · 1 line
Dmitry