drm/amd/display: fix dp_retrieve_lttpr_cap return code
Subsystems (3)
PATCH v2 1/1 drm/amd/display: fix dp_retrieve_lttpr_cap return code
From: Arnd Bergmann <[email protected]>
The dp_retrieve_lttpr_cap() return type changed from 'bool' to 'enum dc_status', so now the early 'return' uses the wrong type:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c: In function 'dp_retrieve_lttpr_cap':drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:5075:24: error: implicit conversion from 'enum <anonymous>' to 'enum dc_status' [-Werror=enum-conversion]
5075 | return false;
| ^~~~~
Convert it to return 'DC_ERROR_UNEXPECTED', which was apparently set as a default return code here but never used.
---
v2 changes:
- use DC_ERROR_UNEXPECTED instead of DC_OK
- remove bogus initializers
--- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +3 -3
@@ -5088,14 +5088,14 @@ static bool dpcd_read_sink_ext_caps(struct dc_link *link)enum dc_status dp_retrieve_lttpr_cap (struct dc_link *link) {uint8_t lttpr_dpcd_data[8 ]; -enum dc_status status =DC_ERROR_UNEXPECTED ; -bool is_lttpr_present = false; +enum dc_status status; +bool is_lttpr_present;/* Logic to determine LTTPR support*/ bool vbios_lttpr_interop = link->dc->caps.vbios_lttpr_aware;if (!vbios_lttpr_interop || !link->dc->caps.extended_aux_timeout_support) -return false; +return DC_ERROR_UNEXPECTED ;/* By reading LTTPR capability, RX assumes that we will enable * LTTPR extended aux timeout if LTTPR is present.
Signature · 1 line
2.39.0