atm: lanai: Use dma_zalloc_coherent()
Subsystems (3)
PATCH 1/1 atm: lanai: Use dma_zalloc_coherent()
From: ye xingchen <[email protected]>
Instead of using dma_alloc_coherent() and memset() directly use dma_zalloc_coherent().
--- drivers/atm/lanai.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/atm/lanai.c +2 -3
@@ -342,8 +342,8 @@ static void lanai_buf_allocate(struct lanai_buffer *buf,* everything, but the way the lanai uses DMA memory would * make that a terrific pain. This is much simpler. */ - buf->start =dma_alloc_coherent (&pci->dev, - size, &buf->dmaaddr,GFP_KERNEL ); + buf->start =dma_zalloc_coherent (&pci->dev, + size, &buf->dmaaddr,GFP_KERNEL );if (buf->start !=NULL ) {/* Success */ /* Lanai requires 256-byte alignment of DMA bufs */ APRINTK((buf->dmaaddr & ~0xFFFFFF00) == 0,
@@ -352,7 +352,6 @@ static void lanai_buf_allocate(struct lanai_buffer *buf, buf->ptr = buf->start; buf->end = (u32 *) (&((unsigned char *) buf->start)[size]); -memset (buf->start,0 , size);break ; } size /=2 ;
Signature · 1 line
2.25.1
From: [email protected]
Quoted 4 lines
Sent: 17 January 2023 09:21
Instead of using
dma_alloc_coherent()andmemset()directly usedma_zalloc_coherent().
I'm sure I've a brain cell that remembers that dma_alloc_coherent() always zeros the buffer.
So the 'zalloc' variant isn't needed and the memset() can just be deleted.
OTOH is it really worth the churn.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
Le 17/01/2023 à 16:37, David Laight a écrit :
Quoted 11 lines
From: [email protected]
Quoted 4 lines
Sent: 17 January 2023 09:21
Instead of using
dma_alloc_coherent()andmemset()directly usedma_zalloc_coherent().I'm sure I've a brain cell that remembers that
dma_alloc_coherent()always zeros the buffer.
So the 'zalloc' variant isn't needed and thememset()can just be deleted.
OTOH is it really worth the churn.
More-over, dma_zalloc_coherent() has been removed at the very beginning of 2019 in commit dfd32cad146e.
It is not existing since v5.0-rc2.
\o/
CJ
Quoted 6 lines
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)