Skip to contentSkip to conversation

drm/amdgpu: update wave data type to 3 for gfx11

PATCH In review Graham Sider 2 participants 2 messages Jan 17, 2023 – Jan 25, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: update wave data type to 3 for gfx11

SQ_WAVE_INST_DW0 isn't present on gfx11 compared to gfx10, so update wave data type to signify a difference.

---
 drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c +2 -2
index f98c67d07a9b..f821309f48c9 100644
@@ -754,8 +754,8 @@ static void gfx_v11_0_read_wave_data(struct amdgpu_device *adev, uint32_t simd,
 	 * zero here */
 	WARN_ON(simd != 0);
 
-	/* type 2 wave data */
-	dst[(*no_fields)++] = 2;
+	/* type 3 wave data */
+	dst[(*no_fields)++] = 3;
 	dst[(*no_fields)++] = wave_read_ind(adev, wave, ixSQ_WAVE_STATUS);
 	dst[(*no_fields)++] = wave_read_ind(adev, wave, ixSQ_WAVE_PC_LO);
 	dst[(*no_fields)++] = wave_read_ind(adev, wave, ixSQ_WAVE_PC_HI);
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw

[AMD Official Use Only - General]

Quoted 40 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Graham Sider
Sent: Tuesday, January 17, 2023 2:42 PM
To: [email protected]
Cc: Sider, Graham <[email protected]>
Subject: [PATCH] drm/amdgpu: update wave data type to 3 for gfx11

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

SQ_WAVE_INST_DW0 isn't present on gfx11 compared to gfx10, so update wave data type to signify a difference.

---
 drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c +2 -2
index f98c67d07a9b..f821309f48c9 100644
@@ -754,8 +754,8 @@ static void gfx_v11_0_read_wave_data(struct
 amdgpu_device *adev, uint32_t simd,
         * zero here */
        WARN_ON(simd != 0);
 
-       /* type 2 wave data */
-       dst[(*no_fields)++] = 2;
+       /* type 3 wave data */
+       dst[(*no_fields)++] = 3;
        dst[(*no_fields)++] = wave_read_ind(adev, wave,
 ixSQ_WAVE_STATUS);
        dst[(*no_fields)++] = wave_read_ind(adev, wave, ixSQ_WAVE_PC_LO);
        dst[(*no_fields)++] = wave_read_ind(adev, wave, ixSQ_WAVE_PC_HI);

--
2.25.1