Skip to contentSkip to conversation

Allow error capture without a request / on reset failure

PATCH Superseded [email protected] 4 participants 18 messages Jan 17, 2023 – Jan 18, 2023

Subsystems (2)

v2 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v2 cover Allow error capture without a request / on reset failure

From: John Harrison <[email protected]>

It is technically possible to get a hung context without a valid request. In such a situation, try to provide as much information in the error capture as possible rather than just aborting and capturing nothing.

Similarly, in the case of an engine reset failure the GuC is not able to report the guilty context. So try a manual search instead of reporting nothing.

v2: Tidy up code flow in error capture. Reword some comments/messages. (review feedback from Tvrtko)
Also fix up request locking issues from earlier changes noticed during code review of this change.

John Harrison (5):
drm/i915: Fix request locking during error capture & debugfs dump drm/i915: Allow error capture without a request drm/i915: Allow error capture of a pending request drm/i915/guc: Look for a guilty context when an engine reset fails drm/i915/guc: Add a debug print on GuC triggered reset

 drivers/gpu/drm/i915/gt/intel_context.c       |  1 +
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  7 +-
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 32 ++++++++-
 drivers/gpu/drm/i915/i915_gpu_error.c         | 71 ++++++++++++-------
 4 files changed, 82 insertions(+), 29 deletions(-)
Signature · 1 line
2.39.0
#1 lore raw

PATCH v2 1/5 drm/i915: Fix request locking during error capture & debugfs dump

From: John Harrison <[email protected]>

When GuC support was added to error capture, the locking around the request object was broken. Fix it up.

The context based search manages the spinlocking around the search internally. So it needs to grab the reference count internally as well. The execlist only request based search relies on external locking, so it needs an external reference count. So no change to that code itself but the context version does change.

The only other caller is the code for dumping engine state to debugfs. That code wasn't previously getting an explicit reference at all as it does everything while holding the execlist specific spinlock. So that needs updaing as well as that spinlock doesn't help when using GuC submission. Rather than trying to conditionally get/put depending on submission model, just change it to always do the get/put.

In addition, intel_guc_find_hung_context() was not acquiring the correct spinlock before searching the request list. So fix that up too.

Fixes dc0dad365c5e ("drm/i915/guc: Fix for error capture after full GPU reset

with GuC")

Fixes 573ba126aef3 ("drm/i915/guc: Capture error state on context reset")
Cc Matthew Brost <[email protected]>
Cc John Harrison <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Tvrtko Ursulin <[email protected]>
Cc Daniele Ceraolo Spurio <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Matthew Auld <[email protected]>
Cc Matt Roper <[email protected]>
Cc Umesh Nerlige Ramappa <[email protected]>
Cc Michael Cheng <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Tejas Upadhyay <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Aravind Iddamsetty <[email protected]>
Cc Alan Previn <[email protected]>
Cc Bruce Chang <[email protected]>
---
 drivers/gpu/drm/i915/gt/intel_context.c           |  1 +
 drivers/gpu/drm/i915/gt/intel_engine_cs.c         |  7 ++++++-
 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 11 +++++++++++
 drivers/gpu/drm/i915/i915_gpu_error.c             |  5 ++---
 4 files changed, 20 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gt/intel_context.c +1 -0
index e94365b08f1ef..df64cf1954c1d 100644
@@ -552,6 +552,7 @@ struct i915_request *intel_context_find_active_request(struct intel_context *ce)
 
 		active = rq;
 	}
+	active = i915_request_get_rcu(active);
 	spin_unlock_irqrestore(&parent->guc_state.lock, flags);
 
 	return active;
drivers/gpu/drm/i915/gt/intel_engine_cs.c +6 -1
index 922f1bb22dc68..517d1fb7ae333 100644
@@ -2236,10 +2236,13 @@ static void engine_dump_active_requests(struct intel_engine_cs *engine, struct d
 	guc = intel_uc_uses_guc_submission(&engine->gt->uc);
 	if (guc) {
 		ce = intel_engine_get_hung_context(engine);
-		if (ce)
+		if (ce) {
+			/* This will reference count the request (if found) */
 			hung_rq = intel_context_find_active_request(ce);
+		}
 	} else {
 		hung_rq = intel_engine_execlist_find_hung_request(engine);
+		hung_rq = i915_request_get_rcu(hung_rq);
 	}
 
 	if (hung_rq)
@@ -2250,6 +2253,8 @@ static void engine_dump_active_requests(struct intel_engine_cs *engine, struct d
 	else
 		intel_engine_dump_active_requests(&engine->sched_engine->requests,
 						  hung_rq, m);
+	if (hung_rq)
+		i915_request_put(hung_rq);
 }
 
 void intel_engine_dump(struct intel_engine_cs *engine,
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +11 -0
index b436dd7f12e42..3b34a82d692be 100644
@@ -4820,6 +4820,8 @@ void intel_guc_find_hung_context(struct intel_engine_cs *engine)
 
 	xa_lock_irqsave(&guc->context_lookup, flags);
 	xa_for_each(&guc->context_lookup, index, ce) {
+		bool found;
+
 		if (!kref_get_unless_zero(&ce->ref))
 			continue;
 
@@ -4836,10 +4838,18 @@ void intel_guc_find_hung_context(struct intel_engine_cs *engine)
 				goto next;
 		}
 
+		found = false;
+		spin_lock(&ce->guc_state.lock);
 		list_for_each_entry(rq, &ce->guc_state.requests, sched.link) {
 			if (i915_test_request_state(rq) != I915_REQUEST_ACTIVE)
 				continue;
 
+			found = true;
+			break;
+		}
+		spin_unlock(&ce->guc_state.lock);
+
+		if (found) {
 			intel_engine_set_hung_context(engine, ce);
 
 			/* Can only cope with one hang at a time... */
@@ -4847,6 +4857,7 @@ void intel_guc_find_hung_context(struct intel_engine_cs *engine)
 			xa_lock(&guc->context_lookup);
 			goto done;
 		}
+
 next:
 		intel_context_put(ce);
 		xa_lock(&guc->context_lookup);
drivers/gpu/drm/i915/i915_gpu_error.c +2 -3
index 9d5d5a397b64e..4107a0dfcca7d 100644
@@ -1607,6 +1607,7 @@ capture_engine(struct intel_engine_cs *engine,
 	ce = intel_engine_get_hung_context(engine);
 	if (ce) {
 		intel_engine_clear_hung_context(engine);
+		/* This will reference count the request (if found) */
 		rq = intel_context_find_active_request(ce);
 		if (!rq || !i915_request_started(rq))
 			goto no_request_capture;
@@ -1618,13 +1619,11 @@ capture_engine(struct intel_engine_cs *engine,
 		if (!intel_uc_uses_guc_submission(&engine->gt->uc)) {
 			spin_lock_irqsave(&engine->sched_engine->lock, flags);
 			rq = intel_engine_execlist_find_hung_request(engine);
+			rq = i915_request_get_rcu(rq);
 			spin_unlock_irqrestore(&engine->sched_engine->lock,
 					       flags);
 		}
 	}
-	if (rq)
-		rq = i915_request_get_rcu(rq);
-
 	if (!rq)
 		goto no_request_capture;
 
Signature · 1 line
2.39.0
#2 lore raw

Re: [PATCH v2 1/5] drm/i915: Fix request locking during error capture & debugfs dump

Quoted 18 lines · On Tue, Jan 17, 2023 at 01:36:26PM -0800, [email protected] wrote:

From: John Harrison <[email protected]>

When GuC support was added to error capture, the locking around the request object was broken. Fix it up.

The context based search manages the spinlocking around the search internally. So it needs to grab the reference count internally as well. The execlist only request based search relies on external locking, so it needs an external reference count. So no change to that code itself but the context version does change.

The only other caller is the code for dumping engine state to debugfs. That code wasn't previously getting an explicit reference at all as it does everything while holding the execlist specific spinlock. So that needs updaing as well as that spinlock doesn't help when using GuC submission. Rather than trying to conditionally get/put depending on submission model, just change it to always do the get/put.

Quoted 5 lines

In addition, intel_guc_find_hung_context() was not acquiring the correct spinlock before searching the request list. So fix that up too.

Fixes dc0dad365c5e ("drm/i915/guc: Fix for error capture after full GPU reset

with GuC")

Must be one line.

Quoted 14 lines
Fixes 573ba126aef3 ("drm/i915/guc: Capture error state on context reset")
Cc Matthew Brost <[email protected]>
Cc John Harrison <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Tvrtko Ursulin <[email protected]>
Cc Daniele Ceraolo Spurio <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Matthew Auld <[email protected]>
Cc Matt Roper <[email protected]>
Cc Umesh Nerlige Ramappa <[email protected]>
Quoted 8 lines
Cc Michael Cheng <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Tejas Upadhyay <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Aravind Iddamsetty <[email protected]>
Cc Alan Previn <[email protected]>
Cc Bruce Chang <[email protected]>

Is it possible to utilize --to --cc parameters to git send-email instead of noisy Cc list?

...

drivers/gpu/drm/i915/gt/intel_engine_cs.c static void engine_dump_active_requests(struct intel_engine_cs *engine, struct d · line 2257

Quoted 2 lines
drivers/gpu/drm/i915/gt/intel_engine_cs.c +2 -0
+	if (hung_rq)
+		i915_request_put(hung_rq);

In Linux kernel the idiom is that freeing resources APIs should be NULL-aware (or ERR_PTR aware or both). Does i915 follows that? If so, the test should be inside i915_request_put() rather than in any of the callers.

...

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c void intel_guc_find_hung_context(struct intel_engine_cs *engine) · line 4863

Quoted 8 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 -0
@@ -4847,6 +4857,7 @@ void intel_guc_find_hung_context(struct intel_engine_cs *engine)
 			xa_lock(&guc->context_lookup);
 			goto done;
 		}
+
 next:
 		intel_context_put(ce);
 		xa_lock(&guc->context_lookup);

Stray change.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw

Re: [PATCH v2 1/5] drm/i915: Fix request locking during error capture & debugfs dump

Quoted 19 lines · Andy Shevchenko
Quoted 18 lines · On Tue, Jan 17, 2023 at 01:36:26PM -0800, [email protected] wrote:

From: John Harrison <[email protected]>

When GuC support was added to error capture, the locking around the request object was broken. Fix it up.

The context based search manages the spinlocking around the search internally. So it needs to grab the reference count internally as well. The execlist only request based search relies on external locking, so it needs an external reference count. So no change to that code itself but the context version does change.

The only other caller is the code for dumping engine state to debugfs. That code wasn't previously getting an explicit reference at all as it does everything while holding the execlist specific spinlock. So that needs updaing as well as that spinlock doesn't help when using GuC submission. Rather than trying to conditionally get/put depending on submission model, just change it to always do the get/put.

Quoted 5 lines
Quoted 4 lines

In addition, intel_guc_find_hung_context() was not acquiring the correct spinlock before searching the request list. So fix that up too.

Fixes dc0dad365c5e ("drm/i915/guc: Fix for error capture after full GPU reset

with GuC")

Must be one line.

In my tree it is one line. git itself does the line wrap when creating the email. I missed that I need to manually unwrap it again before actually sending the email. Although the CI checkpatch also pointed this out in it's own obscure manner.

Quoted 22 lines
Quoted 14 lines
Fixes 573ba126aef3 ("drm/i915/guc: Capture error state on context reset")
Cc Matthew Brost <[email protected]>
Cc John Harrison <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Tvrtko Ursulin <[email protected]>
Cc Daniele Ceraolo Spurio <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Matthew Auld <[email protected]>
Cc Matt Roper <[email protected]>
Cc Umesh Nerlige Ramappa <[email protected]>
Quoted 8 lines
Cc Michael Cheng <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Tejas Upadhyay <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Aravind Iddamsetty <[email protected]>
Cc Alan Previn <[email protected]>
Cc Bruce Chang <[email protected]>
Quoted 2 lines

Is it possible to utilize --to --cc parameters to git send-email instead of noisy Cc list?

This is the list auto-generated by the 'dim fixes' tool. I am told this is the officially correct way to create a fixes patch - copy the output from 'dim fixes' as is into the patch headers.

Quoted 7 lines

...

drivers/gpu/drm/i915/gt/intel_engine_cs.c static void engine_dump_active_requests(struct intel_engine_cs *engine, struct d · line 2257

Quoted 2 lines
drivers/gpu/drm/i915/gt/intel_engine_cs.c +2 -0
+	if (hung_rq)
+		i915_request_put(hung_rq);

In Linux kernel the idiom is that freeing resources APIs should be NULL-aware (or ERR_PTR aware or both). Does i915 follows that? If so, the test should be inside i915_request_put() rather than in any of the callers.

That's as maybe. But this is how i915_request_put() currently works - it is simply a wrapper around 'dma_fence_put(&rq->fence);'. So passing in a null pointer will immediately cause a null pointer deref. If you want the put implementation to change and to re-work all its callers, that should be done in a separate patch and not piled on top of other changes.

Quoted 12 lines

...

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c void intel_guc_find_hung_context(struct intel_engine_cs *engine) · line 4863

Quoted 8 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 -0
@@ -4847,6 +4857,7 @@ void intel_guc_find_hung_context(struct intel_engine_cs *engine)
  			xa_lock(&guc->context_lookup);
  			goto done;
  		}
+
  next:
  		intel_context_put(ce);
  		xa_lock(&guc->context_lookup);

Stray change.

Intentional change to improve the readability of a function that is being modified by other changes in this patch.

John.

Quoted 1 line
#4 lore raw

Re: [PATCH v2 1/5] drm/i915: Fix request locking during error capture & debugfs dump

Quoted 20 lines · John Harrison
Quoted 19 lines · Andy Shevchenko
Quoted 18 lines · On Tue, Jan 17, 2023 at 01:36:26PM -0800, [email protected] wrote:

From: John Harrison <[email protected]>

When GuC support was added to error capture, the locking around the request object was broken. Fix it up.

The context based search manages the spinlocking around the search internally. So it needs to grab the reference count internally as well. The execlist only request based search relies on external locking, so it needs an external reference count. So no change to that code itself but the context version does change.

The only other caller is the code for dumping engine state to debugfs. That code wasn't previously getting an explicit reference at all as it does everything while holding the execlist specific spinlock. So that needs updaing as well as that spinlock doesn't help when using GuC submission. Rather than trying to conditionally get/put depending on submission model, just change it to always do the get/put.

Quoted 7 lines
Quoted 5 lines
Quoted 4 lines

In addition, intel_guc_find_hung_context() was not acquiring the correct spinlock before searching the request list. So fix that up too.

Fixes dc0dad365c5e ("drm/i915/guc: Fix for error capture after full GPU reset

with GuC")

Must be one line.

In my tree it is one line. git itself does the line wrap when creating the email.

Can you elaborate? I never have had such issue with git send-email (starting from v1.6.x of Git for sure).

Quoted 3 lines

I missed that I need to manually unwrap it again before actually sending the email. Although the CI checkpatch also pointed this out in it's own obscure manner.

...

Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
Cc Matthew Brost <[email protected]>
Cc John Harrison <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Tvrtko Ursulin <[email protected]>
Cc Daniele Ceraolo Spurio <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Matthew Auld <[email protected]>
Cc Matt Roper <[email protected]>
Cc Umesh Nerlige Ramappa <[email protected]>
Cc Michael Cheng <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Tejas Upadhyay <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Aravind Iddamsetty <[email protected]>
Cc Alan Previn <[email protected]>
Cc Bruce Chang <[email protected]>
Quoted 5 lines
Quoted 2 lines

Is it possible to utilize --to --cc parameters to git send-email instead of noisy Cc list?

This is the list auto-generated by the 'dim fixes' tool. I am told this is the officially correct way to create a fixes patch - copy the output from 'dim fixes' as is into the patch headers.

Okay, so it may be question to the dim tool then...

...

Quoted 3 lines
Quoted 1 line

Stray change.

Intentional change to improve the readability of a function that is being modified by other changes in this patch.

But not described in the commit message. That's why "stray".

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw

Re: [PATCH v2 1/5] drm/i915: Fix request locking during error capture & debugfs dump

Quoted 25 lines · Andy Shevchenko
Quoted 24 lines · John Harrison
Quoted 23 lines · Andy Shevchenko
Quoted 22 lines · On Tue, Jan 17, 2023 at 01:36:26PM -0800, [email protected] wrote:

From: John Harrison <[email protected]>

When GuC support was added to error capture, the locking around the request object was broken. Fix it up.

The context based search manages the spinlocking around the search internally. So it needs to grab the reference count internally as well. The execlist only request based search relies on external locking, so it needs an external reference count. So no change to that code itself but the context version does change.

The only other caller is the code for dumping engine state to debugfs. That code wasn't previously getting an explicit reference at all as it does everything while holding the execlist specific spinlock. So that needs updaing as well as that spinlock doesn't help when using GuC submission. Rather than trying to conditionally get/put depending on submission model, just change it to always do the get/put.

In addition, intel_guc_find_hung_context() was not acquiring the correct spinlock before searching the request list. So fix that up too.

Fixes dc0dad365c5e ("drm/i915/guc: Fix for error capture after full GPU reset

with GuC")

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Must be one line.

In my tree it is one line. git itself does the line wrap when creating the email.

Can you elaborate? I never have had such issue with git send-email (starting from v1.6.x of Git for sure).

Hmm. Confused. I think it must have been something accidental in a text editor when reviewing the patch. Re-creating the emails now isn't wrapping it.

Quoted 30 lines
Quoted 3 lines

I missed that I need to manually unwrap it again before actually sending the email. Although the CI checkpatch also pointed this out in it's own obscure manner.

...

Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
Cc Matthew Brost <[email protected]>
Cc John Harrison <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Tvrtko Ursulin <[email protected]>
Cc Daniele Ceraolo Spurio <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Matthew Auld <[email protected]>
Cc Matt Roper <[email protected]>
Cc Umesh Nerlige Ramappa <[email protected]>
Cc Michael Cheng <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Tejas Upadhyay <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Aravind Iddamsetty <[email protected]>
Cc Alan Previn <[email protected]>
Cc Bruce Chang <[email protected]>
Quoted 5 lines
Quoted 2 lines

Is it possible to utilize --to --cc parameters to git send-email instead of noisy Cc list?

This is the list auto-generated by the 'dim fixes' tool. I am told this is the officially correct way to create a fixes patch - copy the output from 'dim fixes' as is into the patch headers.

Quoted 8 lines

Okay, so it may be question to the dim tool then...

...

Quoted 3 lines
Quoted 1 line

Stray change.

Intentional change to improve the readability of a function that is being modified by other changes in this patch.

But not described in the commit message. That's why "stray".

Didn't seem worth mentioning. I can add a comment about it.

John.

Quoted 1 line
#6 lore raw

Re: [PATCH v2 1/5] drm/i915: Fix request locking during error capture & debugfs dump

In reply to [email protected]
Quoted 70 lines · On 17/01/2023 21:36, [email protected] wrote:

From: John Harrison <[email protected]>

When GuC support was added to error capture, the locking around the request object was broken. Fix it up.

The context based search manages the spinlocking around the search internally. So it needs to grab the reference count internally as well. The execlist only request based search relies on external locking, so it needs an external reference count. So no change to that code itself but the context version does change.

The only other caller is the code for dumping engine state to debugfs. That code wasn't previously getting an explicit reference at all as it does everything while holding the execlist specific spinlock. So that needs updaing as well as that spinlock doesn't help when using GuC submission. Rather than trying to conditionally get/put depending on submission model, just change it to always do the get/put.

In addition, intel_guc_find_hung_context() was not acquiring the correct spinlock before searching the request list. So fix that up too.

Fixes dc0dad365c5e ("drm/i915/guc: Fix for error capture after full GPU reset

with GuC")

Fixes 573ba126aef3 ("drm/i915/guc: Capture error state on context reset")
Cc Matthew Brost <[email protected]>
Cc John Harrison <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Tvrtko Ursulin <[email protected]>
Cc Daniele Ceraolo Spurio <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Matthew Auld <[email protected]>
Cc Matt Roper <[email protected]>
Cc Umesh Nerlige Ramappa <[email protected]>
Cc Michael Cheng <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Tejas Upadhyay <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Aravind Iddamsetty <[email protected]>
Cc Alan Previn <[email protected]>
Cc Bruce Chang <[email protected]>
---
  drivers/gpu/drm/i915/gt/intel_context.c           |  1 +
  drivers/gpu/drm/i915/gt/intel_engine_cs.c         |  7 ++++++-
  drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 11 +++++++++++
  drivers/gpu/drm/i915/i915_gpu_error.c             |  5 ++---
  4 files changed, 20 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gt/intel_context.c +1 -0
index e94365b08f1ef..df64cf1954c1d 100644
@@ -552,6 +552,7 @@ struct i915_request *intel_context_find_active_request(struct intel_context *ce)
 
  		active = rq;
  	}
+	active = i915_request_get_rcu(active);
  	spin_unlock_irqrestore(&parent->guc_state.lock, flags);
 
  	return active;
drivers/gpu/drm/i915/gt/intel_engine_cs.c +0 -0
index 922f1bb22dc68..517d1fb7ae333 100644
@@ -2236,10 +2236,13 @@ static void engine_dump_active_requests(struct intel_engine_cs *engine, struct d
  	guc = intel_uc_uses_guc_submission(&engine->gt->uc);

drivers/gpu/drm/i915/gt/intel_engine_cs.c static void engine_dump_active_requests(struct intel_engine_cs *engine, struct d · line 2245

Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_engine_cs.c +4 -1
  	if (guc) {
  		ce = intel_engine_get_hung_context(engine);
-		if (ce)
+		if (ce) {
+			/* This will reference count the request (if found) */
  			hung_rq = intel_context_find_active_request(ce);
+		}
  	} else {
  		hung_rq = intel_engine_execlist_find_hung_request(engine);
+		hung_rq = i915_request_get_rcu(hung_rq);

Looks like intel_engine_execlist_find_hung_request can return NULL which i915_request_get_rcu will not handle.

Maybe it would come up simpler if intel_context_find_active_request wouldn't be getting the reference and then you can get one here at a single place for both branches?

Quoted 45 lines
drivers/gpu/drm/i915/gt/intel_engine_cs.c +2 -0
  	}
 
  	if (hung_rq)
@@ -2250,6 +2253,8 @@ static void engine_dump_active_requests(struct intel_engine_cs *engine, struct d
  	else
  		intel_engine_dump_active_requests(&engine->sched_engine->requests,
  						  hung_rq, m);
+	if (hung_rq)
+		i915_request_put(hung_rq);
  }
 
  void intel_engine_dump(struct intel_engine_cs *engine,
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +10 -0
index b436dd7f12e42..3b34a82d692be 100644
@@ -4820,6 +4820,8 @@ void intel_guc_find_hung_context(struct intel_engine_cs *engine)
 
  	xa_lock_irqsave(&guc->context_lookup, flags);
  	xa_for_each(&guc->context_lookup, index, ce) {
+		bool found;
+
  		if (!kref_get_unless_zero(&ce->ref))
  			continue;
 
@@ -4836,10 +4838,18 @@ void intel_guc_find_hung_context(struct intel_engine_cs *engine)
  				goto next;
  		}
 
+		found = false;
+		spin_lock(&ce->guc_state.lock);
  		list_for_each_entry(rq, &ce->guc_state.requests, sched.link) {
  			if (i915_test_request_state(rq) != I915_REQUEST_ACTIVE)
  				continue;
 
+			found = true;
+			break;
+		}
+		spin_unlock(&ce->guc_state.lock);
+
+		if (found) {
  			intel_engine_set_hung_context(engine, ce);
 
  			/* Can only cope with one hang at a time... */

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c void intel_guc_find_hung_context(struct intel_engine_cs *engine) · line 4863

Quoted 7 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 -0
@@ -4847,6 +4857,7 @@ void intel_guc_find_hung_context(struct intel_engine_cs *engine)
  			xa_lock(&guc->context_lookup);
  			goto done;
  		}
+
  next:
  		intel_context_put(ce);
  		xa_lock(&guc->context_lookup);

This hunk I have to leave for someone who know the GuC backend well.

Regards,

Tvrtko

Quoted 27 lines
drivers/gpu/drm/i915/i915_gpu_error.c +2 -3
index 9d5d5a397b64e..4107a0dfcca7d 100644
@@ -1607,6 +1607,7 @@ capture_engine(struct intel_engine_cs *engine,
  	ce = intel_engine_get_hung_context(engine);
  	if (ce) {
  		intel_engine_clear_hung_context(engine);
+		/* This will reference count the request (if found) */
  		rq = intel_context_find_active_request(ce);
  		if (!rq || !i915_request_started(rq))
  			goto no_request_capture;
@@ -1618,13 +1619,11 @@ capture_engine(struct intel_engine_cs *engine,
  		if (!intel_uc_uses_guc_submission(&engine->gt->uc)) {
  			spin_lock_irqsave(&engine->sched_engine->lock, flags);
  			rq = intel_engine_execlist_find_hung_request(engine);
+			rq = i915_request_get_rcu(rq);
  			spin_unlock_irqrestore(&engine->sched_engine->lock,
  					       flags);
  		}
  	}
-	if (rq)
-		rq = i915_request_get_rcu(rq);
-
  	if (!rq)
  		goto no_request_capture;
 
#7 lore raw

Re: [PATCH v2 1/5] drm/i915: Fix request locking during error capture & debugfs dump

Quoted 75 lines · Tvrtko Ursulin
Quoted 74 lines · On 17/01/2023 21:36, [email protected] wrote:

From: John Harrison <[email protected]>

When GuC support was added to error capture, the locking around the request object was broken. Fix it up.

The context based search manages the spinlocking around the search internally. So it needs to grab the reference count internally as well. The execlist only request based search relies on external locking, so it needs an external reference count. So no change to that code itself but the context version does change.

The only other caller is the code for dumping engine state to debugfs. That code wasn't previously getting an explicit reference at all as it does everything while holding the execlist specific spinlock. So that needs updaing as well as that spinlock doesn't help when using GuC submission. Rather than trying to conditionally get/put depending on submission model, just change it to always do the get/put.

In addition, intel_guc_find_hung_context() was not acquiring the correct spinlock before searching the request list. So fix that up too.

Fixes dc0dad365c5e ("drm/i915/guc: Fix for error capture after full GPU reset

with GuC")

Fixes 573ba126aef3 ("drm/i915/guc: Capture error state on context reset")
Cc Matthew Brost <[email protected]>
Cc John Harrison <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Tvrtko Ursulin <[email protected]>
Cc Daniele Ceraolo Spurio <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Matthew Auld <[email protected]>
Cc Matt Roper <[email protected]>
Cc Umesh Nerlige Ramappa <[email protected]>
Cc Michael Cheng <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Tejas Upadhyay <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Aravind Iddamsetty <[email protected]>
Cc Alan Previn <[email protected]>
Cc Bruce Chang <[email protected]>

---
  drivers/gpu/drm/i915/gt/intel_context.c           |  1 + drivers/gpu/drm/i915/gt/intel_engine_cs.c         |  7 ++++++- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 11 +++++++++++ drivers/gpu/drm/i915/i915_gpu_error.c             |  5 ++---

  4 files changed, 20 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gt/intel_context.c +1 -0
index e94365b08f1ef..df64cf1954c1d 100644
@@ -552,6 +552,7 @@ struct i915_request 
 *intel_context_find_active_request(struct intel_context *ce)
             active = rq;
       }
+    active = i915_request_get_rcu(active);
       spin_unlock_irqrestore(&parent->guc_state.lock, flags);
         return active;
drivers/gpu/drm/i915/gt/intel_engine_cs.c +0 -0
index 922f1bb22dc68..517d1fb7ae333 100644
@@ -2236,10 +2236,13 @@ static void 

engine_dump_active_requests(struct intel_engine_cs *engine, struct d guc = intel_uc_uses_guc_submission(&engine->gt->uc); if (guc) {
          ce = intel_engine_get_hung_context(engine);
-        if (ce)
+        if (ce) {

Quoted 8 lines
Quoted 6 lines

+            /* This will reference count the request (if found) */ hung_rq = intel_context_find_active_request(ce); +        }
      } else {
          hung_rq = intel_engine_execlist_find_hung_request(engine); +        hung_rq = i915_request_get_rcu(hung_rq);

Looks like intel_engine_execlist_find_hung_request can return NULL which i915_request_get_rcu will not handle.

Doh! That is correct.

Quoted 2 lines

Maybe it would come up simpler if intel_context_find_active_request wouldn't be getting the reference and then you can get one here at a single place for both branches?

That would require moving the spinlock outside of intel_context_find_active_request so that it can be held while acquiring the request reference. And that means bleeding internal knowledge of which spinlock outside of the implementation and into the caller. As noted, the ideal would be extending the execlist implementation to do early tagging of the hung context/request at the point of hang detection. As opposed to rescanning the entire request list again at this point. And that will mean the lock being used inside 'context_find_active' would be dependent upon GuC vs execlist backend. Which is an implementation detail we really should not be leaking out to the caller.

IMHO, it would be better to refactor engine_dump_active_requests() to acquire the sched_engine spinlock internally and only around the code which actually needs it (some of which is maybe execlist specific and not valid with GuC submission?). Certainly grabbing two independent spinlocks in a nested manner is not a good idea when there is no reason to do so.

John.

Quoted 82 lines
Quoted 46 lines

      }
        if (hung_rq)

drivers/gpu/drm/i915/gt/intel_engine_cs.c +0 -0
@@ -2250,6 +2253,8 @@ static void engine_dump_active_requests(struct 

intel_engine_cs *engine, struct d
      else intel_engine_dump_active_requests(&engine->sched_engine->requests, hung_rq, m);
+    if (hung_rq)
+        i915_request_put(hung_rq);
  }
    void intel_engine_dump(struct intel_engine_cs *engine,

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +2 -0
index b436dd7f12e42..3b34a82d692be 100644
@@ -4820,6 +4820,8 @@ void intel_guc_find_hung_context(struct 
 intel_engine_cs *engine)
         xa_lock_irqsave(&guc->context_lookup, flags);
       xa_for_each(&guc->context_lookup, index, ce) {
+        bool found;
+
           if (!kref_get_unless_zero(&ce->ref))
               continue;
   @@ -4836,10 +4838,18 @@ void intel_guc_find_hung_context(struct intel_engine_cs *engine)

                  goto next;
          }
  +        found = false;
+        spin_lock(&ce->guc_state.lock); list_for_each_entry(rq, &ce->guc_state.requests, sched.link) { if (i915_test_request_state(rq) != I915_REQUEST_ACTIVE) continue;
  +            found = true;
+            break;
+        }
+        spin_unlock(&ce->guc_state.lock);
+
+        if (found) {
              intel_engine_set_hung_context(engine, ce);
                /* Can only cope with one hang at a time... */

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 -0
@@ -4847,6 +4857,7 @@ void intel_guc_find_hung_context(struct 
 intel_engine_cs *engine)
               xa_lock(&guc->context_lookup);
               goto done;
           }
+
Quoted 3 lines

  next:
          intel_context_put(ce);
          xa_lock(&guc->context_lookup);

This hunk I have to leave for someone who know the GuC backend well.

Regards,

Tvrtko

Quoted 26 lines
drivers/gpu/drm/i915/i915_gpu_error.c +2 -3
index 9d5d5a397b64e..4107a0dfcca7d 100644
@@ -1607,6 +1607,7 @@ capture_engine(struct intel_engine_cs *engine,
       ce = intel_engine_get_hung_context(engine);
       if (ce) {
           intel_engine_clear_hung_context(engine);
+        /* This will reference count the request (if found) */
           rq = intel_context_find_active_request(ce);
           if (!rq || !i915_request_started(rq))
               goto no_request_capture;
@@ -1618,13 +1619,11 @@ capture_engine(struct intel_engine_cs *engine,
           if (!intel_uc_uses_guc_submission(&engine->gt->uc)) {
 spin_lock_irqsave(&engine->sched_engine->lock, flags);
               rq = intel_engine_execlist_find_hung_request(engine);
+            rq = i915_request_get_rcu(rq);
 spin_unlock_irqrestore(&engine->sched_engine->lock,
                              flags);
           }
       }
-    if (rq)
-        rq = i915_request_get_rcu(rq);
-
       if (!rq)
           goto no_request_capture;
#8 lore raw

PATCH v2 2/5 drm/i915: Allow error capture without a request

In reply to [email protected]

From: John Harrison <[email protected]>

There was a report of error captures occurring without any hung context being indicated despite the capture being initiated by a 'hung context notification' from GuC. The problem was not reproducible. However, it is possible to happen if the context in question has no active requests. For example, if the hang was in the context switch itself then the breadcrumb write would have occurred and the KMD would see an idle context.

In the interests of attempting to provide as much information as possible about a hang, it seems wise to include the engine info regardless of whether a request was found or not. As opposed to just prentending there was no hang at all.

So update the error capture code to always record engine information if an engine is given. Which means updating record_context() to take a context instead of a request (which it only ever used to find the context anyway). And split the request agnostic parts of intel_engine_coredump_add_request() out into a seaprate function.

v2: Remove a duplicate 'if' statement (Umesh) and fix a put of a null pointer.
v3: Tidy up request locking code flow (Tvrtko)

---
 drivers/gpu/drm/i915/i915_gpu_error.c | 69 ++++++++++++++++++---------
 1 file changed, 46 insertions(+), 23 deletions(-)
drivers/gpu/drm/i915/i915_gpu_error.c +46 -23
index 4107a0dfcca7d..461489d599a7e 100644
@@ -1370,14 +1370,14 @@ static void engine_record_execlists(struct intel_engine_coredump *ee)
 }
 
 static bool record_context(struct i915_gem_context_coredump *e,
-			   const struct i915_request *rq)
+			   struct intel_context *ce)
 {
 	struct i915_gem_context *ctx;
 	struct task_struct *task;
 	bool simulated;
 
 	rcu_read_lock();
-	ctx = rcu_dereference(rq->context->gem_context);
+	ctx = rcu_dereference(ce->gem_context);
 	if (ctx && !kref_get_unless_zero(&ctx->ref))
 		ctx = NULL;
 	rcu_read_unlock();
@@ -1396,8 +1396,8 @@ static bool record_context(struct i915_gem_context_coredump *e,
 	e->guilty = atomic_read(&ctx->guilty_count);
 	e->active = atomic_read(&ctx->active_count);
 
-	e->total_runtime = intel_context_get_total_runtime_ns(rq->context);
-	e->avg_runtime = intel_context_get_avg_runtime_ns(rq->context);
+	e->total_runtime = intel_context_get_total_runtime_ns(ce);
+	e->avg_runtime = intel_context_get_avg_runtime_ns(ce);
 
 	simulated = i915_gem_context_no_error_capture(ctx);
 
@@ -1532,15 +1532,37 @@ intel_engine_coredump_alloc(struct intel_engine_cs *engine, gfp_t gfp, u32 dump_
 	return ee;
 }
 
+static struct intel_engine_capture_vma *
+engine_coredump_add_context(struct intel_engine_coredump *ee,
+			    struct intel_context *ce,
+			    gfp_t gfp)
+{
+	struct intel_engine_capture_vma *vma = NULL;
+
+	ee->simulated |= record_context(&ee->context, ce);
+	if (ee->simulated)
+		return NULL;
+
+	/*
+	 * We need to copy these to an anonymous buffer
+	 * as the simplest method to avoid being overwritten
+	 * by userspace.
+	 */
+	vma = capture_vma(vma, ce->ring->vma, "ring", gfp);
+	vma = capture_vma(vma, ce->state, "HW context", gfp);
+
+	return vma;
+}
+
 struct intel_engine_capture_vma *
 intel_engine_coredump_add_request(struct intel_engine_coredump *ee,
 				  struct i915_request *rq,
 				  gfp_t gfp)
 {
-	struct intel_engine_capture_vma *vma = NULL;
+	struct intel_engine_capture_vma *vma;
 
-	ee->simulated |= record_context(&ee->context, rq);
-	if (ee->simulated)
+	vma = engine_coredump_add_context(ee, rq->context, gfp);
+	if (!vma)
 		return NULL;
 
 	/*
@@ -1550,8 +1572,6 @@ intel_engine_coredump_add_request(struct intel_engine_coredump *ee,
 	 */
 	vma = capture_vma_snapshot(vma, rq->batch_res, gfp, "batch");
 	vma = capture_user(vma, rq, gfp);
-	vma = capture_vma(vma, rq->ring->vma, "ring", gfp);
-	vma = capture_vma(vma, rq->context->state, "HW context", gfp);
 
 	ee->rq_head = rq->head;
 	ee->rq_post = rq->postfix;
@@ -1609,8 +1629,12 @@ capture_engine(struct intel_engine_cs *engine,
 		intel_engine_clear_hung_context(engine);
 		/* This will reference count the request (if found) */
 		rq = intel_context_find_active_request(ce);
-		if (!rq || !i915_request_started(rq))
-			goto no_request_capture;
+		if (rq && !i915_request_started(rq)) {
+			drm_info(&engine->gt->i915->drm, "Got hung context on %s with no active request!\n",
+				 engine->name);
+			i915_request_put(rq);
+			rq = NULL;
+		}
 	} else {
 		/*
 		 * Getting here with GuC enabled means it is a forced error capture
@@ -1624,25 +1648,24 @@ capture_engine(struct intel_engine_cs *engine,
 					       flags);
 		}
 	}
-	if (!rq)
-		goto no_request_capture;
-
-	capture = intel_engine_coredump_add_request(ee, rq, ATOMIC_MAYFAIL);
-	if (!capture) {
+	if (rq) {
+		capture = intel_engine_coredump_add_request(ee, rq, ATOMIC_MAYFAIL);
 		i915_request_put(rq);
-		goto no_request_capture;
+	} else if (ce) {
+		capture = engine_coredump_add_context(ee, ce, ATOMIC_MAYFAIL);
 	}
+
 	if (dump_flags & CORE_DUMP_FLAG_IS_GUC_CAPTURE)
 		intel_guc_capture_get_matching_node(engine->gt, ee, ce);
 
-	intel_engine_coredump_add_vma(ee, capture, compress);
-	i915_request_put(rq);
+	if (capture) {
+		intel_engine_coredump_add_vma(ee, capture, compress);
+	} else {
+		kfree(ee);
+		ee = NULL;
+	}
 
 	return ee;
-
-no_request_capture:
-	kfree(ee);
-	return NULL;
 }
 
 static void
Signature · 1 line
2.39.0
Acked-by on v2 2/5
#9 lore raw

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: Allow error capture without a request

Quoted 155 lines · On 17/01/2023 21:36, [email protected] wrote:

From: John Harrison <[email protected]>

There was a report of error captures occurring without any hung context being indicated despite the capture being initiated by a 'hung context notification' from GuC. The problem was not reproducible. However, it is possible to happen if the context in question has no active requests. For example, if the hang was in the context switch itself then the breadcrumb write would have occurred and the KMD would see an idle context.

In the interests of attempting to provide as much information as possible about a hang, it seems wise to include the engine info regardless of whether a request was found or not. As opposed to just prentending there was no hang at all.

So update the error capture code to always record engine information if an engine is given. Which means updating record_context() to take a context instead of a request (which it only ever used to find the context anyway). And split the request agnostic parts of intel_engine_coredump_add_request() out into a seaprate function.

v2: Remove a duplicate 'if' statement (Umesh) and fix a put of a null pointer.
v3: Tidy up request locking code flow (Tvrtko)

---
  drivers/gpu/drm/i915/i915_gpu_error.c | 69 ++++++++++++++++++---------
  1 file changed, 46 insertions(+), 23 deletions(-)
drivers/gpu/drm/i915/i915_gpu_error.c +45 -19
index 4107a0dfcca7d..461489d599a7e 100644
@@ -1370,14 +1370,14 @@ static void engine_record_execlists(struct intel_engine_coredump *ee)
  }
 
  static bool record_context(struct i915_gem_context_coredump *e,
-			   const struct i915_request *rq)
+			   struct intel_context *ce)
  {
  	struct i915_gem_context *ctx;
  	struct task_struct *task;
  	bool simulated;
 
  	rcu_read_lock();
-	ctx = rcu_dereference(rq->context->gem_context);
+	ctx = rcu_dereference(ce->gem_context);
  	if (ctx && !kref_get_unless_zero(&ctx->ref))
  		ctx = NULL;
  	rcu_read_unlock();
@@ -1396,8 +1396,8 @@ static bool record_context(struct i915_gem_context_coredump *e,
  	e->guilty = atomic_read(&ctx->guilty_count);
  	e->active = atomic_read(&ctx->active_count);
 
-	e->total_runtime = intel_context_get_total_runtime_ns(rq->context);
-	e->avg_runtime = intel_context_get_avg_runtime_ns(rq->context);
+	e->total_runtime = intel_context_get_total_runtime_ns(ce);
+	e->avg_runtime = intel_context_get_avg_runtime_ns(ce);
 
  	simulated = i915_gem_context_no_error_capture(ctx);
 
@@ -1532,15 +1532,37 @@ intel_engine_coredump_alloc(struct intel_engine_cs *engine, gfp_t gfp, u32 dump_
  	return ee;
  }
 
+static struct intel_engine_capture_vma *
+engine_coredump_add_context(struct intel_engine_coredump *ee,
+			    struct intel_context *ce,
+			    gfp_t gfp)
+{
+	struct intel_engine_capture_vma *vma = NULL;
+
+	ee->simulated |= record_context(&ee->context, ce);
+	if (ee->simulated)
+		return NULL;
+
+	/*
+	 * We need to copy these to an anonymous buffer
+	 * as the simplest method to avoid being overwritten
+	 * by userspace.
+	 */
+	vma = capture_vma(vma, ce->ring->vma, "ring", gfp);
+	vma = capture_vma(vma, ce->state, "HW context", gfp);
+
+	return vma;
+}
+
  struct intel_engine_capture_vma *
  intel_engine_coredump_add_request(struct intel_engine_coredump *ee,
  				  struct i915_request *rq,
  				  gfp_t gfp)
  {
-	struct intel_engine_capture_vma *vma = NULL;
+	struct intel_engine_capture_vma *vma;
 
-	ee->simulated |= record_context(&ee->context, rq);
-	if (ee->simulated)
+	vma = engine_coredump_add_context(ee, rq->context, gfp);
+	if (!vma)
  		return NULL;
 
  	/*
@@ -1550,8 +1572,6 @@ intel_engine_coredump_add_request(struct intel_engine_coredump *ee,
  	 */
  	vma = capture_vma_snapshot(vma, rq->batch_res, gfp, "batch");
  	vma = capture_user(vma, rq, gfp);
-	vma = capture_vma(vma, rq->ring->vma, "ring", gfp);
-	vma = capture_vma(vma, rq->context->state, "HW context", gfp);
 
  	ee->rq_head = rq->head;
  	ee->rq_post = rq->postfix;
@@ -1609,8 +1629,12 @@ capture_engine(struct intel_engine_cs *engine,
  		intel_engine_clear_hung_context(engine);
  		/* This will reference count the request (if found) */
  		rq = intel_context_find_active_request(ce);
-		if (!rq || !i915_request_started(rq))
-			goto no_request_capture;
+		if (rq && !i915_request_started(rq)) {
+			drm_info(&engine->gt->i915->drm, "Got hung context on %s with no active request!\n",
+				 engine->name);
+			i915_request_put(rq);
+			rq = NULL;
+		}
  	} else {
  		/*
  		 * Getting here with GuC enabled means it is a forced error capture
@@ -1624,25 +1648,24 @@ capture_engine(struct intel_engine_cs *engine,
  					       flags);
  		}
  	}
-	if (!rq)
-		goto no_request_capture;
-
-	capture = intel_engine_coredump_add_request(ee, rq, ATOMIC_MAYFAIL);
-	if (!capture) {
+	if (rq) {
+		capture = intel_engine_coredump_add_request(ee, rq, ATOMIC_MAYFAIL);
  		i915_request_put(rq);
-		goto no_request_capture;
+	} else if (ce) {
+		capture = engine_coredump_add_context(ee, ce, ATOMIC_MAYFAIL);
  	}
+
  	if (dump_flags & CORE_DUMP_FLAG_IS_GUC_CAPTURE)
  		intel_guc_capture_get_matching_node(engine->gt, ee, ce);
 
-	intel_engine_coredump_add_vma(ee, capture, compress);
-	i915_request_put(rq);
+	if (capture) {
+		intel_engine_coredump_add_vma(ee, capture, compress);
+	} else {
+		kfree(ee);
+		ee = NULL;

drivers/gpu/drm/i915/i915_gpu_error.c capture_engine(struct intel_engine_cs *engine, · line 1671

Quoted 10 lines
drivers/gpu/drm/i915/i915_gpu_error.c +1 -4
+	}
 
  	return ee;
-
-no_request_capture:
-	kfree(ee);
-	return NULL;
  }
 
  static void

LGTM - regardless of how i915_request_get_rcu flow ends up:

Regards,

Tvrtko

#10 lore raw

PATCH v2 3/5 drm/i915: Allow error capture of a pending request

In reply to [email protected]

From: John Harrison <[email protected]>

A hang situation has been observed where the only requests on the context were either completed or not yet started according to the breaadcrumbs. However, the register state claimed a batch was (maybe) in progress. So, allow capture of the pending request on the grounds that this might be better than nothing.

v2: Reword 'not started' warning message (Tvrtko)

---
 drivers/gpu/drm/i915/i915_gpu_error.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/i915_gpu_error.c +3 -6
index 461489d599a7e..1d33822a8ca23 100644
@@ -1629,12 +1629,9 @@ capture_engine(struct intel_engine_cs *engine,
 		intel_engine_clear_hung_context(engine);
 		/* This will reference count the request (if found) */
 		rq = intel_context_find_active_request(ce);
-		if (rq && !i915_request_started(rq)) {
-			drm_info(&engine->gt->i915->drm, "Got hung context on %s with no active request!\n",
-				 engine->name);
-			i915_request_put(rq);
-			rq = NULL;
-		}
+		if (rq && !i915_request_started(rq))
+			drm_info(&engine->gt->i915->drm, "Got hung context on %s with active request %lld:%lld [0x%04X] not yet started\n",
+				 engine->name, rq->fence.context, rq->fence.seqno, ce->guc_id.id);
 	} else {
 		/*
 		 * Getting here with GuC enabled means it is a forced error capture
Signature · 1 line
2.39.0
Reviewed-by on v2 3/5
#11 lore raw

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Allow error capture of a pending request

Quoted 25 lines · On 17/01/2023 21:36, [email protected] wrote:

From: John Harrison <[email protected]>

A hang situation has been observed where the only requests on the context were either completed or not yet started according to the breaadcrumbs. However, the register state claimed a batch was (maybe) in progress. So, allow capture of the pending request on the grounds that this might be better than nothing.

v2: Reword 'not started' warning message (Tvrtko)

---
  drivers/gpu/drm/i915/i915_gpu_error.c | 9 +++------
  1 file changed, 3 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/i915_gpu_error.c +0 -2
index 461489d599a7e..1d33822a8ca23 100644
@@ -1629,12 +1629,9 @@ capture_engine(struct intel_engine_cs *engine,
  		intel_engine_clear_hung_context(engine);
  		/* This will reference count the request (if found) */
  		rq = intel_context_find_active_request(ce);
-		if (rq && !i915_request_started(rq)) {
-			drm_info(&engine->gt->i915->drm, "Got hung context on %s with no active request!\n",

drivers/gpu/drm/i915/i915_gpu_error.c capture_engine(struct intel_engine_cs *engine, · line 1637

Quoted 10 lines
drivers/gpu/drm/i915/i915_gpu_error.c +3 -4
-				 engine->name);
-			i915_request_put(rq);
-			rq = NULL;
-		}
+		if (rq && !i915_request_started(rq))
+			drm_info(&engine->gt->i915->drm, "Got hung context on %s with active request %lld:%lld [0x%04X] not yet started\n",
+				 engine->name, rq->fence.context, rq->fence.seqno, ce->guc_id.id);
  	} else {
  		/*
  		 * Getting here with GuC enabled means it is a forced error capture

Regards,

Tvrtko

#12 lore raw

PATCH v2 4/5 drm/i915/guc: Look for a guilty context when an engine reset fails

In reply to [email protected]

From: John Harrison <[email protected]>

Engine resets are supposed to never fail. But in the case when one does (due to unknown reasons that normally come down to a missing w/a), it is useful to get as much information out of the system as possible. Given that the GuC effectively dies on such a situation, it is not possible to get a guilty context notification back. So do a manual search instead. Given that GuC is dead, this is safe because GuC won't be changing the engine state asynchronously.

v2: Change comment to be less alarming (Tvrtko)

---
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c   | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +15 -2
index 3b34a82d692be..9bc80b807dbcc 100644
@@ -4754,11 +4754,24 @@ static void reset_fail_worker_func(struct work_struct *w)
 	guc->submission_state.reset_fail_mask = 0;
 	spin_unlock_irqrestore(&guc->submission_state.lock, flags);
 
-	if (likely(reset_fail_mask))
+	if (likely(reset_fail_mask)) {
+		struct intel_engine_cs *engine;
+		enum intel_engine_id id;
+
+		/*
+		 * GuC is toast at this point - it dead loops after sending the failed
+		 * reset notification. So need to manually determine the guilty context.
+		 * Note that it should be reliable to do this here because the GuC is
+		 * toast and will not be scheduling behind the KMD's back.
+		 */
+		for_each_engine_masked(engine, gt, reset_fail_mask, id)
+			intel_guc_find_hung_context(engine);
+
 		intel_gt_handle_error(gt, reset_fail_mask,
 				      I915_ERROR_CAPTURE,
-				      "GuC failed to reset engine mask=0x%x\n",
+				      "GuC failed to reset engine mask=0x%x",
 				      reset_fail_mask);
+	}
 }
 
 int intel_guc_engine_failure_process_msg(struct intel_guc *guc,
Signature · 1 line
2.39.0
Acked-by on v2 4/5
#13 lore raw

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Look for a guilty context when an engine reset fails

Quoted 38 lines · On 17/01/2023 21:36, [email protected] wrote:

From: John Harrison <[email protected]>

Engine resets are supposed to never fail. But in the case when one does (due to unknown reasons that normally come down to a missing w/a), it is useful to get as much information out of the system as possible. Given that the GuC effectively dies on such a situation, it is not possible to get a guilty context notification back. So do a manual search instead. Given that GuC is dead, this is safe because GuC won't be changing the engine state asynchronously.

v2: Change comment to be less alarming (Tvrtko)

---
  .../gpu/drm/i915/gt/uc/intel_guc_submission.c   | 17 +++++++++++++++--
  1 file changed, 15 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +12 -1
index 3b34a82d692be..9bc80b807dbcc 100644
@@ -4754,11 +4754,24 @@ static void reset_fail_worker_func(struct work_struct *w)
  	guc->submission_state.reset_fail_mask = 0;
  	spin_unlock_irqrestore(&guc->submission_state.lock, flags);
 
-	if (likely(reset_fail_mask))
+	if (likely(reset_fail_mask)) {
+		struct intel_engine_cs *engine;
+		enum intel_engine_id id;
+
+		/*
+		 * GuC is toast at this point - it dead loops after sending the failed
+		 * reset notification. So need to manually determine the guilty context.
+		 * Note that it should be reliable to do this here because the GuC is
+		 * toast and will not be scheduling behind the KMD's back.
+		 */
+		for_each_engine_masked(engine, gt, reset_fail_mask, id)
+			intel_guc_find_hung_context(engine);

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c static void reset_fail_worker_func(struct work_struct *w) · line 4777

Quoted 10 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +3 -1
+
  		intel_gt_handle_error(gt, reset_fail_mask,
  				      I915_ERROR_CAPTURE,
-				      "GuC failed to reset engine mask=0x%x\n",
+				      "GuC failed to reset engine mask=0x%x",
  				      reset_fail_mask);
+	}
  }
 
  int intel_guc_engine_failure_process_msg(struct intel_guc *guc,

Assuming 1/5 gets blessed by GuC experts this would then look safe to:

Regards,

Tvrtko

#14 lore raw

PATCH v2 5/5 drm/i915/guc: Add a debug print on GuC triggered reset

In reply to [email protected]

From: John Harrison <[email protected]>

For understanding bug reports, it can be useful to have an explicit dmesg print when a reset notification is received from GuC. As opposed to simply inferring that this happened from other messages.

---
 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +4 -0
index 9bc80b807dbcc..6029dbab5feeb 100644
@@ -4665,6 +4665,10 @@ static void guc_handle_context_reset(struct intel_guc *guc,
 {
 	trace_intel_context_reset(ce);
 
+	drm_dbg(&guc_to_gt(guc)->i915->drm, "Got GuC reset of 0x%04X, exiting = %d, banned = %d\n",
+		ce->guc_id.id, test_bit(CONTEXT_EXITING, &ce->flags),
+		test_bit(CONTEXT_BANNED, &ce->flags));
+
 	if (likely(intel_context_is_schedulable(ce))) {
 		capture_error_state(guc, ce);
 		guc_context_replay(ce);
Signature · 1 line
2.39.0
#15 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Allow error capture without a request / on reset failure (rev3)

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: Allow error capture without a request / on reset failure (rev3)
URL : https://patchwork.freedesktop.org/series/111454/
State : warning

== Summary ==

Error: dim checkpatch failed
79d89c5b0cf9 drm/i915: Fix request locking during error capture & debugfs dump
-:26: WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 98df76aeb29b ("drm/i915/guc: Add a debug print on GuC triggered reset")' #26:

Fixes dc0dad365c5e ("drm/i915/guc: Fix for error capture after full GPU reset

total: 0 errors, 1 warnings, 0 checks, 83 lines checked 6ad402b58742 drm/i915: Allow error capture without a request f5f448ea38a4 drm/i915: Allow error capture of a pending request 43da516a0b97 drm/i915/guc: Look for a guilty context when an engine reset fails 98df76aeb29b drm/i915/guc: Add a debug print on GuC triggered reset

#16 lore raw

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Allow error capture without a request / on reset failure (rev3)

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: Allow error capture without a request / on reset failure (rev3)
URL : https://patchwork.freedesktop.org/series/111454/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:117:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:117:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:148:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:148:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:148:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:150:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:150:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:150:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:154:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:154:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:154:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:156:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:156:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:156:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:156:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:156:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:156:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:174:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:174:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:174:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:176:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:176:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:176:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:180:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:180:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:180:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:182:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:182:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:182:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:182:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:182:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:182:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:186:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:186:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:186:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:188:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:188:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:188:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:192:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:192:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:192:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:195:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:195:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:195:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:195:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:195:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:195:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:237:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:237:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:237:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:239:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:239:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:239:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./drivers/gpu/drm/i915/intel_uncore.h:346:1: warning: trying to copy expression type 31 +./drivers/gpu/drm/i915/intel_uncore.h:346:1: warning: trying to copy expression type 31 +./drivers/gpu/drm/i915/intel_uncore.h:351:1: warning: trying to copy expression type 31 +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return'

#17 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for Allow error capture without a request / on reset failure (rev3)

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: Allow error capture without a request / on reset failure (rev3)
URL : https://patchwork.freedesktop.org/series/111454/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12594 -> Patchwork_111454v3
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_111454v3 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_111454v3, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/index.html

Participating hosts (42 -> 44)
------------------------------

Additional (3): fi-kbl-soraka bat-rpls-2 fi-skl-6700k2
Missing (1): fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_111454v3:

### IGT changes ###

#### Possible regressions ####

* igt@debugfs_test@read_all_entries:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-kbl-soraka/igt@debugfs_test@read_all_entries.html
- fi-skl-6700k2: NOTRUN -> [INCOMPLETE][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-skl-6700k2/igt@debugfs_test@read_all_entries.html
- fi-cfl-8109u: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-cfl-8109u/igt@debugfs_test@read_all_entries.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-cfl-8109u/igt@debugfs_test@read_all_entries.html
- fi-kbl-7567u: [PASS][5] -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-kbl-7567u/igt@debugfs_test@read_all_entries.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-kbl-7567u/igt@debugfs_test@read_all_entries.html
- fi-kbl-8809g: [PASS][7] -> [INCOMPLETE][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-kbl-8809g/igt@debugfs_test@read_all_entries.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-kbl-8809g/igt@debugfs_test@read_all_entries.html
- fi-ivb-3770: [PASS][9] -> [INCOMPLETE][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-ivb-3770/igt@debugfs_test@read_all_entries.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-ivb-3770/igt@debugfs_test@read_all_entries.html
- fi-elk-e7500: [PASS][11] -> [INCOMPLETE][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-elk-e7500/igt@debugfs_test@read_all_entries.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-elk-e7500/igt@debugfs_test@read_all_entries.html
- fi-ctg-p8600: [PASS][13] -> [INCOMPLETE][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-ctg-p8600/igt@debugfs_test@read_all_entries.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-ctg-p8600/igt@debugfs_test@read_all_entries.html
- fi-blb-e6850: [PASS][15] -> [INCOMPLETE][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-blb-e6850/igt@debugfs_test@read_all_entries.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-blb-e6850/igt@debugfs_test@read_all_entries.html
- fi-bsw-n3050: [PASS][17] -> [INCOMPLETE][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-bsw-n3050/igt@debugfs_test@read_all_entries.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-bsw-n3050/igt@debugfs_test@read_all_entries.html
- fi-cfl-guc: [PASS][19] -> [INCOMPLETE][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-cfl-guc/igt@debugfs_test@read_all_entries.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-cfl-guc/igt@debugfs_test@read_all_entries.html
- fi-skl-6600u: [PASS][21] -> [INCOMPLETE][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-skl-6600u/igt@debugfs_test@read_all_entries.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-skl-6600u/igt@debugfs_test@read_all_entries.html
- fi-pnv-d510: [PASS][23] -> [INCOMPLETE][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-pnv-d510/igt@debugfs_test@read_all_entries.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-pnv-d510/igt@debugfs_test@read_all_entries.html
- fi-glk-j4005: [PASS][25] -> [INCOMPLETE][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-glk-j4005/igt@debugfs_test@read_all_entries.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-glk-j4005/igt@debugfs_test@read_all_entries.html
- fi-snb-2600: [PASS][27] -> [INCOMPLETE][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-snb-2600/igt@debugfs_test@read_all_entries.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-snb-2600/igt@debugfs_test@read_all_entries.html
- fi-skl-guc: [PASS][29] -> [INCOMPLETE][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-skl-guc/igt@debugfs_test@read_all_entries.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-skl-guc/igt@debugfs_test@read_all_entries.html
- fi-cfl-8700k: [PASS][31] -> [INCOMPLETE][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-cfl-8700k/igt@debugfs_test@read_all_entries.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-cfl-8700k/igt@debugfs_test@read_all_entries.html
- fi-bsw-nick: [PASS][33] -> [INCOMPLETE][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-bsw-nick/igt@debugfs_test@read_all_entries.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-bsw-nick/igt@debugfs_test@read_all_entries.html
- fi-rkl-11600: [PASS][35] -> [INCOMPLETE][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-rkl-11600/igt@debugfs_test@read_all_entries.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-rkl-11600/igt@debugfs_test@read_all_entries.html
- fi-bsw-kefka: [PASS][37] -> [INCOMPLETE][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-bsw-kefka/igt@debugfs_test@read_all_entries.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-bsw-kefka/igt@debugfs_test@read_all_entries.html
- fi-adl-ddr5: [PASS][39] -> [INCOMPLETE][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-adl-ddr5/igt@debugfs_test@read_all_entries.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-adl-ddr5/igt@debugfs_test@read_all_entries.html

* igt@i915_hangman@error-state-basic:
- bat-dg1-5: [PASS][41] -> [INCOMPLETE][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-dg1-5/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-dg1-5/igt@[email protected]
- fi-rkl-guc: [PASS][43] -> [INCOMPLETE][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-rkl-guc/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-rkl-guc/igt@[email protected]
- bat-dg1-6: [PASS][45] -> [INCOMPLETE][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-dg1-6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-dg1-6/igt@[email protected]

* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> [FAIL][47]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-apl-guc/igt@[email protected]
- bat-dg1-5: NOTRUN -> [FAIL][48]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-dg1-5/igt@[email protected]
- fi-rkl-guc: NOTRUN -> [FAIL][49]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-rkl-guc/igt@[email protected]
- bat-dg1-6: NOTRUN -> [FAIL][50]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-dg1-6/igt@[email protected]

#### Warnings ####

* igt@debugfs_test@read_all_entries:
- fi-icl-u2: [ABORT][51] ([i915#7763]) -> [INCOMPLETE][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-icl-u2/igt@debugfs_test@read_all_entries.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-icl-u2/igt@debugfs_test@read_all_entries.html

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@debugfs_test@read_all_entries:
- {bat-jsl-1}: [PASS][53] -> [INCOMPLETE][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-jsl-1/igt@debugfs_test@read_all_entries.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-jsl-1/igt@debugfs_test@read_all_entries.html
- {fi-jsl-1}: [PASS][55] -> [INCOMPLETE][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-jsl-1/igt@debugfs_test@read_all_entries.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-jsl-1/igt@debugfs_test@read_all_entries.html
- {bat-kbl-2}: [PASS][57] -> [INCOMPLETE][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-kbl-2/igt@debugfs_test@read_all_entries.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-kbl-2/igt@debugfs_test@read_all_entries.html
- {bat-adls-5}: [PASS][59] -> [INCOMPLETE][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-adls-5/igt@debugfs_test@read_all_entries.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-adls-5/igt@debugfs_test@read_all_entries.html
- {bat-jsl-3}: [PASS][61] -> [INCOMPLETE][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-jsl-3/igt@debugfs_test@read_all_entries.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-jsl-3/igt@debugfs_test@read_all_entries.html

* igt@i915_hangman@error-state-basic:
- {bat-dg2-9}: [PASS][63] -> [INCOMPLETE][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-dg2-9/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-dg2-9/igt@[email protected]
- {bat-adln-1}: [PASS][65] -> [INCOMPLETE][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-adln-1/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-adln-1/igt@[email protected]
- {bat-rpls-2}: NOTRUN -> [INCOMPLETE][67]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-rpls-2/igt@[email protected]
- {bat-dg2-8}: [PASS][68] -> [INCOMPLETE][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-dg2-8/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-dg2-8/igt@[email protected]
- {bat-adlm-1}: [PASS][70] -> [INCOMPLETE][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-adlm-1/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-adlm-1/igt@[email protected]
- {bat-rpls-1}: [PASS][72] -> [INCOMPLETE][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-rpls-1/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-rpls-1/igt@[email protected]
- {bat-adlp-6}: [PASS][74] -> [INCOMPLETE][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-adlp-6/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-adlp-6/igt@[email protected]
- {bat-dg1-7}: [PASS][76] -> [INCOMPLETE][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-dg1-7/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-dg1-7/igt@[email protected]
- {bat-adlp-9}: [PASS][78] -> [INCOMPLETE][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-adlp-9/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-adlp-9/igt@[email protected]
- {bat-dg2-11}: [PASS][80] -> [INCOMPLETE][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-dg2-11/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-dg2-11/igt@[email protected]
- {bat-dg2-oem1}: [PASS][82] -> [INCOMPLETE][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-dg2-oem1/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-dg2-oem1/igt@[email protected]
- {bat-rplp-1}: [PASS][84] -> [INCOMPLETE][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/bat-rplp-1/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-rplp-1/igt@[email protected]

* igt@runner@aborted:
- {bat-dg2-9}: NOTRUN -> [FAIL][86]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/bat-dg2-9/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_111454v3 that come from known issues:

### CI changes ###

#### Issues hit ####

* boot:
- fi-ilk-650: [PASS][87] -> [FAIL][88] ([i915#7350])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12594/fi-ilk-650/boot.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-ilk-650/boot.html

### IGT changes ###

#### Issues hit ####

* igt@runner@aborted:
- fi-skl-6700k2: NOTRUN -> [FAIL][89] ([i915#4312])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-skl-6700k2/igt@[email protected]
- fi-cfl-8109u: NOTRUN -> [FAIL][90] ([i915#4312])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-cfl-8109u/igt@[email protected]
- fi-ivb-3770: NOTRUN -> [FAIL][91] ([i915#4312])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-ivb-3770/igt@[email protected]
- fi-elk-e7500: NOTRUN -> [FAIL][92] ([i915#4312])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-elk-e7500/igt@[email protected]
- fi-snb-2600: NOTRUN -> [FAIL][93] ([i915#4312])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-snb-2600/igt@[email protected]
- fi-ctg-p8600: NOTRUN -> [FAIL][94] ([i915#4312])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-ctg-p8600/igt@[email protected]
- fi-blb-e6850: NOTRUN -> [FAIL][95] ([i915#4312])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-blb-e6850/igt@[email protected]
- fi-bsw-n3050: NOTRUN -> [FAIL][96] ([i915#4312])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-bsw-n3050/igt@[email protected]
- fi-skl-6600u: NOTRUN -> [FAIL][97] ([i915#4312])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-skl-6600u/igt@[email protected]
- fi-pnv-d510: NOTRUN -> [FAIL][98] ([i915#4312])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-pnv-d510/igt@[email protected]
- fi-glk-j4005: NOTRUN -> [FAIL][99] ([i915#4312])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-glk-j4005/igt@[email protected]
- fi-skl-guc: NOTRUN -> [FAIL][100] ([i915#4312])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-skl-guc/igt@[email protected]
- fi-kbl-soraka: NOTRUN -> [FAIL][101] ([i915#4312] / [i915#4991])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-kbl-soraka/igt@[email protected]
- fi-kbl-7567u: NOTRUN -> [FAIL][102] ([i915#4312])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-kbl-7567u/igt@[email protected]
- fi-cfl-8700k: NOTRUN -> [FAIL][103] ([i915#4312])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-cfl-8700k/igt@[email protected]
- fi-bsw-nick: NOTRUN -> [FAIL][104] ([i915#4312])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-bsw-nick/igt@[email protected]
- fi-rkl-11600: NOTRUN -> [FAIL][105] ([i915#4312])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-rkl-11600/igt@[email protected]
- fi-bsw-kefka: NOTRUN -> [FAIL][106] ([i915#4312])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-bsw-kefka/igt@[email protected]
- fi-adl-ddr5: NOTRUN -> [FAIL][107] ([i915#4312])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-adl-ddr5/igt@[email protected]
- fi-cfl-guc: NOTRUN -> [FAIL][108] ([i915#4312])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/fi-cfl-guc/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#7350]: https://gitlab.freedesktop.org/drm/intel/issues/7350
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7763]: https://gitlab.freedesktop.org/drm/intel/issues/7763

Build changes
-------------

* Linux: CI_DRM_12594 -> Patchwork_111454v3

CI-20190529: 20190529
CI_DRM_12594: 5cec9cff5436577179bab7b52de0465ba169691a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7121: aa16e81259f59734230d441905b9d0f605e4a4b5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111454v3: 5cec9cff5436577179bab7b52de0465ba169691a @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

bbfe814bb44f drm/i915/guc: Add a debug print on GuC triggered reset 820c31964ca3 drm/i915/guc: Look for a guilty context when an engine reset fails 3c3cc3702cb7 drm/i915: Allow error capture of a pending request 7b9165e8a786 drm/i915: Allow error capture without a request 94efccec5768 drm/i915: Fix request locking during error capture & debugfs dump

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111454v3/index.html