Skip to contentSkip to conversation

baseband/acc: ACC200 PMD refactor and rename

PATCH Applied Nicolas Chautru 3 participants 16 messages Jan 17, 2023 – Feb 7, 2023 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

cover baseband/acc: ACC200 PMD refactor and rename

In this serie we are renaming the ACC200PMD to a more generic VRB PMD (Intel vRAN Boost). The 2nd commit is also making sure this is future prood to be able to support both the first implementation of VRB (The one in SPR-EE) as well as future implementations of integrated product.
Most of changes are really rename to a large extend aanmaking the distinction of what is specific to current implementation (VRB1) vs more generic functions (VRB) which would be common to VRB1, VRB2, etc...

Nicolas Chautru (6):
baseband/acc: file renaming from acc200 to generic vrb baseband/acc: extension of the device structure baseband/acc: adding prefix to VRB1 registers baseband/acc: update prefix for VRB PMD functions baseband/acc: rename of remaining acc200 prefix to vrb1
doc: updated naming convention for acc200 PMD

 .../bbdevs/features/{acc200.ini => vrb1.ini}  |   2 +-
 doc/guides/bbdevs/{acc200.rst => vrb1.rst}    |  33 +-
 drivers/baseband/acc/acc200_pf_enum.h         | 108 ---
 drivers/baseband/acc/acc200_pmd.h             | 196 -----
 drivers/baseband/acc/acc200_vf_enum.h         |  83 --
 drivers/baseband/acc/acc_common.h             |  18 +-
 drivers/baseband/acc/meson.build              |   2 +-
 drivers/baseband/acc/rte_acc100_pmd.c         |   6 +-
 .../acc/{rte_acc200_pmd.c => rte_vrb_pmd.c}   | 820 +++++++++---------
 drivers/baseband/acc/vrb1_pf_enum.h           | 108 +++
 drivers/baseband/acc/vrb1_vf_enum.h           |  83 ++
 .../baseband/acc/{acc200_cfg.h => vrb_cfg.h}  |  16 +-
 drivers/baseband/acc/vrb_pmd.h                | 208 +++++
 13 files changed, 843 insertions(+), 840 deletions(-)
 rename doc/guides/bbdevs/features/{acc200.ini => vrb1.ini} (83%)
 rename doc/guides/bbdevs/{acc200.rst => vrb1.rst} (90%)
 delete mode 100644 drivers/baseband/acc/acc200_pf_enum.h
 delete mode 100644 drivers/baseband/acc/acc200_pmd.h
 delete mode 100644 drivers/baseband/acc/acc200_vf_enum.h
 rename drivers/baseband/acc/{rte_acc200_pmd.c => rte_vrb_pmd.c} (82%)
 create mode 100644 drivers/baseband/acc/vrb1_pf_enum.h
 create mode 100644 drivers/baseband/acc/vrb1_vf_enum.h
 rename drivers/baseband/acc/{acc200_cfg.h => vrb_cfg.h} (65%)
 create mode 100644 drivers/baseband/acc/vrb_pmd.h
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/6 baseband/acc: file renaming from acc200 to generic vrb

Renaming files as part of refactor to have generic intel vRAN Boost PMD (vrb) whose acc200 is only one variant.

---
 drivers/baseband/acc/meson.build                         | 2 +-
 drivers/baseband/acc/rte_acc100_pmd.c                    | 2 +-
 drivers/baseband/acc/{rte_acc200_pmd.c => rte_vrb_pmd.c} | 2 +-
 drivers/baseband/acc/{acc200_cfg.h => vrb_cfg.h}         | 6 +++---
 drivers/baseband/acc/{acc200_pmd.h => vrb_pmd.h}         | 8 ++++----
 5 files changed, 10 insertions(+), 10 deletions(-)
 rename drivers/baseband/acc/{rte_acc200_pmd.c => rte_vrb_pmd.c} (99%)
 rename drivers/baseband/acc/{acc200_cfg.h => vrb_cfg.h} (90%)
 rename drivers/baseband/acc/{acc200_pmd.h => vrb_pmd.h} (98%)
drivers/baseband/acc/meson.build +1 -1
index 77c393b533..966cd65c79 100644
@@ -3,6 +3,6 @@
 
 deps += ['bbdev', 'bus_pci']
 
-sources = files('rte_acc100_pmd.c', 'rte_acc200_pmd.c')
+sources = files('rte_acc100_pmd.c', 'rte_vrb_pmd.c')
 
 headers = files('rte_acc_cfg.h')
drivers/baseband/acc/rte_acc100_pmd.c +1 -1
index b3164529dd..e5fe27a06b 100644
@@ -21,7 +21,7 @@
 #include <rte_bbdev_pmd.h>
 #include "acc100_pmd.h"
 #include "acc101_pmd.h"
-#include "acc200_cfg.h"
+#include "vrb_cfg.h"
 
 #ifdef RTE_LIBRTE_BBDEV_DEBUG
 RTE_LOG_REGISTER_DEFAULT(acc100_logtype, DEBUG);
drivers/baseband/acc/rte_vrb_pmd.c renamed from drivers/baseband/acc/rte_acc200_pmd.c +1 -1
similarity index 99%
rename from drivers/baseband/acc/rte_acc200_pmd.c
rename to drivers/baseband/acc/rte_vrb_pmd.c
index 204f37349b..8e61847dd2 100644
@@ -19,7 +19,7 @@
 
 #include <rte_bbdev.h>
 #include <rte_bbdev_pmd.h>
-#include "acc200_pmd.h"
+#include "vrb_pmd.h"
 
 #ifdef RTE_LIBRTE_BBDEV_DEBUG
 RTE_LOG_REGISTER_DEFAULT(acc200_logtype, DEBUG);
drivers/baseband/acc/vrb_cfg.h renamed from drivers/baseband/acc/acc200_cfg.h +3 -3
similarity index 90%
rename from drivers/baseband/acc/acc200_cfg.h
rename to drivers/baseband/acc/vrb_cfg.h
index d77506b560..2b31244818 100644
@@ -2,8 +2,8 @@
  * Copyright(c) 2022 Intel Corporation
  */
 
-#ifndef _ACC200_CFG_H_
-#define _ACC200_CFG_H_
+#ifndef _VRB_CFG_H_
+#define _VRB_CFG_H_
 
 /**
  * @file acc200_cfg.h
@@ -29,4 +29,4 @@
 int
 acc200_configure(const char *dev_name, struct rte_acc_conf *conf);
 
-#endif /* _ACC200_CFG_H_ */
+#endif /* _VRB_CFG_H_ */
drivers/baseband/acc/vrb_pmd.h renamed from drivers/baseband/acc/acc200_pmd.h +4 -4
similarity index 98%
rename from drivers/baseband/acc/acc200_pmd.h
rename to drivers/baseband/acc/vrb_pmd.h
index f3f2627ae9..c37bd4d57b 100644
@@ -2,13 +2,13 @@
  * Copyright(c) 2022 Intel Corporation
  */
 
-#ifndef _RTE_ACC200_PMD_H_
-#define _RTE_ACC200_PMD_H_
+#ifndef _VRB_PMD_H_
+#define _VRB_PMD_H_
 
 #include "acc_common.h"
 #include "acc200_pf_enum.h"
 #include "acc200_vf_enum.h"
-#include "acc200_cfg.h"
+#include "vrb_cfg.h"
 
 /* Helper macro for logging */
 #define rte_bbdev_log(level, fmt, ...) \
@@ -193,4 +193,4 @@ static const struct acc200_registry_addr vf_reg_addr = {
 	.pmon_ctrl_c = HWVfPmCCntrlRegVf,
 };
 
-#endif /* _RTE_ACC200_PMD_H_ */
+#endif /* _VRB_PMD_H_ */
Signature · 1 line
2.34.1
Reviewed-by on v1 1/6
#2 lore raw

Re: [PATCH v1 1/6] baseband/acc: file renaming from acc200 to generic vrb

Quoted 11 lines · Nicolas Chautru

Renaming files as part of refactor to have generic intel vRAN Boost PMD (vrb) whose acc200 is only one variant.

---
  drivers/baseband/acc/meson.build                         | 2 +-
  drivers/baseband/acc/rte_acc100_pmd.c                    | 2 +-
  drivers/baseband/acc/{rte_acc200_pmd.c => rte_vrb_pmd.c} | 2 +-
  drivers/baseband/acc/{acc200_cfg.h => vrb_cfg.h}         | 6 +++---
  drivers/baseband/acc/{acc200_pmd.h => vrb_pmd.h}         | 8 ++++----
  5 files changed, 10 insertions(+), 10 deletions(-)
Quoted 4 lines

rename drivers/baseband/acc/{rte_acc200_pmd.c => rte_vrb_pmd.c} (99%) rename drivers/baseband/acc/{acc200_cfg.h => vrb_cfg.h} (90%) rename drivers/baseband/acc/{acc200_pmd.h => vrb_pmd.h} (98%)

Thanks,
Maxime

#3 lore raw

PATCH 2/6 baseband/acc: extension of the device structure

In reply to Nicolas Chautru

Make the device structure more generic so that to
have personnalization of the VRB PMD to support
multiple variants.

---
 drivers/baseband/acc/acc200_pf_enum.h |   8 +-
 drivers/baseband/acc/acc_common.h     |   6 ++
 drivers/baseband/acc/rte_vrb_pmd.c    | 134 ++++++++++++--------------
 drivers/baseband/acc/vrb_pmd.h        |  27 ++++--
 4 files changed, 92 insertions(+), 83 deletions(-)
drivers/baseband/acc/acc200_pf_enum.h +4 -4
index e52d8f5b19..be1f8dcc8e 100644
@@ -62,10 +62,10 @@ enum {
 	HWPfDmaFec4GdlDescBaseHiRegVf         =  0x00B88084,
 	HWPfDmaFec4GdlRespPtrLoRegVf          =  0x00B88088,
 	HWPfDmaFec4GdlRespPtrHiRegVf          =  0x00B8808C,
-	HWPDmaFftDescBaseLoRegVf              =  0x00B880A0,
-	HWPDmaFftDescBaseHiRegVf              =  0x00B880A4,
-	HWPDmaFftRespPtrLoRegVf               =  0x00B880A8,
-	HWPDmaFftRespPtrHiRegVf               =  0x00B880AC,
+	HWPfDmaFftDescBaseLoRegVf             =  0x00B880A0,
+	HWPfDmaFftDescBaseHiRegVf             =  0x00B880A4,
+	HWPfDmaFftRespPtrLoRegVf              =  0x00B880A8,
+	HWPfDmaFftRespPtrHiRegVf              =  0x00B880AC,
 	HWPfQosmonAEvalOverflow0              =  0x00B90008,
 	HWPfPermonACntrlRegVf                 =  0x00B98000,
 	HWPfQosmonBEvalOverflow0              =  0x00BA0008,
drivers/baseband/acc/acc_common.h +6 -0
index 84a428ee1d..4ca5d704e6 100644
@@ -518,6 +518,8 @@ enum {
 typedef void (*acc10x_fcw_ld_fill_fun_t)(struct rte_bbdev_dec_op *op,
 		struct acc_fcw_ld *fcw,
 		union acc_harq_layout_data *harq_layout);
+typedef uint32_t (*queue_offset_fun_t)(bool pf_device, uint8_t vf_id,
+		uint8_t qgrp_id, uint16_t aq_id);
 
 /* Private data structure for each ACC100 device */
 struct acc_device {
@@ -551,7 +553,11 @@ struct acc_device {
 	bool pf_device; /**< True if this is a PF ACC100 device */
 	bool configured; /**< True if this ACC100 device is configured */
 	uint16_t device_variant;  /**< Device variant */
+	const struct acc_registry_addr *reg_addr;
 	acc10x_fcw_ld_fill_fun_t fcw_ld_fill;  /**< 5GUL FCW generation function */
+	queue_offset_fun_t queue_offset;  /* Device specific queue offset */
+	uint16_t num_qgroups;
+	uint16_t num_aqs;
 };
 
 /* Structure associated with each queue. */
drivers/baseband/acc/rte_vrb_pmd.c +63 -71

283 lines not on this page · raw message

drivers/baseband/acc/vrb_pmd.h +19 -8
index c37bd4d57b..72f92e8414 100644
@@ -32,6 +32,8 @@
 #define RTE_ACC200_PF_DEVICE_ID        (0x57C0)
 #define RTE_ACC200_VF_DEVICE_ID        (0x57C1)
 
+#define ACC200_VARIANT               2
+
 #define ACC200_MAX_PF_MSIX            (256+32)
 #define ACC200_MAX_VF_MSIX            (256+7)
 
@@ -86,7 +88,7 @@
 #define ACC200_STATUS_WAIT      10
 #define ACC200_STATUS_TO        100
 
-struct acc200_registry_addr {
+struct acc_registry_addr {
 	unsigned int dma_ring_dl5g_hi;
 	unsigned int dma_ring_dl5g_lo;
 	unsigned int dma_ring_ul5g_hi;
@@ -116,13 +118,16 @@ struct acc200_registry_addr {
 	unsigned int depth_log1_offset;
 	unsigned int qman_group_func;
 	unsigned int hi_mode;
+	unsigned int pf_mode;
 	unsigned int pmon_ctrl_a;
 	unsigned int pmon_ctrl_b;
 	unsigned int pmon_ctrl_c;
+	unsigned int vf2pf_doorbell;
+	unsigned int pf2vf_doorbell;
 };
 
 /* Structure holding registry addresses for PF */
-static const struct acc200_registry_addr pf_reg_addr = {
+static const struct acc_registry_addr acc200_pf_reg_addr = {
 	.dma_ring_dl5g_hi = HWPfDmaFec5GdlDescBaseHiRegVf,
 	.dma_ring_dl5g_lo = HWPfDmaFec5GdlDescBaseLoRegVf,
 	.dma_ring_ul5g_hi = HWPfDmaFec5GulDescBaseHiRegVf,
@@ -131,9 +136,9 @@ static const struct acc200_registry_addr pf_reg_addr = {
 	.dma_ring_dl4g_lo = HWPfDmaFec4GdlDescBaseLoRegVf,
 	.dma_ring_ul4g_hi = HWPfDmaFec4GulDescBaseHiRegVf,
 	.dma_ring_ul4g_lo = HWPfDmaFec4GulDescBaseLoRegVf,
-	.dma_ring_fft_hi = HWPDmaFftDescBaseHiRegVf,
-	.dma_ring_fft_lo = HWPDmaFftDescBaseLoRegVf,
-	.ring_size = HWPfQmgrRingSizeVf,
+	.dma_ring_fft_hi = HWPfDmaFftDescBaseHiRegVf,
+	.dma_ring_fft_lo = HWPfDmaFftDescBaseLoRegVf,
+	.ring_size =      HWPfQmgrRingSizeVf,
 	.info_ring_hi = HWPfHiInfoRingBaseHiRegPf,
 	.info_ring_lo = HWPfHiInfoRingBaseLoRegPf,
 	.info_ring_en = HWPfHiInfoRingIntWrEnRegPf,
@@ -146,19 +151,22 @@ static const struct acc200_registry_addr pf_reg_addr = {
 	.tail_ptrs_dl4g_lo = HWPfDmaFec4GdlRespPtrLoRegVf,
 	.tail_ptrs_ul4g_hi = HWPfDmaFec4GulRespPtrHiRegVf,
 	.tail_ptrs_ul4g_lo = HWPfDmaFec4GulRespPtrLoRegVf,
-	.tail_ptrs_fft_hi = HWPDmaFftRespPtrHiRegVf,
-	.tail_ptrs_fft_lo = HWPDmaFftRespPtrLoRegVf,
+	.tail_ptrs_fft_hi = HWPfDmaFftRespPtrHiRegVf,
+	.tail_ptrs_fft_lo = HWPfDmaFftRespPtrLoRegVf,
 	.depth_log0_offset = HWPfQmgrGrpDepthLog20Vf,
 	.depth_log1_offset = HWPfQmgrGrpDepthLog21Vf,
 	.qman_group_func = HWPfQmgrGrpFunction0,
 	.hi_mode = HWPfHiMsixVectorMapperPf,
+	.pf_mode = HWPfHiPfMode,
 	.pmon_ctrl_a = HWPfPermonACntrlRegVf,
 	.pmon_ctrl_b = HWPfPermonBCntrlRegVf,
 	.pmon_ctrl_c = HWPfPermonCCntrlRegVf,
+	.vf2pf_doorbell = 0,
+	.pf2vf_doorbell = 0,
 };
 
 /* Structure holding registry addresses for VF */
-static const struct acc200_registry_addr vf_reg_addr = {
+static const struct acc_registry_addr acc200_vf_reg_addr = {
 	.dma_ring_dl5g_hi = HWVfDmaFec5GdlDescBaseHiRegVf,
 	.dma_ring_dl5g_lo = HWVfDmaFec5GdlDescBaseLoRegVf,
 	.dma_ring_ul5g_hi = HWVfDmaFec5GulDescBaseHiRegVf,
@@ -188,9 +196,12 @@ static const struct acc200_registry_addr vf_reg_addr = {
 	.depth_log1_offset = HWVfQmgrGrpDepthLog21Vf,
 	.qman_group_func = HWVfQmgrGrpFunction0Vf,
 	.hi_mode = HWVfHiMsixVectorMapperVf,
+	.pf_mode = 0,
 	.pmon_ctrl_a = HWVfPmACntrlRegVf,
 	.pmon_ctrl_b = HWVfPmBCntrlRegVf,
 	.pmon_ctrl_c = HWVfPmCCntrlRegVf,
+	.vf2pf_doorbell = HWVfHiVfToPfDbellVf,
+	.pf2vf_doorbell = HWVfHiPfToVfDbellVf,
 };
 
 #endif /* _VRB_PMD_H_ */
Signature · 1 line
2.34.1
Reviewed-by on v1 2/6
#4 lore raw

Re: [PATCH v1 2/6] baseband/acc: extension of the device structure

Quoted 4 lines · Nicolas Chautru

Make the device structure more generic so that to
have personnalization of the VRB PMD to support
multiple variants.

Quoted 8 lines
---
  drivers/baseband/acc/acc200_pf_enum.h |   8 +-
  drivers/baseband/acc/acc_common.h     |   6 ++
  drivers/baseband/acc/rte_vrb_pmd.c    | 134 ++++++++++++--------------
  drivers/baseband/acc/vrb_pmd.h        |  27 ++++--
  4 files changed, 92 insertions(+), 83 deletions(-)

Thanks,
Maxime

#5 lore raw

PATCH 3/6 baseband/acc: adding prefix to VRB1 registers

In reply to Nicolas Chautru

Adding prefix to register names specific to VRB1 (ACC200) to avoid future enum collision.

---
 drivers/baseband/acc/acc200_pf_enum.h | 174 +++++++++++++-------------
 drivers/baseband/acc/acc200_vf_enum.h | 128 +++++++++----------
 drivers/baseband/acc/rte_vrb_pmd.c    | 136 ++++++++++----------
 drivers/baseband/acc/vrb_pmd.h        | 134 ++++++++++----------
 4 files changed, 285 insertions(+), 287 deletions(-)
drivers/baseband/acc/acc200_pf_enum.h +87 -87
index be1f8dcc8e..fc38465705 100644
@@ -12,97 +12,97 @@
  * Variable names are as is
  */
 enum {
-	HWPfQmgrEgressQueuesTemplate          =  0x0007FC00,
-	HWPfQmgrIngressAq                     =  0x00080000,
-	HWPfQmgrDepthLog2Grp                  =  0x00A00200,
-	HWPfQmgrTholdGrp                      =  0x00A00300,
-	HWPfQmgrGrpTmplateReg0Indx            =  0x00A00600,
-	HWPfQmgrGrpTmplateReg1Indx            =  0x00A00700,
-	HWPfQmgrGrpTmplateReg2indx            =  0x00A00800,
-	HWPfQmgrGrpTmplateReg3Indx            =  0x00A00900,
-	HWPfQmgrGrpTmplateReg4Indx            =  0x00A00A00,
-	HWPfQmgrVfBaseAddr                    =  0x00A01000,
-	HWPfQmgrArbQDepthGrp                  =  0x00A02F00,
-	HWPfQmgrGrpFunction0                  =  0x00A02F40,
-	HWPfQmgrGrpFunction1                  =  0x00A02F44,
-	HWPfQmgrGrpPriority                   =  0x00A02F48,
-	HWPfQmgrAqEnableVf                    =  0x00A10000,
-	HWPfQmgrRingSizeVf                    =  0x00A20004,
-	HWPfQmgrGrpDepthLog20Vf               =  0x00A20008,
-	HWPfQmgrGrpDepthLog21Vf               =  0x00A2000C,
-	HWPfFabricM2iBufferReg                =  0x00B30000,
-	HWPfFabricI2Mdma_weight               =  0x00B31044,
-	HwPfFecUl5gIbDebugReg                 =  0x00B40200,
-	HWPfFftConfig0                        =  0x00B58004,
-	HWPfFftRamPageAccess                  =  0x00B5800C,
-	HWPfFftRamOff                         =  0x00B58800,
-	HWPfDmaConfig0Reg                     =  0x00B80000,
-	HWPfDmaConfig1Reg                     =  0x00B80004,
-	HWPfDmaQmgrAddrReg                    =  0x00B80008,
-	HWPfDmaAxcacheReg                     =  0x00B80010,
-	HWPfDmaAxiControl                     =  0x00B8002C,
-	HWPfDmaQmanen                         =  0x00B80040,
-	HWPfDma4gdlIbThld                     =  0x00B800CC,
-	HWPfDmaCfgRrespBresp                  =  0x00B80814,
-	HWPfDmaDescriptorSignatuture          =  0x00B80868,
-	HWPfDmaErrorDetectionEn               =  0x00B80870,
-	HWPfDmaFec5GulDescBaseLoRegVf         =  0x00B88020,
-	HWPfDmaFec5GulDescBaseHiRegVf         =  0x00B88024,
-	HWPfDmaFec5GulRespPtrLoRegVf          =  0x00B88028,
-	HWPfDmaFec5GulRespPtrHiRegVf          =  0x00B8802C,
-	HWPfDmaFec5GdlDescBaseLoRegVf         =  0x00B88040,
-	HWPfDmaFec5GdlDescBaseHiRegVf         =  0x00B88044,
-	HWPfDmaFec5GdlRespPtrLoRegVf          =  0x00B88048,
-	HWPfDmaFec5GdlRespPtrHiRegVf          =  0x00B8804C,
-	HWPfDmaFec4GulDescBaseLoRegVf         =  0x00B88060,
-	HWPfDmaFec4GulDescBaseHiRegVf         =  0x00B88064,
-	HWPfDmaFec4GulRespPtrLoRegVf          =  0x00B88068,
-	HWPfDmaFec4GulRespPtrHiRegVf          =  0x00B8806C,
-	HWPfDmaFec4GdlDescBaseLoRegVf         =  0x00B88080,
-	HWPfDmaFec4GdlDescBaseHiRegVf         =  0x00B88084,
-	HWPfDmaFec4GdlRespPtrLoRegVf          =  0x00B88088,
-	HWPfDmaFec4GdlRespPtrHiRegVf          =  0x00B8808C,
-	HWPfDmaFftDescBaseLoRegVf             =  0x00B880A0,
-	HWPfDmaFftDescBaseHiRegVf             =  0x00B880A4,
-	HWPfDmaFftRespPtrLoRegVf              =  0x00B880A8,
-	HWPfDmaFftRespPtrHiRegVf              =  0x00B880AC,
-	HWPfQosmonAEvalOverflow0              =  0x00B90008,
-	HWPfPermonACntrlRegVf                 =  0x00B98000,
-	HWPfQosmonBEvalOverflow0              =  0x00BA0008,
-	HWPfPermonBCntrlRegVf                 =  0x00BA8000,
-	HWPfPermonCCntrlRegVf                 =  0x00BB8000,
-	HWPfHiInfoRingBaseLoRegPf             =  0x00C84014,
-	HWPfHiInfoRingBaseHiRegPf             =  0x00C84018,
-	HWPfHiInfoRingPointerRegPf            =  0x00C8401C,
-	HWPfHiInfoRingIntWrEnRegPf            =  0x00C84020,
-	HWPfHiBlockTransmitOnErrorEn          =  0x00C84038,
-	HWPfHiCfgMsiIntWrEnRegPf              =  0x00C84040,
-	HWPfHiMsixVectorMapperPf              =  0x00C84060,
-	HWPfHiPfMode                          =  0x00C84108,
-	HWPfHiClkGateHystReg                  =  0x00C8410C,
-	HWPfHiMsiDropEnableReg                =  0x00C84114,
-	HWPfHiSectionPowerGatingReq           =  0x00C84128,
-	HWPfHiSectionPowerGatingAck           =  0x00C8412C,
+	VRB1_PfQmgrEgressQueuesTemplate          =  0x0007FC00,
+	VRB1_PfQmgrIngressAq                     =  0x00080000,
+	VRB1_PfQmgrDepthLog2Grp                  =  0x00A00200,
+	VRB1_PfQmgrTholdGrp                      =  0x00A00300,
+	VRB1_PfQmgrGrpTmplateReg0Indx            =  0x00A00600,
+	VRB1_PfQmgrGrpTmplateReg1Indx            =  0x00A00700,
+	VRB1_PfQmgrGrpTmplateReg2indx            =  0x00A00800,
+	VRB1_PfQmgrGrpTmplateReg3Indx            =  0x00A00900,
+	VRB1_PfQmgrGrpTmplateReg4Indx            =  0x00A00A00,
+	VRB1_PfQmgrVfBaseAddr                    =  0x00A01000,
+	VRB1_PfQmgrArbQDepthGrp                  =  0x00A02F00,
+	VRB1_PfQmgrGrpFunction0                  =  0x00A02F40,
+	VRB1_PfQmgrGrpFunction1                  =  0x00A02F44,
+	VRB1_PfQmgrGrpPriority                   =  0x00A02F48,
+	VRB1_PfQmgrAqEnableVf                    =  0x00A10000,
+	VRB1_PfQmgrRingSizeVf                    =  0x00A20004,
+	VRB1_PfQmgrGrpDepthLog20Vf               =  0x00A20008,
+	VRB1_PfQmgrGrpDepthLog21Vf               =  0x00A2000C,
+	VRB1_PfFabricM2iBufferReg                =  0x00B30000,
+	VRB1_PfFabricI2Mdma_weight               =  0x00B31044,
+	VRB1_PfFecUl5gIbDebugReg                 =  0x00B40200,
+	VRB1_PfFftConfig0                        =  0x00B58004,
+	VRB1_PfFftRamPageAccess                  =  0x00B5800C,
+	VRB1_PfFftRamOff                         =  0x00B58800,
+	VRB1_PfDmaConfig0Reg                     =  0x00B80000,
+	VRB1_PfDmaConfig1Reg                     =  0x00B80004,
+	VRB1_PfDmaQmgrAddrReg                    =  0x00B80008,
+	VRB1_PfDmaAxcacheReg                     =  0x00B80010,
+	VRB1_PfDmaAxiControl                     =  0x00B8002C,
+	VRB1_PfDmaQmanen                         =  0x00B80040,
+	VRB1_PfDma4gdlIbThld                     =  0x00B800CC,
+	VRB1_PfDmaCfgRrespBresp                  =  0x00B80814,
+	VRB1_PfDmaDescriptorSignatuture          =  0x00B80868,
+	VRB1_PfDmaErrorDetectionEn               =  0x00B80870,
+	VRB1_PfDmaFec5GulDescBaseLoRegVf         =  0x00B88020,
+	VRB1_PfDmaFec5GulDescBaseHiRegVf         =  0x00B88024,
+	VRB1_PfDmaFec5GulRespPtrLoRegVf          =  0x00B88028,
+	VRB1_PfDmaFec5GulRespPtrHiRegVf          =  0x00B8802C,
+	VRB1_PfDmaFec5GdlDescBaseLoRegVf         =  0x00B88040,
+	VRB1_PfDmaFec5GdlDescBaseHiRegVf         =  0x00B88044,
+	VRB1_PfDmaFec5GdlRespPtrLoRegVf          =  0x00B88048,
+	VRB1_PfDmaFec5GdlRespPtrHiRegVf          =  0x00B8804C,
+	VRB1_PfDmaFec4GulDescBaseLoRegVf         =  0x00B88060,
+	VRB1_PfDmaFec4GulDescBaseHiRegVf         =  0x00B88064,
+	VRB1_PfDmaFec4GulRespPtrLoRegVf          =  0x00B88068,
+	VRB1_PfDmaFec4GulRespPtrHiRegVf          =  0x00B8806C,
+	VRB1_PfDmaFec4GdlDescBaseLoRegVf         =  0x00B88080,
+	VRB1_PfDmaFec4GdlDescBaseHiRegVf         =  0x00B88084,
+	VRB1_PfDmaFec4GdlRespPtrLoRegVf          =  0x00B88088,
+	VRB1_PfDmaFec4GdlRespPtrHiRegVf          =  0x00B8808C,
+	VRB1_PfDmaFftDescBaseLoRegVf             =  0x00B880A0,
+	VRB1_PfDmaFftDescBaseHiRegVf             =  0x00B880A4,
+	VRB1_PfDmaFftRespPtrLoRegVf              =  0x00B880A8,
+	VRB1_PfDmaFftRespPtrHiRegVf              =  0x00B880AC,
+	VRB1_PfQosmonAEvalOverflow0              =  0x00B90008,
+	VRB1_PfPermonACntrlRegVf                 =  0x00B98000,
+	VRB1_PfQosmonBEvalOverflow0              =  0x00BA0008,
+	VRB1_PfPermonBCntrlRegVf                 =  0x00BA8000,
+	VRB1_PfPermonCCntrlRegVf                 =  0x00BB8000,
+	VRB1_PfHiInfoRingBaseLoRegPf             =  0x00C84014,
+	VRB1_PfHiInfoRingBaseHiRegPf             =  0x00C84018,
+	VRB1_PfHiInfoRingPointerRegPf            =  0x00C8401C,
+	VRB1_PfHiInfoRingIntWrEnRegPf            =  0x00C84020,
+	VRB1_PfHiBlockTransmitOnErrorEn          =  0x00C84038,
+	VRB1_PfHiCfgMsiIntWrEnRegPf              =  0x00C84040,
+	VRB1_PfHiMsixVectorMapperPf              =  0x00C84060,
+	VRB1_PfHiPfMode                          =  0x00C84108,
+	VRB1_PfHiClkGateHystReg                  =  0x00C8410C,
+	VRB1_PfHiMsiDropEnableReg                =  0x00C84114,
+	VRB1_PfHiSectionPowerGatingReq           =  0x00C84128,
+	VRB1_PfHiSectionPowerGatingAck           =  0x00C8412C,
 };
 
 /* TIP PF Interrupt numbers */
 enum {
-	ACC200_PF_INT_QMGR_AQ_OVERFLOW = 0,
-	ACC200_PF_INT_DOORBELL_VF_2_PF = 1,
-	ACC200_PF_INT_ILLEGAL_FORMAT = 2,
-	ACC200_PF_INT_QMGR_DISABLED_ACCESS = 3,
-	ACC200_PF_INT_QMGR_AQ_OVERTHRESHOLD = 4,
-	ACC200_PF_INT_DMA_DL_DESC_IRQ = 5,
-	ACC200_PF_INT_DMA_UL_DESC_IRQ = 6,
-	ACC200_PF_INT_DMA_FFT_DESC_IRQ = 7,
-	ACC200_PF_INT_DMA_UL5G_DESC_IRQ = 8,
-	ACC200_PF_INT_DMA_DL5G_DESC_IRQ = 9,
-	ACC200_PF_INT_DMA_MLD_DESC_IRQ = 10,
-	ACC200_PF_INT_ARAM_ECC_1BIT_ERR = 11,
-	ACC200_PF_INT_PARITY_ERR = 12,
-	ACC200_PF_INT_QMGR_ERR = 13,
-	ACC200_PF_INT_INT_REQ_OVERFLOW = 14,
-	ACC200_PF_INT_APB_TIMEOUT = 15,
+	ACC_PF_INT_QMGR_AQ_OVERFLOW = 0,
+	ACC_PF_INT_DOORBELL_VF_2_PF = 1,
+	ACC_PF_INT_ILLEGAL_FORMAT = 2,
+	ACC_PF_INT_QMGR_DISABLED_ACCESS = 3,
+	ACC_PF_INT_QMGR_AQ_OVERTHRESHOLD = 4,
+	ACC_PF_INT_DMA_DL_DESC_IRQ = 5,
+	ACC_PF_INT_DMA_UL_DESC_IRQ = 6,
+	ACC_PF_INT_DMA_FFT_DESC_IRQ = 7,
+	ACC_PF_INT_DMA_UL5G_DESC_IRQ = 8,
+	ACC_PF_INT_DMA_DL5G_DESC_IRQ = 9,
+	ACC_PF_INT_DMA_MLD_DESC_IRQ = 10,
+	ACC_PF_INT_ARAM_ECC_1BIT_ERR = 11,
+	ACC_PF_INT_PARITY_ERR = 12,
+	ACC_PF_INT_QMGR_ERR = 13,
+	ACC_PF_INT_INT_REQ_OVERFLOW = 14,
+	ACC_PF_INT_APB_TIMEOUT = 15,
 };
 
 #endif /* ACC200_PF_ENUM_H */
drivers/baseband/acc/acc200_vf_enum.h +64 -64

138 lines not on this page · raw message

drivers/baseband/acc/rte_vrb_pmd.c +67 -69

362 lines not on this page · raw message

drivers/baseband/acc/vrb_pmd.h +67 -67

147 lines not on this page · raw message

Signature · 1 line
2.34.1
Reviewed-by on v1 3/6
#6 lore raw

Re: [PATCH v1 3/6] baseband/acc: adding prefix to VRB1 registers

Quoted 11 lines · Nicolas Chautru

Adding prefix to register names specific to VRB1 (ACC200) to avoid future enum collision.

---
  drivers/baseband/acc/acc200_pf_enum.h | 174 +++++++++++++-------------
  drivers/baseband/acc/acc200_vf_enum.h | 128 +++++++++----------
  drivers/baseband/acc/rte_vrb_pmd.c    | 136 ++++++++++----------
  drivers/baseband/acc/vrb_pmd.h        | 134 ++++++++++----------
  4 files changed, 285 insertions(+), 287 deletions(-)

Thanks,
Maxime

#7 lore raw

PATCH 4/6 baseband/acc: update prefix for VRB PMD functions

In reply to Nicolas Chautru

Include vrb_ prefix for all generic functions for VRB PMD.

---
 drivers/baseband/acc/rte_vrb_pmd.c | 248 ++++++++++++++---------------
 drivers/baseband/acc/vrb_pmd.h     |   2 +-
 2 files changed, 124 insertions(+), 126 deletions(-)
drivers/baseband/acc/rte_vrb_pmd.c +123 -125
index 01e018f233..c590ce5988 100644
@@ -22,21 +22,19 @@
 #include "vrb_pmd.h"
 
 #ifdef RTE_LIBRTE_BBDEV_DEBUG
-RTE_LOG_REGISTER_DEFAULT(acc200_logtype, DEBUG);
+RTE_LOG_REGISTER_DEFAULT(vrb_logtype, DEBUG);
 #else
-RTE_LOG_REGISTER_DEFAULT(acc200_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(vrb_logtype, NOTICE);
 #endif
 
 /* Calculate the offset of the enqueue register. */
 static inline uint32_t
-queue_offset(bool pf_device, uint8_t vf_id, uint8_t qgrp_id, uint16_t aq_id)
+acc200_queue_offset(bool pf_device, uint8_t vf_id, uint8_t qgrp_id, uint16_t aq_id)
 {
 	if (pf_device)
-		return ((vf_id << 12) + (qgrp_id << 7) + (aq_id << 3) +
-				VRB1_PfQmgrIngressAq);
+		return ((vf_id << 12) + (qgrp_id << 7) + (aq_id << 3) + VRB1_PfQmgrIngressAq);
 	else
-		return ((qgrp_id << 7) + (aq_id << 3) +
-				VRB1_VfQmgrIngressAq);
+		return ((qgrp_id << 7) + (aq_id << 3) + VRB1_VfQmgrIngressAq);
 }
 
 enum {UL_4G = 0, UL_5G, DL_4G, DL_5G, FFT, NUM_ACC};
@@ -156,14 +154,14 @@ updateQtop(uint8_t acc, uint8_t qg, struct rte_acc_conf *acc_conf, struct acc_de
 	if (q_top->first_qgroup_index == -1) {
 		q_top->first_qgroup_index = qg;
 		/* Can be optimized to assume all are enabled by default. */
-		reg = acc_reg_read(d, queue_offset(d->pf_device, 0, qg, d->num_aqs - 1));
+		reg = acc_reg_read(d, d->queue_offset(d->pf_device, 0, qg, d->num_aqs - 1));
 		if (reg & ACC_QUEUE_ENABLE) {
 			q_top->num_aqs_per_groups = d->num_aqs;
 			return;
 		}
 		q_top->num_aqs_per_groups = 0;
 		for (aq = 0; aq < d->num_aqs; aq++) {
-			reg = acc_reg_read(d, queue_offset(d->pf_device, 0, qg, aq));
+			reg = acc_reg_read(d, d->queue_offset(d->pf_device, 0, qg, aq));
 			if (reg & ACC_QUEUE_ENABLE)
 				q_top->num_aqs_per_groups++;
 		}
@@ -172,13 +170,13 @@ updateQtop(uint8_t acc, uint8_t qg, struct rte_acc_conf *acc_conf, struct acc_de
 
 /* Check device Qmgr is enabled for protection */
 static inline bool
-acc200_check_device_enable(struct rte_bbdev *dev)
+vrb_check_device_enable(struct rte_bbdev *dev)
 {
 	uint32_t reg_aq, qg;
 	struct acc_device *d = dev->data->dev_private;
 
 	for (qg = 0; qg < d->num_qgroups; qg++) {
-		reg_aq = acc_reg_read(d, queue_offset(d->pf_device, 0, qg, 0));
+		reg_aq = acc_reg_read(d, d->queue_offset(d->pf_device, 0, qg, 0));
 		if (reg_aq & ACC_QUEUE_ENABLE)
 			return true;
 	}
@@ -187,7 +185,7 @@ acc200_check_device_enable(struct rte_bbdev *dev)
 
 /* Fetch configuration enabled for the PF/VF using MMIO Read (slow). */
 static inline void
-fetch_acc200_config(struct rte_bbdev *dev)
+fetch_acc_config(struct rte_bbdev *dev)
 {
 	struct acc_device *d = dev->data->dev_private;
 	struct rte_acc_conf *acc_conf = &d->acc_conf;
@@ -202,7 +200,7 @@ fetch_acc200_config(struct rte_bbdev *dev)
 	if (d->configured)
 		return;
 
-	if (!acc200_check_device_enable(dev)) {
+	if (!vrb_check_device_enable(dev)) {
 		rte_bbdev_log(NOTICE, "%s has no queue enabled and can't be used.",
 				dev->data->name);
 		return;
@@ -217,7 +215,7 @@ fetch_acc200_config(struct rte_bbdev *dev)
 	reg0 = acc_reg_read(d, d->reg_addr->qman_group_func);
 	reg1 = acc_reg_read(d, d->reg_addr->qman_group_func + 4);
 	for (qg = 0; qg < d->num_qgroups; qg++) {
-		reg_aq = acc_reg_read(d, queue_offset(d->pf_device, 0, qg, 0));
+		reg_aq = acc_reg_read(d, d->queue_offset(d->pf_device, 0, qg, 0));
 		if (reg_aq & ACC_QUEUE_ENABLE) {
 			if (qg < ACC_NUM_QGRPS_PER_WORD)
 				idx = (reg0 >> (qg * 4)) & 0x7;
@@ -275,14 +273,14 @@ fetch_acc200_config(struct rte_bbdev *dev)
 }
 
 static inline void
-acc200_vf2pf(struct acc_device *d, unsigned int payload)
+vrb_vf2pf(struct acc_device *d, unsigned int payload)
 {
 	acc_reg_write(d, d->reg_addr->vf2pf_doorbell, payload);
 }
 
 /* Request device status information. */
 static inline uint32_t
-acc200_device_status(struct rte_bbdev *dev)
+vrb_device_status(struct rte_bbdev *dev)
 {
 	struct acc_device *d = dev->data->dev_private;
 	uint32_t reg, time_out = 0;
@@ -290,7 +288,7 @@ acc200_device_status(struct rte_bbdev *dev)
 	if (d->pf_device)
 		return RTE_BBDEV_DEV_NOT_SUPPORTED;
 
-	acc200_vf2pf(d, ACC_VF2PF_STATUS_REQUEST);
+	vrb_vf2pf(d, ACC_VF2PF_STATUS_REQUEST);
 	reg = acc_reg_read(d, d->reg_addr->pf2vf_doorbell);
 	while ((time_out < ACC200_STATUS_TO) && (reg == RTE_BBDEV_DEV_NOSTATUS)) {
 		usleep(ACC200_STATUS_WAIT); /*< Wait or VF->PF->VF Comms */
@@ -303,7 +301,7 @@ acc200_device_status(struct rte_bbdev *dev)
 
 /* Checks PF Info Ring to find the interrupt cause and handles it accordingly. */
 static inline void
-acc200_check_ir(struct acc_device *acc200_dev)
+vrb_check_ir(struct acc_device *acc200_dev)
 {
 	volatile union acc_info_ring_data *ring_data;
 	uint16_t info_ring_head = acc200_dev->info_ring_head;
@@ -327,7 +325,7 @@ acc200_check_ir(struct acc_device *acc200_dev)
 
 /* Interrupt handler triggered by ACC200 dev for handling specific interrupt. */
 static void
-acc200_dev_interrupt_handler(void *cb_arg)
+vrb_dev_interrupt_handler(void *cb_arg)
 {
 	struct rte_bbdev *dev = cb_arg;
 	struct acc_device *acc200_dev = dev->data->dev_private;
@@ -440,7 +438,7 @@ allocate_info_ring(struct rte_bbdev *dev)
 
 /* Allocate 64MB memory used for all software rings. */
 static int
-acc200_setup_queues(struct rte_bbdev *dev, uint16_t num_queues, int socket_id)
+vrb_setup_queues(struct rte_bbdev *dev, uint16_t num_queues, int socket_id)
 {
 	uint32_t phys_low, phys_high, value;
 	struct acc_device *d = dev->data->dev_private;
@@ -459,7 +457,7 @@ acc200_setup_queues(struct rte_bbdev *dev, uint16_t num_queues, int socket_id)
 		return -ENODEV;
 	}
 
-	if (!acc200_check_device_enable(dev)) {
+	if (!vrb_check_device_enable(dev)) {
 		rte_bbdev_log(NOTICE, "%s has no queue enabled and can't be used.",
 				dev->data->name);
 		return -ENODEV;
@@ -487,7 +485,7 @@ acc200_setup_queues(struct rte_bbdev *dev, uint16_t num_queues, int socket_id)
 	phys_low  = (uint32_t)(d->sw_rings_iova & ~(ACC_SIZE_64MBYTE-1));
 
 	/* Read the populated cfg from ACC200 registers. */
-	fetch_acc200_config(dev);
+	fetch_acc_config(dev);
 
 	/* Start Pmon */
 	for (value = 0; value <= 2; value++) {
@@ -567,7 +565,7 @@ acc200_setup_queues(struct rte_bbdev *dev, uint16_t num_queues, int socket_id)
 
 	/* Mark as configured properly */
 	d->configured = true;
-	acc200_vf2pf(d, ACC_VF2PF_USING_VF);
+	vrb_vf2pf(d, ACC_VF2PF_USING_VF);
 
 	rte_bbdev_log_debug(
 			"ACC200 (%s) configured  sw_rings = %p, sw_rings_iova = %#"
@@ -585,7 +583,7 @@ acc200_setup_queues(struct rte_bbdev *dev, uint16_t num_queues, int socket_id)
 }
 
 static int
-acc200_intr_enable(struct rte_bbdev *dev)
+vrb_intr_enable(struct rte_bbdev *dev)
 {
 	int ret;
 	struct acc_device *d = dev->data->dev_private;
@@ -611,7 +609,7 @@ acc200_intr_enable(struct rte_bbdev *dev)
 			return ret;
 		}
 		ret = rte_intr_callback_register(dev->intr_handle,
-				acc200_dev_interrupt_handler, dev);
+				vrb_dev_interrupt_handler, dev);
 		if (ret < 0) {
 			rte_bbdev_log(ERR,
 					"Couldn't register interrupt callback for device: %s",
@@ -667,7 +665,7 @@ acc200_intr_enable(struct rte_bbdev *dev)
 			return ret;
 		}
 		ret = rte_intr_callback_register(dev->intr_handle,
-				acc200_dev_interrupt_handler, dev);
+				vrb_dev_interrupt_handler, dev);
 		if (ret < 0) {
 			rte_bbdev_log(ERR,
 					"Couldn't register interrupt callback for device: %s",
@@ -686,10 +684,10 @@ acc200_intr_enable(struct rte_bbdev *dev)
 
 /* Free memory used for software rings. */
 static int
-acc200_dev_close(struct rte_bbdev *dev)
+vrb_dev_close(struct rte_bbdev *dev)
 {
 	struct acc_device *d = dev->data->dev_private;
-	acc200_check_ir(d);
+	vrb_check_ir(d);
 	if (d->sw_rings_base != NULL) {
 		rte_free(d->tail_ptrs);
 		rte_free(d->info_ring);
@@ -711,7 +709,7 @@ acc200_dev_close(struct rte_bbdev *dev)
  * Note : Only supporting VF0 Bundle for PF mode.
  */
 static int
-acc200_find_free_queue_idx(struct rte_bbdev *dev,
+vrb_find_free_queue_idx(struct rte_bbdev *dev,
 		const struct rte_bbdev_queue_conf *conf)
 {
 	struct acc_device *d = dev->data->dev_private;
@@ -748,7 +746,7 @@ acc200_find_free_queue_idx(struct rte_bbdev *dev,
 
 /* Setup ACC200 queue. */
 static int
-acc200_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,
+vrb_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,
 		const struct rte_bbdev_queue_conf *conf)
 {
 	struct acc_device *d = dev->data->dev_private;
@@ -852,7 +850,7 @@ acc200_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,
 
 	q->op_type = conf->op_type;
 
-	q_idx = acc200_find_free_queue_idx(dev, conf);
+	q_idx = vrb_find_free_queue_idx(dev, conf);
 	if (q_idx == -1) {
 		ret = -EINVAL;
 		goto free_companion_ring_addr;
@@ -874,7 +872,7 @@ acc200_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,
 		q->aq_depth = (1 << d->acc_conf.q_fft.aq_depth_log2);
 
 	q->mmio_reg_enqueue = RTE_PTR_ADD(d->mmio_base,
-			queue_offset(d->pf_device,
+			d->queue_offset(d->pf_device,
 					q->vf_id, q->qgrp_id, q->aq_id));
 
 	rte_bbdev_log_debug(
@@ -903,7 +901,7 @@ acc200_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,
 }
 
 static inline void
-acc200_print_op(struct rte_bbdev_dec_op *op, enum rte_bbdev_op_type op_type,
+vrb_print_op(struct rte_bbdev_dec_op *op, enum rte_bbdev_op_type op_type,
 		uint16_t index)
 {
 	if (op == NULL)
@@ -934,7 +932,7 @@ acc200_print_op(struct rte_bbdev_dec_op *op, enum rte_bbdev_op_type op_type,
 
 /* Stop ACC200 queue and clear counters. */
 static int
-acc200_queue_stop(struct rte_bbdev *dev, uint16_t queue_id)
+vrb_queue_stop(struct rte_bbdev *dev, uint16_t queue_id)
 {
 	struct acc_queue *q;
 	struct rte_bbdev_dec_op *op;
@@ -945,7 +943,7 @@ acc200_queue_stop(struct rte_bbdev *dev, uint16_t queue_id)
 			q->sw_ring_depth, q->op_type);
 	for (i = 0; i < q->sw_ring_depth; ++i) {
 		op = (q->ring_addr + i)->req.op_addr;
-		acc200_print_op(op, q->op_type, i);
+		vrb_print_op(op, q->op_type, i);
 	}
 	/* ignore all operations in flight and clear counters */
 	q->sw_ring_tail = q->sw_ring_head;
@@ -962,7 +960,7 @@ acc200_queue_stop(struct rte_bbdev *dev, uint16_t queue_id)
 
 /* Release ACC200 queue. */
 static int
-acc200_queue_release(struct rte_bbdev *dev, uint16_t q_id)
+vrb_queue_release(struct rte_bbdev *dev, uint16_t q_id)
 {
 	struct acc_device *d = dev->data->dev_private;
 	struct acc_queue *q = dev->data->queues[q_id].queue_private;
@@ -982,7 +980,7 @@ acc200_queue_release(struct rte_bbdev *dev, uint16_t q_id)
 
 /* Get ACC200 device info. */
 static void
-acc200_dev_info_get(struct rte_bbdev *dev,
+vrb_dev_info_get(struct rte_bbdev *dev,
 		struct rte_bbdev_driver_info *dev_info)
 {
 	struct acc_device *d = dev->data->dev_private;
@@ -1094,9 +1092,9 @@ acc200_dev_info_get(struct rte_bbdev *dev,
 	dev_info->driver_name = dev->device->driver->name;
 
 	/* Read and save the populated config from ACC200 registers. */
-	fetch_acc200_config(dev);
+	fetch_acc_config(dev);
 	/* Check the status of device. */
-	dev_info->device_status = acc200_device_status(dev);
+	dev_info->device_status = vrb_device_status(dev);
 
 	/* Exposed number of queues. */
 	dev_info->num_queues[RTE_BBDEV_OP_NONE] = 0;
@@ -1130,11 +1128,11 @@ acc200_dev_info_get(struct rte_bbdev *dev,
 	dev_info->capabilities = bbdev_capabilities;
 	dev_info->harq_buffer_size = 0;
 
-	acc200_check_ir(d);
+	vrb_check_ir(d);
 }
 
 static int
-acc200_queue_intr_enable(struct rte_bbdev *dev, uint16_t queue_id)
+vrb_queue_intr_enable(struct rte_bbdev *dev, uint16_t queue_id)
 {
 	struct acc_queue *q = dev->data->queues[queue_id].queue_private;
 
@@ -1147,7 +1145,7 @@ acc200_queue_intr_enable(struct rte_bbdev *dev, uint16_t queue_id)
 }
 
 static int
-acc200_queue_intr_disable(struct rte_bbdev *dev, uint16_t queue_id)
+vrb_queue_intr_disable(struct rte_bbdev *dev, uint16_t queue_id)
 {
 	struct acc_queue *q = dev->data->queues[queue_id].queue_private;
 
@@ -1159,16 +1157,16 @@ acc200_queue_intr_disable(struct rte_bbdev *dev, uint16_t queue_id)
 	return 0;
 }
 
-static const struct rte_bbdev_ops acc200_bbdev_ops = {
-	.setup_queues = acc200_setup_queues,
-	.intr_enable = acc200_intr_enable,
-	.close = acc200_dev_close,
-	.info_get = acc200_dev_info_get,
-	.queue_setup = acc200_queue_setup,
-	.queue_release = acc200_queue_release,
-	.queue_stop = acc200_queue_stop,
-	.queue_intr_enable = acc200_queue_intr_enable,
-	.queue_intr_disable = acc200_queue_intr_disable
+static const struct rte_bbdev_ops vrb_bbdev_ops = {
+	.setup_queues = vrb_setup_queues,
+	.intr_enable = vrb_intr_enable,
+	.close = vrb_dev_close,
+	.info_get = vrb_dev_info_get,
+	.queue_setup = vrb_queue_setup,
+	.queue_release = vrb_queue_release,
+	.queue_stop = vrb_queue_stop,
+	.queue_intr_enable = vrb_queue_intr_enable,
+	.queue_intr_disable = vrb_queue_intr_disable
 };
 
 /* ACC200 PCI PF address map. */
@@ -1189,7 +1187,7 @@ static struct rte_pci_id pci_id_acc200_vf_map[] = {
 
 /* Fill in a frame control word for turbo decoding. */
 static inline void
-acc200_fcw_td_fill(const struct rte_bbdev_dec_op *op, struct acc_fcw_td *fcw)
+vrb_fcw_td_fill(const struct rte_bbdev_dec_op *op, struct acc_fcw_td *fcw)
 {
 	fcw->fcw_ver = 1;
 	fcw->num_maps = ACC_FCW_TD_AUTOMAP;
@@ -1606,7 +1604,7 @@ acc200_dma_desc_ld_fill(struct rte_bbdev_dec_op *op,
 }
 
 static inline void
-acc200_dma_desc_ld_update(struct rte_bbdev_dec_op *op,
+vrb_dma_desc_ld_update(struct rte_bbdev_dec_op *op,
 		struct acc_dma_req_desc *desc,
 		struct rte_mbuf *input, struct rte_mbuf *h_output,
 		uint32_t *in_offset, uint32_t *h_out_offset,
@@ -1750,7 +1748,7 @@ enqueue_ldpc_enc_n_op_cb(struct acc_queue *q, struct rte_bbdev_enc_op **ops,
  * all codes blocks have same configuration multiplexed on the same descriptor.
  */
 static inline void
-enqueue_ldpc_enc_part_tb(struct acc_queue *q, struct rte_bbdev_enc_op *op,
+vrb_enqueue_ldpc_enc_part_tb(struct acc_queue *q, struct rte_bbdev_enc_op *op,
 		uint16_t total_enqueued_descs, int16_t num_cbs, uint32_t e,
 		uint16_t in_len_B, uint32_t out_len_B, uint32_t *in_offset,
 		uint32_t *out_offset)
@@ -1870,7 +1868,7 @@ enqueue_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op *op,
  * returns the number of descs used.
  */
 static inline int
-enqueue_ldpc_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op *op,
+vrb_enqueue_ldpc_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op *op,
 		uint16_t enq_descs, uint8_t cbs_in_tb)
 {
 	uint8_t num_a, num_b;
@@ -1899,7 +1897,7 @@ enqueue_ldpc_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op *op,
 		uint32_t out_len_B = (e + 7) >> 3;
 		uint8_t enq = RTE_MIN(num_a, ACC_MUX_5GDL_DESC);
 		num_a -= enq;
-		enqueue_ldpc_enc_part_tb(q, op, enq_descs, enq, e, input_len_B,
+		vrb_enqueue_ldpc_enc_part_tb(q, op, enq_descs, enq, e, input_len_B,
 				out_len_B, &in_offset, &out_offset);
 		enq_descs++;
 	}
@@ -1908,7 +1906,7 @@ enqueue_ldpc_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op *op,
 		uint32_t out_len_B = (e + 7) >> 3;
 		uint8_t enq = RTE_MIN(num_b, ACC_MUX_5GDL_DESC);
 		num_b -= enq;
-		enqueue_ldpc_enc_part_tb(q, op, enq_descs, enq, e, input_len_B,
+		vrb_enqueue_ldpc_enc_part_tb(q, op, enq_descs, enq, e, input_len_B,
 				out_len_B, &in_offset, &out_offset);
 		enq_descs++;
 	}
@@ -1939,7 +1937,7 @@ enqueue_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op,
 		*s_output_head, *s_output;
 
 	desc = acc_desc(q, total_enqueued_cbs);
-	acc200_fcw_td_fill(op, &desc->req.fcw_td);
+	vrb_fcw_td_fill(op, &desc->req.fcw_td);
 
 	input = op->turbo_dec.input.data;
 	h_output_head = h_output = op->turbo_dec.hard_output.data;
@@ -1981,7 +1979,7 @@ enqueue_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op,
 
 /** Enqueue one decode operations for ACC200 device in CB mode */
 static inline int
-enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op,
+vrb_enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op,
 		uint16_t total_enqueued_cbs, bool same_op)
 {
 	int ret, hq_len;
@@ -2017,7 +2015,7 @@ enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op,
 		rte_memcpy(new_ptr + ACC_DESC_FCW_OFFSET,
 				prev_ptr + ACC_DESC_FCW_OFFSET,
 				ACC_FCW_LD_BLEN);
-		acc200_dma_desc_ld_update(op, &desc->req, input, h_output,
+		vrb_dma_desc_ld_update(op, &desc->req, input, h_output,
 				&in_offset, &h_out_offset,
 				&h_out_length, harq_layout);
 	} else {
@@ -2070,7 +2068,7 @@ enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op,
 
 /* Enqueue one decode operations for ACC200 device in TB mode. */
 static inline int
-enqueue_ldpc_dec_one_op_tb(struct acc_queue *q, struct rte_bbdev_dec_op *op,
+vrb_enqueue_ldpc_dec_one_op_tb(struct acc_queue *q, struct rte_bbdev_dec_op *op,
 		uint16_t total_enqueued_cbs, uint8_t cbs_in_tb)
 {
 	union acc_dma_desc *desc = NULL;
@@ -2179,7 +2177,7 @@ enqueue_dec_one_op_tb(struct acc_queue *q, struct rte_bbdev_dec_op *op,
 	desc_idx = acc_desc_idx(q, total_enqueued_cbs);
 	desc = q->ring_addr + desc_idx;
 	fcw_offset = (desc_idx << 8) + ACC_DESC_FCW_OFFSET;
-	acc200_fcw_td_fill(op, &desc->req.fcw_td);
+	vrb_fcw_td_fill(op, &desc->req.fcw_td);
 
 	input = op->turbo_dec.input.data;
 	h_output_head = h_output = op->turbo_dec.hard_output.data;
@@ -2251,7 +2249,7 @@ enqueue_dec_one_op_tb(struct acc_queue *q, struct rte_bbdev_dec_op *op,
 
 /* Enqueue encode operations for ACC200 device in CB mode. */
 static uint16_t
-acc200_enqueue_enc_cb(struct rte_bbdev_queue_data *q_data,
+vrb_enqueue_enc_cb(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_enc_op **ops, uint16_t num)
 {
 	struct acc_queue *q = q_data->queue_private;
@@ -2287,7 +2285,7 @@ acc200_enqueue_enc_cb(struct rte_bbdev_queue_data *q_data,
 
 /** Enqueue encode operations for ACC200 device in CB mode. */
 static inline uint16_t
-acc200_enqueue_ldpc_enc_cb(struct rte_bbdev_queue_data *q_data,
+vrb_enqueue_ldpc_enc_cb(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_enc_op **ops, uint16_t num)
 {
 	struct acc_queue *q = q_data->queue_private;
@@ -2328,7 +2326,7 @@ acc200_enqueue_ldpc_enc_cb(struct rte_bbdev_queue_data *q_data,
 
 /* Enqueue encode operations for ACC200 device in TB mode. */
 static uint16_t
-acc200_enqueue_enc_tb(struct rte_bbdev_queue_data *q_data,
+vrb_enqueue_enc_tb(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_enc_op **ops, uint16_t num)
 {
 	struct acc_queue *q = q_data->queue_private;
@@ -2367,7 +2365,7 @@ acc200_enqueue_enc_tb(struct rte_bbdev_queue_data *q_data,
 
 /* Enqueue LDPC encode operations for ACC200 device in TB mode. */
 static uint16_t
-acc200_enqueue_ldpc_enc_tb(struct rte_bbdev_queue_data *q_data,
+vrb_enqueue_ldpc_enc_tb(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_enc_op **ops, uint16_t num)
 {
 	struct acc_queue *q = q_data->queue_private;
@@ -2384,7 +2382,7 @@ acc200_enqueue_ldpc_enc_tb(struct rte_bbdev_queue_data *q_data,
 			break;
 		}
 
-		descs_used = enqueue_ldpc_enc_one_op_tb(q, ops[i], enqueued_descs, cbs_in_tb);
+		descs_used = vrb_enqueue_ldpc_enc_one_op_tb(q, ops[i], enqueued_descs, cbs_in_tb);
 		if (descs_used < 0) {
 			acc_enqueue_invalid(q_data);
 			break;
@@ -2406,36 +2404,36 @@ acc200_enqueue_ldpc_enc_tb(struct rte_bbdev_queue_data *q_data,
 
 /* Enqueue encode operations for ACC200 device. */
 static uint16_t
-acc200_enqueue_enc(struct rte_bbdev_queue_data *q_data,
+vrb_enqueue_enc(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_enc_op **ops, uint16_t num)
 {
 	int32_t aq_avail = acc_aq_avail(q_data, num);
 	if (unlikely((aq_avail <= 0) || (num == 0)))
 		return 0;
 	if (ops[0]->turbo_enc.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK)
-		return acc200_enqueue_enc_tb(q_data, ops, num);
+		return vrb_enqueue_enc_tb(q_data, ops, num);
 	else
-		return acc200_enqueue_enc_cb(q_data, ops, num);
+		return vrb_enqueue_enc_cb(q_data, ops, num);
 }
 
 /* Enqueue encode operations for ACC200 device. */
 static uint16_t
-acc200_enqueue_ldpc_enc(struct rte_bbdev_queue_data *q_data,
+vrb_enqueue_ldpc_enc(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_enc_op **ops, uint16_t num)
 {
 	int32_t aq_avail = acc_aq_avail(q_data, num);
 	if (unlikely((aq_avail <= 0) || (num == 0)))
 		return 0;
 	if (ops[0]->ldpc_enc.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK)
-		return acc200_enqueue_ldpc_enc_tb(q_data, ops, num);
+		return vrb_enqueue_ldpc_enc_tb(q_data, ops, num);
 	else
-		return acc200_enqueue_ldpc_enc_cb(q_data, ops, num);
+		return vrb_enqueue_ldpc_enc_cb(q_data, ops, num);
 }
 
 
 /* Enqueue decode operations for ACC200 device in CB mode. */
 static uint16_t
-acc200_enqueue_dec_cb(struct rte_bbdev_queue_data *q_data,
+vrb_enqueue_dec_cb(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_dec_op **ops, uint16_t num)
 {
 	struct acc_queue *q = q_data->queue_private;
@@ -2468,7 +2466,7 @@ acc200_enqueue_dec_cb(struct rte_bbdev_queue_data *q_data,
 
 /* Enqueue decode operations for ACC200 device in TB mode. */
 static uint16_t
-acc200_enqueue_ldpc_dec_tb(struct rte_bbdev_queue_data *q_data,
+vrb_enqueue_ldpc_dec_tb(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_dec_op **ops, uint16_t num)
 {
 	struct acc_queue *q = q_data->queue_private;
@@ -2485,7 +2483,7 @@ acc200_enqueue_ldpc_dec_tb(struct rte_bbdev_queue_data *q_data,
 			break;
 		avail -= cbs_in_tb;
 
-		ret = enqueue_ldpc_dec_one_op_tb(q, ops[i],
+		ret = vrb_enqueue_ldpc_dec_one_op_tb(q, ops[i],
 				enqueued_cbs, cbs_in_tb);
 		if (ret <= 0)
 			break;
@@ -2502,7 +2500,7 @@ acc200_enqueue_ldpc_dec_tb(struct rte_bbdev_queue_data *q_data,
 
 /* Enqueue decode operations for ACC200 device in CB mode. */
 static uint16_t
-acc200_enqueue_ldpc_dec_cb(struct rte_bbdev_queue_data *q_data,
+vrb_enqueue_ldpc_dec_cb(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_dec_op **ops, uint16_t num)
 {
 	struct acc_queue *q = q_data->queue_private;
@@ -2526,7 +2524,7 @@ acc200_enqueue_ldpc_dec_cb(struct rte_bbdev_queue_data *q_data,
 			ops[i]->ldpc_dec.n_cb, ops[i]->ldpc_dec.q_m,
 			ops[i]->ldpc_dec.n_filler, ops[i]->ldpc_dec.cb_params.e,
 			same_op);
-		ret = enqueue_ldpc_dec_one_op_cb(q, ops[i], i, same_op);
+		ret = vrb_enqueue_ldpc_dec_one_op_cb(q, ops[i], i, same_op);
 		if (ret < 0) {
 			acc_enqueue_invalid(q_data);
 			break;
@@ -2547,7 +2545,7 @@ acc200_enqueue_ldpc_dec_cb(struct rte_bbdev_queue_data *q_data,
 
 /* Enqueue decode operations for ACC200 device in TB mode */
 static uint16_t
-acc200_enqueue_dec_tb(struct rte_bbdev_queue_data *q_data,
+vrb_enqueue_dec_tb(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_dec_op **ops, uint16_t num)
 {
 	struct acc_queue *q = q_data->queue_private;
@@ -2584,36 +2582,36 @@ acc200_enqueue_dec_tb(struct rte_bbdev_queue_data *q_data,
 
 /* Enqueue decode operations for ACC200 device. */
 static uint16_t
-acc200_enqueue_dec(struct rte_bbdev_queue_data *q_data,
+vrb_enqueue_dec(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_dec_op **ops, uint16_t num)
 {
 	int32_t aq_avail = acc_aq_avail(q_data, num);
 	if (unlikely((aq_avail <= 0) || (num == 0)))
 		return 0;
 	if (ops[0]->turbo_dec.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK)
-		return acc200_enqueue_dec_tb(q_data, ops, num);
+		return vrb_enqueue_dec_tb(q_data, ops, num);
 	else
-		return acc200_enqueue_dec_cb(q_data, ops, num);
+		return vrb_enqueue_dec_cb(q_data, ops, num);
 }
 
 /* Enqueue decode operations for ACC200 device. */
 static uint16_t
-acc200_enqueue_ldpc_dec(struct rte_bbdev_queue_data *q_data,
+vrb_enqueue_ldpc_dec(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_dec_op **ops, uint16_t num)
 {
 	int32_t aq_avail = acc_aq_avail(q_data, num);
 	if (unlikely((aq_avail <= 0) || (num == 0)))
 		return 0;
 	if (ops[0]->ldpc_dec.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK)
-		return acc200_enqueue_ldpc_dec_tb(q_data, ops, num);
+		return vrb_enqueue_ldpc_dec_tb(q_data, ops, num);
 	else
-		return acc200_enqueue_ldpc_dec_cb(q_data, ops, num);
+		return vrb_enqueue_ldpc_dec_cb(q_data, ops, num);
 }
 
 
 /* Dequeue one encode operations from ACC200 device in CB mode. */
 static inline int
-dequeue_enc_one_op_cb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
+vrb_dequeue_enc_one_op_cb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
 		uint16_t *dequeued_ops, uint32_t *aq_dequeued, uint16_t *dequeued_descs)
 {
 	union acc_dma_desc *desc, atom_desc;
@@ -2666,7 +2664,7 @@ dequeue_enc_one_op_cb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
  * That operation may cover multiple descriptors.
  */
 static inline int
-dequeue_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
+vrb_dequeue_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
 		uint16_t *dequeued_ops, uint32_t *aq_dequeued,
 		uint16_t *dequeued_descs)
 {
@@ -2729,7 +2727,7 @@ dequeue_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
 
 /* Dequeue one decode operation from ACC200 device in CB mode. */
 static inline int
-dequeue_dec_one_op_cb(struct rte_bbdev_queue_data *q_data,
+vrb_dequeue_dec_one_op_cb(struct rte_bbdev_queue_data *q_data,
 		struct acc_queue *q, struct rte_bbdev_dec_op **ref_op,
 		uint16_t dequeued_cbs, uint32_t *aq_dequeued)
 {
@@ -2758,7 +2756,7 @@ dequeue_dec_one_op_cb(struct rte_bbdev_queue_data *q_data,
 	if (op->status != 0) {
 		/* These errors are not expected. */
 		q_data->queue_stats.dequeue_err_count++;
-		acc200_check_ir(q->d);
+		vrb_check_ir(q->d);
 	}
 
 	/* CRC invalid if error exists. */
@@ -2781,7 +2779,7 @@ dequeue_dec_one_op_cb(struct rte_bbdev_queue_data *q_data,
 
 /* Dequeue one decode operations from ACC200 device in CB mode. */
 static inline int
-dequeue_ldpc_dec_one_op_cb(struct rte_bbdev_queue_data *q_data,
+vrb_dequeue_ldpc_dec_one_op_cb(struct rte_bbdev_queue_data *q_data,
 		struct acc_queue *q, struct rte_bbdev_dec_op **ref_op,
 		uint16_t dequeued_cbs, uint32_t *aq_dequeued)
 {
@@ -2824,7 +2822,7 @@ dequeue_ldpc_dec_one_op_cb(struct rte_bbdev_queue_data *q_data,
 	op->ldpc_dec.iter_count = (uint8_t) rsp.iter_cnt;
 
 	if (op->status & (1 << RTE_BBDEV_DRV_ERROR))
-		acc200_check_ir(q->d);
+		vrb_check_ir(q->d);
 
 	/* Check if this is the last desc in batch (Atomic Queue). */
 	if (desc->req.last_desc_in_batch) {
@@ -2844,7 +2842,7 @@ dequeue_ldpc_dec_one_op_cb(struct rte_bbdev_queue_data *q_data,
 
 /* Dequeue one decode operations from ACC200 device in TB mode. */
 static inline int
-dequeue_dec_one_op_tb(struct acc_queue *q, struct rte_bbdev_dec_op **ref_op,
+vrb_dequeue_dec_one_op_tb(struct acc_queue *q, struct rte_bbdev_dec_op **ref_op,
 		uint16_t dequeued_cbs, uint32_t *aq_dequeued)
 {
 	union acc_dma_desc *desc, *last_desc, atom_desc;
@@ -2924,7 +2922,7 @@ dequeue_dec_one_op_tb(struct acc_queue *q, struct rte_bbdev_dec_op **ref_op,
 
 /* Dequeue encode operations from ACC200 device. */
 static uint16_t
-acc200_dequeue_enc(struct rte_bbdev_queue_data *q_data,
+vrb_dequeue_enc(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_enc_op **ops, uint16_t num)
 {
 	struct acc_queue *q = q_data->queue_private;
@@ -2941,11 +2939,11 @@ acc200_dequeue_enc(struct rte_bbdev_queue_data *q_data,
 
 	for (i = 0; i < num; i++) {
 		if (cbm == RTE_BBDEV_TRANSPORT_BLOCK)
-			ret = dequeue_enc_one_op_tb(q, &ops[dequeued_ops],
+			ret = vrb_dequeue_enc_one_op_tb(q, &ops[dequeued_ops],
 					&dequeued_ops, &aq_dequeued,
 					&dequeued_descs);
 		else
-			ret = dequeue_enc_one_op_cb(q, &ops[dequeued_ops],
+			ret = vrb_dequeue_enc_one_op_cb(q, &ops[dequeued_ops],
 					&dequeued_ops, &aq_dequeued,
 					&dequeued_descs);
 		if (ret < 0)
@@ -2965,7 +2963,7 @@ acc200_dequeue_enc(struct rte_bbdev_queue_data *q_data,
 
 /* Dequeue LDPC encode operations from ACC200 device. */
 static uint16_t
-acc200_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,
+vrb_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_enc_op **ops, uint16_t num)
 {
 	struct acc_queue *q = q_data->queue_private;
@@ -2981,11 +2979,11 @@ acc200_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,
 
 	for (i = 0; i < avail; i++) {
 		if (cbm == RTE_BBDEV_TRANSPORT_BLOCK)
-			ret = dequeue_enc_one_op_tb(q, &ops[dequeued_ops],
+			ret = vrb_dequeue_enc_one_op_tb(q, &ops[dequeued_ops],
 					&dequeued_ops, &aq_dequeued,
 					&dequeued_descs);
 		else
-			ret = dequeue_enc_one_op_cb(q, &ops[dequeued_ops],
+			ret = vrb_dequeue_enc_one_op_cb(q, &ops[dequeued_ops],
 					&dequeued_ops, &aq_dequeued,
 					&dequeued_descs);
 		if (ret < 0)
@@ -3005,7 +3003,7 @@ acc200_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,
 
 /* Dequeue decode operations from ACC200 device. */
 static uint16_t
-acc200_dequeue_dec(struct rte_bbdev_queue_data *q_data,
+vrb_dequeue_dec(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_dec_op **ops, uint16_t num)
 {
 	struct acc_queue *q = q_data->queue_private;
@@ -3022,10 +3020,10 @@ acc200_dequeue_dec(struct rte_bbdev_queue_data *q_data,
 	for (i = 0; i < dequeue_num; ++i) {
 		op = acc_op_tail(q, dequeued_cbs);
 		if (op->turbo_dec.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK)
-			ret = dequeue_dec_one_op_tb(q, &ops[i], dequeued_cbs,
+			ret = vrb_dequeue_dec_one_op_tb(q, &ops[i], dequeued_cbs,
 					&aq_dequeued);
 		else
-			ret = dequeue_dec_one_op_cb(q_data, q, &ops[i],
+			ret = vrb_dequeue_dec_one_op_cb(q_data, q, &ops[i],
 					dequeued_cbs, &aq_dequeued);
 
 		if (ret <= 0)
@@ -3044,7 +3042,7 @@ acc200_dequeue_dec(struct rte_bbdev_queue_data *q_data,
 
 /* Dequeue decode operations from ACC200 device. */
 static uint16_t
-acc200_dequeue_ldpc_dec(struct rte_bbdev_queue_data *q_data,
+vrb_dequeue_ldpc_dec(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_dec_op **ops, uint16_t num)
 {
 	struct acc_queue *q = q_data->queue_private;
@@ -3061,10 +3059,10 @@ acc200_dequeue_ldpc_dec(struct rte_bbdev_queue_data *q_data,
 	for (i = 0; i < dequeue_num; ++i) {
 		op = acc_op_tail(q, dequeued_cbs);
 		if (op->ldpc_dec.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK)
-			ret = dequeue_dec_one_op_tb(q, &ops[i], dequeued_cbs,
+			ret = vrb_dequeue_dec_one_op_tb(q, &ops[i], dequeued_cbs,
 					&aq_dequeued);
 		else
-			ret = dequeue_ldpc_dec_one_op_cb(
+			ret = vrb_dequeue_ldpc_dec_one_op_cb(
 					q_data, q, &ops[i], dequeued_cbs,
 					&aq_dequeued);
 
@@ -3151,7 +3149,7 @@ acc200_dma_desc_fft_fill(struct rte_bbdev_fft_op *op,
 
 /** Enqueue one FFT operation for ACC200 device. */
 static inline int
-enqueue_fft_one_op(struct acc_queue *q, struct rte_bbdev_fft_op *op,
+vrb_enqueue_fft_one_op(struct acc_queue *q, struct rte_bbdev_fft_op *op,
 		uint16_t total_enqueued_cbs)
 {
 	union acc_dma_desc *desc;
@@ -3178,7 +3176,7 @@ enqueue_fft_one_op(struct acc_queue *q, struct rte_bbdev_fft_op *op,
 
 /* Enqueue decode operations for ACC200 device. */
 static uint16_t
-acc200_enqueue_fft(struct rte_bbdev_queue_data *q_data,
+vrb_enqueue_fft(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_fft_op **ops, uint16_t num)
 {
 	struct acc_queue *q;
@@ -3197,7 +3195,7 @@ acc200_enqueue_fft(struct rte_bbdev_queue_data *q_data,
 		if (unlikely(avail < 1))
 			break;
 		avail -= 1;
-		ret = enqueue_fft_one_op(q, ops[i], i);
+		ret = vrb_enqueue_fft_one_op(q, ops[i], i);
 		if (ret < 0)
 			break;
 	}
@@ -3248,7 +3246,7 @@ dequeue_fft_one_op(struct rte_bbdev_queue_data *q_data,
 		q_data->queue_stats.dequeue_err_count++;
 
 	if (op->status & (1 << RTE_BBDEV_DRV_ERROR))
-		acc200_check_ir(q->d);
+		vrb_check_ir(q->d);
 
 	/* Check if this is the last desc in batch (Atomic Queue). */
 	if (desc->req.last_desc_in_batch) {
@@ -3265,7 +3263,7 @@ dequeue_fft_one_op(struct rte_bbdev_queue_data *q_data,
 
 /* Dequeue FFT operations from ACC200 device. */
 static uint16_t
-acc200_dequeue_fft(struct rte_bbdev_queue_data *q_data,
+vrb_dequeue_fft(struct rte_bbdev_queue_data *q_data,
 		struct rte_bbdev_fft_op **ops, uint16_t num)
 {
 	struct acc_queue *q = q_data->queue_private;
@@ -3297,17 +3295,17 @@ acc200_bbdev_init(struct rte_bbdev *dev, struct rte_pci_driver *drv)
 	struct rte_pci_device *pci_dev = RTE_DEV_TO_PCI(dev->device);
 	struct acc_device *d = dev->data->dev_private;
 
-	dev->dev_ops = &acc200_bbdev_ops;
-	dev->enqueue_enc_ops = acc200_enqueue_enc;
-	dev->enqueue_dec_ops = acc200_enqueue_dec;
-	dev->dequeue_enc_ops = acc200_dequeue_enc;
-	dev->dequeue_dec_ops = acc200_dequeue_dec;
-	dev->enqueue_ldpc_enc_ops = acc200_enqueue_ldpc_enc;
-	dev->enqueue_ldpc_dec_ops = acc200_enqueue_ldpc_dec;
-	dev->dequeue_ldpc_enc_ops = acc200_dequeue_ldpc_enc;
-	dev->dequeue_ldpc_dec_ops = acc200_dequeue_ldpc_dec;
-	dev->enqueue_fft_ops = acc200_enqueue_fft;
-	dev->dequeue_fft_ops = acc200_dequeue_fft;
+	dev->dev_ops = &vrb_bbdev_ops;
+	dev->enqueue_enc_ops = vrb_enqueue_enc;
+	dev->enqueue_dec_ops = vrb_enqueue_dec;
+	dev->dequeue_enc_ops = vrb_dequeue_enc;
+	dev->dequeue_dec_ops = vrb_dequeue_dec;
+	dev->enqueue_ldpc_enc_ops = vrb_enqueue_ldpc_enc;
+	dev->enqueue_ldpc_dec_ops = vrb_enqueue_ldpc_dec;
+	dev->dequeue_ldpc_enc_ops = vrb_dequeue_ldpc_enc;
+	dev->dequeue_ldpc_dec_ops = vrb_dequeue_ldpc_dec;
+	dev->enqueue_fft_ops = vrb_enqueue_fft;
+	dev->dequeue_fft_ops = vrb_dequeue_fft;
 
 	d->pf_device = !strcmp(drv->driver.name, RTE_STR(ACC200PF_DRIVER_NAME));
 	d->mmio_base = pci_dev->mem_resource[0].addr;
@@ -3316,7 +3314,7 @@ acc200_bbdev_init(struct rte_bbdev *dev, struct rte_pci_driver *drv)
 	if ((pci_dev->id.device_id == RTE_ACC200_PF_DEVICE_ID) ||
 			(pci_dev->id.device_id == RTE_ACC200_VF_DEVICE_ID)) {
 		d->device_variant = ACC200_VARIANT;
-		d->queue_offset = queue_offset;
+		d->queue_offset = acc200_queue_offset;
 		d->fcw_ld_fill = acc200_fcw_ld_fill;
 		d->num_qgroups = ACC200_NUM_QGRPS;
 		d->num_aqs = ACC200_NUM_AQS;
@@ -3332,7 +3330,7 @@ acc200_bbdev_init(struct rte_bbdev *dev, struct rte_pci_driver *drv)
 			pci_dev->mem_resource[0].phys_addr);
 }
 
-static int acc200_pci_probe(struct rte_pci_driver *pci_drv,
+static int vrb_pci_probe(struct rte_pci_driver *pci_drv,
 	struct rte_pci_device *pci_dev)
 {
 	struct rte_bbdev *bbdev = NULL;
@@ -3377,14 +3375,14 @@ static int acc200_pci_probe(struct rte_pci_driver *pci_drv,
 }
 
 static struct rte_pci_driver acc200_pci_pf_driver = {
-		.probe = acc200_pci_probe,
+		.probe = vrb_pci_probe,
 		.remove = acc_pci_remove,
 		.id_table = pci_id_acc200_pf_map,
 		.drv_flags = RTE_PCI_DRV_NEED_MAPPING
 };
 
 static struct rte_pci_driver acc200_pci_vf_driver = {
-		.probe = acc200_pci_probe,
+		.probe = vrb_pci_probe,
 		.remove = acc_pci_remove,
 		.id_table = pci_id_acc200_vf_map,
 		.drv_flags = RTE_PCI_DRV_NEED_MAPPING
drivers/baseband/acc/vrb_pmd.h +1 -1
index d4bb16da26..b074c8d4f9 100644
@@ -12,7 +12,7 @@
 
 /* Helper macro for logging */
 #define rte_bbdev_log(level, fmt, ...) \
-	rte_log(RTE_LOG_ ## level, acc200_logtype, fmt "\n", \
+	rte_log(RTE_LOG_ ## level, vrb_logtype, fmt "\n", \
 		##__VA_ARGS__)
 
 #ifdef RTE_LIBRTE_BBDEV_DEBUG
Signature · 1 line
2.34.1
Reviewed-by on v1 4/6
#8 lore raw

Re: [PATCH v1 4/6] baseband/acc: update prefix for VRB PMD functions

Quoted 8 lines · Nicolas Chautru

Include vrb_ prefix for all generic functions for VRB PMD.

---
  drivers/baseband/acc/rte_vrb_pmd.c | 248 ++++++++++++++---------------
  drivers/baseband/acc/vrb_pmd.h     |   2 +-
  2 files changed, 124 insertions(+), 126 deletions(-)

Thanks,
Maxime

#9 lore raw

PATCH 5/6 baseband/acc: rename of remaining acc200 prefix to vrb1

In reply to Nicolas Chautru

Rename remaining variable, comments and enums names when generic usage is applicable. VRB1 is specific to current HW support and VRB is more generic.

---
 drivers/baseband/acc/acc_common.h             |  12 +-
 drivers/baseband/acc/rte_acc100_pmd.c         |   4 +-
 drivers/baseband/acc/rte_vrb_pmd.c            | 352 +++++++++---------
 .../acc/{acc200_pf_enum.h => vrb1_pf_enum.h}  |   8 +-
 .../acc/{acc200_vf_enum.h => vrb1_vf_enum.h}  |   8 +-
 drivers/baseband/acc/vrb_cfg.h                |  10 +-
 drivers/baseband/acc/vrb_pmd.h                | 139 +++----
 7 files changed, 265 insertions(+), 268 deletions(-)
 rename drivers/baseband/acc/{acc200_pf_enum.h => vrb1_pf_enum.h} (97%)
 rename drivers/baseband/acc/{acc200_vf_enum.h => vrb1_vf_enum.h} (96%)
drivers/baseband/acc/acc_common.h +6 -6
index 4ca5d704e6..5bb00746c3 100644
@@ -285,13 +285,13 @@ struct __rte_packed acc_fcw_ld {
 		hcin_decomp_mode:3,
 		llr_pack_mode:1,
 		hcout_comp_mode:3,
-		saturate_input:1, /* Not supported in ACC200 */
+		saturate_input:1, /* Not supported in VRB1 */
 		dec_convllr:4,
 		hcout_convllr:4;
 	uint32_t itmax:7,
 		itstop:1,
 		so_it:7,
-		minsum_offset:1,  /* Not supported in ACC200 */
+		minsum_offset:1,  /* Not supported in VRB1 */
 		hcout_offset:16;
 	uint32_t hcout_size0:16,
 		hcout_size1:16;
@@ -301,7 +301,7 @@ struct __rte_packed acc_fcw_ld {
 	uint32_t negstop_it:7,
 		negstop_en:1,
 		tb_crc_select:2, /* Not supported in ACC100 */
-		dec_llrclip:2,  /* Not supported in ACC200 */
+		dec_llrclip:2,  /* Not supported in VRB1 */
 		tb_trailer_size:20; /* Not supported in ACC100 */
 };
 
@@ -322,7 +322,7 @@ struct __rte_packed acc_fcw_fft {
 		dft_shift:8,
 		cs_multiplier:16;
 	uint32_t bypass:2,
-		fp16_in:1, /* Not supported in ACC200 */
+		fp16_in:1, /* Not supported in VRB1 */
 		fp16_out:1,
 		exp_adj:4,
 		power_shift:4,
@@ -398,7 +398,7 @@ struct __rte_packed acc_dma_req_desc {
 				sdone_enable:1,
 				irq_enable:1,
 				timeStampEn:1,
-				dltb:1, /* Not supported in ACC200 */
+				dltb:1, /* Not supported in VRB1 */
 				res0:4,
 				numCBs:8,
 				m2dlen:4,
@@ -1118,7 +1118,7 @@ cmp_ldpc_dec_op(struct rte_bbdev_dec_op **ops) {
  * @param op_flags
  *   Store information about device capabilities
  * @param next_triplet
- *   Index for ACC200 DMA Descriptor triplet
+ *   Index for VRB1 DMA Descriptor triplet
  * @param scattergather
  *   Flag to support scatter-gather for the mbuf
  *
drivers/baseband/acc/rte_acc100_pmd.c +2 -2
index e5fe27a06b..8b02f66ac2 100644
@@ -262,7 +262,7 @@ acc100_check_ir(struct acc_device *acc100_dev)
 				ring_data->int_nb >
 				ACC100_PF_INT_DMA_DL5G_DESC_IRQ)) {
 			rte_bbdev_log(WARNING, "InfoRing: ITR:%d Info:0x%x",
-				ring_data->int_nb, ring_data->detailed_info);
+					ring_data->int_nb, ring_data->detailed_info);
 			/* Initialize Info Ring entry and move forward */
 			ring_data->val = 0;
 		}
@@ -5206,5 +5206,5 @@ rte_acc_configure(const char *dev_name, struct rte_acc_conf *conf)
 	else if (pci_dev->id.device_id == ACC101_PF_DEVICE_ID)
 		return acc101_configure(dev_name, conf);
 	else
-		return acc200_configure(dev_name, conf);
+		return vrb1_configure(dev_name, conf);
 }
drivers/baseband/acc/rte_vrb_pmd.c +174 -178

1,037 lines not on this page · raw message

drivers/baseband/acc/vrb1_pf_enum.h renamed from drivers/baseband/acc/acc200_pf_enum.h +4 -4
similarity index 97%
rename from drivers/baseband/acc/acc200_pf_enum.h
rename to drivers/baseband/acc/vrb1_pf_enum.h
index fc38465705..82a36685e9 100644
@@ -2,11 +2,11 @@
  * Copyright(c) 2021 Intel Corporation
  */
 
-#ifndef ACC200_PF_ENUM_H
-#define ACC200_PF_ENUM_H
+#ifndef VRB1_PF_ENUM_H
+#define VRB1_PF_ENUM_H
 
 /*
- * ACC200 Register mapping on PF BAR0
+ * VRB1 Register mapping on PF BAR0
  * This is automatically generated from RDL, format may change with new RDL
  * Release.
  * Variable names are as is
@@ -105,4 +105,4 @@ enum {
 	ACC_PF_INT_APB_TIMEOUT = 15,
 };
 
-#endif /* ACC200_PF_ENUM_H */
+#endif /* VRB1_PF_ENUM_H */
drivers/baseband/acc/vrb1_vf_enum.h renamed from drivers/baseband/acc/acc200_vf_enum.h +4 -4
similarity index 96%
rename from drivers/baseband/acc/acc200_vf_enum.h
rename to drivers/baseband/acc/vrb1_vf_enum.h
index 62a4f369bc..b17b2e34dd 100644
@@ -2,11 +2,11 @@
  * Copyright(c) 2021 Intel Corporation
  */
 
-#ifndef ACC200_VF_ENUM_H
-#define ACC200_VF_ENUM_H
+#ifndef VRB1_VF_ENUM_H
+#define VRB1_VF_ENUM_H
 
 /*
- * ACC200 Register mapping on VF BAR0
+ * VRB1 Register mapping on VF BAR0
  * This is automatically generated from RDL, format may change with new RDL
  */
 enum {
@@ -80,4 +80,4 @@ enum {
 	ACC_VF_INT_DMA_MLD_DESC_IRQ = 10,
 };
 
-#endif /* ACC200_VF_ENUM_H */
+#endif /* VRB1_VF_ENUM_H */
drivers/baseband/acc/vrb_cfg.h +5 -5
index 2b31244818..e3c8902b46 100644
@@ -6,27 +6,27 @@
 #define _VRB_CFG_H_
 
 /**
- * @file acc200_cfg.h
+ * @file vrb_cfg.h
  *
- * Functions for configuring ACC200 HW.
+ * Functions for configuring VRB1 HW.
  * Configuration related to encoding/decoding is done through the
  * librte_bbdev library.
  */
 
 /**
- * Configure a ACC200 device.
+ * Configure a VRB1 device.
  *
  * @param dev_name
  *   The name of the device. This is the short form of PCI BDF, e.g. 00:01.0.
  *   It can also be retrieved for a bbdev device from the dev_name field in the
  *   rte_bbdev_info structure returned by rte_bbdev_info_get().
  * @param conf
- *   Configuration to apply to ACC200 HW.
+ *   Configuration to apply to VRB1 HW.
  *
  * @return
  *   Zero on success, negative value on failure.
  */
 int
-acc200_configure(const char *dev_name, struct rte_acc_conf *conf);
+vrb1_configure(const char *dev_name, struct rte_acc_conf *conf);
 
 #endif /* _VRB_CFG_H_ */
drivers/baseband/acc/vrb_pmd.h +70 -69

168 lines not on this page · raw message

Signature · 1 line
2.34.1
Reviewed-by on v1 5/6
#10 lore raw

Re: [PATCH v1 5/6] baseband/acc: rename of remaining acc200 prefix to vrb1

Quoted 14 lines · Nicolas Chautru

Rename remaining variable, comments and enums names when generic usage is applicable. VRB1 is specific to current HW support and VRB is more generic.

---
  drivers/baseband/acc/acc_common.h             |  12 +-
  drivers/baseband/acc/rte_acc100_pmd.c         |   4 +-
  drivers/baseband/acc/rte_vrb_pmd.c            | 352 +++++++++---------
  .../acc/{acc200_pf_enum.h => vrb1_pf_enum.h}  |   8 +-
  .../acc/{acc200_vf_enum.h => vrb1_vf_enum.h}  |   8 +-
  drivers/baseband/acc/vrb_cfg.h                |  10 +-
  drivers/baseband/acc/vrb_pmd.h                | 139 +++----
  7 files changed, 265 insertions(+), 268 deletions(-)
Quoted 3 lines

rename drivers/baseband/acc/{acc200_pf_enum.h => vrb1_pf_enum.h} (97%) rename drivers/baseband/acc/{acc200_vf_enum.h => vrb1_vf_enum.h} (96%)

Thanks,
Maxime

#11 lore raw

PATCH 6/6 doc: updated naming convention for acc200 PMD

In reply to Nicolas Chautru

The documentation for the Intel vRAN Boost PMD
is being updated in term of filename and content
to match with new branding and product name.

---
 .../bbdevs/features/{acc200.ini => vrb1.ini}  |  2 +-
 doc/guides/bbdevs/{acc200.rst => vrb1.rst}    | 33 ++++++++++---------
 2 files changed, 18 insertions(+), 17 deletions(-)
 rename doc/guides/bbdevs/features/{acc200.ini => vrb1.ini} (83%)
 rename doc/guides/bbdevs/{acc200.rst => vrb1.rst} (90%)
doc/guides/bbdevs/features/vrb1.ini renamed from doc/guides/bbdevs/features/acc200.ini +1 -1
similarity index 83%
rename from doc/guides/bbdevs/features/acc200.ini
rename to doc/guides/bbdevs/features/vrb1.ini
index 7319aea726..0372b656ec 100644
@@ -1,5 +1,5 @@
 ;
-; Supported features of the 'acc200' bbdev driver.
+; Supported features of the 'intel vran boost' bbdev driver.
 ;
 ; Refer to default.ini for the full list of available PMD features.
 ;
doc/guides/bbdevs/vrb1.rst renamed from doc/guides/bbdevs/acc200.rst +17 -16
similarity index 90%
rename from doc/guides/bbdevs/acc200.rst
rename to doc/guides/bbdevs/vrb1.rst
index 012b3870a8..881ca5443c 100644
@@ -3,39 +3,39 @@
 
 .. include:: <isonum.txt>
 
-Intel\ |reg| ACC200 vRAN Dedicated Accelerator Poll Mode Driver
-===============================================================
+Intel\ |reg| vRAN Boost Poll Mode Driver (PMD)
+==============================================
 
-The Intel\ |reg| vRAN Dedicated Accelerator ACC200 peripheral enables
+The Intel\ |reg| vRAN Boost integrated accelerator enables
 cost-effective 4G and 5G next-generation virtualized Radio Access Network (vRAN)
-solutions integrated on Sapphire Rapids Edge Enhanced Processor (SPR-EE)
-Intel\ |reg| 7 based Xeon\ |reg| multi-core server processor.
-
+solutions.
+The Intel vRAN Boost v1.0 (VRB1 in the code) is specifically integrated on the
+4th Gen Intel\ |reg| Xeon\ |reg| Scalable processor with Intel\ |reg| vRAN Boost,
+also known as Sapphire Rapids Edge Enhanced (SPR-EE).
 
 Features
 --------
 
-The ACC200 includes a 5G Low Density Parity Check (LDPC) encoder/decoder,
+Intel vRAN Boost v1.0 includes a 5G Low Density Parity Check (LDPC) encoder/decoder,
 rate match/dematch, Hybrid Automatic Repeat Request (HARQ) with access to DDR
 memory for buffer management, a 4G Turbo encoder/decoder,
 a Fast Fourier Transform (FFT) block providing DFT/iDFT processing offload
 for the 5G Sounding Reference Signal (SRS), a Queue Manager (QMGR),
 and a DMA subsystem.
-There is no dedicated on-card memory for HARQ,
-this is using coherent memory on the CPU side.
+There is no dedicated on-card memory for HARQ, the coherent memory on the CPU side is being used.
 
-These correspond to the following features exposed by the PMD:
+These hardware blocks provide the following features exposed by the PMD:
 
 - LDPC Encode in the Downlink (5GNR)
 - LDPC Decode in the Uplink (5GNR)
 - Turbo Encode in the Downlink (4G)
 - Turbo Decode in the Uplink (4G)
 - FFT processing
-- SR-IOV with 16 VFs per PF
+- Single Root I/O Virtualization (SR-IOV) with 16 Virtual Functions (VFs) per Physical Function (PF)
 - Maximum of 256 queues per VF
-- MSI
+- Message Signaled Interrupts (MSIs)
 
-ACC200 PMD supports the following bbdev capabilities:
+The Intel vRAN Boost v1.0 PMD supports the following bbdev capabilities:
 
 * For the LDPC encode operation:
    - ``RTE_BBDEV_LDPC_CRC_24B_ATTACH``: set to attach CRC24B to CB(s).
@@ -104,7 +104,7 @@ Initialization
 --------------
 
 When the device first powers up, its PCI Physical Functions (PF)
-can be listed through these commands for ACC200:
+can be listed through these commands for VRB1:
 
 .. code-block:: console
 
@@ -123,7 +123,7 @@ Install the DPDK igb_uio driver, bind it with the PF PCI device ID and use
 ``lspci`` to confirm the PF device is under use by ``igb_uio`` DPDK UIO driver.
 
 The igb_uio driver may be bound to the PF PCI device using one of two methods
-for ACC200:
+for VRB1:
 
 #. PCI functions (physical or virtual, depending on the use case) can be bound
 to the UIO driver by repeating this command for every function.
@@ -252,7 +252,8 @@ from the VF and not only limited to the PF as captured above.
 
 See for more details: https://github.com/intel/pf-bb-config
 
-Specifically for the bbdev ACC200 PMD, the command below can be used:
+Specifically for the bbdev VRB1 PMD, the command below can be used (note that ACC200 was used
+prevously to refer to VRB1):
 
 .. code-block:: console
 
Signature · 1 line
2.34.1
Reviewed-by on v1 6/6
#12 lore raw

Re: [PATCH v1 6/6] doc: updated naming convention for acc200 PMD

Quoted 4 lines · Nicolas Chautru

The documentation for the Intel vRAN Boost PMD
is being updated in term of filename and content
to match with new branding and product name.

Quoted 8 lines
---
  .../bbdevs/features/{acc200.ini => vrb1.ini}  |  2 +-
  doc/guides/bbdevs/{acc200.rst => vrb1.rst}    | 33 ++++++++++---------
  2 files changed, 18 insertions(+), 17 deletions(-)

rename doc/guides/bbdevs/features/{acc200.ini => vrb1.ini} (83%) rename doc/guides/bbdevs/{acc200.rst => vrb1.rst} (90%)

Thanks,
Maxime

#13 lore raw

Re: [PATCH v1 6/6] doc: updated naming convention for acc200 PMD

Hello,

Quoted 14 lines · Maxime Coquelin
Quoted 4 lines · Nicolas Chautru

The documentation for the Intel vRAN Boost PMD
is being updated in term of filename and content
to match with new branding and product name.

Quoted 8 lines
---
  .../bbdevs/features/{acc200.ini => vrb1.ini}  |  2 +-
  doc/guides/bbdevs/{acc200.rst => vrb1.rst}    | 33 ++++++++++---------
  2 files changed, 18 insertions(+), 17 deletions(-)

rename doc/guides/bbdevs/features/{acc200.ini => vrb1.ini} (83%) rename doc/guides/bbdevs/{acc200.rst => vrb1.rst} (90%)

Quoted 1 line

Guys, the CI failure was obvious, but it seems nobody looked at it...

http://mails.dpdk.org/archives/test-report/2023-January/341526.html

[122/716] Generating html_guides with a custom command.
FAILED: doc/guides/html
/usr/bin/python3 ../buildtools/call-sphinx-build.py /usr/bin/sphinx-build 23.03.0-rc0 /home/runner/work/dpdk/dpdk/doc/guides /home/runner/work/dpdk/dpdk/build/doc/guides -W

Warning, treated as error:
/home/runner/work/dpdk/dpdk/doc/guides/bbdevs/index.rst:7:toctree contains reference to nonexisting document 'bbdevs/acc200' [123/716] Compiling C object 'examples/c590b3c@@dpdk-l2fwd-jobstats at exe/l2fwd-jobstats_main.c.o'.
[124/716] Compiling C object 'examples/c590b3c@@dpdk-l2fwd-crypto at exe/l2fwd-crypto_main.c.o'.
ninja: build stopped: subcommand failed.

I'll send a fix quickly.

Signature · 1 line
David Marchand
#14 lore raw

Re: [PATCH v1 6/6] doc: updated naming convention for acc200 PMD

Quoted 32 lines · David Marchand

Hello,

Quoted 14 lines · Maxime Coquelin
Quoted 4 lines · Nicolas Chautru

The documentation for the Intel vRAN Boost PMD
is being updated in term of filename and content
to match with new branding and product name.

Quoted 8 lines
---
  .../bbdevs/features/{acc200.ini => vrb1.ini}  |  2 +-
  doc/guides/bbdevs/{acc200.rst => vrb1.rst}    | 33 ++++++++++---------
  2 files changed, 18 insertions(+), 17 deletions(-)

rename doc/guides/bbdevs/features/{acc200.ini => vrb1.ini} (83%) rename doc/guides/bbdevs/{acc200.rst => vrb1.rst} (90%)

Quoted 1 line

Guys, the CI failure was obvious, but it seems nobody looked at it...

http://mails.dpdk.org/archives/test-report/2023-January/341526.html

[122/716] Generating html_guides with a custom command.
FAILED: doc/guides/html
/usr/bin/python3 ../buildtools/call-sphinx-build.py /usr/bin/sphinx-build 23.03.0-rc0 /home/runner/work/dpdk/dpdk/doc/guides /home/runner/work/dpdk/dpdk/build/doc/guides -W

Quoted 8 lines

Warning, treated as error:
/home/runner/work/dpdk/dpdk/doc/guides/bbdevs/index.rst:7:toctree contains reference to nonexisting document 'bbdevs/acc200' [123/716] Compiling C object 'examples/c590b3c@@dpdk-l2fwd-jobstats at exe/l2fwd-jobstats_main.c.o'.
[124/716] Compiling C object 'examples/c590b3c@@dpdk-l2fwd-crypto at exe/l2fwd-crypto_main.c.o'.
ninja: build stopped: subcommand failed.

Looking closer, Maxime had fixed this first issue, but it was hiding another one.

/usr/bin/python3 ../buildtools/call-sphinx-build.py /usr/bin/sphinx-build 23.03.0-rc0 /home/runner/work/dpdk/dpdk/doc/guides /home/runner/work/dpdk/dpdk/build/doc/guides -W
Warning, treated as error:
/home/runner/work/dpdk/dpdk/doc/guides/rel_notes/release_22_11.rst:222:unknown
document: ../bbdevs/acc200
[130/718] Compiling C object 'examples/c590b3c@@dpdk-l3fwd-power@exe/l3fwd-power_main.c.o'. [131/718] Compiling C object 'examples/c590b3c@@dpdk-link_status_interrupt@exe/link_status_interrupt_main.c.o'.

Signature · 1 line
David Marchand
#15 lore raw
In reply to Nicolas Chautru
Quoted 32 lines · Nicolas Chautru

In this serie we are renaming the ACC200PMD to a more generic VRB PMD (Intel vRAN Boost). The 2nd commit is also making sure this is future prood to be able to support both the first implementation of VRB (The one in SPR-EE) as well as future implementations of integrated product.
Most of changes are really rename to a large extend aanmaking the distinction of what is specific to current implementation (VRB1) vs more generic functions (VRB) which would be common to VRB1, VRB2, etc...

Nicolas Chautru (6):
baseband/acc: file renaming from acc200 to generic vrb baseband/acc: extension of the device structure baseband/acc: adding prefix to VRB1 registers baseband/acc: update prefix for VRB PMD functions baseband/acc: rename of remaining acc200 prefix to vrb1
doc: updated naming convention for acc200 PMD

  .../bbdevs/features/{acc200.ini => vrb1.ini}  |   2 +-
  doc/guides/bbdevs/{acc200.rst => vrb1.rst}    |  33 +-
  drivers/baseband/acc/acc200_pf_enum.h         | 108 ---
  drivers/baseband/acc/acc200_pmd.h             | 196 -----
  drivers/baseband/acc/acc200_vf_enum.h         |  83 --
  drivers/baseband/acc/acc_common.h             |  18 +-
  drivers/baseband/acc/meson.build              |   2 +-
  drivers/baseband/acc/rte_acc100_pmd.c         |   6 +-
  .../acc/{rte_acc200_pmd.c => rte_vrb_pmd.c}   | 820 +++++++++---------
  drivers/baseband/acc/vrb1_pf_enum.h           | 108 +++
  drivers/baseband/acc/vrb1_vf_enum.h           |  83 ++
  .../baseband/acc/{acc200_cfg.h => vrb_cfg.h}  |  16 +-
  drivers/baseband/acc/vrb_pmd.h                | 208 +++++
  13 files changed, 843 insertions(+), 840 deletions(-)
Quoted 11 lines

rename doc/guides/bbdevs/features/{acc200.ini => vrb1.ini} (83%) rename doc/guides/bbdevs/{acc200.rst => vrb1.rst} (90%) delete mode 100644 drivers/baseband/acc/acc200_pf_enum.h delete mode 100644 drivers/baseband/acc/acc200_pmd.h delete mode 100644 drivers/baseband/acc/acc200_vf_enum.h rename drivers/baseband/acc/{rte_acc200_pmd.c => rte_vrb_pmd.c} (82%) create mode 100644 drivers/baseband/acc/vrb1_pf_enum.h create mode 100644 drivers/baseband/acc/vrb1_vf_enum.h rename drivers/baseband/acc/{acc200_cfg.h => vrb_cfg.h} (65%) create mode 100644 drivers/baseband/acc/vrb_pmd.h

Applied to dpdk-next-baseband/for-main, with typo reported by checkpatch in the doc fixed.

Thanks,
Maxime