create-spdx: fix config build by adding dependency to enable reruns
A message that is not in the archive (sent off-list or not yet received): 1673978504-5453-1-git-send-email-maanyagoenka@linux.microsoft.com
Also, signed off by Paul Eggleton: [email protected]
________________________________
From: [email protected] <[email protected]>
Sent: Tuesday, January 17, 2023 10:01 AM
To: [email protected] <[email protected]>
Cc: Maanya Goenka <[email protected]>; Maanya Goenka <[email protected]>
Subject: [PATCH] create-spdx: fix config build by adding dependency to enable reruns
From: Maanya Goenka <[email protected]>
The issue encountered is about local stos builds failing (when these builds are preceded by a local SoC OS or MOS build). Essentially, the failure is seen when building two different configs with shared state, one where gcc-cross-<arch> has a dependency and one where it doesn't (specifically, one where the abicheck class in meta-binaryaudit is inherited and one where it isn't). Hence, the task signatures change but a rerun of those said tasks does not occur. The result is that when the config with the dependency is built and then the one without is built, due to incorrect dependencies, the SPDX manifest creation stage errors out.
create-spdx relies on BB_TASKDEPDATA to get dependencies and then adds that variable to vardepsexclude. A change in dependencies therefore, does not result in a re-execution of the tasks. This commit adds an explicit dependency on DEPENDS which influences BB_TASKDEPDATA and triggers reruns for new config builds having different dependencies.
--- meta/classes/create-spdx-2.2.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/create-spdx-2.2.bbclass +1 -1
@@ -377,7 +377,7 @@ def collect_dep_recipes(d, doc, spdx_recipe): return dep_recipes collect_dep_recipes[vardepsexclude] += "BB_TASKDEPDATA" - +collect_dep_recipes[vardeps] += "DEPENDS" def collect_dep_sources(d, dep_recipes): import oe.sbom
--
1.8.3.1
Hello Maanya,
Quoted 7 lines · On Tue, 17 Jan 2023 18:02:52 +0000 "Maanya Goenka via lists.openembedded.org"…
Also, signed off by Paul Eggleton: [email protected]
________________________________
From: [email protected] <[email protected]>
Sent: Tuesday, January 17, 2023 10:01 AM
To: [email protected] <[email protected]>
Cc: Maanya Goenka <[email protected]>; Maanya Goenka <[email protected]>
Subject: [PATCH] create-spdx: fix config build by adding dependency to enable reruns
Here you seem to be replying to a patch, but the original patch does not appear neither in my inbox nor in the archives (I checked on lore.kernel.org).
Can you send the patch again? A "[PATCH][RESEND]" tag would be OK I guess.
Thank you!
Signature · 3 lines
Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com