Skip to contentSkip to conversation

dmaengine: tegra: Fix memory leak in terminate_all()

PATCH Applied Akhil R 2 participants 2 messages Jan 18, 2023

Subsystems (3)
lore
Share & tools
lore

Akhil R

author
#0 lore raw

PATCH 1/1 dmaengine: tegra: Fix memory leak in terminate_all()

Terminate vdesc when terminating an ongoing transfer.
This will ensure that the vdesc is present in the desc_terminated list The descriptor will be freed later in desc_free_list().

This fixes the memory leaks which can happen when terminating an ongoing transfer.

Fixes ee17028009d4 ("dmaengine: tegra: Add tegra gpcdma driver")
---
 drivers/dma/tegra186-gpc-dma.c | 1 +
 1 file changed, 1 insertion(+)
drivers/dma/tegra186-gpc-dma.c +1 -0
index 1d1180db6d4e..8f67f453a492 100644
@@ -711,6 +711,7 @@ static int tegra_dma_terminate_all(struct dma_chan *dc)
 			return err;
 		}
 
+		vchan_terminate_vdesc(&tdc->dma_desc->vd);
 		tegra_dma_disable(tdc);
 		tdc->dma_desc = NULL;
 	}
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 6 lines · Akhil R

Terminate vdesc when terminating an ongoing transfer.
This will ensure that the vdesc is present in the desc_terminated list The descriptor will be freed later in desc_free_list().

This fixes the memory leaks which can happen when terminating an ongoing transfer.

Applied, thanks

Signature · 1 line
~Vinod