tests/qtest/qom-test: Stop spamming the test log
PATCH 1/1 tests/qtest/qom-test: Stop spamming the test log
We are still facing the issues that our test logs in the gitlab CI are too big (and thus cut off). A huge part is still caused by the qom-test that prints the path and name of each object it looks at by default. That's too much. Let's be silent by default, and only print the object path+name when running with V=2 (and the properties only with V=3 and higher).
--- tests/qtest/qom-test.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
tests/qtest/qom-test.c +7 -5
@@ -14,7 +14,7 @@#include "qemu/cutils.h" #include "libqtest.h" -static bool verbose; +static int verbosity_level;static void test_properties (QTestState *qts,const char *path,bool recurse) {
@@ -24,7 +24,9 @@ static void test_properties(QTestState *qts, const char *path, bool recurse)QListEntry *entry;GSList *children =NULL , *links =NULL ; -g_test_message ("Obtaining properties of %s" , path); +if (verbosity_level >=2 ) { +g_test_message ("Obtaining properties of %s" , path); + } response =qtest_qmp (qts,"{ 'execute': 'qom-list'," " 'arguments': { 'path': %s } }" , path);g_assert (response);
@@ -51,7 +53,7 @@ static void test_properties(QTestState *qts, const char *path, bool recurse) } }else {const char *prop =qdict_get_str (tuple,"name" ); -if (verbose) { +if (verbosity_level >=3 ) {g_test_message ("-> %s" , prop); } tmp = qtest_qmp(qts,
@@ -109,8 +111,8 @@ int main(int argc, char **argv) {char *v_env =getenv ("V" ); -if (v_env &&atoi (v_env) >=2 ) { - verbose = true; +if (v_env) { + verbosity_level =atoi (v_env); }g_test_init (&argc, &argv,NULL );
Signature · 1 line
2.31.1
Quoted 11 lines · Thomas Huth
We are still facing the issues that our test logs in the gitlab CI are too big (and thus cut off). A huge part is still caused by the qom-test that prints the path and name of each object it looks at by default. That's too much. Let's be silent by default, and only print the object path+name when running with V=2 (and the properties only with V=3 and higher).
Signed-off-by Thomas Huth <[email protected]>--- tests/qtest/qom-test.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
With regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Quoted 11 lines · Thomas Huth
We are still facing the issues that our test logs in the gitlab CI are too big (and thus cut off). A huge part is still caused by the qom-test that prints the path and name of each object it looks at by default. That's too much. Let's be silent by default, and only print the object path+name when running with V=2 (and the properties only with V=3 and higher).
Signed-off-by Thomas Huth <[email protected]>--- tests/qtest/qom-test.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)