Skip to contentSkip to conversation

RISC-V: Fix do_notify_resume / do_work_pending prototype

PATCH Applied Heiko Stuebner 4 participants 5 messages Jan 18, 2023 – Jan 31, 2023 RISC-V

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RISC-V: Fix do_notify_resume / do_work_pending prototype

From: Heiko Stuebner <[email protected]>

Commit b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path") renamed the do_notify_resume function to do_work_pending but did not change the prototype in signal.h Do that now, as the original function does not exist anymore.

Fixes b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path")
---
 arch/riscv/include/asm/signal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/include/asm/signal.h +1 -1
index 532c29ef0376..956ae0a01bad 100644
@@ -7,6 +7,6 @@
 #include <uapi/asm/ptrace.h>
 
 asmlinkage __visible
-void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags);
+void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags);
 
 #endif
Signature · 7 lines
2.39.0


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Reviewed-by on v1 1/1
#1 lore raw
Quoted 28 lines · Heiko Stuebner

From: Heiko Stuebner <[email protected]>

Commit b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path") renamed the do_notify_resume function to do_work_pending but did not change the prototype in signal.h Do that now, as the original function does not exist anymore.

Fixes b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path")
---
 arch/riscv/include/asm/signal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/include/asm/signal.h +1 -1
index 532c29ef0376..956ae0a01bad 100644
@@ -7,6 +7,6 @@
 #include <uapi/asm/ptrace.h>
 
 asmlinkage __visible
-void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags);
+void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags);
 
 #endif
Signature · 1 line
2.39.0

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

Reviewed-by on v1 1/1
#2 lore raw
In reply to Heiko Stuebner
Quoted 18 lines · Heiko Stuebner

From: Heiko Stuebner <[email protected]>

Commit b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path") renamed the do_notify_resume function to do_work_pending but did not change the prototype in signal.h Do that now, as the original function does not exist anymore.

Fixes b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path")
---
 arch/riscv/include/asm/signal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/include/asm/signal.h +0 -0
index 532c29ef0376..956ae0a01bad 100644

arch/riscv/include/asm/signal.h line 10

Quoted 5 lines
arch/riscv/include/asm/signal.h +1 -1
@@ -7,6 +7,6 @@
 #include <uapi/asm/ptrace.h>
 
 asmlinkage __visible
-void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags);
+void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags);

Is that an auto-builder blind spot as it gets jumped to from asm?

Thanks,
Conor.

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#3 lore raw

Am Mittwoch, 18. Januar 2023, 16:40:52 CET schrieb Conor Dooley:

Quoted 21 lines · Heiko Stuebner
Quoted 20 lines

From: Heiko Stuebner <[email protected]>

Commit b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path") renamed the do_notify_resume function to do_work_pending but did not change the prototype in signal.h Do that now, as the original function does not exist anymore.

Fixes b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path")
---
 arch/riscv/include/asm/signal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/include/asm/signal.h +0 -0
index 532c29ef0376..956ae0a01bad 100644
@@ -7,6 +7,6 @@
 #include <uapi/asm/ptrace.h>
 
Quoted 5 lines

arch/riscv/include/asm/signal.h line 10

Quoted 3 lines
arch/riscv/include/asm/signal.h +1 -1
 asmlinkage __visible
-void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags);
+void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags);

Is that an auto-builder blind spot as it gets jumped to from asm?

Yeah, the prototype is seemingly more for show in that case, as I guess from asm we only look for the symbol itself but nothing will check the syntax of the parameters.

@Palmer: any thoughts?

Thanks
Heiko

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#4 lore raw
In reply to Heiko Stuebner
This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:

Hello:

This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:

Quoted 8 lines · On Wed, 18 Jan 2023 15:22:52 +0100 you wrote:

From: Heiko Stuebner <[email protected]>

Commit b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path") renamed the do_notify_resume function to do_work_pending but did not change the prototype in signal.h Do that now, as the original function does not exist anymore.

[...]

Here is the summary with links:
- RISC-V: Fix do_notify_resume / do_work_pending prototype

    https://git.kernel.org/riscv/c/285b6a18daf1

You are awesome, thank you!

Signature · 9 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv