Skip to contentSkip to conversation

MAINTAINERS: Small potatos

PATCH In review Markus Armbruster 4 participants 11 messages Jan 19, 2023 – Jan 30, 2023

lore
Share & tools
lore
#0 lore raw

cover MAINTAINERS: Small potatos

Markus Armbruster (2):
MAINTAINERS: Cover userfaultfd
MAINTAINERS: Cover include/sysemu/accel-blocker.h

 MAINTAINERS | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.39.0
#1 lore raw

PATCH 1/2 MAINTAINERS: Cover userfaultfd

Commit 0e9b5cd6b2 "migration: introduce UFFD-WP low-level interface helpers" added util/userfaultfd.c without covering it in MAINTAINERS. Add it to section "Migration".

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index 0fe50d01e3..0dfdf71d48 100644
@@ -3089,6 +3089,7 @@ S: Maintained
 F: hw/core/vmstate-if.c
 F: include/hw/vmstate-if.h
 F: include/migration/
+F: include/qemu/userfaultfd.h
 F: migration/
 F: scripts/vmstate-static-checker.py
 F: tests/vmstate-static-checker-data/
@@ -3096,6 +3097,7 @@ F: tests/qtest/migration-test.c
 F: docs/devel/migration.rst
 F: qapi/migration.json
 F: tests/migration/
+F: util/userfaultfd.c
 
 D-Bus
 M: Marc-André Lureau <[email protected]>
Signature · 1 line
2.39.0
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] MAINTAINERS: Cover userfaultfd

Quoted 22 lines · * Markus Armbruster ([email protected]) wrote:

Commit 0e9b5cd6b2 "migration: introduce UFFD-WP low-level interface helpers" added util/userfaultfd.c without covering it in MAINTAINERS. Add it to section "Migration".

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +1 -0
index 0fe50d01e3..0dfdf71d48 100644
@@ -3089,6 +3089,7 @@ S: Maintained
 F: hw/core/vmstate-if.c
 F: include/hw/vmstate-if.h
 F: include/migration/
+F: include/qemu/userfaultfd.h
 F: migration/
 F: scripts/vmstate-static-checker.py
 F: tests/vmstate-static-checker-data/

MAINTAINERS F: tests/qtest/migration-test.c · line 3100

Quoted 4 lines
MAINTAINERS +1 -0
@@ -3096,6 +3097,7 @@ F: tests/qtest/migration-test.c
 F: docs/devel/migration.rst
 F: qapi/migration.json
 F: tests/migration/
+F: util/userfaultfd.c
Quoted 6 lines
MAINTAINERS +0 -0
 D-Bus
 M: Marc-Andr?? Lureau <[email protected]>
Signature · 1 line
2.39.0
Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK
Reviewed-by on v1 1/2
#3 lore raw

Re: [PATCH 1/2] MAINTAINERS: Cover userfaultfd

In reply to Markus Armbruster
Quoted 8 lines · Markus Armbruster

Commit 0e9b5cd6b2 "migration: introduce UFFD-WP low-level interface helpers" added util/userfaultfd.c without covering it in MAINTAINERS. Add it to section "Migration".

---
  MAINTAINERS | 2 ++
  1 file changed, 2 insertions(+)
#6 lore raw

PATCH 2/2 MAINTAINERS: Cover include/sysemu/accel-blocker.h

In reply to Markus Armbruster

Commit bd688fc931 "accel: introduce accelerator blocker API" aded include/sysemu/accel-blocker.h and accel/accel-blocker.c. MAINTAINERS covers the latter in section "Guest CPU Cores (other accelerators) / Overall", but not the former. Fix that.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index 0dfdf71d48..c888ccaf7a 100644
@@ -437,7 +437,7 @@ M: Richard Henderson <[email protected]>
 R: Paolo Bonzini <[email protected]>
 S: Maintained
 F: include/qemu/accel.h
-F: include/sysemu/accel-ops.h
+F: include/sysemu/accel-*.h
 F: include/hw/core/accel-cpu.h
 F: accel/accel-*.c
 F: accel/Makefile.objs
Signature · 1 line
2.39.0
#7 lore raw

Re: [PATCH 2/2] MAINTAINERS: Cover include/sysemu/accel-blocker.h

Quoted 4 lines · Markus Armbruster

Commit bd688fc931 "accel: introduce accelerator blocker API" aded include/sysemu/accel-blocker.h and accel/accel-blocker.c. MAINTAINERS covers the latter in section "Guest CPU Cores (other accelerators) / Overall", but not the former. Fix that.

Doesn't this belong to "Read, Copy, Update (RCU)" or "Main loop" sections?

Quoted 18 lines
---
  MAINTAINERS | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index 0dfdf71d48..c888ccaf7a 100644
@@ -437,7 +437,7 @@ M: Richard Henderson <[email protected]>
  R: Paolo Bonzini <[email protected]>
  S: Maintained
  F: include/qemu/accel.h
-F: include/sysemu/accel-ops.h
+F: include/sysemu/accel-*.h
  F: include/hw/core/accel-cpu.h
  F: accel/accel-*.c
  F: accel/Makefile.objs
#8 lore raw

Re: [PATCH 2/2] MAINTAINERS: Cover include/sysemu/accel-blocker.h

Quoted 8 lines · Philippe Mathieu-Daudé
Quoted 4 lines · Markus Armbruster

Commit bd688fc931 "accel: introduce accelerator blocker API" aded include/sysemu/accel-blocker.h and accel/accel-blocker.c. MAINTAINERS covers the latter in section "Guest CPU Cores (other accelerators) / Overall", but not the former. Fix that.

Doesn't this belong to "Read, Copy, Update (RCU)" or "Main loop" sections?

I have no idea, I merely aped the existing accel/accel-*.c line :)

Quoted 17 lines
Quoted 17 lines
---
  MAINTAINERS | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index 0dfdf71d48..c888ccaf7a 100644
@@ -437,7 +437,7 @@ M: Richard Henderson <[email protected]>
 R: Paolo Bonzini <[email protected]>
 S: Maintained
 F: include/qemu/accel.h
-F: include/sysemu/accel-ops.h
+F: include/sysemu/accel-*.h
 F: include/hw/core/accel-cpu.h
 F: accel/accel-*.c
 F: accel/Makefile.objs
Reviewed-by on v1 2/2
#9 lore raw

Re: [PATCH 2/2] MAINTAINERS: Cover include/sysemu/accel-blocker.h

In reply to Markus Armbruster
Quoted 6 lines · Markus Armbruster

Commit bd688fc931 "accel: introduce accelerator blocker API" aded include/sysemu/accel-blocker.h and accel/accel-blocker.c. MAINTAINERS covers the latter in section "Guest CPU Cores (other accelerators) / Overall", but not the former. Fix that.

#10 lore raw

[PATCH 3/2] MAINTAINERS: Cover tpm.c again

In reply to Markus Armbruster

Commit 800d4deda0 "softmmu: move more files to softmmu/" (v5.2.0) updated MAINTAINERS for all moved files but one. Fix that.

Fixes 800d4deda04be016a95fbbf397c830a2d14ff9f6
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index c888ccaf7a..27a2dac726 100644
@@ -3068,7 +3068,7 @@ T: git https://github.com/stefanha/qemu.git tracing
 TPM
 M: Stefan Berger <[email protected]>
 S: Maintained
-F: tpm.c
+F: softmmu/tpm.c
 F: hw/tpm/*
 F: include/hw/acpi/tpm.h
 F: include/sysemu/tpm*
Signature · 1 line
2.39.0