Skip to contentSkip to conversation

power: act8846_pmic: fix number of registers

PATCH In review John Keeping 3 participants 3 messages Jan 19, 2023 – Jan 31, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 power: act8846_pmic: fix number of registers

The highest register on ACT8846 is 0xf5, so set the number of registers to 0xf6, ensuring that the pmic read/write commands are able to access all of the supported registers (and many that are not valid, since the register space is quite sparse).

---
 include/power/act8846_pmic.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/power/act8846_pmic.h +1 -1
index acd0fd671e..84845c70f9 100644
@@ -9,7 +9,7 @@
 
 #include <asm/gpio.h>
 
-#define ACT8846_NUM_OF_REGS	12
+#define ACT8846_NUM_OF_REGS	0xf6
 
 #define BUCK_VOL_MASK 0x3f
 #define LDO_VOL_MASK 0x3f
Signature · 1 line
2.39.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · John Keeping

The highest register on ACT8846 is 0xf5, so set the number of registers to 0xf6, ensuring that the pmic read/write commands are able to access all of the supported registers (and many that are not valid, since the register space is quite sparse).

---
 include/power/act8846_pmic.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by on v1 1/1
#2 lore raw
In reply to John Keeping
Quoted 6 lines · John Keeping

The highest register on ACT8846 is 0xf5, so set the number of registers to 0xf6, ensuring that the pmic read/write commands are able to access all of the supported registers (and many that are not valid, since the register space is quite sparse).

Best Regards,
Jaehoon Chung

Quoted 17 lines
---
 include/power/act8846_pmic.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/power/act8846_pmic.h +1 -1
index acd0fd671e..84845c70f9 100644
@@ -9,7 +9,7 @@
 
 #include <asm/gpio.h>
 
-#define ACT8846_NUM_OF_REGS	12
+#define ACT8846_NUM_OF_REGS	0xf6
 
 #define BUCK_VOL_MASK 0x3f
 #define LDO_VOL_MASK 0x3f