Skip to contentSkip to conversation

fpga: xilinx-pr-decoupler: Use devm_platform_get_and_ioremap_resource()

PATCH In review [email protected] 2 participants 2 messages Jan 19, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fpga: xilinx-pr-decoupler: Use devm_platform_get_and_ioremap_resource()

From: ye xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

---
 drivers/fpga/xilinx-pr-decoupler.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/fpga/xilinx-pr-decoupler.c +1 -3
index 2d9c491f7be9..0039cf11ddd5 100644
@@ -108,7 +108,6 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
 	struct xlnx_pr_decoupler_data *priv;
 	struct fpga_bridge *br;
 	int err;
-	struct resource *res;
 
 	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
@@ -122,8 +121,7 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
 			priv->ipconfig = match->data;
 	}
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	priv->io_base = devm_ioremap_resource(&pdev->dev, res);
+	priv->io_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
 	if (IS_ERR(priv->io_base))
 		return PTR_ERR(priv->io_base);
 
Signature · 1 line
2.25.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 34 lines · On 1/19/23 08:14, [email protected] wrote:

From: ye xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

---
  drivers/fpga/xilinx-pr-decoupler.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/fpga/xilinx-pr-decoupler.c +1 -4
index 2d9c491f7be9..0039cf11ddd5 100644
@@ -108,7 +108,6 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
         struct xlnx_pr_decoupler_data *priv;
         struct fpga_bridge *br;
         int err;
-       struct resource *res;
 
         priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
         if (!priv)
@@ -122,8 +121,7 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
                         priv->ipconfig = match->data;
         }
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       priv->io_base = devm_ioremap_resource(&pdev->dev, res);
+       priv->io_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
         if (IS_ERR(priv->io_base))
                 return PTR_ERR(priv->io_base);
 
--
Quoted 1 line

2.25.1

Thanks,
Michal