drm/mediatek: Drop unbalanced obj unref
Subsystems (3)
PATCH 1/1 drm/mediatek: Drop unbalanced obj unref
From: Rob Clark <[email protected]>
In the error path, mtk_drm_gem_object_mmap() is dropping an obj reference that it doesn't own.
Fixes 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
Signed-off-by Rob Clark <[email protected]>
--- drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 -- 1 file changed, 2 deletions(-)
drivers/gpu/drm/mediatek/mtk_drm_gem.c +0 -2
@@ -169,8 +169,6 @@ static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj, ret =dma_mmap_attrs (priv->dma_dev, vma, mtk_gem->cookie, mtk_gem->dma_addr, obj->size, mtk_gem->dma_attrs); -if (ret) -drm_gem_vm_close (vma);return ret; }
Signature · 1 line
2.38.1
Hi, Rob:
Rob Clark <[email protected]> 於 2023年1月20日 週五 上午7:12寫道:
Quoted 5 lines
From: Rob Clark <[email protected]>
In the error path,
mtk_drm_gem_object_mmap()is dropping an obj reference that it doesn't own.
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
Chun-Kuang.
Quoted 23 lines
Fixes 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 -- 1 file changed, 2 deletions(-)drivers/gpu/drm/mediatek/mtk_drm_gem.c +0
-3@@ -169,8 +169,6 @@ static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj, ret =dma_mmap_attrs (priv->dma_dev, vma, mtk_gem->cookie, mtk_gem->dma_addr, obj->size, mtk_gem->dma_attrs); -if (ret) -drm_gem_vm_close (vma);return ret; } --2.38.1