Skip to contentSkip to conversation

drm/rockchip: Drop unbalanced obj unref

PATCH Applied Rob Clark 2 participants 2 messages Jan 19, 2023 – Feb 5, 2023

Subsystems (4)
lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 drm/rockchip: Drop unbalanced obj unref

From: Rob Clark <[email protected]>

In the error path, rockchip_drm_gem_object_mmap() is dropping an obj reference that it doesn't own.

Fixes 41315b793e13 ("drm/rockchip: use drm_gem_mmap helpers")
---
 drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/rockchip/rockchip_drm_gem.c +0 -3
index 6edb7c52cb3d..19b46c00dcbf 100644
@@ -262,9 +262,6 @@ static int rockchip_drm_gem_object_mmap(struct drm_gem_object *obj,
 	else
 		ret = rockchip_drm_gem_object_mmap_dma(obj, vma);
 
-	if (ret)
-		drm_gem_vm_close(vma);
-
 	return ret;
 }
 
Signature · 1 line
2.38.1
maintainer Applied
#1 lore raw
Quoted 6 lines · Rob Clark

From: Rob Clark <[email protected]>

In the error path, rockchip_drm_gem_object_mmap() is dropping an obj reference that it doesn't own.

Applied, thanks!

[1/1] drm/rockchip: Drop unbalanced obj unref

      commit: 8ee3b0e85f6ccd9e6c527bc50eaba774c3bb18d0

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>